Commit graph

10042 commits

Author SHA1 Message Date
Bogdan Abaev
d446fc3c6f Quick Format: wrap description text of citation properties
- set max-width on the actual citation properties popup
- refactor _buildItemDescription to construct item description
as an array of spans, instead of labels, so that the
text can properly wrap.
2024-08-06 01:21:52 -04:00
Abe Jellinek
36e499c259
ExternalLinkHandler actor: Open some links internally, incl. styles (#4505) 2024-08-06 01:12:41 -04:00
windingwind
129938c8fe
Fix quick search styling (#4501)
fix: #4497
fix: #4498
2024-08-05 05:01:59 -04:00
abaevbog
c5027106c2
fix keyboard focus not landing on feeds itemTree (#4495)
Do not use specific "#item-tree-main-default" selector to
find the itemTree node to focus since a different id
can be set for the table, e.g for the list of feeds.

Use a more general "zotero-items-tree .virtualized-table"
selector to focus the itemTree on tab from quickSearch
and on Escape keypress from an editable-text of itemPane.

Fixes: #4494
2024-08-05 00:39:39 -04:00
Dan Stillman
256efd3195 Update utilities submodule
For zotero/utilities#28
2024-08-05 00:28:42 -04:00
Dan Stillman
4e889934b9 Use 28px tree row height in Comfortable mode at default font size
In line with design
2024-08-04 08:34:39 -04:00
Dan Stillman
833b85d33a Use 22px tree row height in Compact mode at default font size
In line with design

Tested on macOS and Windows
2024-08-03 02:08:17 -04:00
Abe Jellinek
30cb2e1721
Retrieve Metadata & Create Parent: Use autoRenameFiles.fileTypes (#4488) 2024-08-03 01:30:07 -04:00
Abe Jellinek
8209ee6279
File Renaming: Rearrange prefs (#4487) 2024-08-03 01:28:28 -04:00
Kassian Sun
aa19153ebc
Setting - Feeds fix misaligned unread/read cleanup option (#4489) 2024-08-03 00:27:30 -04:00
Abe Jellinek
11a5853657
Auto-rename file and set automatic title after Create Parent Item (#4474) 2024-08-02 02:44:41 -04:00
Abe Jellinek
56bcd8e69c lookup.js: Code style fixes
Should look into updating our ESLint config so it doesn't yell so much
about multiline comments at the beginning of blocks.
2024-08-02 02:01:34 -04:00
Abe Jellinek
1ca243fa8c Add by Identifier: Fix popup positioning 2024-08-02 02:01:34 -04:00
Abe Jellinek
6cb6dd3bb5 File renaming: Fix empty value being added when all types are disabled
And filter out empty values in isRenameAllowedForType() in order to
handle bad pref values set before this commit.

Follow-up to aab90527ec
2024-08-01 10:30:21 -04:00
Abe Jellinek
aab90527ec isRenameAllowedForType(): Handle empty autoRenameFiles.fileTypes
Previously, an empty value for the pref would be treated as matching
*every* MIME type, because s.startsWith('') is true for any string. That
meant that unchecking all the file type checkboxes would actually enable
renaming for all files.
2024-08-01 10:21:18 -04:00
Martynas Bagdonas
61d6ef8d3d Fix context pane leak keeping reader and note-editor iframes in memory
Fixes #4447
2024-08-01 16:04:15 +03:00
windingwind
9a9f11c5e3
Fix attachment annotation box render on non-PDF items (#4478) 2024-08-01 01:45:03 -04:00
Tom Najdek
7c3d04e03a
Warn users running non-ARM version on ARM CPU (#4473) 2024-08-01 01:22:03 -04:00
Abe Jellinek
41fe1e4aea
Create Parent Item: Only call ReactDOM.createRoot() once (#4472)
Also applied to Zotero.AnnotationBox
2024-08-01 00:44:34 -04:00
Abe Jellinek
255de649ca
Autofocus input in Create Parent Item dialog (#4476) 2024-08-01 00:28:53 -04:00
windingwind
ed983484d1
Fix note editor tooltip (#4436) 2024-07-31 03:19:26 -04:00
Abe Jellinek
dd1601793c
Don't set default attachment title if not renaming file (#4459)
Except from Rename File from Parent Metadata.
2024-07-31 01:39:25 -04:00
windingwind
06f359df23 Fix merge window style (#4430) 2024-07-31 01:37:37 -04:00
windingwind
99a2b83cb6 Fix CR attachment box (#4430) 2024-07-31 01:37:31 -04:00
Abe Jellinek
fbcadd06ba Update progress queue dialog styles (#4464) 2024-07-31 01:35:43 -04:00
windingwind
c7757131a6
Fix Prefs window style on Windows (#4465) 2024-07-31 01:28:05 -04:00
windingwind
6530ccd101
Fix Zotero.Item.fileExists calling on unsaved item (#4468) 2024-07-31 01:19:31 -04:00
Tom Najdek
a538a5588e
Reset file renaming preference if input left empty (#4462) 2024-07-30 23:08:41 +02:00
Abe Jellinek
9d8845b961 Locate manager: Fix button spacing (#3807) 2024-07-28 03:26:39 -04:00
Abe Jellinek
10c3459a70 Preferences: Make macOS help button smaller (#3807) 2024-07-28 03:26:31 -04:00
Abe Jellinek
3d0014f258 Preferences: Fix styling a bit (#3807)
- Don't import global Zotero SCSS
   - I think this was always a mistake - preferences have their own
     root SCSS file (preferences.scss) and don't need zotero.scss
- Don't add margins on radio or button labels
   - Like above - I don't think this was correct even before the latest
     button style tweaks!
- Don't add global margins
   - Otherwise we start an arms race with all the other elements in the
     pane - anything without a margin-inline-start will look like it's
     sticking out to the left. Apply specific margins instead.
2024-07-28 03:26:28 -04:00
Abe Jellinek
5f717d3bde Show first-run banner on upgrade (#3807) 2024-07-28 03:26:12 -04:00
abaevbog
1cdb364361
Fix first row of itemTree not getting announced (#4448)
Tweak to the conditional to check if something is focused
via selection.count (instead of selection.focused which
defaults to 0 and fails on the first focused item).

Post: 40fd5efe05.

Fixes: #4444
2024-07-28 02:59:01 -04:00
Tom Najdek
00ae8bb9b2 Add more features to the file renaming functionality (#4424)
* New `attachmentTitle` field, returns the title of the current attachment (or
  the future title of the attachment being created)
* New function `match` to enable testing values with a regex.
* New function `start` to enable truncating from the beginning.
* Ignore new line characters in the template for easier editing.
* Avoid repeated characters when changing case (snake/dash)
* Increase the size of the template input field.

Closes #3252
2024-07-28 02:57:14 -04:00
Grace Dinh
29f4aece24 Add regex replace feature for file renaming (#3562) 2024-07-28 02:56:19 -04:00
Abe Jellinek
4187819cd1
File renaming: Match content type prefixes, add UI (#4431) 2024-07-27 03:01:43 -04:00
Abe Jellinek
4653059536
Select Items dialog: Change accept button label to Select (#4441) 2024-07-27 02:49:22 -04:00
abaevbog
8b67fbcdce
Select Items Dialog: restore tab order (#4442)
After redesign, tab order became: quickSearch -> itemTree ->
cancel and accept buttons -> collectionTree.

This restores original tab sequence: quickSearch -> collectionTree ->
itemsTree -> cancel and accept buttons.
2024-07-27 02:16:38 -04:00
Abe Jellinek
629c5ecab2 Find Full Text: Support Atypon (#4397)
Don't remove all query strings when normalizing URLs - keep 'download'
so that Atypon PDFs/EPUBs resolve correctly.
2024-07-27 02:11:58 -04:00
Abe Jellinek
7020d60351 Generalize Find Available PDF -> Find Full Text (#4397) 2024-07-27 02:11:22 -04:00
Dan Stillman
99df46cbbb Better architecture reporting in error reports 2024-07-27 02:10:19 -04:00
Dan Stillman
a92521bd30 Identify Windows 11 as Windows 11 2024-07-27 02:10:19 -04:00
windingwind
8c5d4c7cd5
Add plugin blocking list (#4438) 2024-07-27 00:23:31 -04:00
Abe Jellinek
b71547469f Select Items dialog: Use drawintitlebar, not chromemargin
Fixes missing window border/shadow and makes it possible to drag the
dialog on Windows.

Closes #4440
2024-07-26 11:44:28 -04:00
Abe Jellinek
7c7d8c1433
Implement Select Items dialog redesign (#4406) 2024-07-26 02:55:43 -04:00
Abe Jellinek
1463b58b5b Preferences: Make _syncToPrefOnModify work like _syncFromPref 2024-07-25 12:57:43 -04:00
Abe Jellinek
dbc8b9bfed Select Items dialog: Double-click to accept
Closes #4428
2024-07-25 10:13:21 -04:00
Abe Jellinek
9a43e8f057 Related box: Filter out missing items
Fixes #4427
2024-07-24 16:58:31 -04:00
Abe Jellinek
0944f3bdc6 Item pane header: Show default context menu for attachment titles
Closes #4415
2024-07-22 12:45:18 -04:00
Martynas Bagdonas
c2575d2a14 Gray out "Import Annotations…" in reader window when no annotations
Fixes #4416
2024-07-22 14:42:14 +03:00