Commit graph

2254 commits

Author SHA1 Message Date
Dan Stillman
38757e55c0 Remove old CSL locale directory 2011-10-31 02:15:01 -04:00
Simon Kornblith
7bafb1100b Update to citeproc-js 1.0.236 2011-10-31 00:37:24 -04:00
Dan Stillman
7b4f16e233 Show the + symbol when dragging items between collections or libraries
TODO: don't show symbol when the item can't be dropped
2011-10-29 15:50:57 -04:00
Dan Stillman
7a5024df6e Change "SVN" references to "source" 2011-10-28 01:27:04 -04:00
Simon Kornblith
0a5f4946d3 Wait until 250 ms after keypress before executing search in QuickFormat
Thanks to mronkko for the patch
2011-10-23 19:09:53 +00:00
Dan Stillman
2e41266c03 Use a DOMDocument instead of E4X for uploaded XML generation -- this is almost an order of magnitude faster and hopefully fixes data corruption issues with E4X on large uploads that were causing validation errors on the server.
Individual objects are still created as E4X (e.g., in itemToXML()) and reparsed into the DOM. Generating individual objects with the DOM would produce roughly another order-of-magnitude speedup.
2011-10-21 21:31:13 +00:00
Dan Stillman
462d9ab199 Automatically trim username in sync preferences 2011-10-20 17:57:50 +00:00
Dan Stillman
4fb9c2877f Fix error when changing item types 2011-10-19 22:27:17 +00:00
Simon Kornblith
11ad20a1d8 Update to citeproc-js 1.0.227 2011-10-15 22:47:17 +00:00
Dan Stillman
40ec344218 Fix a number of problems related to newlines in filenames
- Properly strip newlines and tabs in filenames (broken since May 2011)
- If view isn't editable, don't show Locate button, since the updated path couldn't be sent back up
- Fix access error if a synced file needs to be renamed to be valid but user doesn't have group editing access
- Don't allow newlines in item titles (e.g., via copy/paste)
2011-10-15 05:50:30 +00:00
Dan Stillman
7b902f0fd4 Replace more E4X compound assignment operators with appendChild(), as in r10250 2011-10-14 02:43:12 +00:00
Dan Stillman
8ad3b513a1 - Allow twisty clicks (in collections and items panes) to work in duplicates view
- Move collection selection down if a collection above is opened (since r9950)
2011-10-12 18:41:23 +00:00
Dan Stillman
749b4ee464 Display more helpful message for "Username not set" error when clicking on the sync error icon (previously displayed a full message at sync time for foreground syncs but updated the error icon dialog only for background syncs) 2011-10-12 15:23:53 +00:00
Dan Stillman
456406fc10 Increase max length of duplicate detection field selector menu items, and display tooltip if still cut off 2011-10-12 08:48:47 +00:00
Dan Stillman
c22c87a053 Require at least one last name + first initial match for title matching in duplicate detection 2011-10-11 23:48:20 +00:00
Dan Stillman
01ea59491a - Fix error handling in syncing when using pumpGenerator()
- Take an optional error handler as the third parameter to pumpGenerator()
2011-10-11 16:18:17 +00:00
Dan Stillman
ec6d38df68 Addresses #1796, trigger() checks type rather than event for 'modify', 'delete'
Just take out check for extraData
2011-10-10 17:01:22 +00:00
Simon Kornblith
92382ca856 Update to citeproc-js 1.0.226 2011-10-10 07:23:38 +00:00
Simon Kornblith
da180d3fed Remove debug line 2011-10-10 03:02:28 +00:00
Dan Stillman
3a6977a733 Fix "no such column: groupID" sync error 2011-10-09 19:34:54 +00:00
Dan Stillman
21f1e3789e Fixes #1796, trigger() checks type rather than event for 'modify', 'delete' 2011-10-06 16:04:53 +00:00
Simon Kornblith
8eda39ad7e Requeue nsITimerCallbacks that didn't execute during pumpGenerator 2011-10-06 01:40:35 +00:00
Simon Kornblith
a3f958be00 Fix version checking in Nightly 2011-10-05 18:42:54 +00:00
Dan Stillman
5f82db0970 Ensure library is visible when selecting 2011-10-05 17:52:22 +00:00
Dan Stillman
226196a265 Fix sync error dialog buttons (e.g., Report Errors), and change another setTimeout() call to make function call explicit for AMO 2011-10-05 17:49:35 +00:00
Dan Stillman
8a5f12680d Use collectionTreeView's getSelectedLibraryID() in zoteroPane.js 2011-10-05 17:46:23 +00:00
Dan Stillman
570ba2c909 - Restrict "-" and "+" in source list to current library
- Properly collapse subcollections on "-"
- Retain selection after "+" and select library root after "-"
2011-10-05 17:40:46 +00:00
Dan Stillman
fbb7ded324 Use correct capitalization of csledit.xul and cslpreview.xul in Standalone 2011-10-04 16:22:55 +00:00
Simon Kornblith
62180e0cd2 Remove obsolete nsIJSON uses 2011-10-04 03:14:08 +00:00
Simon Kornblith
0741bb396f Don't attempt to close pipe if we aren't reading from it yet because we haven't yet processed events on the main thread. (Fallout from processNextEvent() removal.) 2011-10-03 17:05:23 +00:00
Simon Kornblith
a259a6b8cd First run guidance for creator menu 2011-10-03 06:04:37 +00:00
Simon Kornblith
27b5505661 First run guidance for save icon 2011-10-03 04:44:40 +00:00
Simon Kornblith
328bc96da7 Fix switching search modes by removing an unnecessary optimization 2011-10-03 02:47:07 +00:00
Simon Kornblith
54147844ab - Show search menu in select items dialog
- Update search menu in non-ZoteroPane dialogs
- Don't send oncommand handler as string
2011-10-03 02:27:42 +00:00
Simon Kornblith
90dd0f34e0 Defer add-on manager load until it's necessary 2011-10-03 01:27:15 +00:00
Simon Kornblith
e68a657303 Allow column selection in select items dialog 2011-10-03 00:17:11 +00:00
Simon Kornblith
0c98f6542a Fix deleting items from unfiled items view 2011-10-03 00:13:13 +00:00
Simon Kornblith
223bfe74db Disable toolbar buttons in collections that cannot be edited 2011-10-02 23:28:38 +00:00
Simon Kornblith
24742691b8 Reduce toolbar button opacity when inactive or disabled 2011-10-02 23:13:18 +00:00
Simon Kornblith
5ed3cba50b Selected item pane button should remain white, even when inactive 2011-10-02 23:02:30 +00:00
Simon Kornblith
051445334b Small fixes to comments 2011-10-02 22:27:43 +00:00
Simon Kornblith
fd5b26dccc Separator should not be selectable in itemTreeView 2011-10-02 22:25:00 +00:00
Simon Kornblith
601c7bf04b UI tweaks 2011-10-02 22:05:33 +00:00
Simon Kornblith
ccec1243c6 Show metadata when clicking an item in quickformat dialog 2011-10-02 21:51:36 +00:00
Simon Kornblith
8da084800e Update to citeproc-js 1.0.213 2011-10-02 20:50:08 +00:00
Simon Kornblith
e6deac829c Disable cross-origin check for detection pending further investigation 2011-10-02 20:08:02 +00:00
Simon Kornblith
7acd6f6722 Fix bustage 2011-10-02 19:43:41 +00:00
Simon Kornblith
5057da9ed3 Properly pass URL 2011-10-02 18:21:41 +00:00
Simon Kornblith
252255c2eb Don't always use cross-site mode 2011-10-02 18:21:01 +00:00
Simon Kornblith
31bc445e4c Allow cross-site processDocuments() calls in Firefox (Chrome/Safari support coming) 2011-10-02 17:26:08 +00:00
Simon Kornblith
3364a533c5 Add "Restore to Library" context menu option 2011-10-02 15:50:54 +00:00
Simon Kornblith
b4c4ec3a86 Refresh trash view when an item is removed from the trash 2011-10-02 15:50:09 +00:00
Simon Kornblith
f52cb2c397 Remove debug code 2011-09-28 21:48:27 +00:00
Simon Kornblith
77f27ff3d3 Don't break integration if setting document preferences on a document on which set document preferences has already been run, but which has no fields. (Thanks to Frank for spotting this.) 2011-09-28 21:48:04 +00:00
Dan Stillman
74d5fc6a84 Make '+' key for items usable on large libraries 2011-09-28 17:46:06 +00:00
Dan Stillman
d9f059c1c4 Fix primary creator type not changing when switching between item types 2011-09-28 17:21:50 +00:00
Simon Kornblith
87978f7a1c Another ~10% collection switching perf win 2011-09-28 06:46:02 +00:00
Simon Kornblith
0a33f1fde7 Fix saving to group libraries 2011-09-28 04:01:39 +00:00
Simon Kornblith
b1275032f5 Fix dragging links to Z standalone 2011-09-27 14:51:15 +00:00
Simon Kornblith
7fa67b32d4 Fix comment 2011-09-26 01:27:16 +00:00
Simon Kornblith
3c8ed5b273 Add itemToCSLJSON utility function. At the moment, this differs from the implementation used by Word integration, but it uses the same mapping table. When we have unit tests, they will be unified. 2011-09-26 01:20:12 +00:00
Simon Kornblith
c982155f21 10-20% speed boost in initial itemTreeView load 2011-09-25 23:06:48 +00:00
Simon Kornblith
030f918e22 Don't let user uncheck "Store references" checkbox if there are stored references 2011-09-23 06:38:08 +00:00
Simon Kornblith
c90394766b - Fix failure to close add citation dialog
- Fix inability to add more than one new citation when using embedded metadata
- Fix error handling in integration
2011-09-23 06:11:36 +00:00
Dan Stillman
4b0309511b The AMO validator strips leading whitespace, so make comment a bit more explicit 2011-09-22 07:03:37 +00:00
Simon Kornblith
17521c96b4 Further abbreviate message 2011-09-22 06:55:35 +00:00
Simon Kornblith
5b5f864943 Combine AMO reviewer comment into 3 lines 2011-09-22 06:50:45 +00:00
Simon Kornblith
606211afa7 Add "Dear friendly AMO reviewer" message to processNextEvent() call that is only used in Z standalone 2011-09-22 06:33:27 +00:00
Simon Kornblith
b7482bc7d6 Avoid yielding in the middle of a transaction because it could be problematic, and don't let other events run until after first yield. 2011-09-22 06:24:08 +00:00
Simon Kornblith
25e384de76 Use generators in place of Zotero.wait() 2011-09-22 05:55:52 +00:00
Simon Kornblith
5e67753b73 Use blocking IO to make sure that pipes are open instead of Zotero.wait() in ipc.js. This also removes our safeguard against hanging the browser if for some reason the pipe gets closed, but it should be okay :-/ 2011-09-22 05:36:01 +00:00
Dan Stillman
e1cc377162 Show Zotero pane progress bar during sync processing
TODO: limit to large syncs?

This needs a lot of testing.

Also:
- Tweak pumpGenerator() wait level behavior to match Zotero.wait()
- If Zotero is closed in the top-most window, show a popup instead of the pane-covering progress meter, and take an optional icon in Zotero.showZoteroPaneProgressMeter() for use in the popup
- Restore protection against opening Zotero pane when Zotero.locked is set
- Display a nicer error if Zotero.DB.commitTransaction() is called without an active transaction
- Allow text with icons to extend to multiple lines in progressWindow popup
- Automatically use current window if one isn't specified in Zotero.repaint()
2011-09-21 23:00:20 +00:00
Simon Kornblith
15c79766e8 Hackish way of avoiding async AddonManager APIs during initialization 2011-09-21 20:30:37 +00:00
Dan Stillman
3eef17578d Just use INSERT OR IGNORE for all relations inserts 2011-09-21 19:48:50 +00:00
Simon Kornblith
8b263ff8e4 Remove Zotero.wait() 2011-09-21 04:37:10 +00:00
Simon Kornblith
50a793c4ea Stop iterating when StopIteration thrown from generator 2011-09-21 04:36:37 +00:00
Simon Kornblith
27b95ebb14 Remove Zotero.sleep() 2011-09-21 03:43:03 +00:00
Simon Kornblith
ed42e0c22d Eliminate processNextEvent(). This needs a lot of testing. 2011-09-21 03:41:49 +00:00
Simon Kornblith
c4bfd17e52 Fix error 2011-09-21 00:34:38 +00:00
Simon Kornblith
4607239fa9 Add a function to pump a generator until it yields false, allowing other events to be processed in between. This is useful because we can then call
yield true;

in place of Zotero.wait() to allow UI events to be processed without exiting the function, thus avoiding the hassle of setting up a large number of callbacks.

This is still painful compared to Zotero.wait(), since the yield has to be present in the generator passed to Zotero.pumpGenerator() and not a child function. However, it's less painful than using a bunch of nested setTimeout() calls.
2011-09-21 00:32:25 +00:00
Simon Kornblith
21aff6f467 Remove processNextEvent() call 2011-09-20 21:59:28 +00:00
Simon Kornblith
d19c87ef83 Remove processNextEvent() call 2011-09-20 21:47:04 +00:00
Simon Kornblith
02506966eb Remove processNextEvent() calls (by avoiding AddonManager) 2011-09-20 21:39:48 +00:00
Simon Kornblith
00b341daf1 Remove processNextEvent() call 2011-09-20 19:36:55 +00:00
Simon Kornblith
f3a64939ed Eliminate processNextEvent call 2011-09-20 19:28:05 +00:00
Dan Stillman
fb46cf23de A couple tweaks for the AMO validator: remove unused function that made a synchronous HTTP request and wrap a setTimeout() callback to clarify that it's a function rather than a string 2011-09-20 12:40:03 +00:00
Simon Kornblith
026bce81a8 Use Zotero.repaint() in callbacks instead of calling Zotero.wait() during translation to reduce non-determinism 2011-09-20 06:23:44 +00:00
Simon Kornblith
23b9d6fdb9 - Forward compatible handling of version comparisons
- Add Zotero.repaint(window), which forces a UI repaint but doesn't execute any other events. We should use this within transactions to eliminate the nondeterminism of Zotero.wait().
2011-09-20 06:17:06 +00:00
Simon Kornblith
9e5c9716e2 Fix preview and resolve issues with classic add citation dialog 2011-09-15 22:24:43 +00:00
Simon Kornblith
051d82fcdf Bump required versions 2011-09-15 08:23:38 +00:00
Simon Kornblith
0d3923182b Minor tweak to debug code 2011-09-15 08:00:07 +00:00
Simon Kornblith
961b4b17d4 Remove antique code 2011-09-15 07:58:42 +00:00
Simon Kornblith
08c8c4dfbd Use asynchronous APIs for collecting fields. This currently has the side effect of breaking the editor. 2011-09-15 07:57:06 +00:00
Simon Kornblith
f71ad877b1 Fix typo 2011-09-13 16:41:43 +00:00
Simon Kornblith
12b72581ab Fix Windows file export error in Zotero Standalone 2011-09-13 16:41:33 +00:00
Simon Kornblith
e809144162 Update to citeproc-js 1.0.213 2011-09-12 01:23:35 +00:00
Simon Kornblith
f9b823d0e8 Don't update citations that haven't changed, even on refresh 2011-09-08 23:21:37 +00:00
Simon Kornblith
517d80f4dd Fix broken Zotero.debug from IE changes 2011-09-08 23:12:31 +00:00
Simon Kornblith
f9c9816183 Add Zotero.URI.getURILibrary() 2011-09-08 18:04:28 +00:00
Simon Kornblith
fbdabed5c0 Add noautohide="true" to panel 2011-09-08 00:07:45 +00:00