Commit graph

8153 commits

Author SHA1 Message Date
Dan Stillman
b0ba7e4646 Show small PDF icon in Attachments column when there's a PDF
Closes #2265

There's also new code for showing a different icon for snapshots, files,
and DOI/URL links, like the web library and iOS app, but it's commented
out for now. The bitmap icons create too much visual noise with the
greater information density and hierarchical tree of the desktop app
(not to mention many more low-DPI displays). We can revisit after
switching to SVGs across the board.
2021-12-22 03:38:12 -05:00
Dan Stillman
04fa066a14 Delete items with unmodified delete key when not in collections
Closes #2209
2021-12-21 03:19:13 -05:00
Dan Stillman
978e2c32b4 Remove "Toggle Tag Selector" command from Shortcuts preference pane
Cmd/Ctrl-Shift-T is now used for reopening a closed tab

This is now a View menu option, so macOS users can assign an
app-specific shortcut key for it. For other platforms that can't do
that, Zutilo could add it, and it will be an option if we add general
key-binding configurability in a future version.

Closes #2281
2021-12-21 02:22:29 -05:00
Dan Stillman
f161d167ae Show "Add Note from Annotations" for all items with PDF attachments
So that this works for PDFs with external annotations that haven't yet
been processed. Going forward, if we add automatic/background scanning,
we can avoid showing this option if the file hasn't changed and there
are no Zotero annotations, which would probably be the majority of
attachments.
2021-12-21 02:22:29 -05:00
Dan Stillman
ea18641a62 Annotation import: Use skipAll for lastProcessedModificationTime save 2021-12-21 02:22:29 -05:00
Dan Stillman
d76cf829b1 Additional logging for PDF annotation import 2021-12-21 02:22:29 -05:00
Adomas Venčkauskas
59969d1a7b Fix citeproc engine variable name in rtfScan.jsx 2021-12-20 15:53:59 +02:00
Dan Stillman
fa95de396d Add en-AU and en-NZ as available locales
Addresses #2268, but better support for other en-* locales will require
other changes, including `timeStyle` support in `Intl.DateTimeFormat` in
a newer Firefox version, which will let us use a custom `DateTimeFormat`
for dates instead of relying on `toLocaleString()`.
2021-12-20 01:24:43 -05:00
Dan Stillman
abe8c39c5b Ignore blank tags when saving from translator
Instead of throwing an error
2021-12-19 03:01:59 -05:00
Dan Stillman
f734e53ed9 Fix broken Export Library after #2214 2021-12-18 22:42:12 -05:00
Martynas Bagdonas
78526d7795 Include annotationKey when using "Add Item Note from Annotation"
Fixes #2279
2021-12-16 13:09:22 +02:00
Dan Stillman
88c3e6ca00 Fix wrong aria-disabled on context/non-context item rows
Regression from #2263
2021-12-15 22:05:28 -05:00
Adomas Ven
44b6cd0525
citeproc-rs support (#2220)
Disabled under zotero.cite.useCiteprocRs by default
2021-12-15 17:28:41 -05:00
Dan Stillman
55e8f7914b Handle style errors in CSL Preview window
Keep going, and log the error
2021-12-15 17:21:26 -05:00
Dan Stillman
b28db2c8f9 Show "Add Notes from Annotations" when multiple items are selected
Closes #2277
2021-12-15 16:37:21 -05:00
Dan Stillman
a648da8507 Markdown/HTML note export: Switch hard-coded translator ids to constants 2021-12-15 06:10:58 -05:00
Dan Stillman
ad21d73ad9 Markdown note export: Replace zotero:// without separate saving code path 2021-12-15 06:10:58 -05:00
Martynas Bagdonas
19977598eb Markdown note export (#2214) 2021-12-15 06:10:58 -05:00
Dan Stillman
63a0452a77 Update submodules 2021-12-15 01:55:36 -05:00
Adomas Ven
0a8ba2bced
Improve tree screen reader accessibility (#2263)
Also:

* Allow opening tree context menu with Shift + F10 and Context Menu button
2021-12-15 01:47:06 -05:00
Dan Stillman
fbef7c00dd Fix error deleting feed item with invalid attachment
This shouldn't happen, and we should make sure we prevent plugins from
doing it, but if an attachment existed in a feed library, neither the
item nor the feed could be deleted.

https://forums.zotero.org/discussion/93453/unsubscribe-rss-feed-fail
2021-12-14 08:17:42 -05:00
Martynas Bagdonas
338d753eb3 Fix itemBox opening popups in wrong bindings 2021-12-13 16:36:47 +02:00
Dan Stillman
644c4e5925 Add objects from failed download requests to sync queue
Previously only individual objects from successful requests that
couldn't be processed for some reason would be added to the queue.

`Sync.APIClient.downloadObjects()` now returns clearer and more
consistent results. It now returns an array of promises for objects with
a `keys` array of requested keys and either a `json` array of returned
API JSON objects or an `error` Error, depending on whether the request
succeeded or failed. This makes it easier to detect remotely missing
objects and request failures.
2021-12-10 05:56:46 -05:00
Martynas Bagdonas
86965988b4 Make PDF reader File menu "Show in Library" option to show parent item
Fixes #2266
2021-12-09 15:32:24 +02:00
Adomas Venčkauskas
aefd3dd94a Reduce timeout when downloading PDF via browser.
Follow up to 4405b59
2021-12-07 16:12:14 +02:00
Adomas Venčkauskas
73fb9c13df Fix preference style list refresh on modification. Closes #2256 2021-12-02 12:40:48 +02:00
Adomas Venčkauskas
0fdfa5f64b Fix test failure after #2248. Closes #2257 2021-12-02 12:21:23 +02:00
Adomas Ven
4405b59044
Add a function to download PDFs via a browser (#2248)
Fixes zotero/translators#2739
2021-12-02 04:27:33 -05:00
Dan Stillman
e54f59ae28 Fix error fetching Nature feeds
Fixes #2249
2021-11-26 04:20:13 -05:00
Dan Stillman
07df7d0dec Fix standalone notes not being added to collections on RDF import
This includes the `Zotero.RDF.getResourceURI()` fix in
zotero/translate@85b39a5be.

This position change here for `this._handleRelated()` for attachments
isn't necessary, since the attachment is already saved and already has
an id, but it's done for consistency with the call for notes (where the
note previously didn't yet have an id).
2021-11-25 00:24:56 -05:00
Tom Najdek
1f6b626717
Change browser in basicViewer to be type="content"
This fixes an issue where JS on a page loaded in the viewer would error
when referring to window.top or window.parent.
2021-11-25 01:02:02 +01:00
Tom Najdek
34d62426c3
Tweak URL matching regexp to be more precise
Institutional login process goes through multiple pages, the URL regexp
is tweaked to be more precise to ensure that no arbitrary URLs are
matched while polling for the final URL with auth code.
2021-11-25 01:01:55 +01:00
Adomas Venčkauskas
d03c495563 Update SingleFile to the latest version 2021-11-19 14:22:45 +02:00
Dan Stillman
32a5826a1f Log more of the response for downloaded PDFs that aren't PDFs 2021-11-16 14:29:53 -05:00
Dan Stillman
54588453dc Fix selection of collections pane on "Focus Libraries Pane" shortcut 2021-11-15 23:13:53 -05:00
Tom Najdek
f10649483e
Mendeley Import: Add more tests for the importer
Also rephrased a comment in the importer code and renamed tests file
to mendeleyImportTest.js for consistency.
2021-11-15 11:19:19 +01:00
Adomas Venčkauskas
dcce807e92 Enable publicationTitle column in feeds. Closes #2242 2021-11-09 16:23:33 +02:00
Adomas Venčkauskas
b9e1923656 Fix rows not deselecting with single click on one item.
Closes #2241
2021-11-08 14:06:36 +02:00
Martynas Bagdonas
80be9f9e3a Disable annotations transferring for read-only items
#2239
2021-11-08 13:24:13 +02:00
Martynas Bagdonas
af689b17fa Fix CMap loading for pdf-worker 2021-11-08 11:42:39 +02:00
Dan Stillman
f5eb99ad4c Upload settings in batches of 250
Closes #2000
2021-11-07 23:46:54 -05:00
Abe Jellinek
cd3304e16c
Don't reset isRead when feed item metadata changes (#2215)
This prevents metadata changes from clearing the isRead status of feed
items as long as GUIDs remain constant. Previously, feed items with
randomized properties (like URLs generated dynamically each time the
feed is served) would be incorrectly marked as unread on every update.
2021-11-05 23:16:12 -04:00
Abe Jellinek
2cf436c67d
Async web translation (#2229) 2021-11-05 23:12:37 -04:00
Martynas Bagdonas
b4cf566d0d Return back writeAtomic for PDF reader setState #2210 2021-11-05 17:09:40 +02:00
Dan Stillman
eb4090058d Tweak menu position and alert text for annotation transferring 2021-11-05 00:30:06 -04:00
Dan Stillman
f400d2a4a4 Include item type name in field-not-valid-for-type error 2021-11-05 00:29:45 -04:00
Tom Najdek
7940915bb0
Fix arXiv ID not imported. Fix #2236. (#2238)
Mendeley online schema uses "arxiv", local DB uses "arxivId" hence it
was skipped. This commit adds mapping and a test.
2021-11-04 15:32:35 -04:00
Tom Najdek
882ecc205e
Mendeley import: Remove code to patch after earlier imports (#2234)
Fixes #2233, Mendeley import: Invalid-field-for-type error
2021-11-03 23:32:36 -04:00
Martynas Bagdonas
c9d4ff4314 Add additional error logging for PDF reader and note editor 2021-11-03 11:50:21 +02:00
Martynas Bagdonas
6ac663a002 Encode a wider range of unicode characters when inserting a note 2021-11-02 15:06:40 +02:00