mirrors/zotero
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
12086 commits 9 branches 362 tags 278 MiB
Commit graph

8343 commits

Author SHA1 Message Date
Adomas Venčkauskas
0d2cfef160 HTML Tree: fix errors being thrown on hover over empty cells 
Regression in 54ad6da1
 2022-02-08 10:00:36 +02:00
Martynas Bagdonas
b865ee8b65 Fix tagsBox issues in a separate note window: 
- Invisible auto-suggested tags
- Oversized tag icon
 2022-02-07 17:39:09 +02:00
Dan Stillman
e4f5241058 Add missing quote in logged error 2022-02-05 03:17:51 -05:00
Adomas Venčkauskas
54ad6da1af HTML Tree: make tooltip setting code use any parent xul node 2022-02-04 14:19:20 +02:00
Dan Stillman
c78bf1b2a3 Fix feed item guid in logged warning when item exists in different feed 2022-02-04 02:18:38 -05:00
Abe Jellinek
e8b574da0b
Fix React icons only using 2x image once (#2324) 
a1267bc fixed repeated re-appending of '@2x' by moving the modified URL
to a local variable, but it still set hasHiDPI to false permanently;
this meant that icons displayed repeatedly in the same window, like the
tab close button, would only use their 2x versions the first time they
were displayed (in the case of tabs, this is the library tab's invisible
close button, so *no* tabs got visible 2x buttons).

This commit moves the HiDPI check and URL modification out of the render
function and instead runs it a single time when i() is first called.
 2022-02-04 00:38:01 -05:00
Adomas Venčkauskas
8de1ddcaf4 HTML Tree: Display a tooltip with full cell contents when truncated 
Closes #2321

Also added tooltips for cells that use an icon in their contents
 2022-02-03 16:09:40 +02:00
Abe Jellinek
4777f0ec89 Double-click/enter to edit feed 
Closes #2323
 2022-02-02 23:03:04 -08:00
Tom Najdek
90da2563c8
Decouple progress queue table from progress window (#2318) 
* Tweaked ProgressQueue to accept multiple listeners per event.
  Removing listeners now requires specifying which one to remove.
* Decoupled progress queue table into new ProgressQueueTable component
 2022-02-02 17:15:57 -05:00
Dan Stillman
1ea1a134ba Reset extensions.spellcheck.inline.max-misspellings 
Closes #2108
 2022-02-02 05:48:23 -05:00
Adomas Venčkauskas
060d2f1c37 Item tree: Add tooltips for header cells. 
Restrict the html-tooltip [title] selector to not fall back to
window title when no title attributes are present.
 2022-02-02 12:25:50 +02:00
Dan Stillman
4e6b68477d PDF reader: Annotation name display changes 
- Show creator's name in groups even when it's the current user
- Don't show name for external annotations
 2022-02-02 03:54:34 -05:00
Dan Stillman
a6e0432848 PDF reader: Tweak annotation deletion confirmation text 2022-02-02 02:09:20 -05:00
Martynas Bagdonas
21ca1555c1 Focus tag input field if tagsBox doesn't have tags 
Fixes #2315
 2022-01-31 19:49:58 +02:00
Dan Stillman
637acbe693 Fix incorrect isEditable() test in Item::moveToLibrary() 2022-01-31 06:48:05 -05:00
Dan Stillman
df64a16b55 Disallow unowned group annotation edits, but allow deletions 
Update `DataObject::isEditable()` to take an optional `op` argument to
test individual operations as opposed to general library editing.
Erasing objects now tests `erase`, and `Item::isEditable()` allows
`erase` for unowned group annotations while disallowing the default
`edit`.

It's still up to the reader to handle this appropriately in the UI and
not allow operations it shouldn't, but this enforces it in the data
layer.
 2022-01-31 06:48:05 -05:00
Dan Stillman
5a0cd78f06 Enable PDF reader by default and enable for groups 
"Zotero" is now the first and default option in the "Open PDFs using"
drop-down in the General pane of the preferences.
 2022-01-31 06:48:05 -05:00
Martynas Bagdonas
f8d7eb8ed7 Prompt confirmation when deleting annotations in PDF reader 2022-01-28 17:32:41 +02:00
Adomas Venčkauskas
d2aa945083 Select full item name upon entering edit mode in the collection tree 
(Instead of placing the cursor at the end of the edit field)
Closes #2316
 2022-01-26 15:10:59 +02:00
Martynas Bagdonas
e46f210b6c
Add color and tag selector to annotations sidebar (#2299) 2022-01-17 04:20:35 -05:00
Martynas Bagdonas
f2e9efaf1d Don't show multiple separators in PDF reader annotation context menu 2022-01-04 19:11:38 +02:00
Dan Stillman
035aac30f2 Fix misplaced '?' in regexp from 52d5652540 2022-01-03 01:31:02 -05:00
Dan Stillman
52d5652540 Don't use Firefox UA for proxy-check S3 domain 
https://forums.zotero.org/discussion/comment/396502/#Comment_396502
 2022-01-03 01:22:49 -05:00
Dan Stillman
4f8fccd598 PDF reader: Page label popup tweaks (#2267) 
- Change text of context menu option
- Add header line above radio boxes
 2021-12-28 01:19:48 -05:00
Martynas Bagdonas
2cd756b7ae PDF reader: Add page label update option to annotation popup (#2267) 2021-12-28 01:19:48 -05:00
Martynas Bagdonas
3cb5340b26 PDF reader: Remove import bar artifacts 2021-12-28 01:19:48 -05:00
Martynas Bagdonas
6913c179dc Optimize annotations batch modification and deletion 2021-12-28 01:19:48 -05:00
Dan Stillman
819dc7f6f4 Include "Zotero/[version]" in file sync requests 
To avoid blocking by some institutional firewalls

https://forums.zotero.org/discussion/93510/general-sync-error
 2021-12-27 15:54:12 -05:00
Dan Stillman
3dab64ddbb Fix error deleting some orphaned or invalid WebDAV files 
If a .prop file was passed to `_deleteStorageFiles()`, it would throw
`deletePropURI.QueryInterface is not a function`.
 2021-12-27 14:53:28 -05:00
Dan Stillman
71248b591d Better handling of export option for notes in items list context menu 
- Show "Export Note…"/"Export Notes…" if only notes or attachments
  selected
- Don't show export option if only attachments and no embedded notes
  (was previously disabled, and still is if all notes or a mixture of
  empty notes and attachments)
 2021-12-26 23:50:15 -05:00
Dan Stillman
5c024e2859 Use Sets instead of Arrays in ZoteroPane.buildItemContextMenu() 2021-12-26 23:27:44 -05:00
Dan Stillman
f3a71a2c09 Log timing info for copying bibliography to clipboard and CSL Preview 2021-12-26 23:19:35 -05:00
Dan Stillman
24104dc685 Fix error generating context menu for multiple standalone attachments 
Regression from f161d167ae
 2021-12-26 23:15:47 -05:00
Dan Stillman
918570479e Hard-code "storage" in error when trying to set data dir to 'storage' 2021-12-24 02:06:39 -05:00
Dan Stillman
d361930bcc Remove PDF metadata retrieval problem reporting 
Closes #1854
 2021-12-23 06:11:13 -05:00
Dan Stillman
d3691473bc HTML tree: Fix Shift-Enter for opening PDFs in separate windows 
This also required React 17, which removed event pooling [1], which was
breaking this even after the code change.

https://forums.zotero.org/discussion/comment/396112/#Comment_396112

[1] https://reactjs.org/blog/2020/08/10/react-v17-rc.html#no-event-pooling
 2021-12-23 01:18:22 -05:00
Adomas Venčkauskas
5dabe390a2 Fix collection and item tree focusing code. Closes #2286 2021-12-22 13:48:41 +02:00
Tom Najdek
bbf3180a10 Fix rtfscan icons reported as having HiDPI variant 2021-12-22 05:06:21 -05:00
Dan Stillman
7285c32d28 Support Cmd/Ctrl-Shift-F to open advanced search window 
https://forums.zotero.org/discussion/93600/shortcut-for-advanced-search

In olden days this used to trigger full-screen mode of our weird "tab
mode" in Firefox, but that hasn't existed in many years. At least on
macOS, the standard shortcut for that is Cmd-Ctrl-F.
 2021-12-22 05:04:41 -05:00
Dan Stillman
0f676dd720 Remove lower row height in virtualized table on macOS 
With the additional PDF icon in the Attachments column from b0ba7e464,
might as well have the same amount of spacing to tell the rows apart.
 2021-12-22 05:04:28 -05:00
Dan Stillman
b0ba7e4646 Show small PDF icon in Attachments column when there's a PDF 
Closes #2265

There's also new code for showing a different icon for snapshots, files,
and DOI/URL links, like the web library and iOS app, but it's commented
out for now. The bitmap icons create too much visual noise with the
greater information density and hierarchical tree of the desktop app
(not to mention many more low-DPI displays). We can revisit after
switching to SVGs across the board.
 2021-12-22 03:38:12 -05:00
Dan Stillman
04fa066a14 Delete items with unmodified delete key when not in collections 
Closes #2209
 2021-12-21 03:19:13 -05:00
Dan Stillman
978e2c32b4 Remove "Toggle Tag Selector" command from Shortcuts preference pane 
Cmd/Ctrl-Shift-T is now used for reopening a closed tab

This is now a View menu option, so macOS users can assign an
app-specific shortcut key for it. For other platforms that can't do
that, Zutilo could add it, and it will be an option if we add general
key-binding configurability in a future version.

Closes #2281
 2021-12-21 02:22:29 -05:00
Dan Stillman
f161d167ae Show "Add Note from Annotations" for all items with PDF attachments 
So that this works for PDFs with external annotations that haven't yet
been processed. Going forward, if we add automatic/background scanning,
we can avoid showing this option if the file hasn't changed and there
are no Zotero annotations, which would probably be the majority of
attachments.
 2021-12-21 02:22:29 -05:00
Dan Stillman
ea18641a62 Annotation import: Use skipAll for lastProcessedModificationTime save 2021-12-21 02:22:29 -05:00
Dan Stillman
d76cf829b1 Additional logging for PDF annotation import 2021-12-21 02:22:29 -05:00
Adomas Venčkauskas
59969d1a7b Fix citeproc engine variable name in rtfScan.jsx 2021-12-20 15:53:59 +02:00
Dan Stillman
fa95de396d Add en-AU and en-NZ as available locales 
Addresses #2268, but better support for other en-* locales will require
other changes, including `timeStyle` support in `Intl.DateTimeFormat` in
a newer Firefox version, which will let us use a custom `DateTimeFormat`
for dates instead of relying on `toLocaleString()`.
 2021-12-20 01:24:43 -05:00
Dan Stillman
abe8c39c5b Ignore blank tags when saving from translator 
Instead of throwing an error
 2021-12-19 03:01:59 -05:00
Dan Stillman
f734e53ed9 Fix broken Export Library after #2214 2021-12-18 22:42:12 -05:00
Martynas Bagdonas
78526d7795 Include annotationKey when using "Add Item Note from Annotation" 
Fixes #2279
 2021-12-16 13:09:22 +02:00
Dan Stillman
88c3e6ca00 Fix wrong aria-disabled on context/non-context item rows 
Regression from #2263
 2021-12-15 22:05:28 -05:00
Adomas Ven
44b6cd0525
citeproc-rs support (#2220) 
Disabled under zotero.cite.useCiteprocRs by default
 2021-12-15 17:28:41 -05:00
Dan Stillman
55e8f7914b Handle style errors in CSL Preview window 
Keep going, and log the error
 2021-12-15 17:21:26 -05:00
Dan Stillman
b28db2c8f9 Show "Add Notes from Annotations" when multiple items are selected 
Closes #2277
 2021-12-15 16:37:21 -05:00
Dan Stillman
a648da8507 Markdown/HTML note export: Switch hard-coded translator ids to constants 2021-12-15 06:10:58 -05:00
Dan Stillman
ad21d73ad9 Markdown note export: Replace zotero:// without separate saving code path 2021-12-15 06:10:58 -05:00
Martynas Bagdonas
19977598eb Markdown note export (#2214) 2021-12-15 06:10:58 -05:00
Dan Stillman
63a0452a77 Update submodules 2021-12-15 01:55:36 -05:00
Adomas Ven
0a8ba2bced
Improve tree screen reader accessibility (#2263) 
Also:

* Allow opening tree context menu with Shift + F10 and Context Menu button
 2021-12-15 01:47:06 -05:00
Dan Stillman
fbef7c00dd Fix error deleting feed item with invalid attachment 
This shouldn't happen, and we should make sure we prevent plugins from
doing it, but if an attachment existed in a feed library, neither the
item nor the feed could be deleted.

https://forums.zotero.org/discussion/93453/unsubscribe-rss-feed-fail
 2021-12-14 08:17:42 -05:00
Martynas Bagdonas
338d753eb3 Fix itemBox opening popups in wrong bindings 2021-12-13 16:36:47 +02:00
Dan Stillman
644c4e5925 Add objects from failed download requests to sync queue 
Previously only individual objects from successful requests that
couldn't be processed for some reason would be added to the queue.

`Sync.APIClient.downloadObjects()` now returns clearer and more
consistent results. It now returns an array of promises for objects with
a `keys` array of requested keys and either a `json` array of returned
API JSON objects or an `error` Error, depending on whether the request
succeeded or failed. This makes it easier to detect remotely missing
objects and request failures.
 2021-12-10 05:56:46 -05:00
Martynas Bagdonas
86965988b4 Make PDF reader File menu "Show in Library" option to show parent item 
Fixes #2266
 2021-12-09 15:32:24 +02:00
Adomas Venčkauskas
aefd3dd94a Reduce timeout when downloading PDF via browser. 
Follow up to 4405b59
 2021-12-07 16:12:14 +02:00
Adomas Venčkauskas
73fb9c13df Fix preference style list refresh on modification. Closes #2256 2021-12-02 12:40:48 +02:00
Adomas Venčkauskas
0fdfa5f64b Fix test failure after #2248. Closes #2257 2021-12-02 12:21:23 +02:00
Adomas Ven
4405b59044
Add a function to download PDFs via a browser (#2248) 
Fixes zotero/translators#2739
 2021-12-02 04:27:33 -05:00
Dan Stillman
e54f59ae28 Fix error fetching Nature feeds 
Fixes #2249
 2021-11-26 04:20:13 -05:00
Dan Stillman
07df7d0dec Fix standalone notes not being added to collections on RDF import 
This includes the `Zotero.RDF.getResourceURI()` fix in
zotero/translate@85b39a5be.

This position change here for `this._handleRelated()` for attachments
isn't necessary, since the attachment is already saved and already has
an id, but it's done for consistency with the call for notes (where the
note previously didn't yet have an id).
 2021-11-25 00:24:56 -05:00
Tom Najdek
1f6b626717
Change browser in basicViewer to be type="content" 
This fixes an issue where JS on a page loaded in the viewer would error
when referring to window.top or window.parent.
 2021-11-25 01:02:02 +01:00
Tom Najdek
34d62426c3
Tweak URL matching regexp to be more precise 
Institutional login process goes through multiple pages, the URL regexp
is tweaked to be more precise to ensure that no arbitrary URLs are
matched while polling for the final URL with auth code.
 2021-11-25 01:01:55 +01:00
Adomas Venčkauskas
d03c495563 Update SingleFile to the latest version 2021-11-19 14:22:45 +02:00
Dan Stillman
32a5826a1f Log more of the response for downloaded PDFs that aren't PDFs 2021-11-16 14:29:53 -05:00
Dan Stillman
54588453dc Fix selection of collections pane on "Focus Libraries Pane" shortcut 2021-11-15 23:13:53 -05:00
Tom Najdek
f10649483e
Mendeley Import: Add more tests for the importer 
Also rephrased a comment in the importer code and renamed tests file
to mendeleyImportTest.js for consistency.
 2021-11-15 11:19:19 +01:00
Adomas Venčkauskas
dcce807e92 Enable publicationTitle column in feeds. Closes #2242 2021-11-09 16:23:33 +02:00
Adomas Venčkauskas
b9e1923656 Fix rows not deselecting with single click on one item. 
Closes #2241
 2021-11-08 14:06:36 +02:00
Martynas Bagdonas
80be9f9e3a Disable annotations transferring for read-only items 
#2239
 2021-11-08 13:24:13 +02:00
Martynas Bagdonas
af689b17fa Fix CMap loading for pdf-worker 2021-11-08 11:42:39 +02:00
Dan Stillman
f5eb99ad4c Upload settings in batches of 250 
Closes #2000
 2021-11-07 23:46:54 -05:00
Abe Jellinek
cd3304e16c
Don't reset isRead when feed item metadata changes (#2215) 
This prevents metadata changes from clearing the isRead status of feed
items as long as GUIDs remain constant. Previously, feed items with
randomized properties (like URLs generated dynamically each time the
feed is served) would be incorrectly marked as unread on every update.
 2021-11-05 23:16:12 -04:00
Abe Jellinek
2cf436c67d
Async web translation (#2229) 2021-11-05 23:12:37 -04:00
Martynas Bagdonas
b4cf566d0d Return back writeAtomic for PDF reader setState #2210 2021-11-05 17:09:40 +02:00
Dan Stillman
eb4090058d Tweak menu position and alert text for annotation transferring 2021-11-05 00:30:06 -04:00
Dan Stillman
f400d2a4a4 Include item type name in field-not-valid-for-type error 2021-11-05 00:29:45 -04:00
Tom Najdek
7940915bb0
Fix arXiv ID not imported. Fix #2236. (#2238) 
Mendeley online schema uses "arxiv", local DB uses "arxivId" hence it
was skipped. This commit adds mapping and a test.
 2021-11-04 15:32:35 -04:00
Tom Najdek
882ecc205e
Mendeley import: Remove code to patch after earlier imports (#2234) 
Fixes #2233, Mendeley import: Invalid-field-for-type error
 2021-11-03 23:32:36 -04:00
Martynas Bagdonas
c9d4ff4314 Add additional error logging for PDF reader and note editor 2021-11-03 11:50:21 +02:00
Martynas Bagdonas
6ac663a002 Encode a wider range of unicode characters when inserting a note 2021-11-02 15:06:40 +02:00
Adomas Venčkauskas
d530d9cf95 Fix collection open state persistance. Closes #2228 2021-10-29 11:28:41 +03:00
Martynas Bagdonas
90cc53361b Refocus to the last focused node when switching back to Zotero Pane tab 2021-10-28 11:25:25 +03:00
Adomas Venčkauskas
be49786668 Fix column reordering and hiding breaking sorting 2021-10-27 15:18:10 +03:00
Adomas Venčkauskas
5f3eeb7fcd Revert "Hack to fix sorting after reordering columns" 
This reverts commit 69a43ec456.
 2021-10-27 15:18:10 +03:00
Adomas Venčkauskas
aa7e502bad Restore ability to select individual items in duplicates view. 
Closes #2225. Only mouse clicks without modifiers will select the group
of duplicate items. This is the same behavior as with the XUL tree.
 2021-10-27 15:18:10 +03:00
Martynas Bagdonas
bc8b1a7c6d
Implement annotations transferring (#2202) 2021-10-27 13:48:40 +03:00
Martynas Bagdonas
a4cf36794e Focus itemsView when switching to Zotero Pane tab 2021-10-27 11:58:35 +03:00
Martynas Bagdonas
91dfcc96bf Make ZoteroPane keydown handler to catch all key presses on the window 
Fixes #2231
 2021-10-27 11:58:34 +03:00
Martynas Bagdonas
cdb826e358 Don't suggest to create note if only ink annotations exist 2021-10-26 16:56:15 +03:00
Martynas Bagdonas
3736a93c2c Add a work-around for mouseup events that are never triggered in reader 2021-10-26 12:12:03 +03:00
Martynas Bagdonas
d1322bd4b6 Improve PDFRenderer efficiency and add support for ink annotations 2021-10-25 12:46:12 +03:00
Martynas Bagdonas
59455ebfa7 Improve ink annotations support: 
- Allow to select in sidebar or PDF page
- Allow to delete or change color
- Generate image and store as with image annotation
 2021-10-22 10:14:28 +03:00
Martynas Bagdonas
6206209ed2 Fix item pane opening creator-type-menu in a wrong itembox binding 2021-10-19 17:14:44 +03:00
Dan Stillman
5f61ac23aa Don't include non-regular items in one-off bibliographies 
Applies to "Create Bibliography from Collection" and "Create
Bibliography from Items". Quick Copy already got this right.

https://forums.zotero.org/discussion/92305/sticky-notes-showing-in-bibliography
 2021-10-18 17:53:14 -04:00
Martynas Bagdonas
a07c052cf0 Allow to use Quick Copy from PDF reader tab 
Fixes #2023
 2021-10-18 09:57:57 +03:00
Adomas Venčkauskas
4e68b624f2 Persist column settings in the select items dialog. Closes #2224 
I didn't check the previous behavior, but I assume it's the same:
This will persist the same settings for the select items dialog in the
classic citation view as well as the add related item dialog.
 2021-10-15 15:43:00 +03:00
Adomas Venčkauskas
7a9bd56b9d Fix when dragging outside of the text of item pane message. Closes #2223 2021-10-14 15:33:43 +03:00
Dan Stillman
3d4a1a230e
Merge pull request #2217 from tnajdek/2216-mendeley-import-skips-over-large-files 
Concurrently downloading large files
 2021-10-13 13:20:00 -04:00
Martynas Bagdonas
8b11737b82 Import existing images when opening a note 
#2186
 2021-10-13 17:49:44 +03:00
Martynas Bagdonas
a4f09419e5 Fix context pane not properly assigning new note as standalone/child 2021-10-08 22:18:23 +03:00
Martynas Bagdonas
645eb86cbc Don't focus Zotero Pane window when opening a tab in background 2021-10-05 17:30:44 +03:00
Martynas Bagdonas
3c3eac43de Don't focus recognized PDF parent if Zotero Pane tab is not selected 2021-10-05 17:30:44 +03:00
Adomas Venčkauskas
78e31cf50f Fix broken font scaling in the retrieve metadata/progress queue dialog. 
Closes #2218
 2021-10-05 12:55:38 +03:00
Adomas Venčkauskas
62e2ccafa0 Replace deprecated usage of Utilities.itemToCSLJSON 2021-10-05 12:55:38 +03:00
Adomas Venčkauskas
82eb7453a8 Add a method to remove event listeners from event dispatchers 2021-10-05 12:55:38 +03:00
Martynas Bagdonas
05139cfff8 Persist pdf-reader sidebar width 
#2184
 2021-10-04 17:10:31 +03:00
Martynas Bagdonas
7f23533ee9 Automatically update citations when user opens a note 2021-10-04 13:23:03 +03:00
Tom Najdek
a745cde2cf
New implementation of a download function #2216 
This resolves a problem where, in certain scenarios,
Zotero.file.download throws an exception even though file is
successfully downloaded.

Furthermore this new download function should be more memory-efficient,
improving performance when dealing with large files.
 2021-10-02 00:39:10 +02:00
Martynas Bagdonas
3b84e29c9e Update context pane notes list when note is moved to/from parent 2021-10-01 14:47:50 +03:00
Martynas Bagdonas
47c61d3a4d Add limitations for attachment notes 2021-10-01 13:19:20 +03:00
Martynas Bagdonas
c0ecd7691b Focus parent from tab "Show in Library", and PDF file from File menu 2021-09-27 13:46:19 +03:00
Martynas Bagdonas
1f634f9e31 Use OS.File.writeAtomic without tmpPath to avoid #2210 2021-09-23 13:53:47 +03:00
Martynas Bagdonas
47d4949b2a Upgrade note-editor schema to v5: 
- Make citation node a leaf node.
- Don't parse citation node inner text.
- Don't trigger citation inner text updating on citation item changes.
- Format citation text only when serializing note HTML.
- Wrap individual citation items into `<span class="citation-item"></span>`.
 2021-09-22 19:30:44 +03:00
Dan Stillman
7e8bc80c1d "Manage Lookup Engines" dialog tweaks (#2195) 
- Lowercase "engines"
- Increase font size
- Switch to hyphenated element id
 2021-09-17 05:38:56 -04:00
Abe Jellinek
241981057b Correct Lookup Engine description 
The Locate dropdown isn't in the Info pane, and the text was a bit more
verbose than it needed to be.
 2021-09-17 05:38:56 -04:00
Dan Stillman
f0a8c9ada3 Merge pull request #2070 from mrtcode:restore-context-pane-tags-related 2021-09-14 01:53:21 -04:00
Dan Stillman
647afbb089 Update related box if related items are renamed or deleted 2021-09-14 01:50:58 -04:00
Martynas Bagdonas
61e3e339bb Restore tags and related tabs, display note links box 2021-09-14 01:50:58 -04:00
Dan Stillman
fa4020f784 HTML tree: Disable clickthrough on collection and item trees 
And also the tag selector, while we're at it. Leaving enabled for the
item pane.

(Clickthrough is responding to a click when the window doesn't have
focus, rather than having the first click just raise the window.)

Fixes #2203
 2021-09-14 00:43:15 -04:00
Dan Stillman
aeabe0b3f6 Fix inability to drag subcollection to top level within group library 
HTML tree regression

Fixes #2201
 2021-09-14 00:43:15 -04:00
Abe Jellinek
c5067edd2d
Fix Scaffold failing to initialize (#2200) 2021-09-09 05:17:35 -04:00
Martynas Bagdonas
7468065528 Switch to library tab when dragging a PDF file over Zotero window 2021-09-07 16:53:20 +03:00
Martynas Bagdonas
d38d42d60c Focus main window when navigating to annotation from note window 2021-09-07 12:01:42 +03:00
Dan Stillman
7672340819 HTML tree: Don't select all items on Cmd-Shift-A 2021-09-02 20:24:44 -04:00
Dan Stillman
576b9b7817 Fix SQL error saving an item with hundreds of related items 
Fixes #2139
 2021-09-01 06:19:56 -04:00
Dan Stillman
14b7206276 Get row height from tree for ItemTree::ensureRowsAreVisible() 2021-09-01 05:15:44 -04:00
Dan Stillman
dadf630728 HTML tree: ensureRowsAreVisible() shouldn't scroll if unnecessary 
Fixes #2166
 2021-09-01 01:45:54 -04:00
Dan Stillman
69a43ec456 Hack to fix sorting after reordering columns 
There's probably a better fix for this, but this seems to work.
 2021-08-31 06:55:57 -04:00
Dan Stillman
4fa7070a31 Fix item tree sorting when column doesn't have .sortDirection property 2021-08-31 06:55:57 -04:00
Martynas Bagdonas
d77b00bf9a Clarify and comment tab moving code 2021-08-31 11:37:01 +03:00
Adomas Venčkauskas
d8af5b7923 Fix wrong collection contents shown when switching collections at startup 
Closes #2175
 2021-08-30 15:19:12 +03:00
Adomas Venčkauskas
d4b3ed7fd8 HTML Tree: Fix opening multiple items with [Enter] 2021-08-30 15:19:12 +03:00
Martynas Bagdonas
b5ea925d02 Jump back to the opening tab even if the PDF was already open 
Fixes #1985
 2021-08-30 14:56:09 +03:00
Martynas Bagdonas
295874f803 Fix issue where non-existing tab is selected when closing multiple tabs 2021-08-30 14:12:22 +03:00
Martynas Bagdonas
b8cb093f79 Open multiple PDFs in tabs if SHIFT wasn't pressed, remove old code 2021-08-30 13:43:14 +03:00
Adomas Ven
cb9df902bc
HTML Tree: make find as you type a virtualized table functionality (#2176) 
Closes #2168, closes #2169.
Adds find-as-you-type to locate, preference style and export
formats managers.

To enable find as you type you need to specify the getRowString(index) prop
on the VirtualizedTable. See prop comment for more info.
 2021-08-30 06:01:08 -04:00
Adomas Venčkauskas
94c4d975a9 HTML Tree: fix item deletion breakage when child items are selected. 
Closes #2174
 2021-08-30 12:50:29 +03:00
Adomas Venčkauskas
873846261e Fix export preferences HTML tree 2021-08-30 12:06:17 +03:00
Martynas Bagdonas
aa7f5289a3 Filter ink annotations before creating note from annotations 2021-08-30 11:06:10 +03:00
Dan Stillman
c2df338430 Allow 'ink' annotation type to be created 2021-08-30 03:58:58 -04:00
Adomas Venčkauskas
37d5e99fde Fix some keyboard selection bugs in HTML collection tree 
Moving pivot via [CMD/CTRL]+[ArrowKey] would change collection tree
focus without updating the UI
Select-all shortcut worked in the collection tree
 2021-08-30 10:23:03 +03:00
Adomas Venčkauskas
b8545590d5 HTML Tree: more fixes to find as you type 2021-08-30 09:57:28 +03:00
Adomas Venčkauskas
2ef5afdd9c Disable typing navigation with modifier keys pressed. Closes #2170 2021-08-30 09:52:13 +03:00
Dan Stillman
d723065a3d HTML tree: Don't move dragged external files by default on macOS 
Fixes #2172
 2021-08-30 02:40:06 -04:00
Dan Stillman
952663de73 Fix failing repo notice tests 2021-08-29 04:41:52 -04:00
Dan Stillman
2459614f04 Add mechanism for showing dialog with notice from repo 
- Messages are shown once a day by default (within the same session for
  id-less messages)
- Messages with an `id` attribute include a checkbox to not show again
  for 30 days
- If an `infoURL` attribute is provided, a "More Information" button is
  shown that launches that URL
- If `title` is provided, it's used for the dialog title. Otherwise
  "Warning" is shown.
 2021-08-29 04:25:49 -04:00
Dan Stillman
ba7d0a18aa Restore itemTree::saveSelection() 
Deprecated for years, but used by ZotFile
 2021-08-29 01:41:40 -04:00
Dan Stillman
8d3adb6f46 HTML tree: Add tree.focus() 
And fix shortcut key for selecting library
 2021-08-28 22:43:09 -04:00
Dan Stillman
dba77cd332 Additional tab context menu tweaks (#2162) 
- Select last reopened tab instead of opening all in background
- Rearrange Close/Close Other Tabs/Reopen Closed Tabs options
- Use proper plural for Reopen Closed Tab[s]
 2021-08-27 16:52:22 -04:00
Martynas Bagdonas
50732d1479 Add tab context menu (#2162) 2021-08-27 16:52:02 -04:00
Dan Stillman
7019544b48 Add ink annotation type 2021-08-27 16:28:45 +03:00
Adomas Venčkauskas
77f726fef3 HTML Tree: improve row scrolling into row behavior upon toggling open 2021-08-27 13:54:33 +03:00
Adomas Venčkauskas
b05e22fa77 HTML Tree: Make search context rows selectable. Closes #2164 
Adds special handling such that context rows are not selected only
when performing a select-all.
 2021-08-27 13:36:03 +03:00
Adomas Venčkauskas
0a7aa10463 HTML Tree: Fix refresh bugs when a feed is modified. Closes #2163 2021-08-27 13:05:35 +03:00
Adomas Venčkauskas
ab9414d1a4 HTML Tree: some additional documentation 2021-08-26 16:40:41 +03:00
Adomas Venčkauskas
a71addb12a Make sure including include.js multiple times does not break monkey-patching 
This is important for plugins that want to monkey-patch interfaces that
are only accessible via require() calls
 2021-08-26 16:21:52 +03:00
Adomas Venčkauskas
b08f2d829f Update the HTML tree to allow extension via Zotero plugins 2021-08-26 16:16:44 +03:00
Adomas Venčkauskas
20e2f33064 HTML Tree: Optimize tree invalidation 2021-08-26 14:40:59 +03:00
Adomas Venčkauskas
bffa64bdda HTML Tree: Re-add item tree methods lost in transition 2021-08-26 10:14:35 +03:00
Adomas Venčkauskas
b91664435f HTML Tree: Fix Show Items from Subcollections. Closes #2160 2021-08-26 09:33:47 +03:00
Martynas Bagdonas
89d1899690 Add UI feedback when moving tab 
Fixes #1988
 2021-08-26 08:23:19 +03:00
Martynas Bagdonas
d55b80df80 Show author and year in PDF reader tab/window title 
Fixes #2034
 2021-08-26 08:23:19 +03:00
Martynas Bagdonas
ecd6d7ce2c Implement tab jumpback 
#1985
 2021-08-26 08:23:19 +03:00
Martynas Bagdonas
b6d562b0cb Allow middle button click to close a tab 
Fixes #1993
 2021-08-26 08:23:19 +03:00
Adomas Venčkauskas
da7527e384 Fix intro message not getting cleared when adding new item. Closes #2158 2021-08-25 18:19:30 +03:00
Dan Stillman
13f2c57196 Fix sizes of items pane messages 
7ef7943a17 made "Loading items…" small again after it got big during
HTMLification but made everything else (e.g., welcome message, My
Publications intro) small as well. This adds an ugly hack to keep the
loading message small for now (without passing dedicated HTML from a
bunch of different places).
 2021-08-25 03:50:12 -04:00
Dan Stillman
0bbe064245 Don't toggle libraries-to-sync row on Enter 
Otherwise if you close the dialog with Enter the current row (which is
probably the row you just changed) is toggled

Regression from HTMLification
 2021-08-25 02:27:45 -04:00
Dan Stillman
4d88e99e9e Increase icon column width in libraries-to-sync dialog 
A bit wider than d4e3a437f, since the column header seems to not
currently be centered properly at narrow widths
 2021-08-25 02:18:08 -04:00
Dan Stillman
92e6a536f1 HTML tree: Add alternating rows to all trees except collections on macOS 2021-08-25 02:16:19 -04:00
Dan Stillman
d0635e12cb
Add disableFontSizeScaling prop to HTML tree (#2155) 
Removes `defaultRowHeight` prop added in adb8aa39f in favor of a prop
that disables font size scaling. A non-default row height can still be
specified with `rowHeight`.

Most of our existing trees need to disable font size scaling, but the
idea is that pretty much everything _should_ scale with font size for
accessibility, and it's a limitation of the current prefs and other UIs
that they don't currently, so it's better to default to scaling and
gradually remove uses of this prop.

This fixes a bug where the HTML trees other than the collection and item
trees would have larger rows but without larger text when font size was
increased.

Also:

- Fixes #2157 by fixing line height adjustment on macOS when at the
  default font size, applying it to all trees, and moving the explicit
  `rowHeight` override from the item tree to the collection tree, which
  should have more spacing than all other trees (rather than the item tree
  having less).
 2021-08-25 01:53:22 -04:00
Adomas Venčkauskas
462af98380 Restore libraries-to-sync UX. Closes #2156 2021-08-24 17:15:17 +03:00
Adomas Venčkauskas
6010390525 HTML Tree: Fix column separators misaligned at startup. Closes #2153 2021-08-24 16:44:55 +03:00
Dan Stillman
d4e3a437fd Reduce width of icon column in libraries-to-sync dialog 
Changed during HTMLification
 2021-08-24 01:25:47 -04:00
Martynas Bagdonas
85b142ccb2
Restore tabs state (#2148) 2021-08-23 13:02:57 -04:00
Dan Stillman
f9035c8fda Show emoji colored tags directly in items list 
We can do fun things now.

Also:

- Make colored tag swatches resize with the font size
- Increase border radius for color swatches, and adjust with size
 2021-08-22 04:41:34 -04:00
Dan Stillman
cc4225db1a Restore localized date in Styles list in Cite prefs 
With the new tree, this was showing the full timestamp from the style
object.
 2021-08-21 06:58:12 -04:00
Dan Stillman
adb8aa39f8 Reduce item tree row spacing 
This matches the previous tree on macOS.
 2021-08-21 06:58:12 -04:00
Dan Stillman
ec35291060 Decrease item tree indent 
Roughly center child item icons between the parent item icon and text,
which looks a bit less awkward than the previous tree's positioning. An
alternative would be to align with the beginning of the parent item text
(a value of 21), but that's a bit spaced out, at least until we have
multiple levels with additional twisties.
 2021-08-21 06:58:12 -04:00
Dan Stillman
c85a434eb6 Reduce collection tree indent 
At least on macOS, this brings it back in line roughly with the previous
version.
 2021-08-21 06:58:12 -04:00
Dan Stillman
c965e6159a Fix collection tree header indentation on macOS 2021-08-21 06:58:12 -04:00
Adomas Venčkauskas
881ab5f59e Store column prefs to a dedicated file in a profile dir instead of XPCOM prefs 2021-08-21 06:58:12 -04:00
Adomas Venčkauskas
a2062bf011 Fix selection not being maintained when collapsing/expanding rows 2021-08-21 06:58:12 -04:00
Adomas Venčkauskas
55c758c9d0 Fix header columns being misaligned with table columns in item tree 
And reindent _virtualized-table.scss
 2021-08-21 06:58:12 -04:00
Adomas Venčkauskas
431d7e1eaa Fix alternating-row colours switching upon child expand-collapse 2021-08-21 06:58:12 -04:00
Adomas Venčkauskas
efc009f724 Fix collection tree header alignment on macOS 2021-08-21 06:58:12 -04:00
Adomas Venčkauskas
7ec89c44ce Improve column sorting speed 2021-08-21 06:58:12 -04:00
Adomas Venčkauskas
ff627b7d3f Ensure column order and width prefs are properly retained 2021-08-21 06:58:12 -04:00
Adomas Venčkauskas
9e04250142 Do not sort a column on mouseup if mousedown occurred on a different one 2021-08-21 06:58:12 -04:00
Adomas Venčkauskas
4cea4519b8 Fix column resizing weirdness with fixed with columns 2021-08-21 06:58:12 -04:00
Adomas Venčkauskas
277503f879 Fix rows not being properly redrawn in duplicates view 2021-08-21 06:58:12 -04:00