Commit graph

4202 commits

Author SHA1 Message Date
Dan Stillman
496d4c5e77 Properly show saveURI errors in Zotero.Attachments.importFromURL() 2015-02-01 21:09:13 -05:00
Dan Stillman
f5c173b1e5 Fix saving files from translators
(More breakage from 5f8b56ef8)
2015-02-01 21:07:24 -05:00
Dan Stillman
fb8149e6db Clarify icon comment 2015-01-31 16:01:53 -05:00
Dan Stillman
bcacb79489 Fix remote file saving
5f8b56ef8 was so many different kinds of broken
2015-01-31 15:23:58 -05:00
Frank Bennett
5cfe4db098 Use nav-bar as target ID for Zotero nav bar icon
The statusBarIcon pref is retained to maintain state across
starts.
2015-01-30 22:42:34 +09:00
Dan Stillman
f04b641f3c Merge pull request #617 from aurimasv/content-handler
Content handlers
2015-01-30 04:09:03 -05:00
Dan Stillman
d8f2d4b268 Merge branch 'fx36-saveURI' into 4.0 2015-01-30 03:56:58 -05:00
mizu
5f8b56ef86 Fix saveURI() in Firefox 36+ 2015-01-30 03:55:35 -05:00
Dan Stillman
783ba4a0b7 Merge pull request #618 from aurimasv/prefs-unicode
Retrieve unmangled unicode strings from preferences
2015-01-30 03:42:34 -05:00
Dan Stillman
f2ffc30728 Merge pull request #607 from rmzelle/rename-style-panes
Localize Style Editor and Preview and other improvements
2015-01-28 22:57:10 -05:00
rmzelle
0be9e73b51 Further improvements to Style Editor and Preview
* Clean up code (remove some pre-CSL 0.8.1 code, see also e32e6aa2f5 )
* Complete localization
* Save vertical space. Editor: remove "pre-wrap" wrapping, use smaller headers, add grippy to collapse CSL code. Preview: remove groupbox
2015-01-28 22:20:20 -05:00
rmzelle
eec1ba4c73 Put JavaScript code from Style Editor and Preview into separate files 2015-01-28 22:20:20 -05:00
rmzelle
6fd3b298de Rename Reference Test and Preview panes
* Also start localization of Zotero Style Preview
2015-01-28 22:07:39 -05:00
Dan Stillman
55d84bcbf3 Merge pull request #609 from aurimasv/retrieve-meta-max-pages
Allow MAX_PAGES (for retrieving metadata) to be user-adjustable
2015-01-21 01:01:47 -05:00
Aurimas Vinckevicius
e8e0f5e831 Bump MAX_PAGES to 15
Re https://forums.zotero.org/discussion/45641/error-getting-metadata/#Item_10
2015-01-20 23:58:41 -06:00
Aurimas Vinckevicius
11017b650c Retrieve unmangled unicode strings from preferences 2015-01-20 23:28:22 -06:00
Aurimas Vinckevicius
f7893ef400 Don't require Zotero restart to change RIS/BibTeX handling preference 2015-01-20 22:46:30 -06:00
Aurimas Vinckevicius
3f3666c972 Add Zotero.Prefs.registerObserver
* Easier monitoring of preference changes
* Takes a preference name and a handler function that will be passed the new value of the preference
* Unregister observer via Zotero.Prefs.unregisterObserver with the same parameters
2015-01-20 22:45:28 -06:00
Aurimas Vinckevicius
4ecdd55717 Continue with default if declining Zotero to handle RIS/BibTex/etc. 2015-01-20 21:54:05 -06:00
Aurimas Vinckevicius
8be83cedec Allow file paths to be specified in attachment.url
In translators, it may not always be clear whether the given URI is a URL or a local file path.
Regression from 849803473a (that piece of code was introduced by me)
Re https://forums.zotero.org/discussion/45710/ris-import-from-endnote-mac-yosemite-to-zotero-standalone/
2015-01-19 15:13:49 -06:00
Aurimas Vinckevicius
869fdf61ae Make sure that there's always a title for a given URL
E.g. https://read.amazon.co.uk/?asin=XXXXXXXXX was resulting in a blank title
2015-01-18 10:41:17 -06:00
Aurimas Vinckevicius
79a79bb47a Fix typo in attachLink.xul 2015-01-18 10:40:12 -06:00
Simon Kornblith
06615f738f Tweak method for parsing XML without a window to handle UTF-8 properly
Fixes issue reported at https://forums.zotero.org/discussion/45556
2015-01-14 01:56:09 -05:00
Steve Jamieson
0d2a205110 Fix for OpenURL 0.1 resolver detection
The discoverResolvers function was looking for the wrong XML tag name representing OpenURL version 0.1 in the response from the WorldCat Registry
2015-01-13 14:20:57 -06:00
Simon Kornblith
7d19e17bb9 Ensure that we pass WebPageDump an XPCNativeWrapper
Fixes some CSS issues in snapshots
2015-01-13 01:51:03 -05:00
Dan Stillman
f1a3cb3577 Update versions, submodules, and repotime 2015-01-12 21:54:56 -07:00
Simon Kornblith
90625e8a05 Fix translators callback from translators on Fx 35 (affects COinS) 2015-01-12 19:33:12 -05:00
Simon Kornblith
5c76347674 Improve translation on Nightly (with e10s disabled)
I haven't fully tested, but this fixes Google Scholar
2015-01-12 11:27:39 -05:00
Simon Kornblith
e082a4fc28 Fix PDF metadata retrieval on Fx 35 2015-01-12 02:44:09 -05:00
Simon Kornblith
da7ee2ba26 Tweak sandboxing for Firefox 35
Now we have to wrap cross-origin objects with a wrapper on the sandbox
side. Also, Function.prototype.apply.apply...
2015-01-12 01:41:01 -05:00
Simon Kornblith
fa75beeefd Fix bookmarklet under Chrome
checkIsOnline isn't called before the connector gets used except in IE.

The mixed content blocker in modern IE combined with the https
redirect breaks communication with ZSA on all pages anyway, so we may
just want to give up on making the bookmarklet talk to ZSA.
2015-01-08 01:46:20 -05:00
Simon Kornblith
541ebd1f22 Merge pull request #596 from aurimasv/conn-reg
Fix regression from 0cd183613f
2015-01-07 20:10:34 -05:00
Philipp Zumstein
d5b4c31575 Right pane (item-pane) can be collapsed
This belongs to issue #509 and was asked several times in the forum.

 * Add attribute `collapse="after"` to the splitter and add a grippy element.
 * To remember its state after restart I copied `zotero-persist="state"`.
 * Handle zotero-items-splitter the same as zotero-collections-splitter in zotero-platform/mac/overlay.css
 * Change min-width to 250px for #zotero-item-pane in zotero/overlay.css.
 * Update the function `updateToolbarPosition` in zotero/zoteroPane.js:
   * The width of the items-toolbar is corrected if the left pane is collapsed (and the icons are grouped on the left margin together).
   * If the right pane is collapsed, then the items-toolbar is made flexible while making the item-toolbar unflexible. As a result the search box and locate icon are flushed right to the other icons.
2015-01-07 10:41:18 +01:00
Aurimas Vinckevicius
8d7db5a63e Remove safeDebug 2014-12-27 01:43:33 -06:00
Aurimas Vinckevicius
20a50d1aaa Refactor Zotero.Utilities.varDump. Add handling for Error and XPCOM objects 2014-12-27 01:43:33 -06:00
Dan Stillman
0b3b296e28 Keep active item pane editing field open when window loses focus
Closes #153
2014-12-26 14:16:41 -05:00
Dan Stillman
3024162bfe Merge pull request #510 from mtd91429/linkURI
Link URI re: issue #486
2014-12-16 12:01:22 -05:00
MTD
849803473a Address silent failure of unrecognized URIs in Attach Link to URI
Generated files for a more robust attached-link-dialog and localized strings
* AttachLink.js
* AttachLink.xul

zotero/xpcom/attachments.js
* created function cleanAttachmentURI
* in function linkFromURL, removed the regex constraints and the comment list of valid protocols
* removed outdated function declaration from beginning of script
* Improved automatic title generation mechanism
2014-12-16 11:20:55 -05:00
Dan Stillman
950302d8ee Merge pull request #507 from f-mb/quick-search-for-civil-law-case
Allow QuickSearch to search for civil law cases
2014-12-15 19:43:58 -05:00
Aurimas Vinckevicius
bb53e7beb2 Fix regression from 0cd183613f
Was breaking connectors
2014-12-11 15:00:50 -06:00
Aurimas Vinckevicius
2f79cb221f Fix duplicate matching when ISBN is non-sensical
Re https://forums.zotero.org/discussion/43046/items-mistakenly-identified-as-duplicates/
2014-12-10 15:59:26 -06:00
Dan Stillman
ee389f106e Merge pull request #593 from rmzelle/update-csl-preview
Update cslpreview.xul
2014-12-10 14:30:02 -05:00
rmzelle
e2f1f354f3 Update Zotero Preview pane
* Remove splitter
* Add explanation of how Zotero Preview pane works
* Limit filtering to citation format
  Also add support for “citation-format” attribute of CSL 1.0
* Remove redundant warning
  (already happens on this.refresh)
* Use "items" instead of "references"
* Clean up HTML a little
* Fix some JSHint warnings
2014-12-10 07:42:05 -05:00
Dan Stillman
09638cbd2c Merge pull request #585 from aurimasv/nfc
Normalize all user and translator input to NFC
2014-12-09 19:21:04 -05:00
Dan Stillman
20dd8c89d8 Remove "CSL" column in Cite -> Styles preferences 2014-12-09 19:19:40 -05:00
Dan Stillman
3a058c68ed Use config URL for all repo requests, and move config to separate file 2014-12-09 18:53:53 -05:00
Dan Stillman
c28ef6f2d6 Use HTTPS for proxy auth check 2014-12-09 18:36:06 -05:00
Dan Stillman
2a27cd506d Remove DB_REBUILD config option
I don't think anyone has used this in many years.
2014-12-09 18:35:03 -05:00
Dan Stillman
4f7e5446e8 Remove unused block 2014-12-09 17:49:15 -05:00
Aurimas Vinckevicius
9ee67ca291 Disable ZSA ping from bookmarklet in non-IE browsers
This means that bookmarklet will only save to server.
2014-12-09 13:12:05 -06:00
Dan Stillman
e3d7101923 Update version 2014-12-02 00:26:41 -05:00
Dan Stillman
d894fdb1d4 Fix citation list generation via right-click and quick copy
Broken by 523724185

Not sure if cslEngine.opt.class is a safe way to get the class. @fbennett?
2014-12-01 17:12:07 -05:00
Dan Stillman
0fd0da2903 Fix "getItemAtRow(...) is undefined" error for some item modifications
Since 67c63a29
2014-12-01 16:51:11 -05:00
Simon Kornblith
01c80610b4 Maybe fix for Firefox 31
Still need to test more comprehensively
2014-12-01 03:17:03 -05:00
Simon Kornblith
0cd183613f Fix for Firefox 34
Passing sandboxes between translators became difficult. This change
loads all translators in the same sandbox, using the same ugly hack as
in the connectors to get us close enough to being able to load
translators into separate scopes for things to work.

Conflicts:
	chrome/content/zotero/xpcom/translation/translate.js
2014-12-01 02:48:53 -05:00
Dan Stillman
524a71cfe8 Fix sync error with missing base directory set
Fixes #376
2014-12-01 02:32:44 -05:00
Dan Stillman
43c03c6aca Update another version 2014-12-01 02:18:04 -05:00
Dan Stillman
d7d542a79c Update version, submodules, and repotime 2014-12-01 02:17:09 -05:00
Dan Stillman
67c63a2968 Remove child items from view when removing parent
https://forums.zotero.org/discussion/42218/
2014-11-28 16:37:40 -05:00
Dan Stillman
55068a0059 Use the whole firstCreator string in sortCreatorAsString mode
And in the default mode, use the whole string up through 'and' or 'et al.'
before falling back to full creator sorting, which could speed things up
slightly.
2014-11-26 20:12:07 -05:00
Aurimas Vinckevicius
bd87bd3f56 Normalize all user and translator input to NFC
This includes storing values into DB and performing searches. Note that export/display of existing data is not normalized. We can try to capture all access points to the database and normalize on output, but that seems like a lot of unnecessary normalization happening all the time. Would probably be best to just normalize existing data.
2014-11-23 13:55:01 -06:00
Aurimas Vinckevicius
ff28b24389 Don't use let inside translate.js. Breaks connectors 2014-11-20 08:42:27 -06:00
Dan Stillman
6e43942385 Fix UI issues with Cyrillic mime types, hopefully 2014-11-17 23:20:11 -05:00
Dan Stillman
828bcd9a11 Merge pull request #577 from fbennett/csl-once-on-drag
Instantate CSL processor once on drag, changing output mode on the fly
2014-11-13 17:15:55 -05:00
Dan Stillman
7ac1ba5242 Fix file sync error with Hola extension enabled
With Hola enabled, uploads were failing with NS_BASE_STREAM CLOSED -- it
seems to do something that causes the stream to be read more than once.
Adding REOPEN_ON_REWIND fixes this.
2014-11-12 20:09:39 -05:00
Simon Kornblith
9017aa69db Fix typo 2014-11-12 14:45:15 -05:00
Dan Stillman
cefab23888 Add tooltip to Zotero toolbar button 2014-11-10 18:06:17 -05:00
Frank Bennett
523724185c Instantate CSL processor once on drag, changing output mode on the fly 2014-11-09 06:46:37 +09:00
Dan Stillman
5bfc1e4199 Fix comment - force-delete on Win/Linux is Shift, not Ctrl 2014-10-28 13:45:55 -04:00
Aurimas Vinckevicius
3b4c502ca9 [RecognizePDF] Attempt to search by ISBN even if we found a DOI
(but only if DOI search failed)
2014-10-24 14:18:26 -05:00
Aurimas Vinckevicius
15722e5022 Allow calling Zotero.Translate.*.translate without setting translator first.
This simply means that detection code will be run first.
Attempting this with Export translators will fail, because trying to detect a translator does not make sense in this case.
2014-10-24 14:18:26 -05:00
Aurimas Vinckevicius
151e95075a Allow dependent styles to override parent style locale
Re https://forums.zotero.org/discussion/36595/defaultlocale-of-dependent-doesnt-override-that-of-its-parent/
2014-10-23 13:00:36 -05:00
Dan Stillman
a737f2c2aa Treat 260-character paths as too long on Windows
I understood the path limit to mean >260, but a user is seeing the error
with a 260-character path [1], so let's try this.

[1] https://forums.zotero.org/discussion/41410
2014-10-21 13:03:52 -04:00
Dan Stillman
226928f1e9 Debugging for "types[i] is undefined" error 2014-10-21 00:45:48 -04:00
Dan Stillman
6c814e2fa2 Update version 2014-10-14 22:55:07 -04:00
Simon Kornblith
4984e87ade Reinstate __exposedProps__
This is ignored in Firefox 33, but seemingly still necessary in
Firefox 32
2014-10-14 22:44:04 -04:00
Dan Stillman
12619273b5 Update submodules and repotime 2014-10-14 03:26:15 -04:00
Dan Stillman
aab3276276 Use old-style searchbox in Yosemite pre-Fx34
Yosemite introduces a new search textbox shape, but Firefox still uses
the old focus ring shape until 34, so we fake the old searchbox shape
for earlier versions.
2014-10-14 02:22:44 -04:00
Simon Kornblith
1f41253256 Update citeproc-js to 1.0.543 2014-10-13 23:25:24 -04:00
Dan Stillman
94060e113f Remove debugging for download overlay issue 2014-10-10 19:23:52 -04:00
Dan Stillman
39b01b80e0 Additional debugging for download overlay issue 2014-10-10 19:18:09 -04:00
Simon Kornblith
d3a69be997 Fix translation under Firefox 33
Our strategy: put arguments into a property of the function, and then
get them out unwrapped. This avoids security checks on arguments passed
to the function.
2014-10-10 18:31:10 -04:00
Dan Stillman
fc0f541ad8 Additional debugging for saving from download overlay 2014-10-10 18:03:13 -04:00
Dan Stillman
8359db1426 Better debugging for saving from download overlay 2014-10-10 17:36:49 -04:00
Dan Stillman
9c9b8b835d Fix crash when dragging items to collections from advanced search window
(Dragging to the items list is still disabled.)
2014-10-10 16:01:09 -04:00
Dan Stillman
e34c0db060 Make 'https' the default in WebDAV prefs drop-down 2014-10-08 13:49:41 -04:00
Dan Stillman
eba296a45f Closes #554, Sync settings pane should point to new TOS 2014-10-08 13:11:30 -04:00
Dan Stillman
497939bb28 Fix "Open Account Settings" button in quota dialog in Standalone
(Untested, but this should work.)
2014-10-08 13:04:56 -04:00
Dan Stillman
71bd1a7f99 Fix state check errors (middle-pane restart messages) during syncing
The state check errors were caused by 4812ab6f, which was a fix for
"Q.async(...)(...) is undefined" errors caused by ad8b81f4c, which was a
fix for "too much recursion" errors related to Task.spawn() on Windows
with JIT enabled.
2014-10-05 12:03:50 -04:00
Dan Stillman
72bb8acfd1 Fix previous commit 2014-10-03 16:06:01 -04:00
Dan Stillman
0f2e24dc5c Log state check errors (and other logError calls) to debug output 2014-10-03 16:05:14 -04:00
Dan Stillman
cb707a55c8 Fix breakage from 10ba5e31d 2014-09-20 16:34:36 -04:00
Dan Stillman
b0550273ae Update another version 2014-09-19 20:43:50 -04:00
Dan Stillman
f09871a1ee Convert additional for..in loops to for loops in getDisplayTitle() 2014-09-19 20:39:23 -04:00
Dan Stillman
10ba5e31d6 Fix error from letter items with more than 10 recipients
https://forums.zotero.org/discussion/40218/
2014-09-19 20:37:59 -04:00
Dan Stillman
ce6cba7974 Don't log stack trace for getString() failure unless unexpected 2014-09-19 15:52:53 -04:00
Dan Stillman
fd31e41e2f Add localization todos 2014-09-18 17:41:46 -04:00
Dan Stillman
57ec10dfd4 Remove unnecessary var 2014-09-18 17:35:25 -04:00
Dan Stillman
48955c8983 Check ext length explicitly in createShortened when checking path length 2014-09-18 17:34:10 -04:00
Dan Stillman
2a986c8635 Don't match extension in createShortened() for dot-files (.hidden) 2014-09-18 17:23:57 -04:00