mirrors/zotero
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
5907 commits 9 branches 362 tags 278 MiB
Commit graph

3762 commits

Author SHA1 Message Date
Dan Stillman
8e8bc15071 Closes #291, Default to last-used item type when creating item via 
keyboard
 2013-07-02 16:48:53 -04:00
Dan Stillman
30a0bbcca2 Fix conflict with Cmd-Shift-A, and probably other third-party shortcuts 
The Zotero shortcut keys, and their event.preventDefault(), were bound
to keydown, so shortcuts bound to keypress were still be called. This
moves most of the shortcut handling code into the keypress handler.

Fixes #344
 2013-07-02 02:43:53 -04:00
Dan Stillman
4d9191ccd8 Fixes #343, Add Item by Identifier textbox is truncated on second open 2013-06-30 01:46:50 -04:00
Dan Stillman
d1e2ea57a5 Maybe fix note overwriting with embedded images in notes 
But given that I can't really reproduce it, this is more of a guess.
 2013-06-28 15:26:23 -04:00
Simon Kornblith
85682dbb19 Remove field codes for empty bibliographies when refreshing 
This happens when a user inserts a bibliography in the middle of a
paragraph and doesn't fully delete it.

Also remove unused code for deleting citations from the document.
 2013-06-27 22:02:35 -04:00
Simon Kornblith
44bb1ad976 Ignore empty bibliography fields 2013-06-27 22:02:31 -04:00
Simon Kornblith
28355c5ab5 Fix error message when inserting a field in an unsupported location 2013-06-27 22:01:31 -04:00
Simon Kornblith
f0c2507b89 Anchor regex 2013-06-19 02:23:26 -04:00
Simon Kornblith
6f9ffe13e3 Don't change capitalization of unabbeviated words in journal titles 
Fixes https://forums.zotero.org/discussion/30352/
 2013-06-18 23:51:46 -04:00
Simon Kornblith
9f0e5c02a6 Ignore files in translators directory not ending in .js 
Fixes #339
 2013-06-13 14:18:59 -04:00
Simon Kornblith
f02132f5a9 Merge pull request #330 from aurimasv/4.0 
Prefer higher priority translators even if they don't target the top frame
 2013-06-06 16:50:34 -07:00
Simon Kornblith
6ef9a061f3 Only use Components.utils.methodjit when supported 
As Boris Zbarsky pointed out in
https://bugzilla.mozilla.org/show_bug.cgi?id=878679,
the setTimeout() hack doesn't help in Firefox 23 and later. For now we
use the useMethodjit hack when available, so that performance won't
regress for Firefox 23, and cross our fingers that
https://bugzilla.mozilla.org/show_bug.cgi?id=776798 is fixed for
Firefox 24.
 2013-06-06 19:38:48 -04:00
Simon Kornblith
1cee348f51 Revert "Remove use of Components.utils.methodjit" 
This reverts commit 53a4d987b6.
 2013-06-06 19:31:09 -04:00
Simon Kornblith
53a4d987b6 Remove use of Components.utils.methodjit 
It appears that this flag can no longer be set in new-ish Nightlies.
This patch switches code that used nsITimers with the
Components.utils.methodjit hack to use setTimeout on the hidden DOM
window instead, so that we still get the JIT. (See
https://bugzilla.mozilla.org/show_bug.cgi?id=776798)

This might also mean that callbacks from doGet etc. no longer get JITed.
At some point, we should test this with the JIT profiler.
 2013-06-05 18:12:52 -04:00
Simon Kornblith
5bfee27ab9 Remove unused getService for VersionComparatorService 2013-06-05 17:55:49 -04:00
Simon Kornblith
5bde5a106b Use Services.obs instead of getService for observer service 2013-06-05 17:54:53 -04:00
Aurimas Vinckevicius
7fb3c13bc2 Prefer higher priority translators even if they don't target the top frame. 
E.g. pdf+html pages for HighWire 2.0 (http://www.plantcell.org/content/25/4/1213.full.pdf+html?with-ds=yes)
 2013-05-27 18:43:42 -05:00
Simon Kornblith
a7984916ad Protect against pasting HTML-formatted text into QuickFormat dialog 2013-05-24 00:39:19 -04:00
Simon Kornblith
c0f3e3c425 Fix box scrolling 2013-05-23 23:27:29 -04:00
Simon Kornblith
a439456f05 Don't let bubbles get highlighted 2013-05-23 23:27:29 -04:00
Simon Kornblith
3eff3605f7 Fix deletion and keyboard navigation 2013-05-23 23:27:29 -04:00
Simon Kornblith
9c63379544 Fix drag and drop in QuickFormat dialog. 
Unfortunately, this required switching from using labels to spans,
which means there is more work to make the delete key work properly
again.
 2013-05-23 23:27:29 -04:00
aurimasv
fdb35e2e92 Allow right-click on multiple items in duplicate view. Closes #53 2013-05-20 04:39:19 -05:00
Dan Stillman
311e6f2fa7 Merge pull request #326 from aurimasv/dup-click 
Tweak duplicate view click behavior
 2013-05-19 20:21:49 -07:00
Aurimas Vinckevicius
4546089672 Tweak duplicate view click behavior 
Allow ctrl/alt/shift click actions in duplicate view. (closes #324)
Allow right-click behavior on single item/attachment selection. (closes #325)
 2013-05-19 22:20:28 -05:00
Dan Stillman
d3ec8fcdcf Ignore standalone-no-display class when building attachment button menu 2013-05-19 00:14:13 -04:00
Dan Stillman
c5291bdd7d Remove unnecessary ids after bfb30eed59 2013-05-19 00:10:49 -04:00
Dan Stillman
903fc0e001 Fix incorrect id in bfb30eed59 2013-05-19 00:10:08 -04:00
aurimasv
bfb30eed59 Don't display snapshot or link from page context menus for Standalone 2013-05-18 23:01:24 -05:00
Dan Stillman
bbf066f55a Merge pull request #313 from adam3smith/adduris 
add more item handler protocols to add by URI
 2013-05-14 00:06:42 -07:00
Dan Stillman
9c82a7a661 Reset Quick Copy list when resetting translators, too 2013-05-10 14:51:41 -04:00
Dan Stillman
5fbd569fdf Fix refreshing of Quick Copy list when resetting styles 2013-05-10 14:49:29 -04:00
Dan Stillman
6b61795d96 Fix NS_ERROR_FILE_IS_LOCKED if no files to add to upload zip 2013-05-10 01:14:22 -04:00
Simon Kornblith
4616a51874 Fix #318, x-www-form-urlencoded, not x-www-urlencoded 2013-05-08 13:23:33 -04:00
Simon Kornblith
2a33ede284 Fix innocuous error installing a style 
Installing a style could throw an error if the preferences were open and the
styles pane had not yet been selected, although the style would be
successfully installed.

See https://forums.zotero.org/discussion/29250/importing-a-new-style/
 2013-05-02 14:48:53 -04:00
Dan Stillman
01fd28b99f Update versions 2013-05-02 03:10:38 -04:00
Dan Stillman
59ef9c89da Fix DB upgrade error after running <=Zotero 4.0.6 on 4.0.7 DB 2013-05-02 03:06:37 -04:00
Dan Stillman
5a2a485a79 Add a WebDAV verification step to ensure 404 on missing files 2013-05-02 01:19:26 -04:00
Dan Stillman
9b5327ecd7 Fix spacing of sync auto-change log message 2013-05-01 23:58:48 -04:00
Dan Stillman
877b8741ae Fix some tag bugs from efda43f6e3 (and maybe also earlier?) 2013-05-01 23:58:33 -04:00
Dan Stillman
efda43f6e3 Speed up saving of tags with many items 
Fixes #289, RIS import gets progressively slower
 2013-05-01 19:16:15 -04:00
Dan Stillman
9e8559b4be Speed up flattenArguments() 2013-05-01 18:29:44 -04:00
Dan Stillman
35f1720b08 Add missing index to creatorData table 
It's amazing what you can find when you actually have a profiler.
 2013-05-01 18:00:28 -04:00
Dan Stillman
8bed3d44ed Remove another extra function wrapper 2013-05-01 16:19:01 -04:00
Dan Stillman
1e47d12436 Remove extra function wrapper 2013-05-01 16:17:32 -04:00
Dan Stillman
75293a475d Use nicer alerts for error reporting error messages 2013-05-01 15:33:15 -04:00
Dan Stillman
2a7a604f28 Use foreground requests for manual sync and error reporting 
Adds a 'foreground' flag to Zotero.HTTP.promise() options

Also, can now pass successCodes: false to always resolve the promise and never
throw UnexpectedStatusException
 2013-05-01 15:30:39 -04:00
Dan Stillman
e09295ee76 Fix compatibility with authenticated proxies 
It's not clear when this became an issue, but our usual background HTTP
requests (set that way to avoid triggering auth prompts when saving from
websites) weren't triggering proxy authentication dialogs, which was breaking
most network activity in Standalone. To fix this, we now make a foreground
request at startup to a file on S3 and resolve the Zotero.proxyAuthComplete
promise when we're done. Any network requests that want to wait for proxy
authentication can wait for that promise.

This behavior can be disabled via the triggerProxyAuthentication hidden pref.
 2013-05-01 06:29:31 -04:00
Simon Kornblith
527e0ebf4e Update to citeproc-js 1.0.460 2013-05-01 01:49:27 -04:00
Dan Stillman
73b90eb1df Update versions 2013-05-01 01:16:41 -04:00
Dan Stillman
e442279210 Update submodules and repotime 2013-05-01 01:11:34 -04:00
Dan Stillman
c78f8b8e77 Return false for group.filesEditable if group.editable is false 
It's possible for filesEditable in the DB to be set to 1 even if
editable is 0. We generally check editable first anyway, but let's be
safe.

Also make editable/filesEditable return booleans instead of numbers
 2013-04-30 18:13:40 -04:00
Dan Stillman
b09daebbde Don't try to upload files if no file editing access for library 
This should fix https://forums.zotero.org/discussion/29149/ and probably
some other things.
 2013-04-30 17:48:01 -04:00
Dan Stillman
cb7070cc4e Fix translator/style updating on startup 2013-04-30 05:33:37 -04:00
Dan Stillman
94af661a07 Update CSL locales 2013-04-27 04:46:25 -04:00
adam3smith
e68889af45 put this into the right function 2013-04-25 16:08:59 -06:00
Dan Stillman
d205aac0e1 Fix group deleting 2013-04-24 16:35:48 -04:00
adam3smith
e901cc1bf3 add Zotero protocoll 2013-04-23 18:20:45 -06:00
adam3smith
4a4490923b add protocol description 2013-04-23 14:21:43 -06:00
Dan Stillman
d128e31467 Fix "Delete reconciliation unimplemented for searches" 
Just ignore the remote deletion
 2013-04-23 15:52:35 -04:00
adam3smith
f47b878f7b add more item handler protocols to add by URI 2013-04-23 13:26:41 -06:00
Simon Kornblith
557140a022 Update citeproc-js to 1.0.455 2013-04-23 14:38:51 -04:00
Simon Kornblith
c112685338 Fix #312, Google Books translator fails in Fx Nightly > 4/2 
Also remove remnants of old DOM bindings
 2013-04-23 00:17:35 -04:00
Dan Stillman
f8515693aa Fix error when no results from regexp search 2013-04-22 20:08:01 -04:00
Dan Stillman
44ea578fd5 Fix updating of item type icon when changing types (broken by 6b7fe80) 2013-04-22 20:07:02 -04:00
Dan Stillman
e3193526fa Fix for WebDAV server returning 300 if lastsync but no lastsync.txt 
https://forums.zotero.org/discussion/29040/
 2013-04-22 15:53:54 -04:00
Dan Stillman
7b24dbd75c Fix "Display character encoding on export" checkbox in prefs 2013-04-22 15:03:18 -04:00
Dan Stillman
0b6312722d Update versions 2013-04-22 01:44:02 -04:00
Dan Stillman
6b7fe8053a Fix UI update when adding/removing colored tags in search modes 
https://forums.zotero.org/discussion/28827/404-colored-tag-search-results/
 2013-04-21 03:06:35 -04:00
Simon Kornblith
ce2828773b Fix saving PDFs open in pdf.js 2013-04-20 21:48:53 -04:00
Dan Stillman
65c7a5988b Limit autocomplete for tags and fields to current library 
Not done for advanced search

Should be easy for saved search, but not yet done
 2013-04-19 15:10:05 -04:00
Dan Stillman
8469ce821b Merge pull request #305 from rsnape/issue-251-fix 
Fix issue #251
 2013-04-19 03:22:05 -07:00
J Richard Snape
1e45aed753 Fix issue #251 
Two changes needed to cope with shift-enter being pressed both
with and without changes to current creator row

Signed-off-by: J Richard Snape <rsnape@dmu.ac.uk>
 2013-04-19 10:53:46 +01:00
Dan Stillman
5c5b9af1d7 Increase max note title length to 120 
https://forums.zotero.org/discussion/28945
 2013-04-19 01:40:25 -04:00
Dan Stillman
41c9a4a433 Fix relative path support to sync properly 
Dual boot and VM setups worked, but only absolute paths were synced,
because syncing uses attachmentPath, which was resolving relative paths
itself (#51). attachmentPath now returns what's in the database (as it
did originally), and getFile() does the resolving instead.

This means that anything relying on attachmentPath directly needs to be
aware that it might get a placeholder-prefixed relative path.
 2013-04-19 01:33:23 -04:00
Frank Bennett
95d8348a77 Remove updateItems() 2013-04-19 11:13:49 +09:00
Frank Bennett
855d0b7fba Use rebuildProcessorState() in RTF Scan. Fixes AGM SIG-CHI Proceedings (numeric style, bib sorted by author), and possibly others. 2013-04-19 10:55:11 +09:00
Simon Kornblith
127cb259c1 Remove old comment 2013-04-18 15:45:24 -04:00
Simon Kornblith
4486ba4495 Remove "%" from list of unencoded entities 
@aurimasv's patch from https://github.com/zotero/zotero/pull/304#issuecomment-16562271
 2013-04-18 15:44:40 -04:00
Simon Kornblith
dbd36a935f Merge pull request #304 from simonster/file-fixes 
Try to parse paths as paths in addition to as URIs
 2013-04-18 09:45:40 -07:00
Simon Kornblith
ecb8cb140d Don't fire explicit styleChanged event on load 
Otherwise, the bottom of the document preferences window can be
cut off the first time it is displayed. A styleChanged event is still
fired after setting the selection.
 2013-04-18 03:30:33 -04:00
Simon Kornblith
6fe1c1cbba Handle pathological case with backslashes in path 2013-04-18 02:56:50 -04:00
Simon Kornblith
61300e4dd7 Try to parse paths as paths in addition to URIs 2013-04-18 02:32:24 -04:00
Simon Kornblith
b8ce002df3 Update to citeproc-js 1.0.451 2013-04-17 18:02:14 -04:00
Dan Stillman
7677eccb9f Addresses #104, Shorten long filenames on import 
This fixes the problem for attached files. I assume this is still a
problem for importSnapshotFromFile(), which uses copyTo() on a
directory. For that we'd need a copyDirectoryToUnique() function that
shortened the names of all files in the directory.
 2013-04-17 16:13:23 -04:00
Dan Stillman
500076ea63 Errors on some file sync requests could hang sync progress 2013-04-17 04:12:11 -04:00
Dan Stillman
084f671b18 Fix downloads on broken WebDAV servers 
cloudme.com and maybe box.com appear to have stopped sending a
Last-Modified header for files, causing Zotero to skip the file download
step. Instead of relying on that, we now save a random id to the
lastsync file and just use that as an ETag.

Also migrate lastsync to lastsync.txt, which might be supported better
on some other broken WebDAV servers.
 2013-04-17 03:07:20 -04:00
Simon Kornblith
a6e79d6bd3 Merge pull request #300 from aurimasv/transBinding 
Revise translator preference rules for clarity & to favor top frame translators
 2013-04-16 23:45:07 -07:00
Simon Kornblith
de2dec921f Fix https://forums.zotero.org/discussion/28922/ 2013-04-17 02:35:44 -04:00
Simon Kornblith
d81e801685 Add about:memory button to Standalone 2013-04-17 02:00:07 -04:00
Simon Kornblith
f42ded42c6 Fix https://forums.zotero.org/discussion/28810/ 2013-04-17 01:11:44 -04:00
Simon Kornblith
ba103721fe Fix typo in deca49c433 2013-04-16 23:33:18 -04:00
Simon Kornblith
deca49c433 Avoid stack overflow in tests 2013-04-16 23:31:23 -04:00
Aurimas Vinckevicius
a0bc26713e Revise translator binding rules for clarity & to favor top frame translators 2013-04-16 19:06:55 -05:00
Simon Kornblith
e893472331 Register as handler for BibTeX mime typese 2013-04-16 12:46:13 -04:00
Dan Stillman
b82a28e708 Extra file sync debugging 2013-04-16 01:10:42 -04:00
Dan Stillman
c185ffc728 Fix purgeDeletedStorageFiles() (from 5442e2e8) 2013-04-16 00:16:51 -04:00
Simon Kornblith
ff5353fec1 Update to citeproc-js 1.0.450 2013-04-16 00:11:19 -04:00
Dan Stillman
9b1b4803dc Update submodules and repotime 2013-04-15 22:26:36 -04:00
Dan Stillman
5442e2e8a8 Fix ZFS purging when switching to WebDAV 2013-04-15 22:21:54 -04:00
Simon Kornblith
bafad27311 IE doesn't support normalize 2013-04-15 15:15:01 -04:00
Simon Kornblith
80b10184b0 Fix race condition when running bookmarklet from Standalone server 2013-04-15 14:52:51 -04:00
Simon Kornblith
5a664ec3d9 Revert XDR timeout changes from 11316d952b 2013-04-15 14:52:27 -04:00
Simon Kornblith
771cfc9ca6 Make bookmarklet origin configurable for tests 2013-04-15 13:43:07 -04:00
Simon Kornblith
11316d952b Don't forget to call fail() after debug messages from IE XDR 2013-04-15 13:25:40 -04:00
Simon Kornblith
210e71b8a5 Tweak timeouts and add additional debugging info for IE Standalone XDR 2013-04-15 13:19:10 -04:00
Dan Stillman
00bb7a168b Update versions 2013-04-15 02:58:25 -04:00
Dan Stillman
4f6fbf364d Use renamed-styles.json and flag from repo to replace renamed styles 
Currently updating renamed-styles.json is a manual process.
 2013-04-15 02:56:32 -04:00
Dan Stillman
6952f46986 Fix Attachment Content regexp search 2013-04-14 21:20:24 -04:00
Simon Kornblith
61864e903f Fix comment 2013-04-14 19:55:30 -04:00
Dan Stillman
f7c3a29a57 Display note title even if first line is just an opening HTML tag 
https://forums.zotero.org/discussion/28857/#Item_14
 2013-04-14 19:14:46 -04:00
Simon Kornblith
d0d0f14edb Disable context menu icons on OS X 2013-04-14 01:47:05 -04:00
Simon Kornblith
fa27e3f3de Merge commit '915a579' into 4.0 2013-04-14 01:23:06 -04:00
Dan Stillman
82c4c90f5c Fix spacing in sync auto-merge dialogs 2013-04-13 03:44:09 -04:00
Dan Stillman
41449871a1 Fix "Source item for keyed source doesn't exist" sync error 
This could occur in 4.0 if a standalone attachment was modified locally
and remotely was changed into a child attachment.
 2013-04-13 03:41:32 -04:00
Aurimas Vinckevicius
915a579bc4 Fix icon for "Remove Item from Collection" 2013-04-13 02:07:01 -05:00
Aurimas Vinckevicius
33fedc306c Add icons to context menus 2013-04-13 01:53:02 -05:00
Dan Stillman
b01ae24f18 Don't deselect tags unnecessarily 
https://forums.zotero.org/discussion/28842/

Related to 4e1fbf974
 2013-04-12 15:57:02 -04:00
Dan Stillman
ef3a5755f8 Colored tags weren't shown in collections with no other tags 2013-04-12 14:40:41 -04:00
rsnape
8ea86d77d3 Update itembox.xml 
Corrects a tiny bug where pressing minus button to remove an unsaved creator row creates incorrect behaviour in the plus button in preceding row. Done in preparation for a fix I have locally for issue #251.  Please advise if I have your preferred workflow wrong.
 2013-04-11 13:16:33 -04:00
Dan Stillman
9c74957bc0 Tweak alignment of sync error icon on Windows 2013-04-11 04:30:51 -04:00
Dan Stillman
2236bab130 Better handle some file sync file access errors 
- Catch additional errors on Windows (too-long paths, maybe aliases)
- Fix "Show File" button (which didn't show in some cases, at least on
  Windows)
- Clarify error message
 2013-04-11 04:28:38 -04:00
Dan Stillman
e716a5367a Some file sync errors weren't being caught and displayed 2013-04-11 04:27:18 -04:00
Simon Kornblith
d08ad1143d Make sure translator test errors appear both in log and in console 2013-04-09 20:37:24 -04:00
Dan Stillman
cc7360dc0c Fix for <div> appearing in some notes instead of <p> 
https://forums.zotero.org/discussion/28781/

Not totally sure how/when this was happening. To fix existing notes,
switch the Format to Paragraph manually.
 2013-04-09 04:14:48 -04:00
Simon Kornblith
f3bb679ebe Merge branch 'resolve-url' into 4.0 2013-04-08 18:36:25 -04:00
Simon Kornblith
7f7fe90ad5 Allow attachments to be saved using relative URLs 
See https://groups.google.com/forum/?fromgroups=#!topic/zotero-dev/bBB8lyXy9V8
and zotero/translators#569
 2013-04-08 18:33:25 -04:00
Dan Stillman
10351968f9 Update versions 2013-04-08 00:51:11 -04:00
Simon Kornblith
abe266d74b Recognize application/xhtml+xml as snapshot 2013-04-07 21:16:15 -04:00
Simon Kornblith
142a48b132 Use ZOTERO_CONFIG for bookmarklet URL 2013-04-07 18:48:18 -04:00
Simon Kornblith
6778d06ae7 Don't break in IE 2013-04-07 17:47:57 -04:00
Simon Kornblith
6ba65270ce Revert "When mimeType is not supplied, try to fetch it from server and redo checks for automatic snapshots." 
This reverts commit 6dd94f0a3a.
 2013-04-07 17:47:57 -04:00
Simon Kornblith
0850ca94b1 Revert "Don't set unknown mimeTypes to "application/octet-stream"" 
This reverts commit f64d087926.
 2013-04-07 17:47:57 -04:00
Dan Stillman
5878dac132 Clarify error message for login manager access failure in Firefox 
Fixes #288, Inappropriate error message when master password times out
 2013-04-07 16:28:40 -04:00
Simon Kornblith
0d6dc81112 Fix https://forums.zotero.org/discussion/28711 2013-04-05 10:48:58 -04:00
Simon Kornblith
5e4c464cf5 Fix lookup of <8 digit PMIDs 2013-04-04 22:24:12 -04:00
Dan Stillman
339225f2fb Fix possible tag-related sync bug 2013-04-04 12:02:27 -04:00
Simon Kornblith
e51434416a Fix abbreviation of single word titles 
https://forums.zotero.org/discussion/28687/
 2013-04-04 11:11:54 -04:00
Dan Stillman
2391c99d66 Update version 2013-04-04 01:03:36 -04:00
Dan Stillman
483da7c42e Fix never-ending auto-sync 2013-04-04 01:01:07 -04:00
Simon Kornblith
c9b73f2bd3 Fix reference test pane 2013-04-03 21:11:44 -04:00
Simon Kornblith
d332c84606 Fix automatic title abbreviation on new installs 2013-04-03 17:32:32 -04:00
Simon Kornblith
0add49e66e Update to citeproc-js 1.0.446 2013-04-03 17:22:54 -04:00
Simon Kornblith
b63430e180 Add link to bug on document.evaluate deprecation warnings 2013-04-03 16:35:30 -04:00
Simon Kornblith
5fec7bdb1c Avoid deprecation warning 2013-04-03 16:30:49 -04:00
Simon Kornblith
a334ac9f60 Properly install styles with BOMs from disk 2013-04-03 14:37:32 -04:00
Simon Kornblith
2b8c28ccaf Support file:/// URIs in Zotero.HTTP.promise() 2013-04-03 14:37:02 -04:00
Simon Kornblith
5e237a2723 done(), not end() 2013-04-03 13:32:18 -04:00
Simon Kornblith
5218c132f5 Fix formatting for copy-pasted bibliographies 2013-04-03 13:28:56 -04:00
Simon Kornblith
15f26e44da Recognize container-title-short as journal abbreviation 2013-04-03 12:58:29 -04:00