mirrors/zotero
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
9389 commits 9 branches 362 tags 278 MiB
Commit graph

6391 commits

Author SHA1 Message Date
Dan Stillman
e62433edfb Fix citeproc-js in Firefox 56 
Our retrieveLocale() implementation was broken by
https://bugzilla.mozilla.org/show_bug.cgi?id=1319111
 2017-09-30 04:01:28 -04:00
Dan Stillman
89babf8832 Fix refresh problems when Advanced Search is open, and maybe other times 2017-09-29 04:24:49 -04:00
Dan Stillman
48d4d2d5a5 Standardize connector server behavior for saves to read-only libraries 
Return a 500 for read-only libraries for all save modes. Read-only views
within editable libraries will save to the library root.

Addresses #185, RIS/BibTeX interception to read-only view behaves
differently from save button
 2017-09-27 17:39:18 -04:00
Adomas Venčkauskas
7a062a7493 Remove connector proxy code 
Observing requests, auto-redirecting and learning proxies no longer
relevant on this codebase (and interferes with Scaffold).
 2017-09-25 14:57:02 +03:00
Dan Stillman
da21c9c47b Remove old archive.org relations 
These aren't allowed by the API and were breaking syncing (and haven't
been exposed anywhere for years anyway).
 2017-09-22 16:58:16 -04:00
Adomas Venčkauskas
42e2f229c0 Apply linux tab fixes to all tabs (e.g. tabs in zotero plugins) 2017-09-22 13:10:27 +03:00
Dan Stillman
19447e7b90 Fix RIS/BibTeX import errors when in library root 2017-09-22 04:12:21 -04:00
Dan Stillman
a455a72534 Remove invalid relations mangled during import 
Not sure if this occurred for our own translators, but it addresses
items created from #1282.
 2017-09-22 01:22:33 -04:00
Dan Stillman
0d3d4323b5 Fix relations import via translators 
Fixes #1282
 2017-09-22 01:02:50 -04:00
Dan Stillman
10cae22c55 Restrict relation predicates to letters and colons for now 2017-09-22 01:01:52 -04:00
Dan Stillman
241e596680 Update citeproc-js to 1.1.178 2017-09-21 15:47:41 -04:00
Dan Stillman
d81e2a5cf0 Fix sync errors from remote item referencing deleted local collection 2017-09-20 05:33:44 -04:00
Dan Stillman
85d7c01c85 Fix getAsync() integer warning when clicking on related item 2017-09-20 03:36:16 -04:00
Dan Stillman
c7639f328f Fix editing in classic citation window (broken by 2901174ba3) 
This is (hopefully) a better fix for selection issues than 2901174ba3. A
reference to the collectionTreeView is stored in a `view` property on
the collectionTreeRow, and when an itemTreeView is initialized and
passed a collectionTreeRow it assigns itself to an `itemTreeView`
property on the row's view.
 2017-09-20 03:36:16 -04:00
Dan Stillman
365e58249d Check for invalid certificate in Zotero.HTTP.request() 
We were checking for this in the sync API client, but that didn't apply
to Amazon S3 for ZFS.
 2017-09-20 00:49:10 -04:00
Dan Stillman
a858368642 Revert "Use eraseTx() instead of erase() when deleting saved search" 
eraseTx() isn't actually valid in this context.

This reverts commit 103c16a563.
 2017-09-19 23:47:03 -04:00
Dan Stillman
8efbfb7c74 Close import progress window on error 
Fixes https://github.com/retorquere/zotero-better-bibtex/issues/719
 2017-09-19 02:35:04 -04:00
Dan Stillman
afc7afeb9c Fix error deleting collection after emptying trash 
Follow-up to c442daedce
Fixes #1317
 2017-09-18 17:03:12 -04:00
Dan Stillman
49506b6d94 Fix non-integer warning when purging ids from sourceList.persist 2017-09-18 17:02:25 -04:00
Dan Stillman
d83d70eb5c Update locate engine download code 
Asyncify, make JSON load failures not fatal, and simplify icon download
code (which also fixes download of CrossRef icon, which was failing for
some reason).
 2017-09-18 02:31:13 -04:00
Dan Stillman
6d53839fbc Add sniffer entry for .ico files 2017-09-18 02:26:31 -04:00
Dan Stillman
d2a33f2613 Update submodules 2017-09-18 01:37:26 -04:00
Dan Stillman
fb61819f6b Update automatic trash emptying after 3872e646ac 
And restore 'limit' parameter used for auto-empty
 2017-09-16 00:51:51 -04:00
Dan Stillman
e25af42ef3 Fix sync event listener after 3872e646ac 2017-09-15 21:02:38 -04:00
Dan Stillman
cc04ddbe4d Fix test failure after 8215ba7a1d 2017-09-15 20:42:17 -04:00
Dan Stillman
3872e646ac Speed up emptying trash 
Shows a progress meter, which allows for larger chunks and fewer
refreshes, avoids unnecessary updating of parent items that are
being deleted anyway, and skip re-sorting of modified items in the
trash.

Closes #1292, Emptying trash is slow
 2017-09-15 20:23:01 -04:00
Dan Stillman
8215ba7a1d Crash Zotero on note-saving error 
Closes #1277, Crash note if not saving properly
 2017-09-15 00:46:29 -04:00
Dan Stillman
18c62be6a4 Fix display of data dir in migration error message 
When migrating prefs from Zotero for Firefox, the prefs specified a
custom data dir, and that directory was missing, the "Previous
directory:" line was blank.
 2017-09-14 18:49:01 -04:00
Dan Stillman
9395af86f7 Fix "SyntaxError: unterminated string literal" on first run 
This could happen when migrating prefs from Firefox when the prefs.js
file included a corrupted line.
 2017-09-14 18:48:00 -04:00
Dan Stillman
103c16a563 Use eraseTx() instead of erase() when deleting saved search 2017-09-13 01:02:07 -04:00
Dan Stillman
c442daedce Update collection cache after "Delete collection and items…" 
Fixes #1314
 2017-09-13 01:01:36 -04:00
Dan Stillman
5ec7c97f30 Add debugging for userID change 2017-09-12 16:22:46 -04:00
Dan Stillman
a47c332895 Show better error message if data dir can't be created 2017-09-12 02:35:06 -04:00
Dan Stillman
e9439c978b Allow setting data directory via -datadir command-line flag 
Can be an absolute path or 'profile' to use 'zotero' subdirectory of
profile directory as in earlier versions (but which won't be treated as
a legacy location eligible for migration)

Closes #1305
 2017-09-11 03:52:51 -04:00
Dan Stillman
33128d1f59 Filter 'XPCOMUtils.jsm' lines from stack traces 2017-09-11 03:52:50 -04:00
Dan Stillman
64e840e418 Continue after failure in Add Item by Identifier 
This should give better feedback when some identifiers fail, but for now
restore 4.0 behavior.

Also add items by identifier in order, not reverse order
 2017-09-10 03:54:26 -04:00
Dan Stillman
2901174ba3 Fix intermittent item selection failure 2017-09-10 03:18:59 -04:00
Dan Stillman
d271683968 Bypass cache by default in Zotero.Utilities.Internal.saveURI() 2017-09-07 23:55:45 -04:00
Dan Stillman
5248b08de0 Remove debug lines 2017-09-02 01:39:09 -04:00
Dan Stillman
1100015d2c Don't purge data tables until after schema update 
It's no longer necessary to do this before syncing, since tags and
creators aren't first-class objects.
 2017-09-02 01:13:34 -04:00
Dan Stillman
69c27cd8a7 Fix potential failure with full-text phrase search 
Phrase searches weren't scoped to the current library, so they could
return unloaded items in other libraries and cause the search to fail.
 2017-09-02 01:13:33 -04:00
Dan Stillman
fd5c48ac51 Simplify Zotero.ItemTreeView.prototype.getSortedItems() 2017-09-01 13:22:46 -04:00
Dan Stillman
ed6d628f4e Fix Create Bib for saved searches 2017-09-01 13:22:46 -04:00
Dan Stillman
01ecff8e2b Fix regression in 05d74c4cac 2017-08-30 18:47:21 -04:00
Dan Stillman
05d74c4cac Don't load note/attachments counts as primary data 
Zotero.Item::numNotes()/numAttachments() now require 'childItems' to
have been loaded.

Fixes #1301, Slow startup with many items in trash
 2017-08-30 18:08:25 -04:00
Dan Stillman
94c4445475 Fix restart error moving away from note that hadn't finished loading 2017-08-30 18:08:24 -04:00
Frank Bennett
b0c0cd6e0c Expose styleEngine in csledit.js, for Abbreviation Filter 2017-08-24 23:26:03 +09:00
Dan Stillman
a15b23e353 Update citeproc-js to 1.1.177 2017-08-23 11:02:19 +02:00
Dan Stillman
f4b73d22b8 Fix error relocating to filename with different Unicode normalization 2017-08-23 11:02:05 +02:00
Dan Stillman
1d19811bd2 Disable strict mode in citeproc-js for now 2017-08-22 12:18:48 +02:00
Dan Stillman
879ed11b69 Update citeproc-js to 1.1.175 2017-08-22 12:18:29 +02:00
Dan Stillman
2919486818 Don't keep checking for lost Z4Fx data directory 2017-08-19 23:47:54 +02:00
Dan Stillman
f45d56113a Remove unnecessary log line 2017-08-19 23:36:39 +02:00
Dan Stillman
0391569f4d Only prompt for recently updated Z4Fx data directories 2017-08-19 23:31:39 +02:00
Dan Stillman
267e3165a2 Add prompt to revert to Zotero for Firefox data directory 
For people affected by migration bugs prior to 5.0.15
 2017-08-19 23:22:07 +02:00
Dan Stillman
d368c4019a Fix data directory migration if only Firefox profile directory 2017-08-19 15:58:42 +02:00
Dan Stillman
6673c64ac6 Fix accessDate when translators set CURRENT_TIMESTAMP 
(But it also seems like we always do that automatically for web
translators, so I'm not sure why so many translators set that.)
 2017-08-19 15:21:57 +02:00
Dan Stillman
de36a6e833 Make sure rootDocument is set in Zotero.Translate.Web.setDocument() 
For non-browser documents that we wrap, defaultView.top.document can be
undefined without being inaccessible.

Fixes regression from dae0986b9b
 2017-08-19 05:23:38 +02:00
Dan Stillman
871cbae499 Update citeproc-js to 1.1.174 2017-08-19 05:23:38 +02:00
Dan Stillman
7386b376f3 Fix linked attachment base directory handling at drive root 
The first letter of the relative path was being removed on save if the
base directory was set to the drive root (e.g. D:\ instead of D:\foo).
 2017-08-18 16:06:56 +02:00
Dan Stillman
1efe54e896 Fix #1286, Show proper error messages for OS.File errors 2017-08-17 15:43:54 +02:00
Dan Stillman
da2dedf7af Use passed URL rather than doc.location in translator processDocuments 
Outside of page contexts (e.g., from an XHR with responseType =
'document'), document.location is null.
 2017-08-16 17:58:59 +02:00
Dan Stillman
065bac3b8a Avoid XML Parsing Error for WebDAV requests that don't return Content-Type 
If responseType isn't set and the response doesn't include a
Content-Type header, Firefox tries to parse the file as XML, and if the
file isn't XML it logs an "XML Parsing Error", which includes the
username and password.
 2017-08-16 01:07:10 +02:00
Dan Stillman
db8bb3484d Update password-hiding logic for malformed-XML XHR errors in reports 2017-08-16 00:41:38 +02:00
Dan Stillman
b171b15d87 Don't log WebDAV Authorization header 2017-08-16 00:41:38 +02:00
Adomas Venčkauskas
dae0986b9b Fix a cross-origin frame access error in Translate.Web.setDocument 2017-08-15 15:36:26 +03:00
Adomas Venčkauskas
a5a7df328a Changes imports from connector to save to selected collection 
Closes #1289
 2017-08-15 11:35:53 +03:00
Dan Stillman
c31f0b6b5c Fix <label class="text-link"/> in basic viewer (e.g., Add-ons pane) 
I'm not sure when this stopped working, or whether the Add-ons pane was
in the basic viewer before, but that fixes it.
 2017-08-15 00:36:43 +02:00
Dan Stillman
8797c7f680 Fix error refreshing missing citation without name part 
https://forums.zotero.org/discussion/66789/
 2017-08-14 21:24:31 +02:00
Dan Stillman
a24f16eb85 Don't look up library name for each downloaded file 2017-08-13 03:26:23 +02:00
Dan Stillman
c9b9d4127d Fix first-run error with some upgrades after 39bfeac86c 2017-08-13 03:00:57 +02:00
Dan Stillman
6bcf92db46 Fix "Open in Library" from Quick Format popup if main window is closed 
Possible now on macOS
 2017-08-12 02:50:27 +02:00
Dan Stillman
c59ae5cf40 Add Zotero.openMainWindow() 
Opens the main Zotero window if it's not open, which is now possible on
macOS.
 2017-08-12 02:49:36 +02:00
Dan Stillman
2770860968 Don't update storage version if file sync is stopped 
Otherwise subsequent syncs won't download the remaining files until
there's a remote storage change.
 2017-08-11 22:29:40 +02:00
Dan Stillman
9069559050 Improve logic for determining whether to check for files to download 
This should fix cases of files not being downloaded after interrupted
syncs until the next time files were changed remotely.
 2017-08-11 22:29:40 +02:00
Dan Stillman
4c13d51f24 Show files remaining in library in sync button tooltip 2017-08-11 18:25:08 +02:00
Dan Stillman
0df967418b Fix error handling for HTTP.request() with responseType: 'document' 2017-08-11 18:25:08 +02:00
Dan Stillman
9202ab8b3c Download missing attachments as needed even in at-sync-time mode 2017-08-11 16:06:06 +02:00
Dan Stillman
3a2f0e6929 Fix URL opening in some places (since 21cc9f16bf) 2017-08-11 11:51:02 +02:00
Dan Stillman
65d63fad37 Fix opening of some links in About pane 2017-08-10 04:51:58 +02:00
Dan Stillman
21cc9f16bf Move ZoteroPane.launchURL() to Zotero.launchURL() 
And add deprecation warning to ZoteroPane.launchURL()
 2017-08-10 04:49:57 +02:00
Dan Stillman
678a6e15cc Better Unicode path comparison in WebDAV.purgeOrphanedStorageFiles() 2017-08-10 04:41:16 +02:00
Dan Stillman
83fe445f8f Fix error message in WebDAV purgeOrphanedStorageFiles() 2017-08-10 03:59:55 +02:00
Dan Stillman
39bfeac86c Choose most recently used data directory when upgrading to 5.0 
Previously, if someone was upgrading from Zotero for Firefox to 5.0 but
at some point had installed Zotero Standalone and told it not to share
the data directory, 5.0 would use the data directory from the Zotero
profile directory, and people would end up with an empty database with a
Zotero Quick Start Guide from years ago.

This checks for the database with the most recent mtime and uses that
data directory instead. In the Firefox profile, that can be either the
default 'zotero' subdirectory or a custom data directory. If one of the
Firefox locations is used, Zotero prefs are read from Firefox, because
it means that Zotero for Firefox was being used (because if Zotero
Standalone had been in use it would've needed a custom data dir setting
pointing at the Firefox database).
 2017-08-10 03:31:56 +02:00
Dan Stillman
d3833b8afd Ignore stored-file path with no 'storage:' 
There was a report of an imported file with a relative path, probably
from some ancient bug (in our code or a plugin's)
 2017-08-09 02:41:07 +02:00
Dan Stillman
a02eb3c328 Don't stop after one uploaded full-text batch 2017-08-09 02:04:04 +02:00
Dan Stillman
07ce273333 Show "Queued" in right pane for unprocessed full-text and allow indexing 2017-08-09 02:01:33 +02:00
Dan Stillman
fffa1badd4 Stop storage requests on shutdown 2017-08-09 02:01:33 +02:00
Dan Stillman
9920a845c6 Don't initialize storage requests until they start 2017-08-09 02:01:33 +02:00
Dan Stillman
a0a2502947 Allow debug output logging to be enabled after later restart 
With the new system, it wasn't possible through the UI to generate debug
output for another action that happened after a restart, since it just
restarted immediately. This adds a prompt after selecting the menu
option that allows for restarting now, restarting later, or cancelling.
 2017-08-05 19:44:58 +02:00
Dan Stillman
b3b9cac078 Fix "Copy as HTML" Quick Copy setting 2017-08-05 03:13:33 +02:00
Dan Stillman
34e23937a1 Remove pointless Bluebird lines from various stack traces 2017-08-05 01:09:57 +02:00
Dan Stillman
7b0ed6da81 Don't unlink account on key info request connection failure 
This can happen when the computer is offline but that hasn't been
detected for some reason.
 2017-08-05 01:07:49 +02:00
Dan Stillman
198fb28e20 Resolve schema update promise even if repository update fails 2017-08-04 16:48:21 +02:00
Adomas Venčkauskas
492293ef84 Fix a wrong cookieSandbox condition for /connector/saveSnapshot 2017-08-02 15:43:55 +03:00
Dan Stillman
c6ab18634d Improve data directory startup error handling 
Better instructions and behavior if the data directory is inaccessible
or missing, including automatically detecting a directory at the default
location if the configured directory is missing and offering to use the
default instead. Together, this means that if, say, security software
prevents Zotero from accessing the data directory within the Firefox
profile, it will suggest that the user move it to ~/Zotero and then
prompt to use that directory.
 2017-07-31 05:42:16 -04:00
Dan Stillman
33eb31d6e2 Fix typo from 991967d5b 2017-07-30 15:25:10 -04:00
Dan Stillman
5123c21e0d Don't close Zotero on macOS when window is closed 
Keep the application open with limited menus, including a Window ->
Zotero option bound to (Cmd-0) that can be used to reopen the main
window.

This allows Zotero to use almost no CPU (instead of a few percentage
points when the window is open, even when hidden with Cmd-H, though it'd
be nice to fix that) and still allow saves from the connector.

There might be some things that aren't being destroyed properly when the
window is closed or other bugginess, but it seems to work pretty well.
 2017-07-30 07:52:58 -04:00
Dan Stillman
a8ba2fac33 Don't rely on last browser window to open prefs from menu 2017-07-30 07:42:56 -04:00
Dan Stillman
ee0b4f5d0d Use nsIWindowWatcher in Zotero.openInViewer() 
Instead of getting the last browser window
 2017-07-30 07:37:34 -04:00