Commit graph

7167 commits

Author SHA1 Message Date
Dan Stillman
7d7afc2b46 Add Style Editor to Developer menu 2019-08-05 05:05:57 -04:00
Dan Stillman
77467b94da Fix item tree crash on Cmd-left-arrow under certain conditions
If a parent item was expanded and all items in the tree, including the
item's child items, were selected, Cmd + Left Arrow would break the
items tree until restart.

This will cause a conflict and need to be applied to the new tree.

(Worth noting that collapseSelectedRows() is currently only called on
Cmd-left-arrow because the XUL tree seemingly swallows a regular
left-arrow (and only applies the collapse to the last-selected row). The
comment in the keypress listener where collapseSelectedRows() is called
suggests that that was meant to be used for all left-arrow keypresses,
but either that stopped working at some point or it only ever worked for
Cmd + Left Arrow because it bypasses the normal tree handling of left-
arrow. In any case, it would be better if left-arrow always collapsed
selected rows, with or without Cmd.)

https://forums.zotero.org/discussion/78515/bug-collapsing-all-items-in-a-collection-breaks-display-of-items-in-all-collections
2019-08-04 01:48:36 -04:00
Dan Stillman
871a275090 Add Help button to Run JavaScript window to open documentation 2019-08-02 07:00:43 -04:00
Dan Stillman
7e7ec07170 Remove "Show developer tools" checkbox and show menu by default
Everybody's a developer now
2019-08-02 07:00:43 -04:00
Dan Stillman
2b6fb73b57 Add Scaffold as a built-in developer tool 2019-08-02 07:00:39 -04:00
Dan Stillman
00c159a1b4 Fix incorrect top padding in tag selector if first tag doesn't fit 2019-08-02 03:13:47 -04:00
Dan Stillman
2a3c4a3555 Add "Show developer tools" option to Advanced prefs
And move Error Console and Run JavaScript to a Developer menu that's
shown in Tools if that option is enabled.

The Memory Info button is now behind its own undefined
extensions.zotero.debug.memoryInfo pref.
2019-08-02 02:56:26 -04:00
Dan Stillman
fda002ec34 Beginning of tests for zotero://select 2019-08-02 02:29:08 -04:00
Dan Stillman
d0002736cd Add 'begins with' operator to field search conditions 2019-08-01 23:40:52 -04:00
Dan Stillman
d551d1901f Fix zotero://select search selection 2019-08-01 22:11:03 -04:00
Dan Stillman
f776156fbd Revert subtitle capitalization for AMA (added in 5.0.70)
https://forums.zotero.org/discussion/comment/337093/#Comment_337093
2019-08-01 17:26:27 -04:00
Dan Stillman
3af8f56c35 Fix server error if User-Agent isn't set
https://forums.zotero.org/discussion/78502/http-user-agents-that-dont-identify-fail-for-zotero-v5-0-71
2019-08-01 16:55:21 -04:00
Dan Stillman
3e3804741f Maybe fix translator deletion?
This caused an error after 9b82373f70 but possibly meant that deleted
translators weren't being properly removed.
2019-07-24 04:32:40 -04:00
Dan Stillman
9b82373f70 Add ability for Scaffold to provide alternative translators
Zotero.Translate::setTranslatorProviderMethods(methods) can be used to
provide custom 'get' and 'getAllForType' methods that override the
default Zotero.Translators methods.
2019-07-24 04:31:11 -04:00
Adomas Venčkauskas
768759ccb1 Fix being unable to remove uncited bibliography entries 2019-07-23 09:39:16 +03:00
Dan Stillman
1968d75814 Fix startup errors due to missed schema update steps for retractedItems
I don't know how this is happening -- people are ending up with an
updated DB version but missing schema changes, despite the DB version
being updated after the schema updates and in the same transaction --
but until we figure it out, apply the schema update steps in
Zotero.Retractions.init() if necessary.
2019-07-22 06:33:12 -04:00
Dan Stillman
8edab3d628 Update citeproc-js to 1.2.18
This fixes Title/Short Title case alignment
2019-07-20 01:59:09 -04:00
Dan Stillman
8c7e47495e Remove Transform Text submenu and put options directly in context menu 2019-07-19 23:13:25 -04:00
Dan Stillman
7d5f6cdbfd Transform Short Title case as well when transforming Title 2019-07-19 23:12:51 -04:00
Dan Stillman
7f8ec82ba2 Update wording of document import prompt 2019-07-18 06:10:00 -04:00
Dan Stillman
9020566de1 Fix "no such table: retractedItems" error from skipped schema update
I'm not sure what's going on, but schema update steps aren't working
properly for a small number of people:

https://forums.zotero.org/discussion/78272/urgent-database-connector-upgrade-error
2019-07-18 05:19:18 -04:00
Dan Stillman
a41e610e6c Fix display of original string length in debug output for ellipsize() 2019-07-17 21:32:51 -04:00
Dan Stillman
686b51df38 Revert "Temporarily disable document-export button for 5.0.71"
This reverts commit 7b7ccea31a.
2019-07-17 19:03:30 -04:00
Dan Stillman
7b7ccea31a Temporarily disable document-export button for 5.0.71 2019-07-17 18:17:52 -04:00
Dan Stillman
fd12eb08b1 Adjust document-export wording
"Export" is too confusing, since you also have to export and import the
file itself.
2019-07-16 02:21:33 -04:00
Dan Stillman
b899e5694a Update citeproc-js to 1.2.17 2019-07-16 02:03:07 -04:00
Dan Stillman
5dd64a5f4c Fix a couple connector server endpoint init() response values 2019-07-16 00:58:39 -04:00
Dan Stillman
7b9d404c42 Allow browser-based access to connector server ping page 2019-07-15 10:06:42 -04:00
Dan Stillman
1cd4e50b59 Don't protect test endpoints 2019-07-15 08:11:56 -04:00
Dan Stillman
2603373b86 Additional protections for HTTP endpoints
Reject browser-based requests that don't require a CORS preflight
request [1] if they don't come from the connector or include
Zotero-Allowed-Request: 1

[1] https://developer.mozilla.org/en-US/docs/Web/HTTP/CORS#Simple_requests
2019-07-15 07:30:12 -04:00
Dan Stillman
fd09d3ef4a Revert "Temporarily disable "Export Document…" button for 5.0.70"
This reverts commit f8927812e9.
2019-07-13 02:26:25 -04:00
Dan Stillman
f8927812e9 Temporarily disable "Export Document…" button for 5.0.70 2019-07-12 20:28:05 -04:00
Dan Stillman
708b8798c2 Check for X-Zotero-Connector-API-Version header in /connector/import 2019-07-12 02:08:55 -04:00
Dan Stillman
2964021661 Update citeproc-js to 1.2.13 2019-07-09 03:04:12 -04:00
Dan Stillman
5ab0239bdf Fix footnotes style in RTF Scan
Not sure when this broke
2019-07-09 02:12:53 -04:00
Dan Stillman
1424fd9a0e Fix updating of the styles page in the RTF Scan dialog
There were various errors due to changes in integrationDocPrefs.xul
since RTF Scan was last worked on.
2019-07-09 01:46:34 -04:00
Dan Stillman
c0fe471db3 Fix retraction warning remaining after item deletion until next selection
Regression from something recent, I think
2019-07-04 22:05:18 -04:00
Adomas Venčkauskas
cd14a536dc Add retracted citation warning tests. Fix a bug with embedded prompts 2019-07-04 15:16:26 +03:00
Dan Stillman
eedc066d41 Allow hiding of retraction warning for replaced works
This is unfortunate, but some journals are abusing (what should be)
unique identifiers.

https://forums.zotero.org/discussion/comment/335113/#Comment_335113
2019-07-04 07:11:53 -04:00
Adomas Venčkauskas
2186e939a9 Set the retracted flag for retracted items even if no prompt is required 2019-07-03 23:10:30 +03:00
Adomas Venčkauskas
9efd7cc07d Retracted item citation warning changes
Allows the user to suppress the item retraction warnings from the
citation dialog and makes the retraction warning suppression global.
See #1710
2019-07-03 15:18:41 +03:00
Adomas Venčkauskas
0f9b073073 Ensure retracted item suppression is saved on any integration operation 2019-07-03 13:55:16 +03:00
Dan Stillman
0beddb9680 Add flags to disable retraction warnings
Separate flags for hiding the retraction altogether and for hiding
citation warnings for it

New functions:

Zotero.Retractions.hideRetraction(item)
Zotero.Retractions.shouldShowCitationWarning(item)
Zotero.Retractions.disableCitationWarningsForItem(item)

Addresses #1710
2019-07-03 01:23:02 -04:00
Dan Stillman
f49d5805cd Apply subtitle capitalization to additional styles
This also fixes a style initialization error when the style id is
invalid, which was a regression in a0be2da42c.
2019-07-01 22:39:12 -04:00
Dan Stillman
d13ffcd9a3 Revert "Temporarily disable "Export Document…" button for 5.0.69"
This reverts commit a6e9d76c41.
2019-06-25 23:53:47 -04:00
Dan Stillman
fb101e8fe6 Fix hanging indent in HTML output after citeproc-js 1.2.2 (5.0.57)
The patch in 0036e0a1e for the change in citeproc-js behavior was
incomplete.
2019-06-25 23:36:57 -04:00
Dan Stillman
a6e9d76c41 Temporarily disable "Export Document…" button for 5.0.69 2019-06-24 21:22:34 -04:00
Dan Stillman
aba37b31e4 Fix error from retractions notifier handler on group modification 2019-06-23 20:01:26 -04:00
Dan Stillman
ead93b6ccc Stop uploading files on quota error until next manual sync or restart 2019-06-22 05:29:47 -04:00
Dan Stillman
94795095f2 Fix potential error on retracted item modification
If a retracted item was in the trash at startup or when detected and
there were no other retracted items in the library, an error would occur
if the item was modified.
2019-06-20 18:18:10 -04:00