Commit graph

12204 commits

Author SHA1 Message Date
Tom Najdek
776769f480
Citavi import: Tweak how page label is determined (#2494)
Instead of attempting to extract `PageRange` value we now let pdf worker
always determine page label.

Also improved citavi tests and fixtures.
2022-03-30 09:34:07 -04:00
Abe Jellinek
a9d7a08a05 Fix merge interface doubling rows in master selector
Master choices would occasionally be doubled in the listbox. Clearing
the innerHTML instead of using removeItemAt() fixes the issue.
2022-03-28 13:24:59 -07:00
Abe Jellinek
83702678e6 Update translators 2022-03-28 10:42:08 -07:00
Adomas Venčkauskas
d7b1a53248 HTML Tree: Improve item tree column header alignment.
Addresses #2153
2022-03-28 13:32:17 +03:00
Dan Stillman
17d9f06b65 Update more try-wrapped calls to getString 2022-03-27 02:37:49 -04:00
Dan Stillman
0842b16a51 Update version 2022-03-26 01:30:48 -04:00
Max Suica
047b639fbb
README.md: Update CI Badge (#2473)
Point visitors to our new Github Actions CI
2022-03-25 22:14:47 -04:00
Abe Jellinek
470d9cd7c2 Update more try-wrapped calls to getString 2022-03-25 16:49:52 -07:00
Abe Jellinek
82228a1072 Search: Use item field localization if string == key
91faa73b19 made getString return the key
instead of throwing on non-en-US locales, so we check if the getString
result is equal to the key even if it doesn't throw.

Fixes #2472.
2022-03-25 16:35:01 -07:00
Abe Jellinek
a3322a9afb
Merge pull request #2397 from AbeJellinek/scaffold-sanitize-for-display 2022-03-25 11:59:05 -07:00
Martynas Bagdonas
4dcb3e7a53 Fix deletion confirmation and copying in standalone PDF reader window
Fixes #2462
2022-03-25 15:53:49 +02:00
Martynas Bagdonas
2f5974e1ab Reduce probability of annotation comment/text being cleared while typing
Fixes #2361
2022-03-24 13:40:43 +02:00
Dan Stillman
91faa73b19 Don't throw from getString() for missing strings in non-English locales
Just show the key

We still merge strings before pushing betas, but this means it won't
crash for source builds, or if we forget. Not sure why we didn't do this
15 years ago.
2022-03-24 07:06:53 -04:00
Dan Stillman
1d1adbca70 Fix error merging items with missing attachment files
Fixes #2453
2022-03-24 06:39:47 -04:00
Dan Stillman
9d91e0d4f7 Update locales from Transifex and merge new English strings 2022-03-24 06:18:17 -04:00
Adomas Venčkauskas
f7e49630c8 Fix some more column picker brokenness 2022-03-24 11:00:16 +02:00
Adomas Venčkauskas
c87b40e5ca Fix secondary sort submenu breakage in 8e31bf5b 2022-03-24 10:33:58 +02:00
Adomas Venčkauskas
8e31bf5b6d Possible fix for missing More Columns submenu. Addresses #2443 2022-03-24 10:28:37 +02:00
Martynas Bagdonas
62f07a7356 Upgrade note-editor schema to v8:
- Allow highlight and citation nodes in headers

Fixes #2467
Related #2390
2022-03-24 10:21:04 +02:00
Dan Stillman
98f2d202a2 Update note-editor submodule 2022-03-24 03:32:54 -04:00
Adomas Venčkauskas
229f42bed2 HTML Tree: Change Cu.reportError() to Zotero.logError() 2022-03-23 13:28:46 +02:00
Martynas Bagdonas
23a4a14b44 Upgrade note-editor schema to v7:
- Allow ul/ol nodes to have `dir` attribute
2022-03-23 12:35:08 +02:00
Adomas Venčkauskas
c083c69be1 Fix note insertion dialog not appearing when classic mode is enabled.
Closes #2463
2022-03-23 11:58:06 +02:00
Adomas Venčkauskas
1b124bff2d Actually fix quick format color issues. See cc5e110 2022-03-23 11:28:50 +02:00
Adomas Venčkauskas
0f2273ea43 Link to manual word plugin installation instructions on install failure.
Closes #2444
2022-03-23 11:12:42 +02:00
Dan Stillman
6d4f3739de Update version 2022-03-23 00:08:42 -04:00
Dan Stillman
fcb16f628b Fix "path.startsWith is not a function" sync error on Windows
`OS.Path.join()` on Windows throws if an integer is passed. Seems like
this would happen on another computer whenever an image annotation is
deleted in a group?
2022-03-23 00:01:00 -04:00
Dan Stillman
37c48dc3ee Remove Zotero.Items.moveChildItems() transaction requirement exception
Follow-up to 734057ff9b

This was supposed to allow ZotFile to continue to work but 1) it
contained a bug and 2) another transaction messed things up for ZotFile
anyway, so we'll just fix this in jlegewie/zotfile#593.
2022-03-22 18:07:40 -04:00
Abe Jellinek
95d8b37f0a Potentially fix ProgressWindow crash
The call to _window.addEventListener() might have been causing an error
when _window was null or undefined (no main Zotero window could be
found), which would prevent _windowLoading from being set to true and
the window from being added to the ProgressWindowSet, which might have
caused unpredictable behavior when positioning windows later on.

I could only briefly reproduce the issue, so this is just one idea. The
call to addEventListener on a potentially null _window was definitely a
bug but I don't know if it caused the crash.
2022-03-22 12:55:47 -07:00
Adomas Venčkauskas
cc5e1106ec Fix quick format issues in Linux dark themes. Closes #2441 2022-03-22 14:32:15 +02:00
Adomas Venčkauskas
227b6354de Item Tree: Reset scrollbar to top on collection change 2022-03-22 13:58:02 +02:00
Adomas Venčkauskas
25230b0fca HTML Tree: Fix focused row losing focus sometimes not being redrawn 2022-03-22 13:58:02 +02:00
Adomas Venčkauskas
eab63acab3 Item Tree: Fix twisty colours on macOS. Closes #2446 2022-03-22 13:57:44 +02:00
Dan Stillman
5df1017689 Correction to Scite access date fix in dc886d3cec 2022-03-22 06:01:30 -04:00
Dan Stillman
dc886d3cec Remove access dates broken by Scite
A non-date value ('INVALID_SCITE_VALUE') apparently gets output as
`false` in toJSON(), which results in a sync error.
2022-03-22 05:53:24 -04:00
Dan Stillman
d14a8b1d92 Put Scite cleanup code in a try/catch
Just to be safe
2022-03-22 05:01:50 -04:00
Dan Stillman
f8e9aa147b Add temporary code to fix invalid values from Scite at startup
https://github.com/scitedotai/scite-zotero-plugin/issues/38
2022-03-22 05:00:28 -04:00
Dan Stillman
f95bf41d13 Revert "Fix "cleanDOI: argument must be a string" startup error"
This reverts commit 8763190328.

This is caused by the Scite plugin, and it's better to block startup
until this is fixed, since it's wrecking other fields too.
2022-03-21 23:49:33 -04:00
Dan Stillman
174f1aadde Fix error adding group item before syncing in Zotero 6
Fixes #2440
2022-03-21 22:50:43 -04:00
Dan Stillman
8763190328 Fix "cleanDOI: argument must be a string" startup error
Due to 0 integer value for DOI from somewhere (a plugin?)

https://forums.zotero.org/discussion/comment/402388/#Comment_402388
https://forums.zotero.org/discussion/comment/402391/#Comment_402391
2022-03-21 22:02:54 -04:00
Dan Stillman
675af801f7 Update version 2022-03-21 22:02:54 -04:00
Abe Jellinek
bca76319ce
getSortTitle: Strip less punctuation, trim (#2442)
Now it:

1. Strips punctuation at the beginning, no matter what it is.
2. Strips non-dash punctuation in other positions.
3. Trims the result.

This should better prevent numerical ranges from being joined into a
single number that ends up incorrectly being sorted to the very bottom.
2022-03-21 20:06:27 -04:00
Dan Stillman
3a9e46f31d Update version 2022-03-21 07:37:19 -04:00
Dan Stillman
afeb6afecf Update translators 2022-03-21 06:33:58 -04:00
Adomas Venčkauskas
7182531ec9 HTML Tree: Improve Linux GTK styling (for dark theme support)
Closes #2424
2022-03-18 11:48:14 +02:00
Martynas Bagdonas
388d18d017 Terminate PDF worker after processing PDFs queue
Fixes #2421
2022-03-17 14:26:07 +02:00
Tom Najdek
e156a46833
Fix build on win 2022-03-17 13:17:28 +01:00
Martynas Bagdonas
edf0c31bdb Remove old note editor binding 2022-03-17 11:18:17 +02:00
Dan Stillman
121f3f3037 Update locales from Transifex 2022-03-16 20:45:18 -04:00
Dan Stillman
ec9b68fdd1 Update pdf-reader submodule 2022-03-16 20:45:18 -04:00