mirrors/zotero
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions
8287 commits 9 branches 364 tags 290 MiB
Commit graph

8287 commits

This branch
This branch
All branches
Author SHA1 Message Date
Dan Stillman
ac34f2c4f4 Allow additional options for support test functions 
- libraryVersion for createGroup()
- Zotero.Item save options for importFileAttachment()
 2016-07-19 18:54:37 -04:00
Dan Stillman
e5d65f5936 Maybe reduce spurious errors in ConcurrentCaller test 2016-07-19 18:53:48 -04:00
Dan Stillman
ee74030d03 Warn if attachmentSyncedModificationTime is set to too-low timestamp 2016-07-19 18:51:15 -04:00
Dan Stillman
3655c09450 Zotero.Item.prototype.deleteAttachmentFile() 2016-07-19 18:51:05 -04:00
Dan Stillman
66ca2cfda2 Fix saving of automatically merged remote changes during sync 2016-07-19 02:27:38 -04:00
Dan Stillman
2857f85656 Alphabetize feed list 2016-07-19 01:50:18 -04:00
Dan Stillman
7b45b920fc Fix clearing of missing fields in Item::fromJSON() 2016-07-18 23:44:36 -04:00
Dan Stillman
35d057decb Use new groups for collections tests 2016-07-18 17:51:59 -04:00
Dan Stillman
2d39614143 Fix subcollections being shown at top level of groups 
Fixes #1065
 2016-07-18 17:51:59 -04:00
Dan Stillman
ab10d1617e Replace deprecated Zotero.Libraries.isEditable() call on note save 2016-07-17 15:14:06 -04:00
Dan Stillman
381fe38b89 Fix #1038, Notes skip back to beginning if typing during auto-save 
Set a unique id on the note editor at initialization and pass it along
to item.saveTx(). When notify() is called, if the save was triggered
from the current note field, don't do a refresh.

This does mean that the note field won't reflect changes (e.g.,
normalizations) made by the save process until the user clicks away and
back, which makes me a little uncomfortable. If we can find specific
cases where that occurs (paste?), we can reevaluate this approach.
 2016-07-17 15:14:06 -04:00
Dan Stillman
69dec87aa6 Allow passing arbitrary values to notifier events from DataObject.save() 
item.saveTx({
    notifierData: {
        foo: 1
    }
});

foo: 1 will be included in the extraData[id] object in notify().
 2016-07-17 15:14:06 -04:00
Dan Stillman
4449da7e91 Tweak note field auto-save triggering 
This avoids unnecessary timeout calls and fixes a problem where typing
in a newly initialized note doesn't save it until the first blur().
 2016-07-17 15:13:39 -04:00
Dan Stillman
6a7e3d0259 Add "is (less|greater) than" to num pages/volumes search conditions 
https://forums.zotero.org/discussion/60897/
 2016-07-16 17:15:17 -04:00
Adomas Ven
b0157efd23 Clone feed item if no translators available (#1061) 2016-07-14 14:17:56 -04:00
Dan Stillman
eb7556533a Merge pull request #1063 from adomasven/fix/use-link-for-id 
Use feed item links for guid if id unavailable
 2016-07-13 12:42:39 -04:00
Adomas Venčkauskas
f7a6464f82 Use feed item links for guid if id unavailable 2016-07-13 13:49:46 +03:00
Dan Stillman
1b6dffb886 Don't refresh collections pane when updating library last-sync times 2016-07-12 03:23:47 -04:00
Dan Stillman
cd3f621a00 Don't auto-sync skipped libraries on change 2016-07-12 00:41:08 -04:00
Dan Stillman
599598566b Use best first creator for OpenURL author, not just first position 
This also fixes Google Scholar Search lookup to use an author not in first creator
position [1].

[1] https://forums.zotero.org/discussion/58384/
 2016-07-11 06:30:55 -04:00
Dan Stillman
83d11947ff Fix UI breakage that prevents switching collections 
I'll add a test later once I figure out how to reproduce this, but I
think this should fix the "id is undefined" errors.
 2016-07-11 06:25:19 -04:00
Dan Stillman
2ebd7bd114 Update search test after c1f7a188e2 
c1f7a188e2 changed createDataObject('search') to create 2 search conditions
instead of 1
 2016-07-07 08:39:19 -04:00
Dan Stillman
c1f7a188e2 Fix error modifying existing saved search with more than 1 condition 
Closes #1056, which wasn't actually the problem
 2016-07-07 07:55:15 -04:00
Dan Stillman
18cf6088b0 Fix CR window for storage files (follow-up from d44eeb752b) 2016-07-07 05:45:58 -04:00
Dan Stillman
54ba532ebd Fix display of parent item title in popup note window 2016-07-07 05:19:26 -04:00
Dan Stillman
d44eeb752b Fix error on CR of child note, and show parent item title in merge pane 2016-07-07 05:18:02 -04:00
Dan Stillman
72bad4309b Show "Choose Parent" button for deleted items in CR window 2016-07-07 04:08:11 -04:00
Dan Stillman
9f9e95ea96 Show conflicts in debug output when showing CR window 2016-07-06 13:56:27 -04:00
Dan Stillman
bfbac24667 Condense debug output for skipped up-to-date items when syncing 2016-07-06 13:54:25 -04:00
Dan Stillman
7dce069490 Merge English strings to locales 2016-07-06 02:14:55 -04:00
Dan Stillman
c40a5a983c Fix #1057, Item order is lost in saved search after item edit 
Broken by 3dc0ad37
 2016-07-06 02:09:14 -04:00
Dan Stillman
5740d4729d Use random title in search condition in createDataObject() test function 
Can be retrieved with search.getConditions()[0].value and included in an item
title to have an item match the created search
 2016-07-06 02:04:53 -04:00
Dan Stillman
fc857dc496 Close #1053, Manual sync option in library context menu 
This also reworks how the collection context menu is built to do more in
JS instead of XUL, though it can't do it all in JS because some
localized strings are in zotero.dtd and are used in standalone.xul too.
 2016-07-02 03:15:37 -04:00
Dan Stillman
893b9ae1fc Show "Duplicate Items" and "Unfiled Items" for all libraries by default 
Previously they only showed for My Library by default, which I suspect
meant that most people didn't know you could get them for other
libraries...

This hides "Duplicate Items" and "Unfiled Items" from the context menu
when they're active, which may or may not be desirable (but we don't
show, say, "Trash" in the context menu).

Also tweaks selection behavior after hide to select next appropriate row
instead of the parent library.
 2016-07-02 03:15:37 -04:00
Dan Stillman
51b3951fb0 Maintain open state of groups on collectionTreeView refresh() 2016-07-02 03:15:37 -04:00
Dan Stillman
86b5042781 Rename _rememberOpenStates() to _saveOpenStates() in collectionTreeView 2016-07-02 01:27:51 -04:00
Dan Stillman
e787bb1183 Fix save()/saveTx() warning when uploading settings 2016-06-30 07:24:06 -04:00
Dan Stillman
2a55e56f3f Save open field when selecting from an item pane context menu 
If a field is open and the user right-clicks on another field (e.g., swap
names, creator type, transform text), any changed value in the open field was
lost.

Also:

- Don't show swap-names menu in single-field mode

I can't quite get programmatic access to context menus to work correctly, so
tests are disabled for now. (They work individually, but not together.)
 2016-06-29 05:35:51 -04:00
Adomas Ven
2cce099928 Add custom view groups for different library types (#1042) 
I originally attempted this with zotero-persist and column attributes,
but there is no good way to make it succinct paramswise and the code was
painful to look at too. Thus different group settings are stored in
preferences.

Currently there are two view groups: "feed" and "default". Items view
columns have two new attributes:
`default-in` - a space separated list of views in which a column is
visible by default
`disabled-in` - a space separated list of views in which a column is
disabled by default (invisible + not possible to enable)

Fields not parsed for feeds are now disabled.
 2016-06-28 20:12:54 -04:00
Dan Stillman
622530e889 Fix #1054, UI breakage after unsubscribing from feed 2016-06-28 14:29:15 -04:00
Dan Stillman
9e6565fe00 Skip skipped groups when syncing 
Except if a library list is passed to Zotero.Sync.Data.Runner.sync() (which
isn't done currently but will be in #1053)

Follow-up to #1033
 2016-06-27 16:48:32 -04:00
Adomas Ven
b0f3a234d0 Allow choosing of synced libraries in sync preferences (#1033) 
Affects Sync button and auto-sync. Manual library sync will be possible later via library context menu.
 2016-06-27 12:47:11 -04:00
Adomas Ven
11e7cef057 Show hard warning dialog when unlinking or linking to a different account (#1047) 
And give option to delete local data when unlinking

This removes the old behavior of merging accounts when syncing with a different username.
 2016-06-27 12:40:38 -04:00
Dan Stillman
eb7bba9d7d Merge pull request #1052 from retorquere/patch-1 
Sort items for translator
 2016-06-27 10:10:04 -04:00
retorquere
bd6dec352c Sort items for translator 
In response to https://forums.zotero.org/discussion/60375?page=1#Item_6
 2016-06-27 15:54:50 +02:00
Dan Stillman
455facee95 Merge pull request #1051 from retorquere/patch-2 
Sort items for translator
 2016-06-27 09:40:33 -04:00
retorquere
32c6e1edb3 Sort items for translator 
In response to https://forums.zotero.org/discussion/60375?page=1#Item_6
 2016-06-27 15:12:02 +02:00
Dan Stillman
caaee87e9e Fix showing of WebDAV settings in sync prefs 2016-06-26 05:29:51 -04:00
Dan Stillman
0ea328dac5 Fix changing of linked attachment base directory 2016-06-26 02:02:22 -04:00
Dan Stillman
7e5b46b146 Merge pull request #1048 from adomasven/fix/linux-test-failures 
Fixes freezing occuring on linux while running tests
 2016-06-25 07:30:35 -04:00