Commit graph

14774 commits

Author SHA1 Message Date
Dan Stillman
a83852367f Fix 64-bit installer refusing to run on non-ARM systems
Some checks are pending
CI / Build, Upload, Test (push) Waiting to run
Regression from b8b4bebf
2024-08-14 22:49:02 -04:00
Dan Stillman
874f42df36 Update utilities submodule
Some checks are pending
CI / Build, Upload, Test (push) Waiting to run
Includes zotero/utilities#36
2024-08-14 17:59:48 -04:00
Abe Jellinek
f0d453187d Fix editable-text dir not affecting existing input
Some checks are pending
CI / Build, Upload, Test (push) Waiting to run
2024-08-14 11:19:04 -06:00
Abe Jellinek
64238d56bc Fix circular reference in getDirection()
Was preventing the field-specific switch branch from being reached.
2024-08-14 11:19:04 -06:00
Tom Najdek
4f1e44978e
Fix <wizard> sometimes starts with the wrong title. Resolve #4533.
Some checks are pending
CI / Build, Upload, Test (push) Waiting to run
This is caused by
https://searchfox.org/mozilla-central/source/toolkit/content/widgets/wizard.js#417-428
where fluent attribute is removed and replaced with the default value.
We need to stick with `data-header-label-id` until this is resolved
upstream.
2024-08-14 17:53:33 +02:00
Tom Najdek
ca83e4303c
Windows installer: Add option to remove installdir when previous installation detected (#4564)
Some checks are pending
CI / Build, Upload, Test (push) Waiting to run
2024-08-14 04:53:19 -04:00
Dan Stillman
f5af1898fd Proper fix for getDirection() problems
Hopefully the last fix for my edits to 181afb9 (#4534)

Follow-up to the previous two commits
2024-08-14 04:01:26 -04:00
Dan Stillman
531e8697be Fix additional breakage when bidi.browser.ui is true
Some checks are pending
CI / Build, Upload, Test (push) Waiting to run
Broken by me in an edit to 181afb9 (#4534)

Follow-up to previous commit
2024-08-14 03:42:08 -04:00
Dan Stillman
ec50539e80 Make Zotero.ItemFields.getBaseIDFromTypeAndField() more resilient
- Return base field instead of throwing if base field is passed for a
  type that has a base-mapped field
- Return false instead of throwing for invalid type-field combination
2024-08-14 03:14:29 -04:00
abaevbog
53ad856ef4
vpat 31 and 33 - aria tweaks for Tools > Plugins (#4560)
Some checks are pending
CI / Build, Upload, Test (push) Waiting to run
- vpat 31: mark which menuitems' button is checked,
otherwise selected options (e.g. Update plugins automatically)
are not announced as such
- vpat 33: when plugin details pane appears, remove
a misleading role="tabpanel" from its section because
it is not structured as a collection of tabs
2024-08-13 16:46:46 -04:00
Adomas Ven
ed311cacb9
Show a different error message for WinWord when no document is found (#4563)
And link to a different troubleshooting page
2024-08-13 16:13:00 -04:00
Dan Stillman
5d998a3b37 Load brand.ftl for Zotero.getString() 2024-08-13 16:06:47 -04:00
windingwind
0530afd669
Fix two item panes occasionally appear at same time (#4561)
Some checks are pending
CI / Build, Upload, Test (push) Waiting to run
2024-08-13 02:43:14 -04:00
Dan Stillman
d879c507a5 Enable auto-scroll by default on Linux
Some checks are pending
CI / Build, Upload, Test (push) Waiting to run
Fixes #4537
2024-08-13 00:06:34 -04:00
Dan Stillman
97650efe05 Fix blurry creator row buttons on non-HiDPI displays
From @yexingsha

Fixes #4549
2024-08-13 00:06:21 -04:00
Dan Stillman
9b23755190 Update CSL locales
Includes https://github.com/citation-style-language/locales/pull/319
2024-08-13 00:06:21 -04:00
abaevbog
8c3f13909c
vpat 59: make quickFormat reference box separator text darker (#4400)
So that on Windows, the separator text on white background
has a high enough contrast ratio for accessibility

Also remove opacity when reference panel opens. Without the opacity
on the reference panel, there is a shadow appearing below and to the
right of the panel on Windows. If we let the panel render with
opacity: 0.9 and only then set opacity: 1, the panel will no longer
be transparent and there will be no shadow.
2024-08-13 00:05:11 -04:00
Abe Jellinek
a566d83411 Migrate to our editMenuOverlay.js
Some checks are pending
CI / Build, Upload, Test (push) Waiting to run
2024-08-12 15:25:31 -06:00
Abe Jellinek
d5deb406d7 Include editMenuOverlay.js in Web Link dialog
Fixes #4544
2024-08-12 15:24:56 -06:00
Abe Jellinek
16bb95ad3f
Collection tree: Keep editing state through refresh (#4556)
Some checks are pending
CI / Build, Upload, Test (push) Waiting to run
2024-08-12 16:43:49 -04:00
Abe Jellinek
51fe17c13d editable-text: Don't move cursor when value/alignment changes on focus (#4534)
Some checks are pending
CI / Build, Upload, Test (push) Waiting to run
For example, clicking in the middle of the Accessed field would move the
cursor to the end, no matter where the click happened. Clicking and
dragging when the field wasn't already focused would select from the
beginning of the field to the drag position.
2024-08-12 15:09:27 -04:00
Abe Jellinek
181afb92ac Bidi improvements and fixes (#4534) 2024-08-12 15:09:10 -04:00
Abe Jellinek
98b3745a20
Update Notes section on add (#4554) 2024-08-12 15:06:09 -04:00
Dan Stillman
b1b06cedde Windows installer: Remove some "Zotero Standalone" references 2024-08-10 04:27:07 -04:00
Dan Stillman
b8b4bebfc5 Windows installer: Improve architecture detection
Show an appropriate error if the ARM64 installer is run on non-ARM
Windows or if the x64 installer is run on a 32-bit system, and set the
correct architecture in `CurrentVersion\Uninstall` registry key.

Also fix `x86`/`x64` being swapped in the registry
(https://groups.google.com/g/zotero-dev/c/1Aju4t2TNTo/m/Ga4V8vLrAQAJ)
2024-08-10 04:26:58 -04:00
Dan Stillman
6e155de3e1 Windows installer: Change HAVE_64BIT_OS to HAVE_64BIT_BUILD
https://bugzilla.mozilla.org/show_bug.cgi?id=598615
2024-08-10 02:14:40 -04:00
Dan Stillman
b564924c7c build_and_run: Fix debugger not showing Zotero sources when using d
`-jsconsole` somehow prevented Zotero sources from showing up in the
Debugger tab of the Browser Toolbox, but there's no reason to show the
Browser Console when we're showing the Browser Toolbox, so just don't
pass `-jsconsole` when `d` is passed.

Fixes #4503
2024-08-10 01:32:46 -04:00
Abe Jellinek
041d190286
Item box: Remove hidden buttons from flex calculations (#4541) 2024-08-09 13:53:25 -06:00
Abe Jellinek
b3589e1d89 macOS menupopup styles: RTL fixes
- Use padding-inline-start for gutter
- Refactor other rules that used left/right margins/paddings, to make
  future accidental breakage less likely

Fixes #4538
2024-08-09 13:15:26 -06:00
abaevbog
a7eb49162e
tweaks to Zotero_Tooltip behavior (#4523)
- hide tooltip on click and make sure it does not appear
for a bit to avoid race conditions (e.g. clicking
right after mousemove stopped)
- do not display a tooltip if a mouse key is being
held (e.g. during drag in itemTree)

Fixes: #4519
2024-08-09 12:23:31 -04:00
windingwind
69b4789c17
Unify richlistitem styling rules (#4511)
Unify richlistitem styling rules

- Fix richlistitem unwanted focus ring on Linux
fix: #4510
- Simplify richlistbox styling rules and do not follow Mozilla code
- Use --default-focusring-width for v-table
2024-08-09 15:57:56 +03:00
Dan Stillman
b7bfdd5f7c Update version 2024-08-09 00:51:55 -04:00
Dan Stillman
f55d5c1067 Set version to 7.0
Some checks failed
CI / Build, Upload, Test (push) Has been cancelled
2024-08-09 00:32:47 -04:00
Dan Stillman
5d54b4d37d Handle absence of Z7 incrementals 2024-08-09 05:20:58 +01:00
Dan Stillman
4816eed0f4 Handle 0 incrementals 2024-08-09 00:17:56 -04:00
Dan Stillman
c8fbad4be7 Update release script for 7.0 2024-08-09 00:17:04 -04:00
Dan Stillman
794dc6bf01 Updated icons for creator row buttons
Fixes alignment issues brought up in
https://github.com/zotero/zotero/pull/4535#issuecomment-2276347669

From @yexingsha
2024-08-08 23:33:15 -04:00
Abe Jellinek
2d32efbccd
Apply tag text color to ellipsis (#4536) 2024-08-08 22:54:10 -04:00
Dan Stillman
9dd3807683 Wider icon for creator-field-mode button (#4535) 2024-08-08 22:50:47 -04:00
Bogdan Abaev
7450622047 itembox: switch creator mode button (#4535)
- added button to switch mode to creator rows
- removed that option from options menu
- extra tweak to avoid cursor flickering during re-render after
clicking on the button
- increased itemPane min-width to 320px

Fixes: #3959
2024-08-08 22:50:26 -04:00
Tom Najdek
19dad92b92
No longer create <browser> instance for each AbstractBox. Fix #4530 (#4532) 2024-08-08 17:54:17 -04:00
Tom Najdek
083ad9ee05
Fix missing margin between colored and emoji tags
In the item tree, emojis are spaced 4px apart, but there was no space
between the colored circles and the first emoji, making it look crowded.
2024-08-08 18:09:19 +02:00
Dan Stillman
7f21da9334 Revert "Add additional backslashes in Exec line in Linux desktop file"
This reverts commit 06741ceb62.

A couple people on Fedora 40 reported that the desktop file was no
longer working for them after this change, and it's not clear that
anyone was having trouble on Ubuntu before it -- someone just noted that
`desktop-file-validate` was showing some warnings.
2024-08-08 07:40:39 -04:00
windingwind
6f6444dc12
Fix tab bar scroll arrow button click not working (#4529)
fix: #4527
2024-08-08 04:19:41 -04:00
windingwind
01f9222735
Remove form element rule !important suffix on Windows (#4528)
Fix tab bar button hover effect on Windows
A follow up fix of #4518
2024-08-08 03:40:59 -04:00
abaevbog
4c32317ba4
Quick Format: Prevent CSS override of background color (#4525)
Followup to 55017926b5
2024-08-08 01:39:18 -04:00
abaevbog
35da1187b3
prefs: fix text-link not clicking on space/enter (#4522)
Fix regression after 117197e11d
where space or enter would not trigger a click on
link outside of the main window.

".keyboard-clickable" is handled by listener in ZoteroPane,
so links outside of it (e.g. preferences) are not affected by it.
For now, just explicitly handle "keypress" event by the
zotero-text-link component.

Also, added a focus-ring around the link so it is visible
when it is focused.

Fixes: #4521
2024-08-08 00:24:19 -04:00
Abe Jellinek
531f55120c
Feed settings: Make disclosure triangle focusable, extract SCSS (#4513)
- <hbox> -> <button>, <toolbarbutton> -> <dropmarker>
- Extract styles to SCSS and use focus-ring mixin

Fixes #4512
2024-08-08 00:22:09 -04:00
Abe Jellinek
14ab0cd529
Fix button selector specificity on Windows (#4518)
And remove !important.
2024-08-08 00:21:26 -04:00
Tom Najdek
214a668286
Trim plural/selector variants in ftl-to-json
Updated ftl-tx to a version that includes this fix.
2024-08-07 11:41:37 +02:00