Abe Jellinek
63864f2f86
duplicateAndConvertSelectedItem: Don't copy abstracts ( #2799 )
2022-08-29 16:15:31 -04:00
Abe Jellinek
b646073dfa
fx-compat: Fix style clash on disabled Export checkbox
2022-08-27 22:33:45 -04:00
Martynas Bagdonas
09ba429723
Update note-editor submodule and strings for math and table insertion
...
(cherry picked from commit d156bef42a
)
2022-08-25 14:27:42 +03:00
Adomas Venčkauskas
4f0b07505a
Fix SingleFile snapshot saving stalling in Firefox Connector
...
Update SingleFile submodule
2022-08-24 11:49:45 +03:00
Abe Jellinek
92095314c6
fx-compat: Preferences: Use our edit menu overlay
...
So text context menu actually works.
2022-08-22 16:46:50 -04:00
Abe Jellinek
c2254f3783
fx-compat: Scaffold: Native checkboxes, dropmarker
2022-08-22 16:20:28 -04:00
Abe Jellinek
d653ec817c
fx-compat: Add by Identifier: Prevent expand after invalid ID input
2022-08-22 12:51:35 -04:00
Abe Jellinek
85e13dc3ee
Zotero.PreferencePanes: Auto-generate ID, rearrange params
...
A manual pane ID isn't often necessary, since you can just give a manual ID to
the root element in your XHTML. Let's make things a bit simpler for the caller
and reduce the potential for conflicts.
2022-08-22 10:52:25 -04:00
Dan Stillman
0655d4350e
Update package-lock.json
2022-08-22 01:15:21 -04:00
Dan Stillman
170f1962ad
Don't repeatedly upload relations
...
Fixes #2772
2022-08-22 01:15:21 -04:00
Tom Najdek
454368e3d3
Make citavi annotations importer more resilient
2022-08-19 12:05:30 -04:00
Tom Najdek
cff02b04a0
Fix importing Citavi annotations in some cases
2022-08-19 12:05:30 -04:00
Dan Stillman
0695154661
Update pdf-reader submodule
2022-08-19 12:05:30 -04:00
Dan Stillman
5103d904f3
Include proper test for b373291c02
for #2771
2022-08-19 12:05:30 -04:00
Dan Stillman
e9e1add9b8
Fixed filed items with annotations appearing in Unfiled Items
...
Fixes #2771
Regression from 20c6fe67
2022-08-19 12:05:30 -04:00
Abe Jellinek
22b00c33de
Empty Trash: Visually remove deleted items, refresh icon ( #2606 )
...
There were a few problems causing the incorrect behavior:
1. Rows were being removed only if they had no non-deleted children, which
wasn't the right check. We want to remove all rows with no *deleted*
children.
2. Children of the removed rows weren't being removed with them.
3. We weren't invalidating the tree (which _removeRows() doesn't do).
Also:
* Erase trashed annotation after getAnnotations() test
Because ItemTree#notify() doesn't yet correctly handle refresh events on
parent items that are themselves children (three-level nesting: item ->
attachment -> annotation), this test was causing a failure in
itemTreeTest.js.
2022-08-19 09:14:24 -04:00
Martynas Bagdonas
40ae2e3246
Fix navigation to annotation when opening an unloaded PDF reader tab
...
Regression from 142e3b09
2022-08-18 04:12:44 -04:00
Martynas Bagdonas
8ca7356489
Fix regression for broken "Snow in Page"
...
Fixes #2764
Regression from 7ec54fd
2022-08-18 04:12:44 -04:00
Abe Jellinek
0eaf5887ea
fx-compat: Scaffold: Use platform keys like zoteroPane
2022-08-17 16:47:39 -04:00
Abe Jellinek
f5f49c7b1d
fx-compat: Scaffold: Non-async detectWeb and async scrape by default
...
We don't usually want an async detectWeb, since HTTP requests should only be
used there in very exceptional cases. We do usually want an async scrape (and we
were already - mistakenly - awaiting it).
2022-08-17 16:31:30 -04:00
Dan Stillman
f7b8d25e75
Update localized string for pdf-reader
2022-08-17 03:47:30 -04:00
Dan Stillman
d3d6a6be48
Fix and disable item-tree test for emptying trash
...
20c6fe6737
caused this to start failing, but only because the test was
testing something too specific. The change in that commit caused more
rows to be left behind when emptying the trash (for reasons I should
probably look into), but the trash wasn't being emptied properly before,
which #2606 should fix. This test should be restored as part of that PR.
2022-08-17 03:35:54 -04:00
Dan Stillman
402dc286d1
Update pdf-reader submodule
2022-08-17 03:35:28 -04:00
Dan Stillman
c3ee588bfe
Match parent attachments for annotation tags
...
Expose annotation tags in tag selector and match parent attachments when
filtering/searching
This also fixes searching for annotation text or comments when using
Everything quick search.
This is temporary until we display annotations in the items list
directly.
2022-08-17 03:35:28 -04:00
Dan Stillman
eca253d4a3
Update pdf-reader submodule
2022-08-16 06:09:09 -04:00
Dan Stillman
6cd1a41a32
Fix importing of standalone attachments without URLs
...
And allow `importSnapshotFromFile()` without `parentItemID` or
`libraryID`, which is more consistent with other attachment functions
Follow-up to 318e4852e9
https://forums.zotero.org/discussion/comment/414802/#Comment_414802
2022-08-16 06:09:00 -04:00
Abe Jellinek
b03657add3
fx-compat: Use DOMParser constructor in _eventToEventTitle
2022-08-15 10:38:11 -04:00
Dan Stillman
676abca671
Fix importing of standalone attachments
...
Maybe has been broken for years?
https://forums.zotero.org/discussion/99020/warning-data-loss-when-exporting-collections
2022-08-13 16:24:14 -04:00
Dan Stillman
d546caca4c
Don't relate book sections to each other when creating from book
...
Fixes #2757
2022-08-13 05:46:04 -04:00
Dan Stillman
344a10421a
Fix copying of standalone attachments between libraries
...
Regression in f684984b07
(maybe a race condition)
2022-08-13 02:04:07 -04:00
Abe Jellinek
30197a09d2
Revert mistaken change from 26069a580a
...
Shouldn't have made it into that commit.
2022-08-12 15:36:54 -04:00
Abe Jellinek
fc86bdb55c
fx-compat: Fix error when Edit menu is shown
2022-08-12 15:34:27 -04:00
Abe Jellinek
26069a580a
fx-compat: Fix Quit when main window is closed
...
Application menu items, contrary to the comment I added in a654ad291f
,
actually *do* belong in hiddenWindow.xhtml so that they still work when
zoteroPane.xhtml is closed. They just can't be split between there and
zoteroPane.xhtml. This commit moves all of them to hiddenWindow.xhtml and
reimplements openPreferences() in a non-Zotero-object-dependent way.
Fixes #2738
2022-08-12 15:34:26 -04:00
Abe Jellinek
9ab813ebdc
fx-compat: Item box: Vertically center field contents
...
Fixes alignment of the "y m d" label on the date field and the buttons to the
right of creator fields.
2022-08-11 16:46:03 -04:00
Abe Jellinek
333cf8cc2a
Add Book -> Book Section and Book Section -> Book to context menu ( #2754 )
2022-08-11 16:28:32 -04:00
Martynas Bagdonas
4f52eb9be3
Fix PDF reader selector popup that was never opening
...
(cherry picked from commit e4e3c72036
)
2022-08-11 14:22:52 +03:00
Martynas Bagdonas
d1550a3fd5
Fix regression preventing opening PDF reader window when the tab is open
...
(cherry picked from commit 0857cefb0c
)
2022-08-11 14:22:52 +03:00
Adomas Venčkauskas
d6909ec8e5
Update SingleFile config for current version
...
They got updated upstream and the backwards-compat code
does not run for the way we execute singlefile
See https://github.com/gildas-lormeau/SingleFile/issues/1021
Addresses https://github.com/zotero/zotero-connectors/issues/398
2022-08-11 14:00:40 +03:00
Adomas Venčkauskas
2dd54fddf4
Prevent singlefile config from overwriting the Zotero.SingleFile namespace
2022-08-11 13:51:57 +03:00
Dan Stillman
c90f8415b3
Improve test for event-title
substitution
...
And add comments
Follow-up to 20d0f103f
2022-08-11 03:57:25 -04:00
Dan Stillman
ebacb83563
Reset Zotero.locale
to 'en-US' after cite test
2022-08-11 03:57:20 -04:00
Dan Stillman
7eab91a160
Automatically substitute event-title
for event
in styles
...
Stopgap until styles are updated in citation-style-language/styles#6151
2022-08-11 03:57:15 -04:00
Abe Jellinek
df5bde79e5
Add test for 87455d
2022-08-11 03:57:09 -04:00
Dan Stillman
57b91a0add
Move item box comment from 87455d28c3
...
The code seems to have already been applied on the fx102 branch
2022-08-11 03:56:46 -04:00
Abe Jellinek
678a6101b3
Advanced Search: Make sure items are loaded ( #2743 )
2022-08-11 03:53:39 -04:00
Dan Stillman
72d4cdd3a3
Don't preselect Act for multiple sources in classic citation dialog
...
"Multiple Sources…" wasn't properly handled by 629892b0b8
https://forums.zotero.org/discussion/98877/act-instead-of-page
https://twitter.com/drezvera99/status/1554521940684984320
2022-08-11 03:53:34 -04:00
Martynas Bagdonas
098886bcb6
Select existing unloaded tab instead of opening a new one
...
Fixes #2740
2022-08-11 03:52:53 -04:00
Martynas Bagdonas
9190eb8f34
Allow to scroll tabs with mouse wheel
...
Fixes #2724
2022-08-11 03:52:45 -04:00
Abe Jellinek
1f9e518581
Duplicates Merge: Preserve embedded annotations ( #2728 )
2022-08-11 03:52:40 -04:00
Adomas Venčkauskas
63148dff3b
Do not load-timeout on browser PDF download during content load
...
Closes #2726
2022-08-11 03:52:31 -04:00