mirrors/zotero
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions
13850 commits 9 branches 364 tags 290 MiB
Commit graph

10896 commits

Author SHA1 Message Date
Adomas Venčkauskas
34b389d118 Fix the startup missing data directory picker not working 2024-02-14 13:22:41 +02:00
Abe Jellinek
f729172bdd Fix error after setting custom file handler 2024-02-13 13:58:49 -05:00
Abe Jellinek
872e7b2427 Item/attachment box: Prevent default label focus/blur behavior 
Since ceb1dd7da3 added a tabindex on
#zotero-view-item, clicking anywhere outside a field in the pane will
blur the active field. That's an improvement, but it conflicted with our
custom label behavior - when an active field's label is clicked, we want
to blur it and keep it blurred, but the default behavior is to re-focus
it on mouseup.

Fix by preventing the default focus behavior on mousedown/click.
 2024-02-09 14:38:56 -05:00
Abe Jellinek
6a39980a97 Save Abstract edits when switching items 
Since itemPane.js sets mode before item, the editable-text's value would
get reset before save() ran.

Not touching the header since we're replacing that with an item-box
field (which does not have this bug) soon anyway.

Fixes #3679
 2024-02-09 12:21:56 -05:00
Adomas Venčkauskas
0aea17581e Citation Dialog: Show selected notes in the Add Note dialog 
Closes #3642
 2024-02-09 14:24:05 +02:00
Adomas Venčkauskas
d852185950 Citation Dialog: Fix open documents being matched multiple times. 
Closes #3690
 2024-02-09 14:17:43 +02:00
Abe Jellinek
4a91df1b1d
Add test for SandboxItem#setExtra() (#3572) 2024-02-09 09:34:47 +02:00
Adomas Venčkauskas
90282b3739 Clear item tree pivot after switching collections. Closes #3551 
After switching collections and shift-clicking on the item tree
will no longer group-select from the pivot of the previous selection
 2024-02-08 15:03:02 +02:00
Bogdan Abaev
527fa5b12f linux: collection highlight on control 
On Linux, trigger collection highlighting on Control instead of Alt
to not interfere with the menubar.

Addresses: #3683
 2024-02-08 10:07:36 +02:00
Adomas Venčkauskas
88482bd776 Do not register the menu access key handlers multiple times 2024-02-07 17:18:56 +02:00
Bogdan Abaev
fc5aa1a6ba win: no collection highlight if input is focused 
So that collections do not randomly get highlighted when one clicks
Ctrl-C/Ctrl-V to copy-paste something in the itemPane
 2024-02-06 15:20:43 -05:00
abaevbog
ceb1dd7da3
additions to keyboard nav for toolbar buttons and reader (#3602) 
- handle space and enter in zotero pane to always click on toolbarbutton.
It ensures consistent behavior across all components to avoid Enter
triggering click on some buttons but not others.
- address the issue of focus not being able to leave the reader once it
gets there. On Escape, when reader is opened, instead of re-focusing the reader,
focus the selected tab. From there, Enter will focus the reader, and tabbing
allows you to reach the itemPane.
- Tab/Shift-tab moves focus between Sync button and itemPane when
reader is opened
 2024-02-06 12:51:06 -05:00
Bogdan Abaev
e69ce9b86c avoid ztabindex overlap when new creator is added 
Increated the ztabindex offset for non-creator rows, so that when a new
creator is added but not saved yet, there is no two elements with
the same ztabindex which would break tab-based navigation

Fixes: #3666
 2024-02-06 12:44:29 -05:00
Bogdan Abaev
15d5dcaaee itemBox creator names fixes 
- Instead of setting default name as the value of the field when a
creator name is empty, set the default names as a placeholder so that
it shows up only when the field is empty.
- Have the creator options show up before the creator is saved so that
the mode can be switches before saving the creator.
- Re-do of capitalizeCreatorName to not break when one of the names is focused.

Fixes: #3610
 2024-02-06 12:44:29 -05:00
abaevbog
3a2cd70684
update tab when collection row is updated (#3673) 
When saved search, collection or feed is renamed, update the zotero-pane
tab so that it has the new title.

Fixes: #3664
 2024-02-06 02:23:09 -05:00
Abe Jellinek
de89e82e75 Make Tags/Related sections functional in note windows 
Fixes #3581
 2024-02-05 17:11:42 -05:00
Dan Stillman
f29f87ad5b Fix missing "Edit Saved Search" label 
Regression from f8108aca45

https://forums.zotero.org/discussion/111486/zotero-7-beta-edit-saved-search-from-right-click-on-a-saved-search-collection
 2024-02-04 06:22:50 -05:00
Abe Jellinek
6486c509ad Fix customElements.js error when editing saved search 
Fixes #3672
 2024-02-02 15:32:55 -05:00
windingwind
3acef799f5
Fix custom elements import (#3639) 
Fixes #3600
 2024-02-02 04:02:08 -05:00
abaevbog
a74c86d948
collection search tooltiptext and placeholder cleanup (#3632) 
Fluent tooltiptext for collection search button and placeholder
for collection search input
 2024-02-02 03:58:27 -05:00
abaevbog
4a3a80b4f8
editable-text min/max-lines attributes (#3649) 
- min/max-lines attribute on editable-text determines how tall the field
can/has to be
- if max-lines is not specified (or is below 1), the textarea will expand
as much as needed without overflow
- removed hardcoded height and variables from css, substituted them with
usage of these attributes for consistency
- No fields have any max-lines at this point, so all fields will expand as
needed
 2024-02-02 03:53:23 -05:00
Abe Jellinek
c10dabcbba Ignore editable-text blurs caused by window becoming inactive 
Fixes #3588
 2024-02-02 03:39:55 -05:00
Abe Jellinek
6b1940cebb Add generic menu for all unfocused editable-texts 2024-02-02 03:39:55 -05:00
Abe Jellinek
af79e9c405 Ignore base-mapped fields more robustly 2024-02-02 03:39:55 -05:00
Abe Jellinek
b8c1b7c139 Fix DOI View Online/Copy as URL regression 
Was opening/copying the bare DOI, not the URL.
 2024-02-02 03:39:55 -05:00
Abe Jellinek
fa6e6f9458 Make existing edit context menus more context-aware 
- Don't show the default text editing context menu when right-clicking
  an unfocused editable-text
- In item box/header context menus, only show Copy and Paste (plus
  field-specific transform options) when unfocused

Fixes #3619
 2024-02-02 03:39:35 -05:00
abaevbog
9823b1199a
no extra arrows from scrollable components on win (#3634) 
Somehow `scrollbar-width: thin` removes unnecessary arrows from
editable-text textarea and itemPane on windows

Addresses: #3633
 2024-02-02 03:05:59 -05:00
Tom Najdek
41ccbc90a0
Fix missing variable value in import wizard localization. Fix #3471 2024-02-01 15:41:23 +01:00
Tom Najdek
6efbf4c2ec
Fix tab content misaligned in RTL mode. Fix #3658 2024-02-01 15:41:23 +01:00
abaevbog
8bcf1d446a
url/doi/options icon does not occupy space unless hovered (#3631) 
url/doi/options do not occupy space unless the row is focused or hovered.
This does not apply to options icons after multiline fields because
it would shrink textarea on hover and shift text in an awkward way.

Fixes: #3612
 2024-02-01 04:27:32 -05:00
Martynas Bagdonas
8a9df4a1b3 Move context pane toggle into reader toolbar 
Related #3648
 2024-02-01 14:49:59 +08:00
Dan Stillman
ebd3d7a988 Fix wrong tab being selected after Reopen Closed Tab 
Fixes #3651
 2024-02-01 00:55:02 -05:00
Tom Najdek
493c3add8a
Fix a memory leak in file renaming preferences pane (#3654) 2024-02-01 00:44:22 -05:00
Dan Stillman
f8108aca45 Move "Rename Collection" and "Edit Saved Search" to Fluent 
Without ellipses

And remove unused "Edit Feed…", which is in zotero.dtd too
 2024-02-01 00:42:14 -05:00
Abe Jellinek
a4c09ed701 Trigger inline editing from Rename Collection... 2024-02-01 00:42:14 -05:00
Abe Jellinek
ab5def98a7 Move item type menu CSS override to SCSS 2024-01-31 14:48:59 -05:00
Abe Jellinek
0e251b4975 Scaffold: Fix tests losing defer: true on update 2024-01-31 14:30:34 -05:00
Abe Jellinek
7944253bed Scaffold: Update HiddenBrowser to use object-oriented API 
Fixes updating tests.
 2024-01-31 14:27:21 -05:00
Abe Jellinek
3f348e3340 Use actual placeholder attribute for editable-texts 
As far as I can tell, the Abstract field was the only editable-text
using a placeholder set by Fluent.

https://github.com/zotero/zotero/pull/3632#issuecomment-1919619813
 2024-01-31 13:06:57 -05:00
Abe Jellinek
a4c75df182 Don't allow pinning Item Notes and All Notes 
Fixes #3626
 2024-01-31 12:52:56 -05:00
Abe Jellinek
a23b5310e6 Fix nonfunctional Advanced Search menu item in dialogs 2024-01-30 11:43:56 -05:00
windingwind
1375de4ba2
Fix quick format background (#3638) 2024-01-30 01:58:50 -05:00
Martynas Bagdonas
a12c032ab9 Fix not updating reader "Add to Note" button regression 2024-01-30 09:30:28 +08:00
Martynas Bagdonas
9edfcba9a9 Hide item notes list section in context pane for parentless attachments 2024-01-29 16:06:52 +08:00
abaevbog
e68b9b80ad
opened tabs menu visibility improvements (#3620) 
- Added tooltip to display the entire title of the tab on hover
- Ellipsize the text of the tab title to display as much of the last
word as possible

Fixes: #3609
 2024-01-29 02:40:09 -05:00
Tom Najdek
41294e0ff7
Fix a bug where first column is clipped if it has fixed or static width (#3605) 
Also:

* Fix issues with notes and attachment columns
* Tweak first-column attachment column alignment
 2024-01-29 02:37:46 -05:00
Dan Stillman
418ec5cfc0 Move "Print" to zotero.ftl 
Follow-up to d606644a78
 2024-01-29 02:31:55 -05:00
Martynas Bagdonas
630eccf72f Fix context pane note back button regression 
Fixes #3616
 2024-01-29 15:18:37 +08:00
Martynas Bagdonas
3a3a81b0ed Add missing "Use Dark Mode for Content" to reader window menu 
Fixes #3592
 2024-01-29 15:18:37 +08:00
Martynas Bagdonas
d606644a78 Localize "Print" and "Save As" in reader tab/window File menu 2024-01-29 15:18:37 +08:00
Martynas Bagdonas
5eb0ed109b Fix broken Fluent localization in reader window menu 2024-01-29 15:18:37 +08:00
Dan Stillman
0045cd1b7a Fix search bar in classic citation dialog and Related Items dialog 
Fixes #3599
 2024-01-29 02:13:05 -05:00
Adomas Venčkauskas
452ee3a55b Fix citation dialog open documents not working when a standalone pdf is open 
Closes #3621
 2024-01-29 09:11:12 +02:00
Dan Stillman
8275970df9 Use newer red in Z SVG 2024-01-28 01:58:33 -05:00
Abe Jellinek
7f993167b4 Fix regression that broke Date field tooltip 
Field inputs are XUL in Z6, HTML in pre-redesign Z7, and XUL again in
post-redesign Z7. We switched to the title attribute for HTML but didn't
switch back to tooltipText when going back to XUL.
 2024-01-26 13:40:16 -05:00
Abe Jellinek
00ca99ae86 Item box: Fix Short Title rendering as multiline 
Also, rerender editable-text when noWrap changes.
 2024-01-26 13:38:29 -05:00
Dan Stillman
1cc5c1ce2e Disable automatic safe mode for now 
Until we can figure out why some shutdowns are counting as crashes

https://github.com/zotero/zotero/issues/3196
 2024-01-26 07:35:09 -05:00
windingwind
c21c5632c2
Fix attachment row annotation button bug (#3577) 2024-01-26 00:51:27 -05:00
Dan Stillman
9151fb3558 Force white background in quick-format dialog for now 
To avoid unpleasantness in dark mode
 2024-01-25 00:20:50 -05:00
Dan Stillman
f7fe38b94b Prevent overriding of quick-format selection background color for now 2024-01-25 00:08:35 -05:00
windingwind
63c532398b Fix sidenav default buttons display bug 2024-01-24 23:32:24 -05:00
windingwind
665f812bd1 Fix sidenav button visibilities update bugs 2024-01-24 23:32:24 -05:00
windingwind
7fe01d6c03 Clicking filename label should focus/blur field in attachment box 2024-01-24 23:32:24 -05:00
abaevbog
f990cb3f4b tabs menu updates 
- CMD-F will focus the input field
- ArrowLeft/Right keypresses are ignored
- Reset focus index on the focus of the input field
 2024-01-24 23:32:24 -05:00
Dan Stillman
69054bea4a Merge new English strings 2024-01-24 23:32:24 -05:00
abaevbog
1a82ae5c3b collection filter sizing tweaks 
- ensure filter field is hidden if the pane is collapsed
- JS-based max-width setting to prevent overflow outside of collection pane
 2024-01-24 23:32:24 -05:00
Abe Jellinek
608b732fbb Open tabs menu: Move margin/padding to SCSS 2024-01-24 23:32:24 -05:00
Abe Jellinek
873c87956c Open tabs menu: Escape regex special characters 
So we don't throw an error/match inappropriately when the filter
contains backslashes, periods, pluses, and so on.
 2024-01-24 23:32:24 -05:00
Abe Jellinek
a1134255ee Always rerender sidenav, even if item doesn't change 
Feeds issue remains.
 2024-01-24 23:32:23 -05:00
Abe Jellinek
2b50536775 Tweak method name 2024-01-24 23:32:23 -05:00
Dan Stillman
c2cc5e1935 Separate lines for extension-change confirmation into two strings 2024-01-24 23:32:23 -05:00
windingwind
4f73ea0cfa Fix attachment box rename 2024-01-24 23:32:23 -05:00
Abe Jellinek
3472d6cabe Prevent window overflow in Standard mode 2024-01-24 23:32:23 -05:00
Dan Stillman
613a907f3e Change pref from reader.useDarkModeForContent to reader.contentDarkMode 2024-01-24 23:32:23 -05:00
abaevbog
620b35ab78 minor focus tweaks 
- after an item is added via "Add item by identifier" panel, end
focus to that item in itemTree.
- restored default behavior when the focus remains visible around an
element when all menupopups open, except for the item type menu in itemBox.
- opening item type menu will still hide the focus-ring
 2024-01-24 23:32:23 -05:00
abaevbog
ed8e3f142b itempane keyboard navigation 
- right/left arrows on section header expand/collapse the sections
- space/enter on section header toggle section collapsed/expanded
- tab from the header goes through the header's buttons and then
tabs into the section if that's opened
- arrow up/down on the header jumps to the previous/next header
- space/enter on clickable elements simulate a click
- if there is a pinned section, tab from the title will focus its header
 2024-01-24 23:32:23 -05:00
windingwind
3bdcf34a89 Fix stacked mode layout when toggle item pane 2024-01-24 23:32:23 -05:00
windingwind
7f58873e0b Fix item pane size when switching to note in stacked mode 2024-01-24 23:32:23 -05:00
Dan Stillman
1d8baa635a New app icons 2024-01-24 23:32:22 -05:00
Tom Najdek
ccfc3127ba Tweak padding in the tag selector list 2024-01-24 23:32:22 -05:00
Dan Stillman
61cca0fc69 Use Fluent instead of DTD for "Use Dark Mode for Content" string 2024-01-24 23:32:22 -05:00
abaevbog
11fc1ebd8e remove "Go to this item online" tooltip from url field in itembox 
Also:

- set the .tooltiptext for options button in fluent file, so that text
shows up on hover
- added tooltiptext to creator + and - buttons
 2024-01-24 23:32:22 -05:00
Abe Jellinek
b8f2aaafa9 Attachment preview: Fix cut-off snapshots 
Also:
- Prevent selecting any text within the snapshot
 2024-01-24 23:32:22 -05:00
Abe Jellinek
832a6f3eff Fix right-click -> Merge Items... 2024-01-24 23:32:22 -05:00
windingwind
0cd7a52dc0 Fix attachment preview retry and error catch 2024-01-24 23:32:21 -05:00
windingwind
1c343ee820 Fix viewItem unnecessary scroll 2024-01-24 23:32:21 -05:00
windingwind
86947d7154 Remove attachment-preview-box 2024-01-24 23:32:21 -05:00
Abe Jellinek
3ac8f803c9 Fix duplicate creator context menus, extract utility function 2024-01-24 23:32:21 -05:00
Abe Jellinek
f468245caf Attachments box: Don't set this._item to non-regular item 
Fixes occasional errors due to `getAttachments()` being called on a
non-regular item in `updateCount()`.
 2024-01-24 23:32:21 -05:00
Martynas Bagdonas
c208325aeb Add menu option to toggle dark mode for reader content 2024-01-24 23:32:21 -05:00
Abe Jellinek
c549a96834 Restore notes-box add button 2024-01-24 23:32:21 -05:00
Tom Najdek
03be35426c Couple of small fixes to the tag selector 
* Add bottom padding
* Increase padding for macOS 0-width scrollbars
 2024-01-24 23:32:21 -05:00
Tom Najdek
71d6e219bd Switch to .svg spinner icon for the PDF metadata retrieval 2024-01-24 23:32:21 -05:00
Dan Stillman
29bfbbf4f1 Merge new English strings 2024-01-24 23:32:20 -05:00
Dan Stillman
f084b8c8ad Move density options to separate submenu in View 2024-01-24 23:32:20 -05:00
abaevbog
4a096665a0 refresh collectionTree rowMap after row is added 
It prevents the trash row from getting wrong offset and overlapping
with the row above it
 2024-01-24 23:32:20 -05:00
Abe Jellinek
be3d7c95f9 Match Reset Sync with "Sync Reset Options" 
Only adding warning2 because that's really the only relevant, searchable part of the warning.
 2024-01-24 23:32:20 -05:00
Abe Jellinek
05747f050a Fix undefined errors in feed settings window 2024-01-24 23:32:19 -05:00
windingwind
982289b484 Fix dialog background 2024-01-24 23:32:19 -05:00
Tom Najdek
2f9a12c2da Improve "Run JavaScript" dialog 2024-01-24 23:32:19 -05:00