Commit graph

10994 commits

Author SHA1 Message Date
Dan Stillman
1ae4d12a39 Tweak error text when registering custom item-pane sections 2024-03-30 04:44:32 -04:00
Dan Stillman
56e02b3cad headheader in ItemPaneManager.registerSection() 2024-03-30 04:44:20 -04:00
Abe Jellinek
4e912b84c0 fx-compat: Copy over fx115 Window menu changes (#3899) 2024-03-30 01:02:09 -04:00
Abe Jellinek
1b646fb6e2 fx-compat: Fix up Scaffold a bit
- Output pane no longer gets huge after load
- URL box grows
- Metadata grid fills available space (but still needs work re overflow)
- row-resize cursor on Tests splitter
2024-03-30 01:02:09 -04:00
Abe Jellinek
0f61646e26 fx-compat: Preferences: Fix content not growing with window 2024-03-30 01:02:09 -04:00
windingwind
4407c24329 Support tooltiptext on ItemPane custom section head buttons
Fix ItemPane custom section head button event listener
Update ItemPaneManager document
2024-03-30 01:02:08 -04:00
Dan Stillman
849ffe0133 Don't try to register command line handler if already registered
Avoids an error when reiniting during tests
2024-03-30 01:02:08 -04:00
abaevbog
89320a7ee4 fx115: fix tags autocomplete breakage (#3882)
With fx115, changes from 49fe2b98d9
made the autocomplete popup appear blank when the reader tab is opened.
Not re-creating the PopupAutoComplete in tagsBox makes the items from
autocomplete popup visible again. But it makes the autocomplete appear
below the "Add tags" popup for annotations (what 49fe2b98d9
originally fixed), and it also creates a duplicate <popupset>
with a new autocomplete panel at the bottom of the DOM every time autocomplete runs.
The duplicate <panel>s do not have an id.

Manually adding a <popupset> with a <panel> whose id="PopupAutoComplete"
does not create any duplicates and properly positions the popup.

Fixes: #3881
2024-03-30 01:02:08 -04:00
windingwind
98ed686212 fx115: fix the itemBox rows stretching on menu open (#3898) 2024-03-30 01:02:08 -04:00
abaevbog
2f4a232c41 fx115: fix tooltips for tabs, tabs menu and virtualized table (#3877)
Fix and improve tooltip logic

- fx115: move main html-tooltip outside of the deck, otherwise it only
shows up in the library tab.
- Zotero_Tooltip is not required in the tabs bar and the button of the
tag selector. Setting the tooltip attribute on the closest XUL parent
and adding title attribute makes the tooltip properly appear.
- Remove manual handling of the hover effect from tabs manu. The
hover effect doesn't stick around after drag-drop with fx115 anymore,
so it's not required. And then the usual title attribute works for the
tooltip.
- Set title instead of tooltiptext attribute in tagSelectorList
so that the tooltip appears

After zotero@8e2790e,
the pointer effects don't fire on the actual cells of the table
(only on the parent row), so the tooltips do not appear for the cells.
This is a (hopefully) temporary solution to handle mousemove events over the row
of the table, find the right cell that the mouse is over, and
use Zotero_Tooltip to manually display the tooltip.

Tweaked Zotero_Tooltip to create the fake tooltip and place it into
the DOM. Zotero_Tooltip is also imported by virtualized-table as a module
because one shouldn't have to load it in .xhtml file for every new window
where the virtualized-table is used.
2024-03-30 01:02:08 -04:00
Adomas Venčkauskas
dca7dcccab fx115: Changes for word processor plugin support 2024-03-30 00:58:58 -04:00
Adomas Venčkauskas
7276b8c50d fx115: Readd support for -file, -url and winword command line handlers 2024-03-30 00:58:58 -04:00
windingwind
e51739e1d4 fx115: fix layout on Windows 2024-03-30 00:58:58 -04:00
windingwind
a110e86cff fx115: fix main window element layout 2024-03-30 00:58:58 -04:00
windingwind
bda096a26f fx115: fix attachment box label overflow 2024-03-30 00:58:57 -04:00
windingwind
42724d13f7 fx115: fix context pane notes list layout 2024-03-30 00:58:57 -04:00
windingwind
64489b243f fx115: fix context pane sidenav render 2024-03-30 00:58:57 -04:00
windingwind
41acf4c737 Implement ItemPane custom section API
Unify properties as getter in ContextPane
Replace section `mode` with `editable`
Remove section `inTrash`
2024-03-30 00:58:57 -04:00
windingwind
b34859d882 CEify contextPane 2024-03-30 00:58:57 -04:00
windingwind
b2ad17d604 CEify itemPane 2024-03-30 00:58:57 -04:00
Dan Stillman
827bcd704d fx115: Fix "Check for Updates" window
Also:

- Tweak text to be less alarming (fixes #3074)
- Don't show "No updates found" if update was already downloaded
  (fixes #3148)

Download progress still isn't shown (#3130) but I'll fix that later
2024-03-30 00:58:57 -04:00
Dan Stillman
b42e412c4f Spaces to tabs in updates.js 2024-03-30 00:58:57 -04:00
Dan Stillman
cd3fda98d1 Fix broken tests due to protocol handler and autocomplete re-registration
For the protocol handler, unregister on reinit(). For autocomplete, just
skip registration if already registered.
2024-03-30 00:58:57 -04:00
abaevbog
349ae52b9c fx115: working autocomplete (#3789)
- autocomplete registration removed from chrome.manifest
- static registration happening in zotero.js
- tweaks to autocomplete methods to implement nsIAutoCompleteSearch based on
https://searchfox.org/mozilla-central/source/toolkit/components/autocomplete/tests/unit/test_378079.js#154
2024-03-30 00:58:57 -04:00
Abe Jellinek
8cb0c58b60 Restore old flags
Fixes reports!
2024-03-30 00:58:56 -04:00
Abe Jellinek
506482551d Register protocol handler dynamically
Fixes reader but not reports yet.
2024-03-30 00:58:56 -04:00
Bogdan Abaev
1b12b66e48 fx115: classic citation dialog fixes
- have panes for item selection occupy all available space
- use Zotero ES module to fix simple editor

search in classic citation dialog seems broken
2024-03-30 00:58:56 -04:00
Bogdan Abaev
2d3bc12ca0 fx115: lookup panel fixes
- do not resize based on scrollable content - it shrinks the panel
- add padding into the stylesheet
- remove onShowing, since it doesn't seem needed anymore
2024-03-30 00:58:56 -04:00
Bogdan Abaev
5f37ae4ab1 fx115: fix tabs menu
Fixed visuals and working drag-drop again.

Fx115 made previously used toolbarbuttons act very strange wih drag-drop:
instead of dragging the actual button, the #text node would receive
dragstart event and a single letter would end up being dragged.
During troubleshooting, elements created via document.createXULElement
had this issues while being dragged (or acted oddly in other ways, e.g.
refusing to be dragged at all).

This includes a minor rewrite to use div-s instead of XUL components.
2024-03-30 00:58:56 -04:00
Bogdan Abaev
87297f8d29 fx115 fixes
A number of style changes to fix layout for fx115.

- Make panes occupy all width/height based on layout.
- Display the tag splitter on windows and mac.
- Fix to odd fx115 behavior that gives an un-collapsed pane the
initial width of min-width * 2.
- Ensure that whenever there is a width attribute on contextPane, it will
be present in the style as well.
- Set width = 0 on zotero pane when it is not selected because it kept
preventing the contextPane from properly expanding.
- Context pane has its height changed on splitter drag.
- Set height of the context pane in stacked mode to 0 to avoid
having a blank gap after collapse.
- Remove negative margin before the toolbar if the collection tree
is collapsed on mac.
- Tweaks splitter styles to have mouse target of more than 1px.
Added positive z-index to make sure splitters are not covered by panes.
Splitter styles are somewhat unified for all platforms.
- Fix lookup panel sizing
- Quicksearch margin edits to not squize the input field.
- Collection and quick search fields layout fixed
- Use flex properties to fix layout
- fix outline display for editable-text
- fix the contextpane width going out of bounds
- stacked itemPane is visible after layout change
- In stacked view, prevent itemPane from being dragged so high that
it covers itemTree and overlaps with toolbar
2024-03-30 00:58:56 -04:00
Dan Stillman
dd745ed1aa fx115: PathUtils.normalize() requires files to exist
Unlike OS.Path.normalize()
2024-03-30 00:58:55 -04:00
windingwind
28f4857592 Fix windows menu style 2024-03-30 00:58:55 -04:00
windingwind
c8d49e76e5 Fix title bar layout 2024-03-30 00:58:55 -04:00
Abe Jellinek
6854ad814b fx115: Preferences: Make style manager scroll again 2024-03-30 00:58:55 -04:00
Abe Jellinek
5ca626c143 Don't resize window when Sync preferences are loaded 2024-03-30 00:58:55 -04:00
Abe Jellinek
0c5479f033 Replace TEMP_ strings in hiddenWindow.xhtml
Restores correct menuitem labels and shortcuts.
2024-03-30 00:58:55 -04:00
Dan Stillman
32793b80ae fx115: Temporarily disable missing entities for localized keys 2024-03-30 00:58:54 -04:00
Dan Stillman
f38506bccb fx115: Remove dialogOverlay.dtd include 2024-03-30 00:58:54 -04:00
Dan Stillman
65a7bf7fc0 Fix doctype declaration in updates.xhtml 2024-03-30 00:58:54 -04:00
Dan Stillman
92dfca2dc9 fx115: Temporarily disable integration loading 2024-03-30 00:58:54 -04:00
Dan Stillman
b6a597a7f9 fx115: nsIPromptService → Services.prompt 2024-03-30 00:58:54 -04:00
Dan Stillman
ef75f59037 fx115: Remove support for OS.File instance from md5Async() 2024-03-30 00:58:54 -04:00
Dan Stillman
95caebde2b Remove some old connector code 2024-03-30 00:58:54 -04:00
Dan Stillman
920461cd9d fx115: Update lots of OS.File/OS.Path uses 2024-03-30 00:58:54 -04:00
Dan Stillman
5a8a7ebccc fx115: Bundle PluralForm.jsm from older Firefox 2024-03-30 00:58:54 -04:00
Dan Stillman
d026d9684f fx115: Comment out -moz-tree-image CSS rules
We used them for pie spinners for attachment downloads in the items
list, but I guess we lost that with the new tree, and now they just log
warnings because the property was removed. We should reimplement with
SVG.
2024-03-30 00:58:53 -04:00
Dan Stillman
f472ee6a4c fx115: Remove global.dtd includes and chromedir attribute
It only had `locale.dir`, which it looks like we can handle in different
ways now:

- CSS rules with `:-moz-locale-dir(ltr)`
- `let isLTR = document.documentElement.matches(":-moz-locale-dir(ltr)");`
2024-03-30 00:58:53 -04:00
Dan Stillman
13ab3bd87f fx115: Add command-line handling to Firefox command-line handler
XPCOM objects have to be statically registered now, so instead of
creating our own command-line handler, just stuff our code into the
Firefox one.

A few parameters require the Zotero object, which isn't available in the
Firefox CLH, so I've left those in zotero-service.js for now until we
decide how to deal with those.
2024-03-30 00:58:53 -04:00
Dan Stillman
e76c6c6a1a fx115: Update loadURI() calls to take nsIURI and remove loadURIWithFlags
https://bugzilla.mozilla.org/show_bug.cgi?id=1810141
https://bugzilla.mozilla.org/show_bug.cgi?id=1444760
2024-03-30 00:58:53 -04:00
Dan Stillman
c36f40735c fx115: Change FilePicker to Mozilla ESM style
var { FilePicker } = ChromeUtils.importESModule('chrome://zotero/content/modules/filePicker.mjs');
2024-03-30 00:58:53 -04:00