Commit graph

3947 commits

Author SHA1 Message Date
aurimasv
1390b1300a [RDF] QNAME fixes
* Allow periods in QNAMEs
* Don't break when there are illegal characters in the predicate. Use the strategy proposed at http://www.w3.org/TR/2014/REC-rdf-syntax-grammar-20140225/#section-Serialising (generate namespace that consumes all illegal characters)
* More robust namespace name generation

Closes #128
2014-03-06 07:00:44 -06:00
Dan Stillman
5ddfdec584 Fix first item drag of session
https://forums.zotero.org/discussion/35206/
2014-03-02 05:22:58 -05:00
Simon Kornblith
015b37a85e Merge pull request #453 from aurimasv/rdflib-rdf-value
Correctly handle literals with attributes in RDF
2014-02-24 11:03:53 -05:00
Dan Stillman
7a83a5762a Fix error recovering from DB corruption maker if main DB doesn't exist
Also add better logging
2014-02-22 03:53:27 -05:00
Dan Stillman
62e779beec Show redirect URL in the sync stream listener (for file downloads)
Also consolidate the display-URL-password-hiding logic in http.js
2014-02-21 19:07:08 -05:00
Dan Stillman
79cd7197ff Fix a rare cause of sync conflicts
Sometime in the past SQL datetimes saved to the server could be
interpreted as multipart dates, causing the date portion to be stripped
from the visible field. I fixed this previously on the server, but a
full sync could result in conflicts for any such values that synced
down. Instead, overwrite the local version (keeping Date Modified the
same) if there are no other changes.
2014-02-21 19:02:02 -05:00
Dan Stillman
1d4a6b0848 Fix [Attachment Content] [does not contain] searches in "all" mode 2014-02-19 00:52:27 -05:00
Dan Stillman
62bc5830eb Fix some harmless errors in the console editing autocomplete fields
"comment.split is not a function"
2014-02-18 18:43:58 -05:00
Dan Stillman
04fa4a0943 Fix Zotero crash pasting in creator with certain leading whitespace 2014-02-18 18:42:06 -05:00
aurimasv
01631d6c9d Fix some bugs with charset encoding on import 2014-02-17 20:37:11 -06:00
Dan Stillman
5d54dd9fbf Tweaks to csledit
- Show "Citation Style Language" in Format drop-down
- Reverse positions of Refresh and Save

Follow up to #454
2014-02-14 04:13:18 -05:00
Dan Stillman
6444477580 Fix csledit breakage from 39dd3d81
Follow-up from #454
2014-02-14 04:00:41 -05:00
adam3smith
39dd3d8114 add "Save" button and "Near Note" position to CSL Preview 2014-02-14 00:59:44 -07:00
Simon Kornblith
41c19992fe Fix strict mode error from https://forums.zotero.org/discussion/34871/ 2014-02-12 01:02:54 -05:00
Aurimas Vinckevicius
89782e78bf Zotero.Translate.IO._RDFSandbox.getResourceURI should return the contents of rdf:value where available 2014-02-08 20:31:09 -06:00
Aurimas Vinckevicius
83e261930e [rdflib.js] Literals with attributes should be added as rdf:value nodes 2014-02-08 20:29:41 -06:00
Dan Stillman
a6ab904cd0 Note link tweaks
- Send modifier keys through to loadURI() when clicking Open Link in notes
- Open link in parent window from external note window
- Don't show both menus on right-click

Follow-up from #450
2014-02-04 21:02:05 -05:00
Joscha Legewie
2f9c7fd839 TinyMCE Improvements: Open links from note window with popup and auto-create links 2014-02-04 20:58:51 -05:00
Dan Stillman
d966166abc Fix indexing error with empty documents 2014-02-01 16:37:05 -05:00
Dan Stillman
fadd486dc1 API change: item.attachmentCharset now returns charset name, not ID
Since apparently half of our own code didn't know that it returned an
ID...

The item.attachmentCharset setter can still take either name or ID.
2014-02-01 03:16:21 -05:00
Dan Stillman
07b8d56401 Fix (caught) error accessing this.decoder due to private method call
Follow-up to #440
2014-02-01 03:16:05 -05:00
Dan Stillman
7a9966bbe3 Fix indexing error adding items with repeated words
Probably words that didn't make it into the same in-memory insertion
batch, since the UNION would make those distinct.

Follow up to #440
2014-02-01 03:12:02 -05:00
Dan Stillman
d7ce74f1c5 Update version and maxVersion 2014-01-31 18:23:15 -05:00
Dan Stillman
2cd0d5988f Update submodules and repotime 2014-01-31 18:12:54 -05:00
Dan Stillman
f9f61fca86 More full-text indexing tweaks
Follow up from #440

- Convert curly single quotes to straight quotes before inserting
- Add General and Supplemental Unicode punctuation ranges to getClass()
  (so that fancy punctuation doesn't end up in words)
- Move single-quote test from getClass() to semanticSplitter(), and
  consider it a letter only if in the middle of a word
- Add comments to semanticSplitter()

This might be ever-so-slightly slower, but it's neglible. (War and Peace
seems to now take ~1570ms instead of ~1500ms for me.)
2014-01-31 17:43:29 -05:00
Dan Stillman
7036d07acc Remove unused _separateElements() 2014-01-31 17:43:29 -05:00
friflaj
c22ddd2ce6 Faster indexed word insert, faster word splitter
Uses SQL insert ... select to speed up the inserts, and ports the Firefox word splitter to JS
to prevent xpcom call overhead
2014-01-31 17:43:29 -05:00
Simon Kornblith
71a3751179 Merge pull request #433 from aurimasv/retrieve-meta
Retrieve Metadata query limit fixes
2014-01-31 00:16:09 -08:00
aurimasv
3c21e7c999 [Retrieve Metadata] Add/fix comments 2014-01-31 02:10:20 -06:00
Aurimas Vinckevicius
859e99f020 [Retrieve Metadata] Focus item in Zotero pane when double-clicking
* Fixes #446
2014-01-31 02:09:35 -06:00
aurimasv
57350fae1e [Retrieve Metadata] Use a single queue to query Google Scholar. Window closing tweaks.
* Close window on blur after completion on Mac (revert previous change)
* Don't close window when canceling
* Add Esc handler to cancel/close window
* Allow columns to be resized
* Fixes #445
* Fixes #444
2014-01-31 02:09:35 -06:00
aurimasv
4bedb61aa2 [Retrieve Metadata] Look for JSTOR stable URLs and convert to DOIs
Thanks to myqlarson for the suggestion. See https://forums.zotero.org/discussion/29354/1/query-limit-reached/#Item_42
2014-01-31 02:00:28 -06:00
aurimasv
b3da19e96d [Retrieve Metadata] Recognize HTTP 503 code as Google Scholar CAPTCHA + other tweaks.
* Stop metadata retrieval when cancelled
* Display CAPTCHA dialog
* Don't close window on blur
* Use Zotero.Utilities.cleanISBN to validate ISBNs
2014-01-31 02:00:28 -06:00
Dan Stillman
121b75ef6c Remove synced settings from deleted libraries in integrity check 2014-01-24 19:06:33 -05:00
Dan Stillman
1f3cd9a1ae Don't wipe out fields from fieldsCombined during DB integrity check 2014-01-24 19:05:59 -05:00
Dan Stillman
c1c2f6b9de Merge pull request #402 from adam3smith/transform-sentence
Change Transform text so that sentence case capitalizes after :, ?, ! Th...
2014-01-14 11:22:21 -08:00
adam3smith
953c94c7fe Change Transform text so that sentence case capitalizes after :, ?, ! This is in line with English usage and this function is principally useful for English titles.
also deal with punctuation at the beginning of title

Also fix capitalizeTitle to work with quotation marks and Spanish beginning punctuation. Also adds ? and ! as punctuation after which it always capitalizes

switch sentence case conversion to a regex; I'm leaving capitalizeTitle as the substring routine, it's the same length and probably slightly more efficient.
2014-01-14 08:18:06 -07:00
aurimasv
a334e1f462 Use documentURI/URL instead of location.href.
document.location is null after the document is detached from its parent window (e.g. after we navigate to a different page in the same hidden browser)
2014-01-07 22:02:15 -06:00
adam3smith
49ecb8ecac slightly adjust regex 2014-01-05 10:53:30 -07:00
adam3smith
875567dbc9 fix PMCID parsing 2014-01-04 08:00:32 -07:00
Dan Stillman
d50765536c Update version 2013-12-17 23:39:47 -05:00
Dan Stillman
c9dbd34e01 Fix issue with old-style persisted 'collapsed' attribute on tag selector
If localstore.rdf has the tag selector persisted closed from before
zotero-persist, the 'state' attribute on the splitter that we now use
won't cause the tag selector to open.
2013-12-17 19:15:22 -05:00
Simon Kornblith
b5760d7f45 Don't try to detect a proxy on documents with no docShell/webNav
This would previously have thrown an error. I'm not sure what these
documents would be, but it's a safe bet that they're not loaded in a
normal browser window.
2013-12-16 22:00:17 -05:00
Simon Kornblith
b841ccf7b3 Fix typo 2013-12-16 21:51:35 -05:00
Simon Kornblith
b7f6f97ced Fix broken startup on Windows Aurora/Nightly
We were telling ourselves to release the DB lock because of the
discrepancy between Zotero.appName and the message window name
2013-12-16 20:32:50 -05:00
Simon Kornblith
83bc0628db Fix Zotero.Integration.activate() with no args in Mac Aurora/Nightly
This is only used when there is a window open in the background anyway
2013-12-16 20:27:52 -05:00
Dan Stillman
d182665173 Allow left pane collapsed state to persist
Also fix weirdness trying to open collapsed tag selector after restart.
(The splitter's 'state' attribute has to be persisted, not the
'collapsed' state of the pane in question.)
2013-12-16 19:17:25 -05:00
Simon Kornblith
d8ce6ce6f3 Fix an old typo 2013-12-16 10:29:58 -05:00
Simon Kornblith
6fa04103c2 Fix a bug where the Zotero pane would not close when opening Standalone
If Zotero Standalone was opened before Firefox, closed, and opened
again, the user would see a message stating Zotero Standalone was open,
but the pane would not have closed. This was purely cosmetic.
2013-12-14 02:07:36 -05:00
Simon Kornblith
8502b68730 Broadcast persistent descriptor is for database, not data directory 2013-12-13 18:36:21 -05:00
Dan Stillman
b82728aeea Update submodules, versions, and repotime 2013-12-13 18:23:04 -05:00
Simon Kornblith
0aa50eaff5 Update citeproc-js to 1.0.517 2013-12-13 17:29:57 -05:00
Simon Kornblith
d84bffb1c2 Fixes that should hopefully protect against database corruption
- When opening the DB, always tell other Zotero instances to close it,
  regardless of whether they are holding the lock.
- Don't let database re-open after it has been closed. This also fixes
  some issues with connector switching.
2013-12-13 17:25:50 -05:00
Dan Stillman
ea50098d30 Debugging for not saving into collection 2013-12-10 22:21:34 -05:00
Dan Stillman
683af21691 Fix file sync errors with passwords containing % + two hex digits
Usernames and passwords going into nsIURI have to be percent-encoded.
2013-12-04 02:17:11 -05:00
Dan Stillman
5f1e582b05 Include timings in -zoterodebug output 2013-11-30 03:16:56 -05:00
Dan Stillman
6ff0ea6d18 Add -zoterodebug command-line flag to force debug output
This should make it much easier to debug startup errors, particularly in
Standalone.

This also adds a general mechanism to set Zotero initialization options via
command-line flags.
2013-11-30 01:55:48 -05:00
Aurimas Vinckevicius
04335ef418 Properly revert attachment renames if they fail. Closes #430 2013-11-23 23:36:49 -06:00
Aurimas Vinckevicius
59ef7cba04 When renaming attachment files, keep file extension if not provided 2013-11-23 23:36:49 -06:00
Dan Stillman
64fb9efa76 Fix newlines not showing up in Abstract/Extra fields 2013-11-23 03:24:57 -05:00
Dan Stillman
305edd893c Revert relations purge debugging 2013-11-21 20:41:22 -05:00
Dan Stillman
1e0674cf7c Fix some bugs adding items to various views
- Refresh Unfiled Items view when items are added
- Fix brief freeze ("too much recursion") adding an item to a search
  where the new item doesn't appear. Now, select the library root
  instead if a manually added item doesn't appear in the current view.
- Fix immediate closing of title field when adding an item to a
  collection rather than the library root
2013-11-21 19:52:13 -05:00
Dan Stillman
5d85bffc9c Add back pane close icon with Australis 2013-11-21 02:15:39 -05:00
Dan Stillman
860ebdb3fd Make Esc (or clicking X on Windows) cancel Rebuild/Clear Index
Previously the secondary actions were being triggered, with no way to
fix that due to https://bugzilla.mozilla.org/show_bug.cgi?id=345067
2013-11-19 15:53:19 -05:00
Dan Stillman
a75192d744 Add ellipses to Rebuild/Clear Index buttons in prefs
And add punctuation.ellipsis localized string
2013-11-19 15:52:30 -05:00
Simon Kornblith
481e00bfc8 Update citeproc-js 2013-11-19 02:13:54 -05:00
Dan Stillman
322755e745 Update repotime, submodules, and versions 2013-11-19 01:39:52 -05:00
Dan Stillman
7014b875c7 Protect all contractions in full-text content, not just first
nsISemanticUnitScanner doesn't seem to be able to deal with single
quotes, so protect those. (There might be other characters it doesn't
handle, but this is ancient code, so it stays as is for now.)
2013-11-19 01:37:55 -05:00
Dan Stillman
e2e6dc71e2 Don't try to index files longer than 250K chars in the background
This should fix the intermittent freezes people were seeing. We'll
process these large files when we replace nsISemanticUnitScanner.
2013-11-19 01:35:14 -05:00
Dan Stillman
5744161a52 Add osfile.jsm import, and remove debugging lines 2013-11-18 19:56:08 -05:00
Dan Stillman
98b7ab78d5 Additional debugging for putContentsAsync freeze 2013-11-17 23:34:19 -05:00
Dan Stillman
f2034eec29 Use OS.File.writeAtomic() for Zotero.File.putContentsAsync() if UTF-8
It might be possible to write non-UTF-8 data by passing another charset
to TextEncoder, but I haven't tried it.

Firefox 19+ only, and for now, at least, only if data is passed as
string rather than input stream
2013-11-17 19:08:09 -05:00
Dan Stillman
deffa464e3 Don't try more than 5 times to fill 500K limit
This will hopefully fix freezes during full-text syncs.
2013-11-17 14:04:26 -05:00
Dan Stillman
cb41a2ecd6 Don't use single DB transaction when rebuilding full-text index
This might slow down the rebuild, but it will hopefully also prevent
excessive memory usage and crashing.
2013-11-16 15:54:31 -05:00
Dan Stillman
fb03c87305 Disable full-text purging, for now
This isn't technically any slower than before, but if people were using
multiple computers, they might not have had their entire full-text index
on a single computer before full-text syncing.
2013-11-16 15:45:23 -05:00
Dan Stillman
4aa3e77aeb Yet more relations purging error debugging 2013-11-14 02:31:30 -05:00
Dan Stillman
a688d9ab00 Debugging for relations purging error that won't get cut off 2013-11-13 16:49:32 -05:00
Dan Stillman
8490871108 Blacklist Firefox charset warning 2013-11-13 12:57:49 -05:00
Dan Stillman
6a0c623698 Debugging and temporary fix for relations purging issue 2013-11-13 12:08:44 -05:00
Dan Stillman
f4abe14b59 Merge branch 'db-update' into 4.0 2013-11-13 00:32:48 -05:00
Dan Stillman
8e52dcca42 Tweak the text a bit in #410 2013-11-13 00:31:45 -05:00
Dan Stillman
0d7e14bb6b Update versions, submodules, and repotime 2013-11-12 00:33:19 -05:00
Dan Stillman
86afad9b35 Fix "columns itemID, tagID are not unique" sync error
I'm not sure what's causing this, but it will quite likely go away in
4.1 regardless.
2013-11-11 23:03:06 -05:00
aurimasv
e21fa7290d Move import.charset preference element to the correct prefpane 2013-11-11 04:37:46 -06:00
Dan Stillman
6d73bd3256 Merge pull request #412 from aurimasv/webdav-sec
Check network errors against SEC error set as well
2013-11-08 00:38:31 -08:00
aurimasv
d9ab469bc8 Check network errors against SEC error set as well 2013-11-08 02:33:20 -06:00
Dan Stillman
f7fe9ab64b Better fix for merging items in unsynced libraries
Addresses a79872436
2013-11-08 03:09:34 -05:00
Dan Stillman
a798724366 Fix error merging items with relations in unsynced library 2013-11-08 03:08:03 -05:00
Dan Stillman
76da3e67fb Tweak the tree row height a bit on Windows 2013-11-08 02:57:09 -05:00
Dan Stillman
5079158772 Remove unnecessary 'return;' 2013-11-08 02:14:52 -05:00
aurimasv
e9f011ab57 Do not show SSL error message for other network errors 2013-11-07 23:48:55 -06:00
aurimasv
8c3cf11df1 Open update wizard in Standalone 2013-11-07 20:56:40 -06:00
aurimasv
8994961c85 Add "Check for Update" button to error alert when DB version is newer 2013-11-07 20:56:40 -06:00
Dan Stillman
331ef4ac34 Apply Fx25 tree-row fix to Windows only, and fix spacing there too
"height: auto" (from another extension's fix for this) actually caused
the bottoms of tree rows to be cut off on Windows (and at least on one
Linux installation with Chinese characters).
2013-11-07 03:23:55 -05:00
Simon Kornblith
77669b5c17 Update to citeproc-js 1.0.502 2013-11-06 12:10:29 -05:00
Dan Stillman
31c36c528c Don't send full-text content in read-only libraries 2013-11-06 11:32:23 -05:00
Dan Stillman
3c16eb2fb3 Update versions 2013-11-06 11:23:03 -05:00
Dan Stillman
92ef3d6c81 Fix error dragging items from My Library to group library 2013-11-06 11:16:58 -05:00
Simon Kornblith
48a852fb32 Bind fulltext shutdown listener to this 2013-11-05 23:22:28 -05:00
Dan Stillman
342e631beb Don't reindex downloaded full-text content if already up to date 2013-11-05 17:20:29 -05:00