mirrors/zotero
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
8610 commits 9 branches 362 tags 278 MiB
Commit graph

5848 commits

Author SHA1 Message Date
Dan Stillman
3830aa1125 Mark trashed items as unsynced and update parents (including note list) 
Regression from 3a0e0cb088
 2017-02-15 14:22:34 -05:00
Dan Stillman
469d689f37 Fix emptying from trash (broken in 7ede52355d) 
Zotero.Items.eraseTx() doesn't exist -- use Zotero.Items.erase() instead
 2017-02-10 14:11:10 -05:00
Dan Stillman
3a0e0cb088 Drastically speed up moving items to the trash 
E.g., moving 3,600 items to the trash now takes 4 seconds instead of 62

Instead of saving each item, update internal state and database directly
(which is more brittle but worth it). Also avoid unnecessary sorting
after removing an item from the items tree.
 2017-02-08 23:42:55 -05:00
Dan Stillman
58edb3143e Update ProgressWindow constructor call after c00db272f 2017-02-08 21:23:36 -05:00
Dan Stillman
ed047f06df Don't select items added via import 2017-02-08 21:19:32 -05:00
Dan Stillman
a4572c9442 Make sure 'collections' passed to Translate is an array 2017-02-08 14:58:03 -05:00
Dan Stillman
27cb099c82 Allow asynchronous item saving in import translators 
This allows for imported items to be saved individually instead of being
saved in a batch after processing the entire imported file (which for
large imports would hang the UI, even if the actual saving was
asynchronous). This also fixes the progress meter during asynchronous
saves.

To take advantage of this, import translators will need to return a
promise when available (using the native Promise object) from doImport()
and wait for optional promises from item.complete().

The logic here can probably be streamlined further. (E.g., we might be
able to say that item.complete() always returns a promise.) It's
complicated by the fact that, at the moment, Promise isn't available in
child sandboxes, though this can probably be fixed.

Tests forthcoming, but they require a translator that supports this,
which needs to be committed separately.

View with -w for a cleaner diff.
 2017-02-08 14:56:44 -05:00
Dan Stillman
3e35764405 Allow altering text in a ProgressWindow line in OO mode 
And fix progress meter display
 2017-02-08 14:32:07 -05:00
Dan Stillman
12ad749087 Fix additional file sync error with no remote stored hash 
Follow-up to c9694e93b0
 2017-02-08 14:12:16 -05:00
Dan Stillman
55e9a0ee35 Update empty state of parent collection when deleting subcollection 2017-02-03 01:18:00 -05:00
Dan Stillman
a57ea28d42 Fix csledit 
Closes #1149

(There's an additional change in #1149, but as far as I can tell it's
not necessary for csledit.xul.)
 2017-02-03 00:53:43 -05:00
Dan Stillman
3a2fb2938d Remove temporary debugging buttons in prefs 2017-02-03 00:07:16 -05:00
Dan Stillman
1a49018bdc Fix moving items between collections 
`mozSourceNode` seems to no longer be set in `dataTransfer` objects
during drags, so we now store it in `Zotero.DragDrop`.
 2017-02-03 00:07:16 -05:00
Dan Stillman
76bc61e882 Don't unload object on save error if not new 2017-02-03 00:07:16 -05:00
Dan Stillman
79a07cad9e Return array copy in ItemFields.getItemTypeFields()/getTypeFieldsFromBase() 2017-02-03 00:07:16 -05:00
Dan Stillman
7ede52355d Require DB transaction in Zotero.Collection.prototype.removeItems() 
For consistency with Zotero.Collection.prototype.addItems()
 2017-02-03 00:07:16 -05:00
Dan Stillman
f98de97e4d Don't select last item in list when item is removed from collection 2017-02-03 00:07:16 -05:00
Adomas Venčkauskas
9ecfc31fd4 Fix translation error reporting in connectors 
Closes zotero/zotero-connectors#101
 2017-02-02 16:16:22 -03:00
Dan Stillman
0b9b758029 Don't localize "OpenURL" 2017-02-02 02:01:06 -05:00
Adomas Venčkauskas
ef0d9afe8e Address debug reporting in connector (zotero/zotero-connectors#97) 2017-01-31 19:46:20 -03:00
Adomas Venčkauskas
21a7a49a1b Fix broken date class (regression 38b0fb2) 2017-01-31 19:02:30 -03:00
Adomas Venčkauskas
38b0fb2650 Zotero.Promise.coroutine not supported in connector shared code (broken ef1ff8b) 2017-01-31 19:00:15 -03:00
Adomas Venčkauskas
c4d39ba79f Update translate error report with promisified info (broken c3dcaf9) 2017-01-31 18:23:19 -03:00
Dan Stillman
26eebcfc44 More report note fixes 
Restore handling of plaintext notes from before 835003dd6d, and search
for a wider set of HTML indicators to avoid showing markup when no <p>
tags.
 2017-01-31 13:56:45 -05:00
Dan Stillman
4871374673 Don't modify options object passed to DataObject.save() 2017-01-31 01:25:51 -05:00
Dan Stillman
835003dd6d Parse note content in reports as HTML instead of XML 
And remove raw-markup fallback when not XML
 2017-01-31 01:25:51 -05:00
Dan Stillman
ae47ae28bd Fix #1163, Unable to open zotero urls from tinymce 2017-01-30 14:01:04 -05:00
Dan Stillman
b073c3e680 Fix mangled output from Zotero.Utilities.getAsyncInputStream() 
Proper fix (as opposed to 5236d01791) for
https://forums.zotero.org/discussion/64022/5-0-beta-generate-report-is-often-garbled
 2017-01-30 13:33:23 -05:00
Dan Stillman
10111dbd98 Ensure modified item stays visible 
There seems to be a bug here where, if the item is off-screen when
modified, it doesn't become visible, but it now does stay visible when
it's on-screen to begin with.
 2017-01-29 09:18:16 -05:00
Dan Stillman
48a81e3b46 Fix 412 after choosing local file on file conflict 2017-01-29 07:50:46 -05:00
Dan Stillman
c00db272fa Add option to Zotero.ProgressWindow to not close on click 
ProgressWindow now takes an options object instead of a window (which is now an
available option, along with 'closeOnClick')
 2017-01-27 21:05:41 -05:00
Dan Stillman
4d56191f0c Fix importing of files using relative paths 2017-01-27 20:51:12 -05:00
Dan Stillman
22d460312c Make ZFS file syncing always enabled for publications library for now 
At least until we have a better interface for setting library-specific
sync settings

Previously, if My Library file syncing was disabled or set to WebDAV, My
Publications files wouldn't be uploaded.
 2017-01-27 14:14:33 -05:00
Dan Stillman
27974791b0 Fix error in recursiveCollections mode with huge number of subcollections 2017-01-27 12:00:28 -05:00
Dan Stillman
31ed9bd70b Fix misplaced line in e23452363b 2017-01-26 18:30:18 -05:00
Dan Stillman
aec9b2a531 Automatically use remote version when two items in trash are in conflict 2017-01-26 18:07:01 -05:00
Dan Stillman
e23452363b Handle auto-hyphenated ISBN during item conflict 
Always keep the hyphenated version, and don't consider it a visible conflict
 2017-01-26 15:08:34 -05:00
Dan Stillman
3a1bec1ab3 Fix "Show in Library" in item context menu 2017-01-26 02:57:14 -05:00
Dan Stillman
3415aae908 Fix error generating reports 
9b247ebba7 follow-up
 2017-01-24 15:42:28 -05:00
Dan Stillman
50b7dd39a0 Don't show incorrect instructions for adding Locate engines 
Not currently possible in 5.0

https://github.com/zotero/zotero-connectors/issues/92
 2017-01-24 03:54:30 -05:00
Dan Stillman
cfa15a3e3c Rename "Full Sync" to "Reset Data Sync History", and don't start sync 
This allows generating debug output for full sync of a single library.

Also clarify some dialog text
 2017-01-24 03:38:21 -05:00
Dan Stillman
c3ba7340c6 Update submodules 2017-01-24 02:51:18 -05:00
Dan Stillman
edb08e179c Fix item key search (broken by a01f2765e4) 2017-01-23 08:46:42 -05:00
Dan Stillman
a01f2765e4 Fix quick search and quick format bar (broken in 9b247ebba7) 
As evidenced by majorly failing tests
 2017-01-23 08:40:18 -05:00
Dan Stillman
249f9c6495 Temporary prefs buttons to debug slow DB issue 2017-01-23 07:20:36 -05:00
Dan Stillman
41413b1ab2 Fix push sync for group libraries 2017-01-23 07:01:41 -05:00
Dan Stillman
cddc84ffe3 Make sure translator file ends with newline when saving 
Fixes https://github.com/zotero/scaffold/issues/37
 2017-01-23 05:57:18 -05:00
Dan Stillman
c9694e93b0 Fix file upload error when remote attachment has no stored hash 2017-01-22 15:30:18 -05:00
Dan Stillman
b3c28dc79e Fix item keys in report ids 2017-01-21 06:36:28 -05:00
Dan Stillman
9b247ebba7 Fix error trying to generate report for many items 
When adding many search conditions (e.g., when matching many items with the
`key` condition), the query can fail due to either the bound parameter limit or
the expression tree size limit.

To avoid this, add support for an 'inlineFilter' property on search conditions
when using the 'is' or 'isNot' operator. 'inlineFilter' is a function that
returns a quoted value suitable for direct embedding in the SQL statement, or
false if not valid. Multiple consecutive conditions for the same 'inlineFilter'
field are combined into an `IN (x, y, z)` condition.
 2017-01-21 03:38:36 -05:00