Commit graph

6368 commits

Author SHA1 Message Date
Dan Stillman
30ae61d60e More 2x icon fixes
Follow-up to 5b2af4845b
2017-10-18 04:09:10 -04:00
Dan Stillman
5b2af4845b Toolbar button and icon overhaul
- New 2x toolbar button shapes and other icons from @johanneskrtek --
  this HiDPI-ifies basically all graphics other than a few remaining item
  type icons
- Use the Mac search dropmarker for all menu buttons, since it's wider
  and more pleasant. Reduce menu button padding slightly to compensate.
- Better toolbar button state for inactive window and pressed state
- Fix dropmarker overlap in tag selector icon

Closes #347, Better/retina-style OS X toolbar icons
Closes #1339, Create new button PNGs for macOS
2017-10-17 20:53:43 -04:00
Dan Stillman
1f5639da42 Fix #1335, Item drag and drop is unreliable
Regression from e62433edfb

Load a locale file once via nsIConverterInputStream and cache it for
subsequent retrieveLocale() calls. I'm not sure if using a stream
instead of synchronous XHR is actually necessary now that there's
caching, but it can't hurt.
2017-10-09 23:07:47 -04:00
Dan Stillman
68b5ac456f Add note input event debugging via extensions.zotero.debugNoteEvents 2017-10-08 18:00:28 -04:00
Dan Stillman
8f3909713f Save note on forward-delete when text is selected
This doesn't generate a keypress event for some reason, even though it
does when no text is selected.
2017-10-08 17:59:40 -04:00
Dan Stillman
4fb8f44d01 Fix rebuilding of full-text index 2017-10-08 16:58:06 -04:00
Dan Stillman
08d322932d Fix sync error from invalid link mode in database
And add cleanup step to DB integrity check
2017-10-08 04:42:42 -04:00
Dan Stillman
773a93f55d Fix item selection that requires switching to library root
Broken in c7639f328f
2017-10-07 05:05:34 -04:00
Dan Stillman
d4569d3640 Remove unnecessary condition 2017-10-07 03:45:58 -04:00
Dan Stillman
982719bf83 Fix data-dir-not-found error on first run with no legacy dataDir 2017-10-07 03:45:58 -04:00
Dan Stillman
492e7917b6 Fix breakage in the connector from 365e58249d 2017-10-05 17:18:43 -04:00
Dan Stillman
7d14da3a8c Fix translator test mismatches due to 5.0 tag format 2017-10-05 17:18:43 -04:00
Dan Stillman
ffcf608de1 Don't show "Running handler" for 'debug' handler during translation 2017-10-05 17:18:42 -04:00
Dan Stillman
9209edd081 Use object for translate() in translator tests 2017-10-05 17:18:42 -04:00
Dan Stillman
23cf6bd007 Use new HTTP.processDocuments() in translatorTester 2017-10-05 17:18:42 -04:00
Dan Stillman
d5261841be Allow substrings when filtering translator tests 2017-10-05 17:18:42 -04:00
Dan Stillman
c44af1c7bd Fix import translators in translation-server 2017-10-05 17:18:42 -04:00
Dan Stillman
819be60796 Switch to XMLHttpRequest for processDocuments()
processDocuments() now uses an XHR 'document' request, wrapped to
provide a 'location' property, and uses promises for a simpler call
signature (though the old one will continue to work, for existing
translators). 'done' and 'exception' can now be handled via promises,
and in the translator sandbox an optional noCompleteOnError argument
instructs it not to automatically cancel the translation process with an
error (e.g., for supplementary materials).

Since we do need a hidden browser in some situations (e.g., for saving
snapshots), the old hidden-browser-based processDocuments() is still
available as Zotero.HTTP.loadDocuments().

This hopefully also fixes various problems with document property access
in translation-server.
2017-10-05 17:18:42 -04:00
Dan Stillman
5f9dc05956 Increase size of page logged for invalid PDF download 2017-10-04 21:36:28 -04:00
Dan Stillman
ff798d332b Avoid double item save when adding attachment 2017-10-04 21:35:59 -04:00
Dan Stillman
fcc366a176 Fix #1272, Different-account warning with same username
If you swapped in a database with a different sync account from the
stored one and then opened the prefs, it would update the username to
match the username from the API key, and then when you synced it would
warn you using the new username for both accounts.

This stops the prefs from updating the username in the DB, so it only
happens during a sync.

(This behavior was put in in 77a95b5e6d, I guess so that if you open the
prefs twice before a sync it won't briefly show a missing/outdated
username after the first time, but that's not a big deal.)
2017-10-03 02:02:00 -04:00
Dan Stillman
dc11b37ced Log warning if key not passed to getByLibraryAndKey() 2017-10-01 22:05:40 -04:00
Dan Stillman
531170353b Fix bidirectional relations on Duplicate Item 2017-10-01 22:04:11 -04:00
Dan Stillman
c0143300c4 Fix additional refresh bug when Advanced Search window is open
Follow-up to 89babf8832
2017-10-01 00:23:37 -04:00
Dan Stillman
699d5634e9 Add deprecation warning for itemTreeView::saveSelection() 2017-09-30 23:46:43 -04:00
Dan Stillman
4eb18e5eba Make missing row in itemTreeView::getSelectedItems() non-fatal
This might help avoid the search bar brokenness that people are seeing
(and that we can't reproduce), though the same problem might just cause
a later error.
2017-09-30 23:45:00 -04:00
Dan Stillman
52bbb79fd0 Remove citeproc-prereqs, which isn't necessary anymore 2017-09-30 19:07:29 -04:00
Dan Stillman
e62433edfb Fix citeproc-js in Firefox 56
Our retrieveLocale() implementation was broken by
https://bugzilla.mozilla.org/show_bug.cgi?id=1319111
2017-09-30 04:01:28 -04:00
Dan Stillman
89babf8832 Fix refresh problems when Advanced Search is open, and maybe other times 2017-09-29 04:24:49 -04:00
Dan Stillman
48d4d2d5a5 Standardize connector server behavior for saves to read-only libraries
Return a 500 for read-only libraries for all save modes. Read-only views
within editable libraries will save to the library root.

Addresses #185, RIS/BibTeX interception to read-only view behaves
differently from save button
2017-09-27 17:39:18 -04:00
Adomas Venčkauskas
7a062a7493 Remove connector proxy code
Observing requests, auto-redirecting and learning proxies no longer
relevant on this codebase (and interferes with Scaffold).
2017-09-25 14:57:02 +03:00
Dan Stillman
da21c9c47b Remove old archive.org relations
These aren't allowed by the API and were breaking syncing (and haven't
been exposed anywhere for years anyway).
2017-09-22 16:58:16 -04:00
Adomas Venčkauskas
42e2f229c0 Apply linux tab fixes to all tabs (e.g. tabs in zotero plugins) 2017-09-22 13:10:27 +03:00
Dan Stillman
19447e7b90 Fix RIS/BibTeX import errors when in library root 2017-09-22 04:12:21 -04:00
Dan Stillman
a455a72534 Remove invalid relations mangled during import
Not sure if this occurred for our own translators, but it addresses
items created from #1282.
2017-09-22 01:22:33 -04:00
Dan Stillman
0d3d4323b5 Fix relations import via translators
Fixes #1282
2017-09-22 01:02:50 -04:00
Dan Stillman
10cae22c55 Restrict relation predicates to letters and colons for now 2017-09-22 01:01:52 -04:00
Dan Stillman
241e596680 Update citeproc-js to 1.1.178 2017-09-21 15:47:41 -04:00
Dan Stillman
d81e2a5cf0 Fix sync errors from remote item referencing deleted local collection 2017-09-20 05:33:44 -04:00
Dan Stillman
85d7c01c85 Fix getAsync() integer warning when clicking on related item 2017-09-20 03:36:16 -04:00
Dan Stillman
c7639f328f Fix editing in classic citation window (broken by 2901174ba3)
This is (hopefully) a better fix for selection issues than 2901174ba3. A
reference to the collectionTreeView is stored in a `view` property on
the collectionTreeRow, and when an itemTreeView is initialized and
passed a collectionTreeRow it assigns itself to an `itemTreeView`
property on the row's view.
2017-09-20 03:36:16 -04:00
Dan Stillman
365e58249d Check for invalid certificate in Zotero.HTTP.request()
We were checking for this in the sync API client, but that didn't apply
to Amazon S3 for ZFS.
2017-09-20 00:49:10 -04:00
Dan Stillman
a858368642 Revert "Use eraseTx() instead of erase() when deleting saved search"
eraseTx() isn't actually valid in this context.

This reverts commit 103c16a563.
2017-09-19 23:47:03 -04:00
Dan Stillman
8efbfb7c74 Close import progress window on error
Fixes https://github.com/retorquere/zotero-better-bibtex/issues/719
2017-09-19 02:35:04 -04:00
Dan Stillman
afc7afeb9c Fix error deleting collection after emptying trash
Follow-up to c442daedce
Fixes #1317
2017-09-18 17:03:12 -04:00
Dan Stillman
49506b6d94 Fix non-integer warning when purging ids from sourceList.persist 2017-09-18 17:02:25 -04:00
Dan Stillman
d83d70eb5c Update locate engine download code
Asyncify, make JSON load failures not fatal, and simplify icon download
code (which also fixes download of CrossRef icon, which was failing for
some reason).
2017-09-18 02:31:13 -04:00
Dan Stillman
6d53839fbc Add sniffer entry for .ico files 2017-09-18 02:26:31 -04:00
Dan Stillman
d2a33f2613 Update submodules 2017-09-18 01:37:26 -04:00
Dan Stillman
fb61819f6b Update automatic trash emptying after 3872e646ac
And restore 'limit' parameter used for auto-empty
2017-09-16 00:51:51 -04:00