Dan Stillman
0ea328dac5
Fix changing of linked attachment base directory
2016-06-26 02:02:22 -04:00
Dan Stillman
7e5b46b146
Merge pull request #1048 from adomasven/fix/linux-test-failures
...
Fixes freezing occuring on linux while running tests
2016-06-25 07:30:35 -04:00
Dan Stillman
2f562a4fdf
Fix Travis errors with OS.File.DirectoryIterator for real
2016-06-24 21:12:29 -04:00
Dan Stillman
edc996b1ed
Sanity-check OS.File.DirectoryIterator entry.isDir only on Travis
...
Follow up from 2c2a5a378
2016-06-24 18:32:35 -04:00
Dan Stillman
2d88b07855
Set Zotero.automatedTest flag instead of .noUserInput on Travis
...
And don't skip alerts in Zotero.alert() during automated tests. (That
was intended to avoid long timeouts after unexpected failures, but,
e.g., PDF metadata lookups (which are currently disabled in automated
tests) should just be mocked so they don't intermittently fail.)
2016-06-24 18:28:32 -04:00
Dan Stillman
12fef05e18
Fix processDownload test failure on Travis
...
OS.File.DirectoryIterator, used by OS.File.removeDir(), isn't reliable
on Travis, returning entry.isDir == false for directories, so use
nsIFile instead
See also: 2c2a5a378
2016-06-24 18:15:32 -04:00
Dan Stillman
b1e98929fa
Remove zipDirectory debugging
2016-06-24 16:54:34 -04:00
Dan Stillman
2c2a5a3787
Maybe fix zipDirectory() test failures on Travis
2016-06-24 16:50:08 -04:00
Dan Stillman
ec212119cc
More zipDirectory debugging
2016-06-24 16:36:20 -04:00
Dan Stillman
62de330bef
Make sure sync errors are logged
...
This might result in some double-logging, but that's better than no
logging.
2016-06-23 14:37:20 -04:00
Dan Stillman
df1c92b9a3
Fix "librariesToSync is undefined" when full-text syncing is disabled
2016-06-23 14:28:13 -04:00
Adomas Venčkauskas
3f25d64984
Fixes freezing occuring on linux while running tests
...
server_connectorTest - alternating port prevents
exceptions not catchable in JS for httpd server when the socket
and the port remains open after httpd.stop() callback
support - changes the window on which `setTimeout()` is ran in dialogs.
If the timeout is ran on the main window the `dialog` object appears to
lose certain properties and not respond to interactions completely.
2016-06-23 16:15:48 +03:00
Dan Stillman
8bbf0bf495
Only test against stable Firefox for now
...
Don't run more than one test per commit, given current frequency of
commits and spurious failures.
2016-06-23 05:41:46 -04:00
Dan Stillman
6a523347b2
Cancel delayed quickCopy initialization when resetting DB during tests
...
And improve cancellation of scheduled feed checks
2016-06-23 05:38:15 -04:00
Dan Stillman
511222bcaf
Skip child items when generating export format for CSL JSON
...
itemToCSLJSON() doesn't seem to need child items, so when a Zotero.Item
is passed to it, don't bother loading child items when calling
itemToExportFormat() to convert the item into the necessary format.
2016-06-23 04:26:24 -04:00
Dan Stillman
0238a2c13c
Fix errors citing items in unloaded libraries
2016-06-23 04:17:33 -04:00
Dan Stillman
74fe2a2bdc
Pass empty array to sync/finish event if no synced libraries
2016-06-23 03:08:16 -04:00
Dan Stillman
3de40256bf
Restore drag-and-drop Quick Copy
2016-06-23 03:08:16 -04:00
Dan Stillman
8a0081c84e
Sort translators list in Quick Copy drop-down
2016-06-23 03:08:16 -04:00
Dan Stillman
d4532f0cdf
Merge pull request #1040 from rmzelle/inherit-class
...
Correctly inherit "class" from parent style
2016-06-23 03:05:49 -04:00
Dan Stillman
16524113c7
Merge pull request #1046 from zuphilip/patch-2
...
Change const to var in utilities
2016-06-23 03:01:36 -04:00
Philipp Zumstein
f6da7bb8d4
Change const to var in utilities
...
In order to make these mappings also available when the
script is used with `loadSubScript` from outside we
have to use `var` instead of `const`, `let`.
See https://github.com/aurimasv/z2csl/issues/6
2016-06-23 00:38:48 +02:00
Dan Stillman
c2dd531cec
Fix waitForDialog() with modal dialogs in popup windows (e.g., prefs)
2016-06-22 15:46:44 -04:00
Dan Stillman
4d516c68bf
More zipDirectory() test debugging
2016-06-22 06:52:41 -04:00
Dan Stillman
94e0e8b752
Debugging for zipDirectory() test failure on Travis
2016-06-22 06:42:30 -04:00
Dan Stillman
b5344119bb
Don't warn if a modified library property is accessed before save
...
getCellText() can be called between when a property (e.g., .name) is
changed and when ._changed is reset after the save, making this warning
unavoidable
2016-06-22 06:26:02 -04:00
Dan Stillman
48a072d254
Update library version after settings upload
2016-06-22 05:58:12 -04:00
Adomas Venčkauskas
834597c8bb
Fix test failures introduced after #1044
2016-06-22 05:47:24 -04:00
Adomas Ven
dd8fd2b1ac
Feed syncing ( #1044 )
...
Closes #1036
Also:
- Store sync info for feeds more compactly. Address #1037
2016-06-22 03:24:22 -04:00
Dan Stillman
451c12513e
Remove unused toResponseJSON() overrides for Collection/Search
2016-06-20 01:21:24 -05:00
Dan Stillman
8e0e69332e
Fix syncing of search conditions
2016-06-20 01:08:25 -05:00
rmzelle
e49c09f4a1
Correctly inherit "class" from parent style
2016-06-18 20:28:28 -04:00
Dan Stillman
2225f459b7
Fix breakage after certain Notifier events with My Publications selected
2016-06-14 15:24:47 -04:00
Dan Stillman
87abfdf64d
Merge pull request #1032 from adomasven/fix/feed-dates
...
Changes date parsing and handling for feeds. Closes #1024 , #1025
2016-06-14 13:38:38 -04:00
Adomas Venčkauskas
137290b97f
Changes date parsing and handling for feeds. Closes #1024 , #1025
2016-06-14 13:22:04 +03:00
Dan Stillman
099b45438d
Merge branch '4.0'
2016-06-13 23:02:22 -04:00
Dan Stillman
954677636e
Fix hang if another key is pressed after Enter in Quick Format dialog
2016-06-13 23:00:08 -04:00
Dan Stillman
c312576d02
Fix indicated return value in comment for itemToExportFormat()
2016-06-13 04:57:26 -04:00
Adomas Ven
f9449b1749
Fixes hidden columns showing on restart. Closes #1030 ( #1031 )
2016-06-13 04:56:39 -04:00
Philipp Zumstein
a200f6cfc5
Fix more for-each-in ( #1029 )
2016-06-12 01:23:45 -04:00
Dan Stillman
7dda5a2f69
Fix saving to collection from fallback search translators
...
Fixes #1028
2016-06-11 14:54:06 -04:00
Dan Stillman
b0ef76cf57
Fix instances of browser windows being left open after tests
2016-06-11 05:10:06 -04:00
Dan Stillman
0b75b75b96
When merging items, add master item to all collections
...
Also changes Zotero.Item.prototype.clone() to take an `options` object for its
second parameter instead of a boolean `skipTags`. The object includes
`skipTags` as well as a new `includeCollections` property to add the new item
to the same collections.
2016-06-10 23:26:32 -04:00
Dan Stillman
e66954a6f7
Correct comment for Zotero.Date.isoToDate()
...
isoToDate() does handle non-UTC time zones
2016-06-10 20:37:53 -04:00
Dan Stillman
3179a2f0e7
Fix various issues with note pane tags box
2016-06-10 20:35:14 -04:00
Dan Stillman
3de5ed1332
Don't show "false" for empty notes after restart
2016-06-10 19:44:33 -04:00
Dan Stillman
41fe8365a9
Fix #1027 , 5.0: Not possible anymore to add tags to notes
...
Still a little weirdness in the tags popup that I'll clean up, but it should
work now.
2016-06-10 19:21:54 -04:00
Dan Stillman
fdd90b04d3
Save to My Library via connector when read-only library is selected
...
(Or My Publications, which is editable but shouldn't allow direct saving)
Also switches to My Library
2016-06-09 02:47:29 -04:00
Dan Stillman
de19d2fee5
Update locales from Transifex
2016-06-09 02:43:37 -04:00
Dan Stillman
0cf102b0e6
Fix missing word in string
2016-06-07 12:36:27 -04:00