8562 commits

Author	SHA1	Message	Date
Dan Stillman	d03b0a716d	Don't preselect Act for multiple sources in classic citation dialog ... "Multiple Sources…" wasn't properly handled by 629892b0b8 https://forums.zotero.org/discussion/98877/act-instead-of-page https://twitter.com/drezvera99/status/1554521940684984320	2022-08-06 02:29:26 -04:00
Abe Jellinek	bb2b37a73a	Item box: Prevent tabbing to hidden fields ... This one's probably been around for a while! Reproduce by creating an item with a fieldMode = 1 creator, tabbing past the creator, and then shift-tabbing back to it. Your cursor will end up in the invisible first name field and further shift-tabs can't move it past. Cherry-picked from fx102: 080ada78ee	2022-08-05 16:31:09 -04:00
Martynas Bagdonas	7ec54fdaa9	Select existing unloaded tab instead of opening a new one ... Fixes #2740	2022-08-05 18:22:30 +03:00
Martynas Bagdonas	5a659b070d	Allow to scroll tabs with mouse wheel ... Fixes #2724	2022-07-29 13:06:33 +03:00
Abe Jellinek	ad96323881	Duplicates Merge: Preserve embedded annotations (#2728)	2022-07-29 05:06:44 -04:00
Adomas Venčkauskas	fc0f6157d0	Do not load-timeout on browser PDF download during content load ... Closes #2726	2022-07-26 13:49:23 +03:00
Martynas Bagdonas	6733f2edca	Freeze note schema version to 8 ... We can do it because it was only used to create a note from annotations. No need to update schema version in Zotero client, unless using new features when creating a note from annotations.	2022-07-25 18:04:00 +03:00
Martynas Bagdonas	e1997620a4	Fix regression that prevents showing the last selected tab on startup ... Fixes #2723	2022-07-25 11:51:05 +03:00
Martynas Bagdonas	0785b3a086	Fix regression that prevents showing new notes in contextPane notes list	2022-07-21 13:27:32 +03:00
Adomas Venčkauskas	ba5cb7d5c6	Fixes some assets not being saved with SingleFile snapshots ... Part of zotero/zotero-connectors#394 When saving an item (e.g. on arxiv) with a site translator, the translator may add a custom snapshot attachment URL which does not match the translation URL (the URL in the browser where translation was initiated) in which case Zotero handles snapshot saving. Zotero loads the page in a background browser. By default images are not loaded in this browser. SingleFile due to CORS restrictions has to refetch all resources that are not from the same domain or subdomain, but uses pre-loaded resources (images) from the same domain. Before this change any images that were from the same domain as the saved website were not saved in the snapshot. This commit fixes that.	2022-07-20 14:28:56 +03:00
Adomas Venčkauskas	d822da4c06	Changes for updated SingleFile submodule	2022-07-20 14:28:56 +03:00
Dan Stillman	6921268dc0	Localize "Export PDF…" menu option ... Fixes #2710	2022-07-20 01:04:00 -04:00
Dan Stillman	5c61815f36	Update translate submodule	2022-07-18 19:43:18 -04:00
Dan Stillman	b5ca5aed3a	Update submodules	2022-07-18 19:14:24 -04:00
Dan Stillman	9d0cd005f8	Increase Mendeley API timeout to 60 seconds ... To see if we can fix the 30-second timeout here: https://forums.zotero.org/discussion/comment/412750/#Comment_412750	2022-07-18 08:29:45 -04:00
Dan Stillman	98d6f40e4a	Add warning in toolbar for 'dev' channel builds	2022-07-16 04:19:42 -04:00
Martynas Bagdonas	2cad5b00d1	Use Quick Copy (Markdown) for direct plain-text copying from note-editor ... Fixes #2505	2022-07-15 15:06:19 +03:00
Abe Jellinek	95239db0fd	Prevent deleting My Publications ... Previously showed a blank confirmation dialog and logged an error.	2022-07-13 16:23:50 -04:00
Martynas Bagdonas	4c063e7b6e	Prevent delayed context pane expansion and pdf-reader rerender/resize when switching from library tab	2022-07-12 18:00:21 +03:00
Martynas Bagdonas	07f1517712	Don't include quotes when {{highlight}} is placed in a blockquote ... Fixes #2697	2022-07-12 12:12:21 +03:00
Martynas Bagdonas	f0e0971c69	Include quotation marks for highlights by default, but allow to disable ... Fixes #2697	2022-07-11 15:32:02 +03:00
Dan Stillman	26a5e2900a	Better fix for errors from invalid sort fields ... Just catch the error from `ItemTree::sort()` and clear the secondary-sort and fallback-sort prefs so that sorting works on the next attempt. Replacement for a8ed30ce80 https://groups.google.com/g/zotero-dev/c/kc0-C6-SA74/m/bhHniGceAQAJ	2022-07-11 01:30:38 -04:00
Dan Stillman	34d66381d1	Revert "Validate fields in ItemTree::getSortFields()" ... This reverts commit a8ed30ce80 and related commits. We'll address breakage from invalid sort fields another way, without inconveniencing plugin authors. https://groups.google.com/g/zotero-dev/c/kc0-C6-SA74/m/bhHniGceAQAJ	2022-07-11 00:43:15 -04:00
Dan Stillman	f7dbcdde4b	Sort empty rows last for Date/Year columns when descending ... Date columns start in descending order, so put empty rows at end Also remove a seemingly unnecessary exception for Title when not the primary sort and just always sort it with empty rows first	2022-07-10 23:47:02 -04:00
Dan Stillman	c4563af381	Fix sorting of attachments and notes columns ... Regression from a8ed30ce80	2022-07-10 23:26:36 -04:00
Dan Stillman	56e7f0a10f	Fix sorting by Item Type and feed item itemID ... Regression from a8ed30ce80	2022-07-10 17:31:01 -04:00
Dan Stillman	124c18d54d	CookieSandbox: Fix error setting request cookies ... Regression from 6af3b0276a, showing up as "trackedBy is undefined" error https://forums.zotero.org/discussion/98322/no-snapshot-or-pdf-autosaved-using-zotero-connector-on-safari	2022-07-10 06:28:56 -04:00
Dan Stillman	cf8819cc06	Add localized string for timestamp CSL locator ... Not included in the CSL locales: https://forums.zotero.org/discussion/comment/412060/#Comment_412060	2022-07-09 18:07:07 -04:00
Dan Stillman	c5dbf0169f	Merge pull request #2693 from tnajdek/mendeley-import-improve-feedback ... Multiple improvements to Mendeley importer	2022-07-09 01:43:50 -04:00
Abe Jellinek	3f282fc25f	recursiveCollections: Remove from all subcollections on delete (#2689)	2022-07-09 01:37:14 -04:00
Dan Stillman	629892b0b8	Add CSL 1.0.2 locators and switch to CSL locales for localization ... And move Page to middle of list, while still selecting by default https://forums.zotero.org/discussion/comment/396602/#Comment_396602	2022-07-09 01:00:07 -04:00
Dan Stillman	a8ed30ce80	Validate fields in ItemTree::getSortFields() ... To avoid startup hang if a plugin does something bad: https://forums.zotero.org/discussion/comment/411843/#Comment_411843 Fixes #2692	2022-07-08 06:01:23 -04:00
Tom Najdek	43f15e7517	Improve log output for multiple Mendeley imports ... Helps with debugging cases where new import is started while previous one is still being cancelled	2022-07-07 13:40:40 +02:00
Tom Najdek	df11227e0a	Lint code related to Mendeley importer	2022-07-07 13:40:40 +02:00
Tom Najdek	d418d79e70	Fix a bug in regex extracting fields to "extra" ... Because regex is built using a template string, \s* is actually escaped into s*, i.e. literal "s" appearing 0 or more times. In most cases this would mean that output can have spacing slightly off. In extreme case, when identifier starts with letter "s", this could this could lead to identifier being stored incorrectly. Also adjusted tests to be more strict and mock data to cover this case.	2022-07-07 13:40:40 +02:00
Tom Najdek	42aebccbf4	Mendeley import: detect win close, better feedback ... * Detect wizard cancel/close and interrupt import. This will still have to wait for current fetch (file or metadata) to complete but will then advance to the cleanup stage * Advance progress bar during metadata fetch * Add some extra logging	2022-07-07 13:40:33 +02:00
Tom Najdek	7b6e19435b	Don't try to remove temporary dir after import ... Previously we had a structure that also created folders in temp dir, that has since changed but code in cleanup phase to remove containing dir has been accidentally left unremoved.	2022-07-07 10:09:53 +02:00
Martynas Bagdonas	f650f95081	Fix disabled "Add to Note" when a child note is open ... Fixes #2687	2022-07-06 11:33:22 +03:00
Dan Stillman	0357026865	Update global schema and utilities for CSL 1.0.2	2022-07-05 01:34:10 -04:00
Martynas Bagdonas	92d89becc7	Adjust page rotation labels in PDF reader ... Fixes #2669	2022-07-01 16:33:08 +03:00
Martynas Bagdonas	49f9642c0d	Show parent item title for child notes in context pane ... Fixes #2681	2022-07-01 15:32:14 +03:00
Martynas Bagdonas	f0b896d282	Implement smart notes switching in contextPane (#2671) ... Fixes #2650	2022-07-01 03:28:20 -04:00
Dan Stillman	b215d93ac9	Update utilities submodule and date-parsing tests ... Includes strToDate() fixes	2022-06-22 04:41:33 -04:00
Adomas Venčkauskas	43c86c0e58	Limit the force-click during drag fix to macOS (4fb0661b)	2022-06-15 09:08:30 +03:00
Adomas Venčkauskas	6f3f5d2ea8	Fix alt-arrow not working on macOS when editing collection names. ... Fixes #2651	2022-06-14 14:27:34 +03:00
Adomas Venčkauskas	4fb0661b50	Fix force-click during drag sometimes causing collections to switch ... Closes #2652	2022-06-14 14:18:36 +03:00
Abe Jellinek	57ab92b5b9	Fix error if New Collection prompt is canceled	2022-06-09 18:32:14 -05:00
Dan Stillman	7b20972c27	Use String.fromCharCode() to load Chinese characters in strToDate() test ... Follow-up to dc045250a6	2022-06-09 00:03:34 -04:00
Dan Stillman	dc045250a6	Fix parsing of Chinese and other non-ASCII month names ... https://forums.zotero.org/discussion/97683/bug-locale-issues-concerning-zotero-and-zotero-connector	2022-06-08 23:45:18 -04:00
Dan Stillman	256bd157ed	Properly strip ZWJ in isOnlyEmoji()	2022-06-07 20:36:48 -04:00
Dan Stillman	2b45b7fea3	Fix Emoji detection ... And move to Zotero.Utilities.Internal.isOnlyEmoji() Fixes #2643	2022-06-07 20:12:29 -04:00
Abe Jellinek	d8069fac50	Fix sorting by attachment (#2586)	2022-06-07 01:32:27 -04:00
Dan Stillman	b658f09dd8	citeproc-js: Add space after left margin in plain-text mode ... This adds a space after the the number in some numeric styles ("[1]" in IEEE style, "1." in Nature) when pasting bibliography entries into a plain-text editor. Some styles (ACS, AMA, Vancouver) will need to be updated to remove their hard-coded spaces to avoid double spaces after this change. Patch from @zepinglee Fixes #2633	2022-06-07 00:57:01 -04:00
Martynas Bagdonas	5799bdd554	Add support for PDF page deletion and rotation (#2595) ... * Add support for PDF page deletion and rotation Fixes #2561	2022-06-07 00:53:37 -04:00
Adomas Venčkauskas	62c7b4db2b	Log full hidden browser count after its creation	2022-06-06 12:50:21 +03:00
Adomas Venčkauskas	caa0b05e5f	Fix a MIMETypeHandler.removeHandler() bug	2022-06-06 12:49:58 +03:00
Adomas Venčkauskas	5095543bef	Improve downloadPDFViaBrowser handlers and logging	2022-06-06 12:49:28 +03:00
Adomas Venčkauskas	6af3b0276a	Fix cookieSandbox not overriding user agent if no cookies for domain. ... Potential fix for #2635	2022-06-06 12:48:29 +03:00
Martynas Bagdonas	67700f8a2c	Fix library tab tooltip always staying on top	2022-05-31 15:37:30 +03:00
Dan Stillman	d12f3eda61	Fix detection of some emoji set as colored tags ... Emoji such as ⭐️ that began as text-based Unicode characters and depend on Variation Selector-16 to display the emoji presentation weren't being properly detected.	2022-05-26 06:53:36 -04:00
Dan Stillman	ebc23d73b0	Add prefs for timeouts for downloading PDF via browser ... 1 second isn't enough for some users, so try 1.5, and allow for easier debugging via a pref. https://forums.zotero.org/discussion/96431/i-have-access-to-pdf-but-zotero-cannot-automatically-add-it https://forums.zotero.org/discussion/97277/unable-to-download-papers-using-zotero-chrome-extension	2022-05-20 05:01:57 -04:00
Dan Stillman	419f74379b	Feed import: Don't fail on OPML entry with no title or text ... https://forums.zotero.org/discussion/96841/impossible-dimporter-ompl-rss	2022-05-20 00:33:25 -04:00
Martynas Bagdonas	3fd0abf6b0	Avoid error interrupting annotation extraction from multiple items	2022-05-16 13:42:44 +03:00
Dan Stillman	69616500d8	Update translators, styles, and CSL locales	2022-05-16 00:56:13 -04:00
Dan Stillman	693f9a7e1b	Try to open external PDF reader to page number for "Show on Page" ... PDF-handling code from `ZoteroPane.viewAttachment()` predates `Zotero.OpenPDF` and didn't handle page numbers for external PDF readers, so when called from "Show on Page" in a note (via `ZoteroPane.viewPDF()`) it just launched the file itself in the specified handler or via the OS. For now, change to use `Zotero.OpenPDF.openToPage()` when there's a page number. Later we should use `Zotero.OpenPDF` for everything, but that code is more complicated than just using `launchFile()`, so we'll need to do some testing (particularly on Linux) to see what's best. (Note that "Show on Page" with an external reader doesn't make a ton of sense, since you can't actually see the annotation, but opening the right page is better than nothing.) Fixes #2612	2022-05-15 04:28:30 -04:00
Abe Jellinek	0c0afb129b	Scaffold templates: Pull URL from doc ... Link URLs could lead to redirects.	2022-05-12 14:49:30 -07:00
Abe Jellinek	a11c5987ad	Fix Scaffold load error when fontSize pref is set	2022-05-10 09:10:13 -07:00
Adomas Venčkauskas	4d35cdf095	Remove unneeded constant in virtualized table	2022-05-10 17:03:34 +03:00
Adomas Venčkauskas	eb6b14a218	Fix item tree column resizing issues ... Report https://forums.zotero.org/discussion/97077/problem-with-column-width-adjustment	2022-05-10 17:02:36 +03:00
Adomas Venčkauskas	a406e62fd3	Item Tree: Fix column dividers not aligned for second-level items ... Closes #2605	2022-05-10 13:52:32 +03:00
Adomas Venčkauskas	aa483f579f	HTML tree: Find-as-you-type remains on matching string. ... Closes #2607	2022-05-10 13:35:31 +03:00
Abe Jellinek	db5b535ea6	Update translate submodule	2022-05-07 20:34:37 -07:00
Adomas Ven	c49a05d486	Improve column resizing robustness (#2588) ... Also: * Add staticWidth and minWidth column properties	2022-05-03 03:00:23 -04:00
Martynas Bagdonas	01645c5e51	Pin library tab (#2589) ... Fixes #2575	2022-05-03 01:21:59 -04:00
Abe Jellinek	097308c5c6	Update utilities submodule	2022-05-02 17:12:39 -07:00
Dan Stillman	b6fdeeca13	Fix deadlock in integrity check before DB schema upgrade ... One of the repair steps uses a transaction, which is reasonable, so don't run integrity check within transaction at startup.	2022-05-01 02:14:45 -04:00
Dan Stillman	d201fdc119	Fix target is undefined error during upgrade from Zotero 4 ... https://forums.zotero.org/discussion/96811/database-upgrade-error-when-migrating-from-version-4-0-to-6-0-directly-skipping-zotero-5 Regression from 078e3bb07, probably	2022-05-01 02:14:36 -04:00
Dan Stillman	5e0674b842	Add logging for PDF exports	2022-04-30 05:17:41 -04:00
Abe Jellinek	9829ea7009	Update utilities, move tests, add to CI (#2584)	2022-04-30 04:55:11 -04:00
Adomas Venčkauskas	ff920de130	Fix integration transaction getting stuck when google docs tab is closed ... Closes #2583	2022-04-29 15:19:20 +03:00
Adomas Venčkauskas	fca16d2ad5	Fix find-as-you-type not matching beyond first letter ... Closes #2581	2022-04-29 15:19:20 +03:00
Martynas Bagdonas	70c9bef320	Switch tabs with Cmd-Option-←/→ ... Fixes #2475	2022-04-29 12:56:04 +03:00
Abe Jellinek	3bfc6740c4	Add tests for improved compareCallNumbers (#2579)	2022-04-28 04:43:30 -04:00
Abe Jellinek	5196ba379b	Update typeSchemaData and builder script (#2576)	2022-04-28 02:12:29 -04:00
Martynas Bagdonas	fe14ee79a3	Show a few missing options in Tools menu when PDF reader tab is open ... Fixes #2502	2022-04-27 18:20:41 +03:00
Martynas Bagdonas	41bdd36068	Add an option to disable smart quotes ... Fixes #2524	2022-04-27 10:23:10 +03:00
Dan Stillman	a4cdaf0407	Show "Add Note from Annotations" in attachment context menu	2022-04-27 02:34:42 -04:00
Dan Stillman	c405fa76a1	Add sortNotesChronologically.reader pref for PDF reader notes list ... And default to true. I forgot we were sorting reverse chronologically by default in order to make it easy to open recent notes. Follow-up to https://github.com/zotero/zotero/issues/2526 for https://forums.zotero.org/discussion/96743/pdf-reader-two-feature-requests	2022-04-26 17:59:45 -04:00
Martynas Bagdonas	10c8fc4c74	Implement tab duplication ... Fixes #2566	2022-04-26 19:41:51 +03:00
Abe Jellinek	89aaa10504	Sort LC call numbers better, sort integers as integers (#2569) ... * Update utilities submodule after https://github.com/zotero/utilities/pull/8 * Extract and add tests	2022-04-26 04:11:29 -04:00
Martynas Bagdonas	7a06671ecb	Fix undefined variable issue in annotation templates	2022-04-26 08:29:42 +02:00
Adomas Venčkauskas	d96ebad82a	Allow adding multiple sources at once in classic citation dialog. ... Closes #2568	2022-04-25 13:28:00 +03:00
Adomas Venčkauskas	1be2d69f1e	Log integration invocations before other integration actions	2022-04-25 12:43:48 +03:00
Martynas Bagdonas	b8d427790c	Fix error when using a note template and checking if array is not empty	2022-04-23 14:52:24 +07:00
Adomas Venčkauskas	d9463daa66	HTML Tree: Search by typing loops instead of starting from beginning ... Closes #2559	2022-04-22 10:58:25 +03:00
Martynas Bagdonas	c1fde1d3d9	Improve tab title visibility and adjust scroll arrow scroll step ... Fixes #2554 Fixes #2553	2022-04-22 13:07:18 +07:00
Dan Stillman	031ff1824b	Fix middle click to close tabs (#1993)	2022-04-21 12:23:14 -04:00
Martynas Bagdonas	a8cb9bfddd	Restore custom note styling ... Fixes #2560	2022-04-21 13:17:04 +07:00
Abe Jellinek	f91ca9c18a	Don't merge with a deleted master attachment	2022-04-20 11:04:24 -07:00
Martynas Bagdonas	142e3b09f8	Unload tabs (#2500) ... - Keep all tabs unloaded on Zotero opening. - Keep loaded only the last five selected tabs. - Keep loaded only in the last 24h selected tabs. Fixes #2383	2022-04-20 03:14:50 -04:00
Dan Stillman	578986ab1e	Fix item types not appearing in New Item submenu ... https://forums.zotero.org/discussion/96530/a-issue-about-new-item-drop-down-menu After a type from the submenu was selected and added to the MRU, the submenu wouldn't be updated. Not sure how long this has been going on. Fixes #2534	2022-04-19 23:04:18 -04:00
Martynas Bagdonas	5d442b706e	Make tab bar scrollable (#2506) ... Fixes #2232	2022-04-19 18:51:32 -04:00
Adomas Ven	7b0d6951d2	Update csl validator for CSL 1.0.2 (#2493)	2022-04-19 18:42:48 -04:00
Dan Stillman	3f10e4c064	Bad JSON in sync cache shouldn't break syncing ... https://forums.zotero.org/discussion/95926/zotero-not-syncing-report-id-1924846177	2022-04-19 17:49:13 -04:00
Adomas Venčkauskas	5ca8486047	Adjust conditional clause for Windows from 76276a3	2022-04-15 11:21:07 +03:00
Adomas Venčkauskas	76276a39ce	HTML Tree: adjust row padding per OS	2022-04-15 11:15:40 +03:00
Abe Jellinek	e8ad2fab95	getSortTitle: Only strip initial punctuation clusters (#2537) ... Specifically exclude @, #, and *	2022-04-15 02:08:14 -04:00
Dan Stillman	498e38730b	Update translate submodule	2022-04-14 18:06:32 -04:00
Abe Jellinek	d842e7a9bc	Fix save() without transaction when saving search	2022-04-14 14:39:34 -07:00
Adomas Venčkauskas	01506b27e9	Allow moving cursor by clicking on collection name while editing ... Closes #2513	2022-04-14 17:03:54 +03:00
Adomas Venčkauskas	599c6821b7	Ensure columns don't resize when switching tabs	2022-04-14 16:51:13 +03:00
Abe Jellinek	1538a836b9	Show label of translator that causes import error (#2539)	2022-04-14 07:01:43 -04:00
Dan Stillman	08d3880d88	Don't remove relations in annotation item JSON ... This was causing UUIDs for annotations from Mendeley imports to be removed after a sync, resulting in annotations being duplicated on a reimport.	2022-04-14 06:37:30 -04:00
Abe Jellinek	3792c89fbd	Allow >4 numbers after the decimal point in Dewey ... https://github.com/zotero/zotero/pull/2538#issuecomment-1097292396	2022-04-12 15:45:50 -07:00
Abe Jellinek	ce39185fa7	Sort call numbers alphabetically, handle Dewey specially (#2538)	2022-04-12 17:40:25 -04:00
Abe Jellinek	e03c1603ca	Fix "%S" in displayed startup error message	2022-04-11 19:03:29 -07:00
Abe Jellinek	38f5551ee5	Add "Open PDF in New Window" to context menu (#2490) ... Also: * Remove Locate tooltips	2022-04-11 17:53:40 -04:00
Abe Jellinek	a5fc8b859c	Context Pane: Use getNoteTitle() ... ad36c9fb2a (r71022779)	2022-04-11 13:36:03 -07:00
Abe Jellinek	b8b1f8be55	Disable Import actions in uneditable libraries (#2471)	2022-04-11 16:12:43 -04:00
Abe Jellinek	ad36c9fb2a	Context Pane: Sort notes in item tree order ... Fixes #2526.	2022-04-11 10:13:50 -07:00
Abe Jellinek	892c1169c8	Attachment merge: Compare link mode type ... Actually fixes #2527.	2022-04-11 09:30:16 -07:00
Adomas Venčkauskas	237bd8f0ce	Fix Restore Column Order in Item Tree not always working ... Closes #2521	2022-04-11 13:55:30 +03:00
Adomas Ven	4c445554a3	Item Tree: Attempt to fix OS font scaling (#2488)	2022-04-11 05:16:59 -04:00
Martynas Bagdonas	2af7275968	Fix template condition evaluating to true for empty string from function ... Fixes #2529	2022-04-11 12:22:20 +07:00
Abe Jellinek	be0b0a7151	Always autocomplete creators in hideEditor (#2516)	2022-04-11 00:21:14 -04:00
Abe Jellinek	47a2f3cad9	Attachment merge: Compare linkModes, improve logging ... Using keys instead of IDs should make logs more useful. Fixes #2527.	2022-04-09 20:39:37 -07:00
Dan Stillman	0df8b7670d	Fix broken tag selector with colored tags that differ with normalization ... https://forums.zotero.org/discussion/96138/lost-content-in-tag-selector An entered character from the CJK_COMPATIBILITY_IDEOGRAPHS block (char code 63834, or similar) was normalized to the CJK_UNIFIED_IDEOGRAPHS block (char code 35712), which then caused an expected key not to exist. To fix, normalize colored tag values coming from the DB.	2022-04-09 06:24:17 -04:00
Martynas Bagdonas	2112aa7271	Don't jump back to library tab when PDF recognition finishes	2022-04-08 15:31:28 +07:00
Adomas Venčkauskas	b850d16c89	Fix integration error handling code when citeproc-rs disabled. ... Closes #2508	2022-04-08 10:41:35 +03:00
Martynas Bagdonas	bdbde99fa7	Remove alpha channel from highlight color when inserting a note ... Fixes #2499	2022-04-08 13:00:33 +07:00
Abe Jellinek	dea9fc5e88	Scaffold: setInterval -> activate listener	2022-04-07 19:50:13 -07:00
Abe Jellinek	a40ab83b71	Fix double separator in Edit menu on Win/Linux (#2507)	2022-04-06 23:42:13 -04:00
Abe Jellinek	fbaa1c6e61	Fix huge Scaffold toolbar icons on Win/Linux	2022-04-05 14:50:05 -07:00
Adomas Venčkauskas	c510d91461	Fix an error that causes test failures (regression 9a5657b)	2022-04-05 10:08:10 +03:00
Adomas Venčkauskas	5b9ac2ca53	Fix a non-terminal startup error introduced in d7b1a53	2022-04-05 10:08:10 +03:00
Adomas Venčkauskas	9a5657bf79	Item Tree: Fix fixed-width columns sometimes changing width	2022-04-04 16:06:51 +03:00
Martynas Bagdonas	f877476c1a	Partially disable buggy ff <64 table resizing handles in note-editor ... Unfortunately the first opened note will still have the handles.	2022-04-01 17:09:08 +07:00
Martynas Bagdonas	3f4030ff80	Allow copying image annotations to external text fields ... Fixes #2447	2022-04-01 17:09:08 +07:00
Abe Jellinek	a5b3d6440b	Fix next duplicates set selection after merge (#2448)	2022-03-31 17:46:30 -07:00
Martynas Bagdonas	3356557493	Add 'Zoom to Page Height' PDF reader option ... Fixes #2255	2022-03-31 15:52:00 +07:00
Martynas Bagdonas	8e54f1649b	Add annotation to note at cursor position ... Fixes #2487	2022-03-31 12:14:11 +07:00
Abe Jellinek	e922ae711a	Fix ProgressQueue titles for cases, letters, etc. ... Handles items with an alternate field that maps to title (like cases) and items for which the title is usually filled in by updateDisplayTitle() (like letters).	2022-03-30 16:30:07 -07:00
Abe Jellinek	2a1ce292d2	Remove Note Font Size -> Reset restart prompt ... + replace empty menuitem with a divider as in the Font Size menu.	2022-03-30 14:55:48 -07:00
Abe Jellinek	27c9086222	Scaffold: Show "defer" value in test list	2022-03-30 14:49:42 -07:00
Abe Jellinek	745069c070	Don't strip punctuation before numbers ... Fixes #2496	2022-03-30 11:58:55 -07:00
Dan Stillman	f2209974b2	Don't show "Export PDF" in reader ... Save As already exists	2022-03-30 14:13:24 -04:00
Dan Stillman	e0097df068	Remove "Store Annotations in File" option (#2498) ... This is a confusing, bad option, which was already disabled in groups, and this removes it from personal libraries as well. People seem to be using it mainly because they think annotations are locked into Zotero if they don't, which is causing them to ask for this to be done automatically on every edit, which we don't do because it would result in constant file syncing and file conflicts [1]. We provide multiple export options for exporting PDFs with annotations, and people can use those when sharing a file with people who don't use Zotero. Otherwise, if storing annotations in the file is a priority, they can use an external reader that's not designed to be tightly integrated into Zotero. (As a rare hack, it's of course also possible to export the PDF with annotations, replace the original file, and import the annotations.) [1] https://www.zotero.org/support/kb/annotations_in_database	2022-03-30 13:58:59 -04:00
Tom Najdek	56321a7a6d	Fix regression: download() fails for non-http URLs (#2497) ... This fixes compatiblity with some addons that use Zotero.File.download to extract files from their XPI bundle.	2022-03-30 12:15:40 -04:00
Tom Najdek	776769f480	Citavi import: Tweak how page label is determined (#2494) ... Instead of attempting to extract `PageRange` value we now let pdf worker always determine page label. Also improved citavi tests and fixtures.	2022-03-30 09:34:07 -04:00
Abe Jellinek	a9d7a08a05	Fix merge interface doubling rows in master selector ... Master choices would occasionally be doubled in the listbox. Clearing the innerHTML instead of using removeItemAt() fixes the issue.	2022-03-28 13:24:59 -07:00