Commit graph

11067 commits

Author SHA1 Message Date
Abe Jellinek
210d815173 Prevent duplicate main window
Fixes #3964
2024-04-13 01:07:00 -04:00
Dan Stillman
c31c091cb0 Fix size of progress meter at startup
(Though it still doesn't animate, for some reason)

Addresses #3961
2024-04-13 00:32:36 -04:00
Dan Stillman
d236058351 Fix styling in Document Preferences window 2024-04-13 00:30:29 -04:00
Dan Stillman
45fbf8bb12 fx115: Fix Edit Bibliography dialog
https://forums.zotero.org/discussion/113647/zotero-7-beta-73-fails-to-open-add-edit-bibliography-window-in-word
2024-04-13 00:29:36 -04:00
Abe Jellinek
c031e1fbbd Scaffold: Disable sticky headers in Tests editor 2024-04-12 13:21:17 -07:00
Abe Jellinek
b029e561f3 fx115: Scaffold: Restore flex ratio in Tests tab 2024-04-12 13:18:52 -07:00
Dan Stillman
b3b0f04214 fx-compat: Add OS.Path.split() to shim 2024-04-12 06:41:38 -04:00
abaevbog
68596148b0
vpat: 4 change focus sequence in zotero pane (#3954)
From the sync button, tabbing will move focus in the following mannger:
collections toolbar -> collections -> tags selector -> itemTree toolbar
-> itemTree.
2024-04-12 06:32:02 -04:00
abaevbog
9421e09e84
vpat 3: consistent focus order in all directions (#3953)
On last tab in the itemPane/contextPane, focus will wrap around
to the selected tab to complete the loop. It ensures
that the focus order is consistent regardless of the
directions.

Also, minor tweaks to focusWrapAround in Zotero_Tabs
to properly move focus to the last focusable entry in
the contextPane.
2024-04-12 06:26:47 -04:00
abaevbog
4432f88f1d
vpat_11: add roles and states to tags in selector (#3967)
- set each tag's role as "checkbox"
- set "aria-checked" status depending on if the tag
is selected
- added aria-label to tag selector so it does not
default to "grid"
2024-04-12 06:22:16 -04:00
abaevbog
91bc1a3e2d
vpat 6: aria labels for buttons in item/context panes (#3957)
Added aria labels and button roles for buttons in the
item/Collection pane. This includes buttons in the header
as well as rows from notes, related, collections, and
attachments section that act as buttons. Also added
missing aria-labelledby for mini-itembox rows below
attachment preview to have filename, dateModified
and etc. properly labelled.

This also covers most of vpat 16.

This does not affect how tags/header/itemBox entries are announced.
There is a separate issue with NVDA and JAWS sometimes struggling
with announcing text inside of `editable-text` component,
so this will be handled separately.
2024-04-12 04:53:35 -04:00
Adomas Venčkauskas
7f573d7717 Replace UA rv to potentially fix bot detection avoidance 2024-04-12 10:34:39 +03:00
abaevbog
117197e11d
vpat: 1 add role="link" to links components (#3952)
- added role="link" to "zotero-text-link" custom component,
using that instead of directly setting the class
wherever possible
- in all other cases, added role="link" directly to links
- added tooltiptext and "noClick" option to zotero-text-link
so that this component could be used in attachmentBox.js
- use "keyboard-clickable" class in zotero-text-link
instead of a separate listener to handle keypresses for brevity
2024-04-11 23:02:53 -04:00
Abe Jellinek
5263c79ea8 BlockingObserver: Re-enable in CI 2024-04-11 22:59:48 -04:00
Abe Jellinek
35f5b19ffd BlockingObserver: Remove platformMajorVersion check 2024-04-11 22:59:48 -04:00
Abe Jellinek
5099da355c BlockingObserver: Don't block when browserId is 0 2024-04-11 22:59:48 -04:00
Abe Jellinek
6ebb15778b
fx115: Fix Scaffold richlistboxes and load dialog sizing (#3968) 2024-04-11 22:53:59 -04:00
Tom Najdek
14586d72b0
Use theme colors in debug viewer 2024-04-11 20:08:10 +02:00
Dan Stillman
80357b1938 CI: Proper disabling of BlockingObserver for #3962 2024-04-11 06:08:02 -04:00
Dan Stillman
df3b9fa425 CI: Temporarily disable BlockingObserver to fix HTTP request failures 2024-04-11 05:30:01 -04:00
Adomas Venčkauskas
70d999291b Fix Dictionary window missing a scrollbar. Closes #3960 2024-04-11 10:53:54 +03:00
Abe Jellinek
398454f85b
zotero://open handler: Decode CFI and selector (#3955) 2024-04-10 19:54:04 -04:00
Tom Najdek
878fc20cec
fx115: Migrate or remove -moz-box-flex which is no longer recognized
* feed settings: part of the grid, not needed
* progress queue: migrated to flex
* tab-bar-container: already fixed in scss
* zotero-lookup-multiline-progress: migrated to flex
* zotero-lookup-textbox: removed, does nothing
* #zotero-prefpane-advanced #data-dir-path: migrated to flex
* #zotero-prefpane-sync: migrated to flex on #storage-url, removed from #storage-password to fix layout
* .search-condition: migrated to flex
* updates.css: migrated to flex
2024-04-10 17:32:04 +02:00
Dan Stillman
d21fc40115 Update Mozilla strings for fx115
(Or technically 125, but I don't think any strings we need were
removed)

This fixes the Edit and Window menu (except for some macOS Window
strings that seem to come from the system) in non-English locales.
2024-04-10 07:33:40 -04:00
Dan Stillman
914a8d8956 fx-compat: Fix width of read-only data directory field in Advanced prefs 2024-04-10 07:17:21 -04:00
Martynas Bagdonas
1951c95e6b Wait until annotation saving is finished before triggering another save 2024-04-10 11:38:28 +01:00
Tom Najdek
fcc366abe2
Fix narrow input fields in "Attach link to URI" dialog 2024-04-10 11:51:09 +02:00
Adomas Venčkauskas
61db9ff0cc Advanced search: do not run search on adding condition
https://forums.zotero.org/discussion/113522/zotero-7-beta-unresponsive-during-advanced-search
2024-04-10 12:29:29 +03:00
Adomas Venčkauskas
1811c77f85 Advanced search: Fix window size issues
- Set minimum dimensions
- Make sure adding/removing conditions only resizes the window
  by the appropriate vertical amount

https://forums.zotero.org/discussion/113523/zotero-7-beta-advanced-search-window-resized-when-pressing
2024-04-10 12:29:25 +03:00
Dan Stillman
0da1702589 Revert "fx115: fix element width/height persist (#3944)"
This reverts commit ecea550a37.

It seems to be causing various UI issues, including the items list
sliding under the item pane when the collections pane is expanded
(though I can no longer reproduce that).
2024-04-09 18:22:52 -04:00
Martynas Bagdonas
81eb0b51bc Fix incorrect flex value that prevents showing reader content in window 2024-04-09 23:15:23 +01:00
windingwind
ecea550a37
fx115: fix element width/height persist (#3944) 2024-04-09 18:00:40 -04:00
windingwind
49923780ca
fx115: replace text/unicode with text/plain in clipboard code (#3945) 2024-04-09 17:47:40 -04:00
windingwind
8b37a9889a Hide item notes in reader
fix: #3941
2024-04-09 20:36:28 +08:00
Dan Stillman
d654daae28 Add try/catch when loading plugin bootstrap.js 2024-04-08 23:17:25 -04:00
Dan Stillman
56c3635214 Merge new English strings 2024-04-08 18:18:28 -04:00
Dan Stillman
591132a2d9 Add brand.ftl to update wizard 2024-04-08 05:23:41 -04:00
Tom Najdek
91cd9814e1
Improve error message in the Mendeley importer (#3900) 2024-04-08 01:46:59 -04:00
windingwind
86bb8f06cb
Fix richlistitem cut-off with double-byte characters (#3931) 2024-04-08 01:38:38 -04:00
windingwind
8b30f08db8 Update warning of ItemPaneSectionElementBase
fix: #3905
2024-04-07 23:21:34 +08:00
Dan Stillman
78c0a3d050 Remove Zotero.platform and Zotero.oscpu and add Zotero.arch
`Zotero.arch` == `aarch64`, `x86_64`, `x86`
2024-04-06 04:41:04 -04:00
Dan Stillman
c6256402e4 Fix logged error when changing data directory 2024-04-05 07:39:53 -04:00
Tom Najdek
b9de90c485
Mendeley importer: Sniff for mime-type if octet-stream reported. #3454 2024-04-05 12:57:52 +02:00
windingwind
4d05367f1d
Fix progress window title bar on win and linux (#3915) 2024-04-05 06:41:33 -04:00
windingwind
808fe9b665 Fix ItemDetails notifier type key 2024-04-05 18:39:53 +08:00
Tom Najdek
9e5831a0bf
Fix misaligned spinner and flickering button in sync pref pane. Fix #3923
Using timeout in credentialsChange caused button to become momentarily disabled
making it flicker. I've verified that the delay is no longer needed and that the
button becomes disabled when using backspace to clear the login/password input field.
2024-04-05 12:05:47 +02:00
abaevbog
5f076dfeea
fx115: Citation dialog fixes (#3889)
- css tweaks for proper sizing and minor cleanup
of unused classes and properties
- added flip="none" for the panels to not bounce
around window's edges
- removed dialog's marginBottom on macOS - it doesn't
seem needed anymore
- close and reopen panel when window's height changes
on all platforms. It used to only happen on windows
but now the panel remains at it's original location on
macOS as well, so we'll always reopen the panel so
that is is positioned close to the dialog
- try to postion the panel in the middle on windows
- fix progress meter not appearing

* improved qf window drag

- not using old windowDraggingUtils since it causes
issues on windows with the mouse outrunning the window.
- instead, set -moz-window-drag: drag on dialog when
the mouse is over the red border
- added chromeutils param to the window. These are required
for dragging to work on windows and their values are
important because wrong values will cause the window to
shrink and basically disappear. 0,0,15,0 seems to work
most reliably though the reason why other values (e.g.
0,2,2,2 as on the ZoteroPane window) break window is not
clear
- added margins around the dialog on windows. moz-window-drag
doesn't seem to properly work for mouse clicks very close
to the window's edge
- with fx115, the <panel> does not follow the window
when it is dragged, so we have to hide the panel during dragging.
Unfortunately, mouseup/down events don't fire on the dialog when
moz-window-drag: drag is set on windows. Without these events,
as a workaround, we check window's position periodically and
hide/display the reference panel based on that.
- removed initial window.resizeTo() right when the content is
loaded. It's not needed and sometimes causes rendering
issues when the dialog appears shrunk.

* fx115 linux css edits

- try to make the dialog look like dialogs on other platforms.
Red background, no chrome etc. The actual window's background can't seem
to be transparant, so no round borders
- minor edits to sizing on linux
2024-04-05 12:07:24 +03:00
Tom Najdek
09eb9b4e77
fx115: Fix a couple of long tag fixer window size issues 2024-04-04 18:15:49 +02:00
Adomas Venčkauskas
34d857d310 fx115: Generate bibliography and doc prefs dialog fixes
- Use min-width: 100vw on the <dialog> element to prevent
  window.sizeToContent() from expanding the dialog unnecessarily on
  style selection
- Set the window min-width since fx115 width attribute on the window is
  ignored
- Set ids to persist position and dimensions
2024-04-04 15:24:53 +03:00
Dan Stillman
9df39c941b Fix error when unlinking account and deleting data
Fixes #3919
2024-04-04 07:10:04 -04:00