Commit graph

1469 commits

Author SHA1 Message Date
Simon Kornblith
fb91854601 don't load all addons on Fx4 startup 2010-11-05 05:05:36 +00:00
Simon Kornblith
6d320ab307 tag saving fix and remove unnecessary attachment code 2010-11-05 04:11:08 +00:00
Simon Kornblith
924c537473 perform full same origin check on translator for getTranslatorObject(), rather than checking equality of URIs 2010-11-05 03:34:20 +00:00
Simon Kornblith
ee101b5bc0 fix getTranslatorObject(), and throw an error if cross-site getTranslatorObject() is attempted 2010-11-05 03:26:00 +00:00
Simon Kornblith
253e439a0c fix DOM XML 2010-11-05 03:14:36 +00:00
Simon Kornblith
36cba09f6d make MODS work with Fx 4 2010-11-05 03:12:22 +00:00
Simon Kornblith
3409811b6c Zotero.CreatorTypes.getLocalizedString() 2010-11-05 03:11:49 +00:00
Simon Kornblith
3c28e25eab remove abstracted data layer calls 2010-11-05 03:10:56 +00:00
Simon Kornblith
925bc7ca5b fix 2.1b1-related field code corruption 2010-11-05 02:52:14 +00:00
Simon Kornblith
b31eb91a4a undo apparent revert of r7224 by merging r7225 2010-11-04 17:09:09 +00:00
Simon Kornblith
f4d722d028 don't leave TabSelect uncommented 2010-11-04 01:31:30 +00:00
Simon Kornblith
d9fb09c1d6 fix handling of tab switching in Fx4 2010-11-04 01:30:59 +00:00
Dan Stillman
7ecb788615 Fix typo in Swedish localization 2010-11-03 17:38:27 +00:00
Simon Kornblith
4c4998b7f8 fix "me" 2010-11-03 15:31:00 +00:00
Simon Kornblith
3f2a8a39ab - Overhaul of Zotero.Translate instance. New code should use new Zotero.Translate.Web, Zotero.Translate.Import, etc. The core Translate class is now abstracted away from data access, read/write IO, and the sandbox API. This all needs more testing.
- Translators now use configOptions and displayOptions properties in their metadata instead of Zotero.configure() and Zotero.addOption() to specify interfaces.
- Replaced now broken Zotero.Utilities.inArray() appearances in MODS.js with proper indexOf() calls
2010-11-02 21:39:54 +00:00
Simon Kornblith
f6e09f7103 Update to citeproc-js 1.0.68
From Frank's release notes:

Further refactoring of output queue mechanism, to unify all quote-
swapping and detection code for duplicate terminal punctuation and
spaces in a single function.  No changes to behavior, unless there is
a hole in the test suite somewhere.

Fix an output nesting mismatch error triggered by items with two
institutional authors in sequence, when rendered with a style that
sorts on the bibliography.

In the output queue mechanism, fix a bug in the migration of a leading
terminal character in a prefix to the preceding sibling suffix.
2010-10-31 18:18:11 +00:00
Simon Kornblith
8207201c6a merge r7225 to trunk 2010-10-31 05:19:43 +00:00
Simon Kornblith
2f5fc456c7 don't double-wrap properties 2010-10-30 17:38:58 +00:00
Simon Kornblith
cd7211da99 update to citeproc-js 1.0.67
From Frank's release notes:

Reimplement duplicate terminal punctuation handling in new
adjustPunctuation() function. Remove old functions used for this
purpose, which were excessively complex and fragile. Some operations
in queue.js may now be redundant, since the new code does a much
better job of cleaning up the output queue in advance of
serialization.

Clears some remaining duplicate punctuation issues.

Corrects errors in the placement of punctuation where multiple
terminal punctuation marks span a formatting boundary (i.e. italics,
boldface, etc.).
2010-10-28 17:00:09 +00:00
Simon Kornblith
f10b1dbd94 don't actually need isConnector 2010-10-27 02:45:39 +00:00
Simon Kornblith
214d857861 fix startup error on Fx 3.6 2010-10-27 02:45:04 +00:00
Simon Kornblith
e0e84bc22a - eliminate for each in future cross-browser code
- move itemTypeExists, getCreatorsForType, and getLocalizedCreatorType back under ZU
- modify OpenURL code to use ZU.itemTypeExists
2010-10-27 02:10:45 +00:00
Simon Kornblith
e61dd60024 move Zotero.Date and Zotero.OpenURL to independent files 2010-10-27 00:36:20 +00:00
Simon Kornblith
d22ccf2219 Zotero.Utilities changes:
- Zotero.Utilities is now a singleton
- Zotero.Utilities.HTTP is now Zotero.HTTP
- Zotero.Utilities.md5 and Zotero.Utilities.Base64 are now located under Zotero.Utilities.Internal
- Zotero.Utilities.AutoComplete has been eliminated

This needs testing to make sure there is no associated breakage.
2010-10-25 00:58:47 +00:00
Simon Kornblith
21a2188caa move getSQLDataType to Z.DB 2010-10-25 00:17:53 +00:00
Simon Kornblith
acdc36c9a1 kill ZU.isInt 2010-10-25 00:01:10 +00:00
Simon Kornblith
8d3e25dbfa kill ZU.min3 2010-10-25 00:00:29 +00:00
Simon Kornblith
a4cb8608da remove ZU.probability 2010-10-24 23:55:50 +00:00
Simon Kornblith
85b703aa33 kill Zotero.arrayToHash, which looks like it was never used, and Zotero.hasValues 2010-10-24 23:49:00 +00:00
Simon Kornblith
8bf5a5fb17 also remove inArray from ZU 2010-10-24 23:42:33 +00:00
Simon Kornblith
f1402708c0 kill Zotero.inArray() and Zotero.arraySearch() 2010-10-24 23:41:32 +00:00
Simon Kornblith
9e3f4576d2 check the right type variable 2010-10-24 19:08:01 +00:00
Simon Kornblith
f7e6843d68 a marginally better solution to XPCCrossOriginWrapper woes achieved by binding child sandboxes to the same locations as parent sandboxes
this won't work if a web/search translator wants to call getTranslatorObject on another web/search translator, but that doesn't happen at the moment, so it should sufficie
2010-10-24 19:04:44 +00:00
Simon Kornblith
95003c88e4 fix translation in Fx 4 trunk builds 2010-10-24 06:52:54 +00:00
Simon Kornblith
9740c42666 try to workaround death of explicit SJOW 2010-10-24 05:35:21 +00:00
Simon Kornblith
26edf1a3f9 hide create item from current page button in standalone (and create new file for standalone-specific CSS) 2010-10-24 05:27:39 +00:00
Simon Kornblith
3f778299b8 correctly display titlebar 2010-10-24 05:16:10 +00:00
Simon Kornblith
43fd51b71c fix CookieManager interaction with hidden browsers 2010-10-18 21:35:50 +00:00
Simon Kornblith
1575ce9df0 fix CookieManager bugs that were breaking Google Scholar 2010-10-18 19:45:10 +00:00
Simon Kornblith
42edc63bf8 fix strange "invalid quantifier" error in Fx4 2010-10-16 20:02:12 +00:00
Simon Kornblith
90922843b0 update to citeproc-js 1.0.66
from Frank's announcement:

Adjustment to the conditions controlling the tainting of entries
carrying year-suffix values.

Avoid redundant application of year-suffix values during
disambiguation.

Provide a default "institution" format blob on the output queue, to
avoid a processor crash with lone institutional author names.
2010-10-15 23:21:21 +00:00
Simon Kornblith
363f059ca3 - run plug-in cleanup() method before displaying dialogs (so that ScreenUpdating is re-enabled before dialogs are shown in WinWord)
- code clean-up
2010-10-15 21:32:49 +00:00
Simon Kornblith
4c2b717c65 add ID to preferences section so that OpenOffice.org prefpane shows paths 2010-10-15 19:17:01 +00:00
Simon Kornblith
d4da080967 Styles->Cite section in Zotero preferences and split to "Word Processors" and "Styles" tabs
also change "Shortcut Keys" to just "Shortcuts" (since the icon is a key anyway)
2010-10-15 05:36:37 +00:00
Simon Kornblith
98ef051951 update to citeproc-js 1.0.65
From Frank's release notes:

citeproc-js 1.0.64:

This release just pulls through the actual changes described in 1.0.62
and 1.0.63.

Apologies for any confusion this caused.

citeproc-js 1.0.65:

Do not needlessly circumvent name disambiguation logic. Reverses a
patch introduced in the 1.0.61 through 1.0.64 series of changes.

Apply the concise and correct fix for the undefined-in-name bug
previously addressed by the 1.0.61 through 1.0.64 series of releases.
Just replacing an undefined variable with an empty string does the
trick.

Force an initialized name that lacks an explicit string value on
initialize-with to full form, but only when using the by-cite
disambiguation rule.

Permit update of year-suffix when it is added, in addition to when it
exists and then changes.

Protect against an undefined value in updateItems(), which can
apparently sometimes occur in the course of word processor plugin
transactions.

Map page-first variable to page when snooping for a value. Prevents a
lone page-first cs:text node within a cs:group from being suppressed
for lack of output.

Repair recently amended appendCitationCluster() command to return a
list of paired values, in accordance with the processor manual.

Extend restoreProcessorState() to work with an empty argument, for
resetting the processor to a pristine state (for use case suggested by
Carles Pina).
2010-10-15 01:03:39 +00:00
Dan Stillman
639e0794bc Clarify NoScript warning to say that a restart is required 2010-10-13 18:16:19 +00:00
Dan Stillman
d8341eb2d1 Fix June and July abbreviations in French locale 2010-10-12 17:14:53 +00:00
Dan Stillman
f0d58fa948 Don't load javascript: and data: URIs from URI field 2010-10-09 20:33:55 +00:00
Dan Stillman
490794dfb9 More XPI fixes for TinyMCE 2010-10-09 19:22:28 +00:00
Dan Stillman
f17e0d6d28 Reapply r3565 to fix TinyMCE in XPI builds 2010-10-09 18:08:38 +00:00
Dan Stillman
d309ad2539 Hide location and status bar and skip Zotero translators on TinyMCE popups 2010-10-09 18:03:03 +00:00
Dan Stillman
ee6c386bae Run Cut/Copy/Paste commands in notes with chrome privileges so they work 2010-10-09 17:21:25 +00:00
Dan Stillman
79334fdbd5 Tell NoScript users how to fix note display 2010-10-09 09:37:07 +00:00
Dan Stillman
c7c27935d0 Fix CSS paths in read-only note and integration views (not yet tested) 2010-10-09 08:12:37 +00:00
Dan Stillman
744b4a597b Missed file from previous commit 2010-10-09 08:06:08 +00:00
Dan Stillman
84f59ab451 Run TinyMCE as content rather than chrome (and now without needing any modifications)
Also upgraded to latest version

Popup windows currently show location and status bars, which needs to be fixed
2010-10-09 08:04:25 +00:00
Simon Kornblith
f4dfc13eab update to citeproc-js 1.0.63 (I think; the code itself still says 1.0.61, but this should be the latest revision available on bitbucket)
Form Frank's release notes:

citeproc-js 1.0.63:

Fix appendCitationCluster() to return a simple string, and required by
Zotero RTF Scan or any similar utility.

citeproc-js 1.0.62:

Block needless initialization of names where
the full name is requested and initialization
is not.

citeproc-js 1.0.61:

Block needless initialization of names where
form is long, no initialization is requested,
and last names are identical.

citeproc-js 1.0.60:

Turn on the parsing of name prefixes and
suffixes by default.

(This change should make CSL 1.0 name prefix
and suffix handling designed by Rintze Zelle
available to existing applications, without complex
changes to the user interface.)
2010-10-09 04:13:51 +00:00
Dan Stillman
8cedbbe125 Don't display trash message when deleting from group collection 2010-10-08 08:43:59 +00:00
Dan Stillman
f58d6f3597 Uncomment valid_elements in TinyMCE config 2010-10-08 07:54:44 +00:00
Dan Stillman
b7a7e4e7ce Sanitize note markup in TinyMCE
[Uncommented note.html's valid_elements in r7027]
2010-10-08 06:44:33 +00:00
Dan Stillman
c9c5fa79f5 Closes #1735, csledit.xul with citeproc-js
Thanks to Frank for the patch
2010-10-07 18:52:18 +00:00
Simon Kornblith
a3ce940fd6 activate the appropriate app with Zotero standalone 2010-10-04 01:32:28 +00:00
Simon Kornblith
a5365bb938 closes #1732, Creator sequence breaks in RDF export with > 10 creators (thanks Frank) 2010-10-04 00:40:59 +00:00
Simon Kornblith
60026d5f39 sandbox cookies in connector to prevent a potential security vulnerability (although this vulnerability would be quite difficult to exploit in a serious manner) 2010-10-04 00:26:06 +00:00
Simon Kornblith
1640d07776 code cleanup in connector and prohibit GET requests 2010-10-03 19:11:48 +00:00
Dan Stillman
5f099967b2 - Move translatorCache to userdata so that translators aren't reinstalled after a system.sql update
- Delete existing translatorCache via schema update to fix translator filename bug in 2.1b1 build
2010-10-03 17:44:10 +00:00
Simon Kornblith
a1eb0e4af7 update to citeproc-js 1.0.59
From Frank's announcement:

Extend punctuation swapping to cases
where quotes entered within a locator.

Implement context-sensitive pluralization
of labels.

Fix bug affecting givennames with more
than two words when rendered in full
form without initialization.

Fixes et al. behavior affecting some
mixed personal and institutional name
combinations.
2010-10-02 20:40:26 +00:00
Simon Kornblith
52479d7c2e update updateCSL.xsl to r41 2010-10-02 20:33:40 +00:00
Simon Kornblith
fc1df31d10 don't automatically adjust pref, since it shouldn't be necessary unless the user has made manual modifications 2010-10-02 20:09:32 +00:00
Simon Kornblith
5bd30580c5 add hidden pref for enabling/disabling connector 2010-10-02 20:08:16 +00:00
Dan Stillman
908b96ccc4 - Add some month/year tests (many of which fail -- refs #1731)
- Always delete empty strToDate part (for proper testing)
2010-10-02 05:18:48 +00:00
Dan Stillman
7b6e017d38 Use display title for related items in reports 2010-09-30 22:50:30 +00:00
Dan Stillman
8a5e5385cb Addresses #1726, Firefox 4 Compatibility 2010-09-30 22:02:24 +00:00
Dan Stillman
6b9f9643da Fixes #1158, Cannot drag item to tag with both automatic and manual versions
And create a manual tag when dragging to an automatic tag in the tag selector
2010-09-30 22:00:45 +00:00
Dan Stillman
7ff2ddae89 Sync credentials weren't cleared if username field was removed first 2010-09-30 18:16:40 +00:00
Dan Stillman
c41f754138 Don't throw an error trying to index an unindexable text file (e.g., text/xml) 2010-09-29 04:09:08 +00:00
Dan Stillman
1e2dc0035f Replace HEAD requests in ZFS syncing with GET requests to work around compatibility problems with proxy servers and security software 2010-09-28 23:44:16 +00:00
Dan Stillman
7f12d2c095 Trim Amazon XML response as possible fix to a user's error 2010-09-28 19:14:52 +00:00
Simon Kornblith
c629a99185 Merge citeproc-js 1.0.57
From Frank's release notes:

citeproc-js 1.0.54:
- Fix misplacement of labels that (should) appear before the
 nameset to which they apply.

citeproc-js 1.0.55:
- Fix bug that triggered "registry[id] undefined"
 error in some disambiguation operations.

- Fix bug affecting voluntary suppression
 of small caps in rich text parsing engine.

- Add methods for setting multilingual
 transliteration, translation, and sort
 parameters on configured processor.

citeproc-js 1.0.56:
- Distinguish between transliterations of
 (personal) names and transliterations of
 titles in recently-added multilingual
 configuration methods.

citeproc-js 1.0.57:
- Correctly handle singleton conditional nodes (if and else-if).
2010-09-27 17:55:20 +00:00
Simon Kornblith
7f83086e1c remove extraneous backslash (although it should not be causing any issues) 2010-09-27 17:34:39 +00:00
Simon Kornblith
5d2db73cc9 fix RTF bibliography generation 2010-09-27 17:25:51 +00:00
Simon Kornblith
8bb80de5db fix bibliography style persistence 2010-09-27 17:12:41 +00:00
Sean Takats
71ab2401f8 Remove Nagoya from About box. 2010-09-26 04:52:04 +00:00
Simon Kornblith
86941ba9fc don't use appendRelativePath to fix Windows issues 2010-09-25 16:09:55 +00:00
Simon Kornblith
c5b703da82 more path fixes 2010-09-25 16:05:15 +00:00
Simon Kornblith
a7c7b8d488 fix path on Windows 2010-09-25 16:04:18 +00:00
Simon Kornblith
48680fbfd8 fix issues searching for existing zotero data directory on windows 2010-09-25 16:00:31 +00:00
Dan Stillman
3abda6bbd8 Use regexp object instead of string 2010-09-23 06:11:35 +00:00
Dan Stillman
1adf489801 Standalone: Open HTTP(S) URLs externally in default browser
Other URLs (such as zotero://attachment) won't work yet
2010-09-23 06:10:04 +00:00
Simon Kornblith
9f2d231741 don't attempt to collapse toolbar in Z standalone 2010-09-23 05:18:47 +00:00
Simon Kornblith
48017eb1b6 make standalone.xul have windowtype navigator:browser (not actually sure this is a good idea for a long-term solution) 2010-09-23 05:05:37 +00:00
Simon Kornblith
4fb708778a fix hidden browser creation in Z standalone 2010-09-23 04:57:36 +00:00
Simon Kornblith
d06a19b6a8 add Zotero Connector 2010-09-23 04:14:19 +00:00
Dan Stillman
253485d96f Remove de-CH and de-AT CSL locales 2010-09-21 00:19:33 +00:00
Dan Stillman
749b13bc02 Replace nsIPrompt with nsIPromptService for Fx4 compatibility 2010-09-20 06:10:06 +00:00
Simon Kornblith
50934eef0c support importing on Windows and *NIX 2010-09-20 02:50:24 +00:00
Simon Kornblith
498489f8c3 on first run of Standalone Zotero, allow user to share data directory with and import settings from Zotero for Firefox 2010-09-20 02:24:07 +00:00
Dan Stillman
4edfceae80 Fix "%S" showing up instead of hostname in WebDAV SSL certificate error 2010-09-19 03:01:52 +00:00
Dan Stillman
8e3b1615bf Throw plugin incompatibility error properly 2010-09-16 15:50:53 +00:00
Dan Stillman
eb95974891 Commons: Remove "zc-test-" prepending 2010-09-16 08:02:45 +00:00
Dan Stillman
0d47e224fa About pane updates 2010-09-16 07:31:32 +00:00
Simon Kornblith
48a143505b remove unnecessary fallback code 2010-09-16 06:25:52 +00:00
Simon Kornblith
66ac0bddcd remove debug code accidentally included in previous commit 2010-09-16 06:23:47 +00:00
Simon Kornblith
e9bedc640b complain regarding out-of-date Word plug-in 2010-09-16 06:22:39 +00:00
Dan Stillman
9e488aa8f0 Work around encoding issue with em dash in tooltip 2010-09-16 04:06:32 +00:00
Dan Stillman
917910d1d0 Add warning to Sync->Reset pane 2010-09-14 21:12:29 +00:00
Dan Stillman
f5d383a91e Commons:
- Check getDisplayTitle() in pre-upload title check
- Use display title for ZIP filename, and run through getValidFileName()
- Use display title in URI
2010-09-10 02:32:02 +00:00
Dan Stillman
60ae71d964 Merge r6708 from branch to trunk 2010-09-09 22:01:53 +00:00
Dan Stillman
56a31cbd72 Include collection name in "Cannot move collection into one of its own descendents" message to help with manual fixing 2010-09-09 01:58:37 +00:00
Dan Stillman
72ffd78143 Remove debug code 2010-09-09 01:57:36 +00:00
Dan Stillman
2f2e8c25da Additional file sync debugging 2010-09-08 18:33:28 +00:00
Dan Stillman
af304f0834 Commons:
- Align bucket name checks between UI and data layer
2010-09-08 17:51:24 +00:00
Dan Stillman
6c7413ed72 Commons:
- Fix collection creation
- Don't display alerts for errors retrieving bucket contents, since IA returns various errors for a while after bucket creation
2010-09-08 17:31:30 +00:00
Dan Stillman
bc53f32595 Recover from wrong-library-tag-item issue without using the DB Repair Tool 2010-09-08 08:44:42 +00:00
Dan Stillman
3fb8d66e1e Link to SSL certificate error KB page on error 2010-09-07 20:21:13 +00:00
Dan Stillman
055f641188 Fix error message in previous commit 2010-09-07 19:01:26 +00:00
Dan Stillman
539ac39d70 Trigger Full Sync when trying to insert an item into a missing local library (though I think the causes of this have been addressed server-side) 2010-09-07 18:39:05 +00:00
Dan Stillman
1f93fa405c Fix an NS_ERROR_FAILURE from nsIFileURL.file, though I don't yet know what causes it 2010-09-07 08:57:35 +00:00
Dan Stillman
6a42d2ee12 Suggest restarting Firefox and/or computer to fix file sync errors 2010-09-07 00:33:42 +00:00
Dan Stillman
e69f9d156f Fixes #1721, Zotero.File.getContents() method ignores small values of maxLength
- Modified version of Frank's patch -- among other things, requested bytes aren't guaranteed by readString()
- Unit tests
2010-09-06 19:10:15 +00:00
Dan Stillman
330f8697f8 Check for long tags not associated with items after TAG_TOO_LONG sync error 2010-09-06 18:36:34 +00:00
Dan Stillman
6ba92efdbb - Add instructions line to CR window saying to click Next/Done
- Resize CR window better for smaller screens (which will hopefully keep the button in view)
2010-09-05 07:18:06 +00:00
Simon Kornblith
937b583c9f update to citeproc-js 1.0.53 (finally)
In this release:

 Fix a subtle bug that caused full author names to
 be erroneously rendered in citations although the
 style parameters did not permit them.
2010-09-04 22:52:52 +00:00
Dan Stillman
3ce6e429ed Commons:
- Fix encoding issues with uploaded files
- Use a more reliable method of generating the file list that doesn't depend on IA filename sanity
- Get user display name from and prepend slugify()'ed version to bucket names (still including "zc-test-" for now)
2010-09-03 20:22:32 +00:00
Dan Stillman
c0091db15e Fixes #1719, Autosync suspension needs to persist
Don't auto-sync on Zotero pane open if a manual sync is required
2010-09-02 16:48:48 +00:00
Dan Stillman
0e45473992 Commons:
- Items must have a title
- Warn if some items are skipped
2010-09-02 04:23:48 +00:00
Dan Stillman
b97c2213b6 Commons:
- Encode apostrophes, since IA wants it that way
- Allow uploading only for regular items with attached files
- Fix error if no local item
2010-09-02 03:14:14 +00:00
Dan Stillman
3d555e030a Commons:
- Don't break reloading on "Invalid response retrieving file upload parameters"
- Don't break loading if a <file> doesn't have a <format>
2010-09-02 02:03:10 +00:00
Dan Stillman
01d3d0057c Don't try to download attachments with empty paths, which can't be saved 2010-09-01 05:42:02 +00:00
Dan Stillman
338096e1a3 Display more helpful message for "Hash not found in HEAD response" error 2010-09-01 05:13:28 +00:00
Dan Stillman
a815fefa28 - Second half of ZFS quota message wasn't being shown in dialog
- Display filename of file that would put user over quota
2010-08-31 17:50:03 +00:00
Dan Stillman
a081315876 Fix UI update on Commons enable/disable 2010-08-31 06:45:45 +00:00
Dan Stillman
ab398bcd84 JS strict warning 2010-08-30 21:00:35 +00:00
Dan Stillman
2d47daf684 Fix for cursor being reset to beginning while editing notes 2010-08-30 20:54:25 +00:00
Dan Stillman
43a6d5190b Fix a couple JS strict warnings 2010-08-30 19:18:33 +00:00
Dan Stillman
6ba90d53b3 Missing semicolon 2010-08-30 18:39:04 +00:00
Dan Stillman
9c366a4bcb Clear Commons credentials on disable 2010-08-30 18:38:32 +00:00
Dan Stillman
a3108335f3 Fix importing of Commons settings, possibly 2010-08-30 18:28:52 +00:00
Dan Stillman
25d354d83d Advanced earches for exact creator names didn't match creators without first names 2010-08-30 00:46:38 +00:00
Dan Stillman
e17bffcdd4 Disable unresponsive script warning during translator initialization, since subsequent runs should be much quicker due to cache
(Change is just an indent, despite messiness of diff)
2010-08-29 18:45:59 +00:00
Dan Stillman
80f5047687 Commons:
- Reload bucket on bucket click if not loaded in the last 60 seconds
- Add "Show Original" button to Commons metadata pane to switch back to original linked item, if it exists
- Hide metadata pane tabs in Commons view
- Add support for setting credentials via zotero.org (untested, and not yet stored in Fx login manager)

Also:

- Add ZoteroPane.getItemGroup() function
2010-08-29 04:14:05 +00:00
Dan Stillman
c97491821f Don't include deleted items in "Export Library" output 2010-08-28 17:21:24 +00:00
Dan Stillman
0d9f45b0fa Fixes #1714, Adding by PMID doesn't work for groups 2010-08-28 17:00:43 +00:00
Dan Stillman
dbcc4408bc Fix FK constraint error (previously requiring a Full Sync to fix) that could occur if an attachment/note was added to a collection on one side and made a child item on the other 2010-08-27 19:27:08 +00:00
Dan Stillman
feca078284 Clarify comments 2010-08-27 19:21:01 +00:00
Dan Stillman
6a12bfd521 Remove obsolete line 2010-08-27 19:18:56 +00:00
Dan Stillman
fe6713b358 Fix CSS parsing errors (which possibly meant the affected rules aren't necessary) 2010-08-27 19:16:29 +00:00
Dan Stillman
476a5b385d Fix JS strict warning 2010-08-27 19:11:13 +00:00
Dan Stillman
e437ecce6b Fix JS strict errors 2010-08-27 19:10:06 +00:00
Dan Stillman
053b6dace3 Fix JS strict warning 2010-08-27 19:08:41 +00:00
Dan Stillman
6a629490b3 - Fix an XML parsing error (due to trailing whitespace, weirdly) that could cause endless sync icon spinning
- Remove extra whitespace in collection-item blocks that was causing sync upload errors (also fixed on the server)
2010-08-26 21:34:44 +00:00
Dan Stillman
4bc7ab9016 Add note that Commons processing could take a while 2010-08-26 06:32:24 +00:00
Dan Stillman
eec491fe7a Handle invalid filenames without failure during import
Export should be fixed to run exported filenames through getValidFileName()
2010-08-25 16:21:49 +00:00
Dan Stillman
e0c8e30161 - Include translator filename in error message on JSON parsing failure
- Recategorize Zotero.log() errors so they show up as chrome errors in Console2
2010-08-24 21:08:04 +00:00
Dan Stillman
f10da8c527 Don't die if /Users/Shared doesn't exist on OS X 2010-08-24 21:05:38 +00:00
Dan Stillman
b3aa705bfd Fixes #1713, Don't show Zotero Commons in Word Processor Plugins 2010-08-24 20:23:52 +00:00
Dan Stillman
23dae26408 Fix "JavaScript component threw a number as an exception" error (which is actually "Cannot move collection into one of its own descendents!") 2010-08-24 18:57:00 +00:00
Simon Kornblith
4d91ec8f8b fix refresh operation 2010-08-16 08:52:13 +00:00
Simon Kornblith
2f671725b8 disable caching of citeproc-js items (for now) 2010-08-16 08:48:55 +00:00
Simon Kornblith
64f810dd5a fix issues inserting new citations with locators with accented characters (citations will still need to be reinserted) 2010-08-16 08:46:07 +00:00
Simon Kornblith
09ff9ec083 fix upgrading of documents with non-page locatorType 2010-08-16 08:19:12 +00:00
Simon Kornblith
ecd6309fbc update to citeproc-js 1.0.52
closes #1709: [patch] citeproc-js 1.0.51 compatibility patch: makeBibliography() return value
closes #1712: [patch] citeproc-js 1.0.52 compatibility patch

From Frank's notes for 1.0.52:

In this release, the following change may require accomodation
within the calling application:

 The processor quashes double spaces in the output.
 RTF control words can be terminated with a space, but
 this causes an immediately following space to be lost
 from the output. To avoid this, the RTF output mode of
 the processor has been adjusted to terminate RTF control
 words with {} rather than space. Applications that convert
 processor output between other formats (such as HTML)
 may need to be adjusted to accomodate this new behavior.

Also in this release:

 Reverse the RTF-related conservatism in the quashing
 of duplicate spaces that was introduced in 1.0.51.

 Add missing parens to suspect test condition (not
 related to any known bug).

From Frank's notes for 1.0.51:

The API return value changes slightly with this version:

 For styles that have no bibliography element, the command
 makeBibliography() now returns false, rather than a
 stub bibliography object.  Code adjustments in the
 calling application may be required to accommodate
 this change in behavior.

 In other bibliography and citation returns, the processor
 now provides new arrays, bibliography_errors and
 citation_errors respectively, with information on
 bibliography entries or cites that produce no meaningful
 rendered output.  Details are in the processor manual:

   http://gsl-nagoya-u.net/http/pub/citeproc-doc.html#handling-items-with-no-rendered-form

Also in this release:

 Fix string breakage affecting text-case="title".

 Fix over-aggressive quashing of spaces, which affected
 spacing following RTF entities.
2010-08-16 08:07:07 +00:00
Dan Stillman
a94675f402 Add better message for error Kaspersky users have gotten 2010-08-09 06:37:01 +00:00
Dan Stillman
c17336291b Display better messages for NS_ERROR_FAILURE file sync errors 2010-08-09 06:24:06 +00:00
Dan Stillman
1a7629a589 Closes #1710, Clipboard citation copy w/Ctrl-Alt-A always Ibid.
Frank's patch
2010-08-09 01:55:50 +00:00
Dan Stillman
521ab94e35 Ignore any mention of CVE-2009-3555 in error messages 2010-08-06 17:52:33 +00:00
Dan Stillman
bbc8f7812c Add ability to create Zotero Commons buckets via the UI
- "zc-test-" is currently prepended to bucket names
2010-08-06 17:42:14 +00:00
Dan Stillman
6ea7e3dd65 Fix error in Related Items dialog 2010-08-02 21:32:11 +00:00
Simon Kornblith
253ab1e86a closes #1567, Fullscreen does not restore 2010-08-02 02:55:05 +00:00
Simon Kornblith
021cbc8725 closes #1285, Add typeof checks to data read from scraper sandbox
use XPCSafeJSObjectWrappers to enforce security of everything coming out of translators. this seems to work, but needs testing.
2010-08-02 02:26:46 +00:00
Simon Kornblith
dff5adf480 addresses #699, Reconcile Zotero item types with CSL schema
maps dictionaryEntry and encyclopediaArticle to entry-dictionary and entry-encyclopedia respectively (instead of chapter)
2010-08-01 23:11:38 +00:00
Simon Kornblith
63f346b504 closes #1609, Bibliography printing broken
this currently leaks a hidden browser object, since deleting it seems to cause the print command to fail. this may not be a big issue, since this feature is used so rarely anyways...
2010-08-01 20:34:29 +00:00
Simon Kornblith
fe37dc73e1 restore copyright notice to citeproc.js (accidentally removed in last commit) 2010-08-01 20:16:14 +00:00
Simon Kornblith
685338b41a update to citeproc-js 1.0.50
From Frank's announcements:

In 1.0.45:

 Fix duplicate terminal punctuation
 affecting bibliography output.

 Eliminate dereferencing assignments, for
 compatibility with some JS implementations.

 Suppress duplicate spaces affecting some
 styles.

In 1.0.46:

 Add option to updateItems() and updateUncitedItems()
 to suppress sorting of the bibliography.

In 1.0.47:

 Fix a duplicate space issue.

 General refactoring of code for identifying an quashing
 duplicate punctuation and spaces.  The code should be
 easier to control when further issues involving punctuation
 arise down the road.

 Provide for replacement of the citation number in
 numbered styles with a slug, so that strings in a
 bibliography listing can be used in a template
 without rerendering.  This is useful in some server-side
 applications.

In 1.0.48:

 Permit author to vary between parallel citations. Useful
 for French case-and-commentary string cites.

 Permit author to vary between parallel citations. Useful
 for French case-and-commentary string cites.

 Fix bug in short form title support.

 Further fixes to quashing of duplicate punctuation
 and spaces.

 Fix issues with bibliography slug.

 Provide for parsing experimental variables out of the
 content of the note variable.  For use in advance
 testing of styles that require changes to the variables
 available in CSL, or supplied by the calling application.

In 1.0.49:

 Extend support for "parallel" legal citations to include
 case and comment string citations used in French legal
 writing.

 Fix XML parsing code in xmldom.js to screen XML comments
 from the processor.  Thanks to Carles Pina for reporting
 this fault (relevant to non-Firefox, non-gecko browsers).

 Tighten up conditions for suppression of the trailing year
 where the volume number and the year have the same value.
 Suppression will no longer occur when the rendered date
 contains additional details (day, month).

 Throw a more meaningful error when an invalid locale
 is requested.  Thanks to Carles Pina.

 Fix missing definition of quotes="false" in formats.js.
 Thanks to Carles Pina.

 Fix bug in handling of capitalized characters used in
 citeproc-js hackaround for multi-character initials.

In 1.0.50:

 Apply output-mode-specific text_escape function to
 affixes and delimiters.

 Strip XML declaration from CSL and locale strings
 received for parsing in the xmldom.js module.

 Add paranoia fallback to handle comment nodes that
 sneak past the XML parser.
2010-08-01 20:14:51 +00:00
Simon Kornblith
8fe9c5e9e7 closes #1684, checkbox to temporarily disable proxy code
also adds a parameter to disable proxy redirection by domain (although if I had known how much work would be involved in implementing this before I started, I wouldn't have bothered)
2010-08-01 20:10:18 +00:00
Simon Kornblith
84fcd7d4b8 oops: there is no wrappedJSObject for collectionsView 2010-08-01 19:57:42 +00:00
Simon Kornblith
b285f6a7d4 closes #1705, [PATCH] Item cited in document not reselected when cite reopened for editing 2010-08-01 19:56:45 +00:00
Simon Kornblith
c9003f1f40 closes #1706, [PATCH] Item with non-ASCII characters corrupted on save when Show Editor is open
The problem here was that entities weren't properly being encoded as Unicode RTF when the editor was used, because TinyMCE was replacing high characters with HTML entities that were not properly decoded. This is now fixed.
2010-08-01 19:53:08 +00:00
Dan Stillman
c7f025519b Fixes #1696, Group item reported missing from Zotero library on next citation edit
Was breaking when libraryID!=groupID
2010-07-26 17:43:58 +00:00
Simon Kornblith
aec3c4381f closes #1699, Simplified _zoteroFieldMap for citeproc-js (thanks to Frank) 2010-07-26 01:01:18 +00:00
Simon Kornblith
e6a97b46b2 closes #1698, bookAuthor -> container-author CSL mapping (thanks to Frank) 2010-07-24 17:41:56 +00:00
Dan Stillman
d8db1cd61f Store a space in WebDAV lastsync file to work around a server issue where timestamp of an empty file isn't updated on PUT 2010-07-23 18:07:53 +00:00
Simon Kornblith
d022b966fe tweak date regexp to handle WTN8601 properly 2010-07-21 19:52:28 +00:00
Dan Stillman
0acaf22576 Fix Edit Bibliography window on trunk (related to Fx2/3 code removal) 2010-07-13 19:07:08 +00:00
Dan Stillman
ccae2e0b7c Fix error removing >1000 items from a tag (due to compiled SQLite limit) 2010-07-13 19:00:58 +00:00
Dan Stillman
0b83c8c166 Auto-empty trash items older than 30 days by default
- Warning needed on upgrade about this
- Controlled by trashAutoEmptyDays hidden pref, with 0 disabling the functionality
2010-07-13 18:33:47 +00:00
Dan Stillman
9dad2c6048 Commons:
- Use same character-stripping logic as IA when looking for RDF file
- Better handling of empty RDF files
2010-07-13 17:47:01 +00:00
Dan Stillman
2d0874dd66 Remove old Commons code 2010-07-12 17:45:22 +00:00
Dan Stillman
43c0ae9e8a Commons: Fix authentication issue involving files with semicolons or other extended chars, but more fixes are needed on IA side 2010-07-12 17:36:05 +00:00
Simon Kornblith
8068c17f8f closes #1689, When editing a citation, the reference is not selected if it does not exist in the currently selected collection within the Zotero pane 2010-07-12 11:24:29 +00:00
Simon Kornblith
3571b41d95 pick running copy of Word for Mac as AppleScript target 2010-07-12 10:46:25 +00:00
Simon Kornblith
3b0ee0285b add SID to generated openurl 0.1 URLs 2010-07-11 08:02:28 +00:00
Dan Stillman
395833b940 Restore setTimeout() call removed in previous commit 2010-07-09 20:48:10 +00:00
Dan Stillman
92383c7f20 Addresses #1037, Remove Firefox 2.0/3.0-specific code 2010-07-09 20:25:17 +00:00
Dan Stillman
84cf9d8cbe Closes #1037, Remove Firefox 2.0/3.0–specific code 2010-07-09 20:10:43 +00:00
Dan Stillman
973d2cd38c Fix version in newer DB version error message (trunk and branch) 2010-07-09 05:16:13 +00:00
Dan Stillman
00611dc288 Fix message for newer DB version error 2010-07-09 05:10:48 +00:00
Simon Kornblith
d592d3156e Fix translation in Fx4 2010-07-08 22:45:42 +00:00
Dan Stillman
f3a8cbd993 Switch back to multiple items per Zotero Commons bucket
- Creating buckets not yet supported
- Some now-unused single-item-per-bucket code still needs to be removed
- Child attachments are not displayed in Zotero Commons pane
- Manual refreshing via bucket right-click (or a Firefox restart) is currently necessary after adding items
- Double-clicking bucket takes you to bucket page; double-clicking item takes you to named anchor
2010-07-07 18:34:09 +00:00
Dan Stillman
7ce0e9ee23 Don't cache HTTP GET requests in Zotero.Utilities.HTTP.doGet() 2010-07-07 18:28:25 +00:00
Simon Kornblith
2e951139fe use contentLength parameter to determine length of updateCSL.xsl rather than hardcoding a limit 2010-07-06 18:43:15 +00:00
Simon Kornblith
ca0328729a addresses #1691, Update Zotero.QuickCopy.getContentFromItems() for new citation API
fix up problems on first drag
2010-07-06 18:39:49 +00:00
Simon Kornblith
a857cb3e5b closes #1691, Update Zotero.QuickCopy.getContentFromItems() for new citation API
caches updateCSL.xsl, since apparently doing an XHR to load it during drags was breaking things
2010-07-06 18:17:45 +00:00
Dan Stillman
77ecfce0fe Addresses #1691, Update Zotero.QuickCopy.getContentFromItems() for new citation API
Frank's latest patch, but drag-and-drop is still broken for me on OS X. Need to see if this is just my working copy.
2010-07-06 17:42:41 +00:00
Dan Stillman
970c317095 Comment out init() call for Zotero.Connector, which hasn't yet been committed 2010-07-06 17:39:13 +00:00
Simon Kornblith
43c57ec18c closes #1688, Preferences window appears in wrong screen position on Windows 2010-07-06 10:37:16 +00:00
Simon Kornblith
35c44b7470 fix race condition 2010-07-06 10:11:25 +00:00
Simon Kornblith
139036490c a better way of getting the install directory in Fx4 2010-07-06 09:25:58 +00:00
Simon Kornblith
63e08cd714 addresses #1690, Modify all XPCOM components for Firefox 4.0b2+ 2010-07-06 09:02:35 +00:00
Simon Kornblith
59817af546 references #1691, Update Zotero.QuickCopy.getContentFromItems() for new citation API
put a string in date.literal, instead of the whole date object, when passing to citeproc-js
2010-07-06 07:55:07 +00:00
Simon Kornblith
10cbc0ceeb don't stick an extra newline between all bibliography entries (changes to citeproc-js RTF formatter code) 2010-07-06 07:23:10 +00:00
Simon Kornblith
477d0effe0 call integration.cleanup() before attempting to display any dialogs 2010-07-06 06:53:45 +00:00
Simon Kornblith
13f0b1bfd2 closes #1493, Style/Font Behavior In WP Plugins
closes #1325, better integration with word-processor styles

WinWord plug-in update is still to come
2010-07-06 06:47:59 +00:00
Simon Kornblith
1b353fb2b2 Update to citeproc-js 1.0.44
From 1.0.39:
 Fix a tiny bug that could cause erroneous position values when
 previewing under some circumstances, resulting in an incorrect
 cite form in preview, and a different (although correct) cite form
 in the document.

From 1.0.40:
 Avoid update to position data of other citations during
 previewing.  On-the-fly updates of related citations upon
 citation edit or insert following preview were broken, but
 should now work correctly.

From 1.0.41:
 Reset processor's internal last_name_rendered variable,
 to prevent previous runs of the processor from affecting
 bibliography output.

From 1.0.42:
 Provisional implementation of ellipsis truncation for
 creator listings as required by APA 6th, in anticipation
 of upcoming point release of CSL schema and specification.

From 1.0.43:
 In test.py, change the -E bundled code dump option to -Z,
 and describe as a Zotero bundle option in script help messages.

 Include an assignment of CSL.error to Zotero.debug in the Zotero
 bundle, so that error messages and warnings from the processor will
 pass through correctly, without crashing the processor.

 Render literal passthrough strings on date objects only when
 the year is included among the requested date elements.

 Add temporary code to normalize the structure of some date
 input objects.

 (... and so we bid a sad farewell to the Meaning of Life
 release.)

From 1.0.44:
 According to the CSL specification, group elements implicitly
 suppress output of term= and value= text elements, if at least
 one element (text, number, names or date) with a variable=
 attribute is in the group, and no such element will produce
 output.  This provides a flexible  and concise syntax for
 attaching customized labels to rendered elements.  An earlier
 version of citeproc-js always rendered empty dates as the short
 form of the "no date" term ("n.d.").  Experience showed this was
 undesirable, and the behavior was withdrawn.  However, the
 code that reported date elements as always producing output
 lingered on, and it was the cause of incorrect output in recent
 testing.  This has been corrected in this release.

 This release also correctly reports dates with only a literal (non-
 parsed) form as non-empty to the same implicit conditional
 code in an enclosing group element.
2010-07-06 04:29:55 +00:00
Dan Stillman
34800ec810 Don't show context menu for source pane headers (e.g., "Group Libraries") 2010-07-03 20:14:30 +00:00
Dan Stillman
37e1245aaf Closes #1691, Update Zotero.QuickCopy.getContentFromItems() for new citation API
Thanks to Frank for the patch
2010-07-02 06:09:46 +00:00
Dan Stillman
953fa4a660 Closes #1687, Append reporter name to title in UI for law cases
Slightly modified verison of Frank's patch
2010-06-30 06:10:15 +00:00
Simon Kornblith
5649e26ec2 closes #1686, Set selected item titles with getDisplayTitle() (thanks to Frank) 2010-06-30 05:34:48 +00:00
Simon Kornblith
aa19d412c1 don't kill Zotero if for whatever reason deleting the integration pipe fails 2010-06-30 03:35:36 +00:00
Simon Kornblith
2d92f3776e pass "false" and not null to nsIProcess.run (not that it seems to make any difference) 2010-06-30 03:25:54 +00:00
Simon Kornblith
f11986ce04 - offer to remove Zotero integration pipe owned by root
- locale updates for this patch and r6207
2010-06-30 03:24:14 +00:00
Dan Stillman
1d08b9ec31 Remove debug output 2010-06-29 16:54:30 +00:00
Simon Kornblith
09416a5738 closes #992, COinS should have an appropriate rfr_id to identify what program was used to generate the span 2010-06-29 07:03:30 +00:00
Simon Kornblith
23f21bac56 fix formatting from previous patch 2010-06-29 06:43:39 +00:00
Simon Kornblith
78d46dc0f0 closes #1680, Allow repeat use of item in a citation (patch due entirely to Frank)
see notes at referenced ticket for information re: modifications in behavior
2010-06-29 06:34:20 +00:00
Dan Stillman
40b6ed19f8 Remove debug line 2010-06-29 06:07:06 +00:00
Dan Stillman
ae65267d5d Use DB cache and new translators.index file in XPIs to skip unnecessary translator extraction on upgrades 2010-06-29 06:04:04 +00:00
Simon Kornblith
0876e689c8 remove the option to disable proxy detection from the proxy dialog, since it makes less sense now 2010-06-29 05:28:13 +00:00
Simon Kornblith
79f5204050 remove some debug code from the last patch 2010-06-29 05:27:32 +00:00
Simon Kornblith
9914eee1f1 closes #1685, notificationbox warnings for proxy 2010-06-29 05:25:41 +00:00
Simon Kornblith
8f1298f45b closes #1683, Fix small typo that blocks style install
thanks Frank!
2010-06-28 19:42:48 +00:00
Simon Kornblith
ee8c60939a open a transaction for translatorCache updates 2010-06-28 16:54:06 +00:00
Simon Kornblith
b87b46aa95 Update to citeproc-js 1.0.38
From Frank's announcement:

 Fix appendCitationCluster() to work with the API revision
 made to processCitationCluster() in point release 1.0.28.

 When user provides a cite suffix that ends with a full stop,
 suppress the normal inter-cite join.
2010-06-28 09:31:35 +00:00
Simon Kornblith
bddb583e43 - cache translators in DB to reduce startup times on Windows
- fix some error handling in translate.js
2010-06-28 09:07:44 +00:00
Simon Kornblith
903d37c434 update to citeproc-js 1.0.37
From Frank's announcement:

 Quash duplicate terminal punctuation at the end of citations.
 This can happen where an abbreviated term such as id. or
 ibid. is rendered at the end of a citation in a note style,
 in which the note is terminated with a period.

 Eliminate implicit for loops in array constructs, which is
 sadly not available in Chromium JS engine.
2010-06-28 02:47:46 +00:00
Simon Kornblith
05583b1992 closes #1099, Add cancel button to Edit Bibliography
closes #744, Select multiple items/entire collection in edit bibliography dialog

- adds "Cancel", "Revert", and "Revert All" buttons to edit bibliography dialog
- permits multiple item selections in edit bibliography dialog
- removing items in the edit bibliography dialog now leaves the citations intact, but removes them from the document
2010-06-28 02:38:48 +00:00
Simon Kornblith
68c4a47bf3 - don't automatically associate .edu sites (except Project MUSE)
- if a docShell has allowMetaRedirects turned off (as is the case in our hidden browsers), don't proxy
2010-06-25 21:29:22 +00:00
Simon Kornblith
afd758f509 support additional parameters in integration pipe
(these are not urgent, and i don't actually plan on using them at the present, but they might be a good idea)
2010-06-24 09:54:46 +00:00
Simon Kornblith
8e7d467ddf automatic smart quotes when saving from editor 2010-06-22 05:52:57 +00:00
Simon Kornblith
18025da6a3 remove debug code 2010-06-20 19:13:20 +00:00
Simon Kornblith
303f980954 Fix for "The command is not available because no document is open" error (part 2) 2010-06-20 10:48:38 +00:00
Simon Kornblith
4556ea3f10 fixes #1668, Items added in multiple mode not recognized unless visible (twice)
fix Accept button issue by using getAttribute() rather than id property, but also scroll to newly inserted citation, since it's probably the desirable behavior
2010-06-18 18:19:52 +00:00
Simon Kornblith
13ae25e445 Commit citeproc-js 1.0.36
From Frank's announcement:

 Refresh citations in which names or year suffixes have
 (potentially) changed.
2010-06-18 05:31:03 +00:00
Simon Kornblith
d73b6f1171 - commit citeproc-js 1.0.35
From Frank's announcement:
 Simplify save/restore operations for previewing.

 Tie in tainting code for disambig values registered via disambig_cites.js.
 Possibly over-aggressive about rerendering now, but it works.

In quick initial testing, at least, this release appears to be eerily stable in Zotero.
2010-06-17 17:30:06 +00:00
Simon Kornblith
112b6d22e8 closes #1598, Possible to click Insert Citation twice
When the user attempts to access Integration functionality while a request is still in progress, we now bring Firefox/Zotero to the foreground.
2010-06-17 06:38:03 +00:00
Simon Kornblith
6d4d953859 - Update to citeproc-js 1.0.34
From Frank's 1.0.31 announcement:

 Extensions to the test fixtures for previewCitationCluster(),
 which revealed shortcomings in the name state restoration
 code.

 Properly restore name state in previewCitationCluster().

 Roll back previewCitationClusterStatic() command that
 was introduced in the last (unannounced) 1.0.30 release.
 Discussion and more careful thought showed that it is not
 safe and not generally a good idea to make blind assumptions
 about document state.

From Frank's 1.0.33 announcement:

 In preview mode, avoid tampering with the registry data,
 of items in the citation to be previewed that already
 exist in the registry.  Fixes errors in subsequent
 rendering of year suffixes.

 Suppress redundant return value for current cite, when it is
 tainted by an update by processCitationCluster().

From Frank's 1.0.34 announcement:

 Include year suffix in clone of disambiguation
 configuration.  Failure to include this parameter
 appears to have been behind some intermittent
 glitches in preview handling of year suffixed
 citations.

 Avoid processor crash when unregistered citation
 objects are encountered in preview mode.  The crash
 points occur during tainting, which is irrelevant
 in preview mode, so no harm is done; but I'm not
 really sure why this would ever happen.  Possibly
 specific to the Zotero version used for testing.

 Add a couple of paranoia operations to processCitationCluster():

   Issue a bogus warning citation in the event of a processor
   crash.  This should come out for production.

   Slice citationsPre and citationsPost when they enter
   the processor.  I've been exploring some instability
   with large numbers of same-author/same-year cites in
   Zotero, and thought that mallability of list input
   might be part of the problem.  No idea whether these
   lists can or do change length or content during processing,
   but just in case.
2010-06-17 05:42:00 +00:00
Simon Kornblith
13a3524f0c closes #1665, Single cursor position in addCitation dialog (thanks Frank!) 2010-06-13 23:22:34 +00:00
Simon Kornblith
1da48cf8d2 - implement previewCitationCluster(), restoreProcessorState(), new "bibchange" flag in processCitationCluster() output, and new opt.sort_citations flag in word processor integration
- upgrade to citeproc-js 1.0.29

From Frank's 1.0.25 announcement:

 Provide new command, previewCitationCluster(), that returns
 string for hypothetical citation at specified position,
 without affecting processor state.

 Fix bug that would have cause appendCitationCluster() to
 run updateItems() unnecessarily.

 Provide for forced generation of citationID, for internal use
 in previewing.

From Frank's 1.0.26 announcement:

 Implement new command restoreProcessorState(), for use in,
 er, restoring the processor state, when position variables
 and citation sort keys are already known.

From Frank's 1.0.27 announcement:

 This fixes a couple of obvious problems in the code of the new
 restoreProcessorState() command.

From Frank's 1.0.28 announcement:

 This version introduces a significant change to the return
 value of processCitationCluster().  It is now an array with
 two elements, the first being a JS object that serves as a
 data segment, and the second the list of two-element arrays
 representing insertion indexes and strings for insertion
 (as previously documented).  An API change of this scale
 probably calls for some more visible sign in the version
 numbering, but the original statement on versioning says
 that the major and minor numbers will align with the CSL
 schema, so we stay at level 1.0.

 The data segment referred to above contains just one element
 currently, "bibchange", which is true if processing the
 citation results in any change affecting the bibliography.

 This release also introduces one change and one addition to
 style configuration flags.  The flag at citation.opt["citation-number-sort"]
 has been moved to opt.citation_number_sort, for clarity and
 consistency.  A new flag, opt.sort_citations, is true if
 citations are sorted by the style in any way.

From Frank's 1.0.29 announcement:

 Complete reimplementation of cite-level disambiguation.
 The new code is more compact and maintainable, and
 avoids thrashing behavior that afflicted the previous
 code when a large number of cites required both
 add-names and year-suffix disambiguation.

 Suppress year suffix when fresh ambig keys are generated.
 Inserts by a plugin affecting year suffixes should now be
 correctly handled.
2010-06-13 22:53:57 +00:00
Simon Kornblith
25f3b150e4 - update to citeproc-js 1.0.24
From Frank's 1.0.23 announcement:
 Cope with two disambiguation cases, involving add-names and
 add-givenname, that succeeded in crashing the processor.

From Frank's 1.0.24 announcement:
 Cope with item IDs of numeric type, and roll back
 one patch from 1.0.23 that becomes unnecessary as
 a result.

Together, these updates fix several issues with citation previewing.
2010-06-06 06:46:10 +00:00
Simon Kornblith
d0441d334e commit Rintze's changes to translate.js for Scaffold compatibility 2010-06-06 03:11:24 +00:00