Commit graph

13103 commits

Author SHA1 Message Date
Dan Stillman
fd50a5b65e Switch to UTF-16 helper function for xul.dll binary patching 2023-05-26 06:45:23 -04:00
Dan Stillman
889a812fdc Replace "FirefoxCP" with "ZoteroCP" in subprocess names
"Isolated Web Content", "Socket Process", "Web Content", etc.

Closes #3137
2023-05-26 06:45:23 -04:00
Dan Stillman
cd20df8d74 Fix sw_vers being run repeatedly in View Output window on macOS
Fixes #3136
2023-05-26 06:45:23 -04:00
Dan Stillman
d14d281e7c Avoid warning about null bytes when checking for Git LFS checkouts 2023-05-26 02:08:17 +00:00
Dan Stillman
febcf2568e Update locales from Transifex and merge new English strings 2023-05-25 21:56:32 -04:00
Dan Stillman
3f739fc1b4 "Capitalize" → "Fix Case" for creator context menu
https://forums.zotero.org/discussion/105117/zotero-7-thank-you-for-adding-right-click-case-change-for-author-names
2023-05-25 21:56:31 -04:00
Dan Stillman
b2b768cd4b Fix fileQuitItemUnix is null error in PDF reader window 2023-05-25 21:56:31 -04:00
Abe Jellinek
4cfe682367
Remove outdated startup error messages (#3138) 2023-05-25 21:38:12 -04:00
Abe Jellinek
42572efca9 Fix error when adding link attachment with unparseable URL
https://forums.zotero.org/discussion/105158/zotero-7-beta-attach-link-to-uri-logosres-does-not-work-any-longer
2023-05-25 18:45:48 +03:00
Abe Jellinek
a4c3f5267b Fix ScienceDirect PDF downloads
ScienceDirect sometimes puts the `name` directive at the end of the Content-Type
header instead of in Content-Disposition. That isn't strictly spec-approved, but
there are other directives (`charset` and `boundary`) that can also be appended
to Content-Type per the spec. We want to strip them before looking for handlers.

https://forums.zotero.org/discussion/105194/sciencedirect-pdf-downloads-not-working-zotero-7
2023-05-25 17:57:32 +03:00
Abe Jellinek
76b7fd0dc1 Set preventDefault flag when URL is passed to CLH
Fixes #3132
2023-05-25 17:28:16 +03:00
Dan Stillman
117dbe1fe0 Clear Zotero.skipLoading after data directory tests
This was causing a startup error in the re-enabled debug output tests,
which don't reset app state.
2023-05-25 05:45:53 -04:00
Dan Stillman
6e2ec2300d Fix checking for Firefox profiles high up in filesystem
This was triggering an erroneous warning dialog about a failure to check
for Firefox profiles during Linux tests (where the profile is at
something like /tmp/tmp.l5phnqSxBH/Zotero), but it could also affect a
custom profile directory location.
2023-05-25 03:37:06 -04:00
Dan Stillman
feb12fafe8 Add Git LFS checkout checks to app build script
For people with existing repos who haven't re-run check_requirements
2023-05-25 03:24:18 -04:00
Abe Jellinek
6405997723 Use Zotero.appName in window title 2023-05-25 09:13:42 +03:00
Abe Jellinek
91fec9024c Bidi: Fix control characters appearing in reader window titles on Windows
Fix in 6d5ce578e4 only affected tabs.

Fixes #3135
2023-05-25 09:05:36 +03:00
Dan Stillman
4ca4278635 Update Word for Mac submodule 2023-05-24 17:30:14 -04:00
Abe Jellinek
794b27c1ad Test debug output logging again
Now that we run tests in Zotero with application menus.
2023-05-24 20:59:29 +03:00
Abe Jellinek
087a9859b4 Fix preference binding issues and "Include Zotero Links" checkboxes
- Set zotero-noteQuickCopy-menu's preference attribute to the correct key
- Warn about all ID-ish preference attribute values
  - zotero-noteQuickCopy-menu's preference attribute was being set to the ID of
    a now-nonexistent <preference> element. preference attribute values should
    be preference keys now, but we were only warning if the associated
    <preference> element was actually there
  - We can't warn in all cases where the preference doesn't yet exist, because
    some preferences don't have default values, and we shouldn't limit to
    preferences that don't exist, because then the warning will stop showing
    after the preference is persisted once
- When a <preference> ID is replaced by the associated key, update the
  preference attribute so future syncFromPref() and syncToPrefOnModify() calls
  will set the correct preference
- Listen to a range of events on all bound nodes, no matter their type
- Don't resolve _firstPaneLoadDeferred until actually done loading

Fixes #3131.
2023-05-24 20:46:00 +03:00
Martynas Bagdonas
26068a855c Make note editor iframe an XUL element to avoid focus anomalies
Fixes #3128
2023-05-24 17:38:15 +01:00
Dan Stillman
722287b81a Switch back to @mozilla.org/browser/clh;1 and fix tests
In Firefox 102, `-file` was being swallowed by `nsBrowserContentHandler`
in BrowserContentHandler.jsm, so ab7d916e0 overrode that by using the
same contract id for our main nsICommandLineHandler in
zotero-service.js. But `nsBrowserContentHandler` also handles `-chrome`,
which we were using in tests to pass runtests.html. There's no need to
pass in dynamically though -- we can just hard-code that and open the
window ourselves.
2023-05-24 08:21:16 -04:00
Dan Stillman
744e73bfdb Revert "fx-compat: Handle files opened via OS (#3120)"
This reverts commit ab7d916e0d.

Switching to `@mozilla.org/browser/clh;1` broke tests and possibly other
command-line things, so disable for now.
2023-05-24 06:53:23 -04:00
Dan Stillman
0b1d958a86 Fix erroneous warning if Firefox profile directory can't be found
`Zotero.File.getContentsAsync()` now uses IOUtils rather than OS.File
2023-05-24 06:53:23 -04:00
Dan Stillman
14875c962b Fix broken building on Windows from de154ab407 2023-05-24 08:29:43 +01:00
Dan Stillman
9da76eab43 Don't open second window when launching a second time 2023-05-24 02:25:20 -04:00
Dan Stillman
0734f6d55b Add commented-out line to save copy of Firefox Windows installers
For fetch_xulrunner development
2023-05-24 02:25:20 -04:00
Dan Stillman
f5433f04e6 Update searchfox link to permalink 2023-05-24 02:25:20 -04:00
Abe Jellinek
ab7d916e0d
fx-compat: Handle files opened via OS (#3120) 2023-05-24 01:37:41 -04:00
Abe Jellinek
caa1036da2 Remote translation: Don't use wantGlobalProperties
Not necessary - just use the properties we inherit from contentWindow. This
fixes the DOMParser constructor, which fails if called without a window context
from a non-system principal.

https://forums.zotero.org/discussion/105163/zotero-7-doi-translator-broken-in-scaffold
2023-05-23 22:30:24 +03:00
Abe Jellinek
fd6ea99967 Item box: Always save current item when switching items
Fixes #3125
2023-05-23 19:40:09 +03:00
Abe Jellinek
61749d39a6 Item box: Populate both fields on creator autocomplete click
Fixes #3129
2023-05-23 19:06:56 +03:00
Martynas Bagdonas
04a44cfbaa Update pdf-reader submodule 2023-05-23 12:00:17 +01:00
Dan Stillman
8440501ad2 Remove unused Zotero.isBigSurOrLater property 2023-05-23 01:55:31 -04:00
Dan Stillman
f9dab9b041 Show correct OS info in error reports 2023-05-23 01:55:31 -04:00
Dan Stillman
478dcc4f0f Add Zotero.Utilities.Internal.subprocess(command, args)
To run a short-lived command and return stdout

The Subprocess module can also start long-running process and
communicate with them, but we'll implement something different for that
if we need it.
2023-05-23 01:46:25 -04:00
Dan Stillman
522de4ad92 Add 32/64-bit info after version number in about dialog on Windows/Linux 2023-05-22 23:58:00 -04:00
Dan Stillman
de154ab407 Skip check for "Zotero" in xul.dll on macOS 2023-05-22 08:23:53 -04:00
Dan Stillman
39b8a33166 Fix Git LFS checkout check when not in repo root 2023-05-22 06:39:03 -04:00
Dan Stillman
0c3d8eeb6f Upload deployment ZIP from 'main' branch 2023-05-22 06:27:53 -04:00
Dan Stillman
66623b945e Temporary fix for context-menu options getting triggered on Windows
https://forums.zotero.org/discussion/105103/right-click-on-collections-or-items-not-functioning-properly-in-zotero-7
2023-05-22 06:16:53 -04:00
Dan Stillman
840a98ff40 Update app build scripts for branch reshuffling
`master` → `6.0`, `fx102` → `main`
2023-05-22 04:10:21 -04:00
Dan Stillman
55fe6f33f5 fx-compat: Fix XMLSerializer calls
https://forums.zotero.org/discussion/105118/zotero-7-error-upon-exporting-in-mods-format
2023-05-22 01:34:41 -04:00
Dan Stillman
9622fcccdb Show consistent paths for missing scripts in check_requirements 2023-05-22 01:25:58 -04:00
Dan Stillman
5d0c1f38ef Add check for Git LFS in check_requirements 2023-05-22 01:25:54 -04:00
Dan Stillman
08213eb8fb fx102 branch is no more 2023-05-21 18:52:26 -04:00
Dan Stillman
4eb951c977 Add 7.0 beta build script 2023-05-21 18:38:38 -04:00
Dan Stillman
879da4feef Don't include 6.0 builds in incrementals 2023-05-21 22:37:42 +00:00
Dan Stillman
c653449cc0 Increase active tabs count from 2 to 3 on <=8 GB systems
To match current Zotero 6 behavior on non-Windows systems
2023-05-20 19:12:19 -04:00
Dan Stillman
54d56f468b Update styles and translators 2023-05-20 16:10:57 -04:00
Dan Stillman
4a68c04891 fetch_xulrunner: Use local copies of Firefox on Windows if available
Allows for faster fetch_xulrunner development without repeatedly
downloading Firefox from Mozilla servers. Already possible on macOS.
2023-05-20 12:52:12 +01:00