mirrors/zotero
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions
13794 commits 9 branches 364 tags 290 MiB
Commit graph

9496 commits

Author SHA1 Message Date
Martynas Bagdonas
630eccf72f Fix context pane note back button regression 
Fixes #3616
 2024-01-29 15:18:37 +08:00
Martynas Bagdonas
3a3a81b0ed Add missing "Use Dark Mode for Content" to reader window menu 
Fixes #3592
 2024-01-29 15:18:37 +08:00
Martynas Bagdonas
d606644a78 Localize "Print" and "Save As" in reader tab/window File menu 2024-01-29 15:18:37 +08:00
Martynas Bagdonas
5eb0ed109b Fix broken Fluent localization in reader window menu 2024-01-29 15:18:37 +08:00
Dan Stillman
0045cd1b7a Fix search bar in classic citation dialog and Related Items dialog 
Fixes #3599
 2024-01-29 02:13:05 -05:00
Adomas Venčkauskas
452ee3a55b Fix citation dialog open documents not working when a standalone pdf is open 
Closes #3621
 2024-01-29 09:11:12 +02:00
Abe Jellinek
7f993167b4 Fix regression that broke Date field tooltip 
Field inputs are XUL in Z6, HTML in pre-redesign Z7, and XUL again in
post-redesign Z7. We switched to the title attribute for HTML but didn't
switch back to tooltipText when going back to XUL.
 2024-01-26 13:40:16 -05:00
Abe Jellinek
00ca99ae86 Item box: Fix Short Title rendering as multiline 
Also, rerender editable-text when noWrap changes.
 2024-01-26 13:38:29 -05:00
Dan Stillman
1cc5c1ce2e Disable automatic safe mode for now 
Until we can figure out why some shutdowns are counting as crashes

https://github.com/zotero/zotero/issues/3196
 2024-01-26 07:35:09 -05:00
windingwind
c21c5632c2
Fix attachment row annotation button bug (#3577) 2024-01-26 00:51:27 -05:00
windingwind
63c532398b Fix sidenav default buttons display bug 2024-01-24 23:32:24 -05:00
windingwind
665f812bd1 Fix sidenav button visibilities update bugs 2024-01-24 23:32:24 -05:00
windingwind
7fe01d6c03 Clicking filename label should focus/blur field in attachment box 2024-01-24 23:32:24 -05:00
abaevbog
f990cb3f4b tabs menu updates 
- CMD-F will focus the input field
- ArrowLeft/Right keypresses are ignored
- Reset focus index on the focus of the input field
 2024-01-24 23:32:24 -05:00
abaevbog
1a82ae5c3b collection filter sizing tweaks 
- ensure filter field is hidden if the pane is collapsed
- JS-based max-width setting to prevent overflow outside of collection pane
 2024-01-24 23:32:24 -05:00
Abe Jellinek
608b732fbb Open tabs menu: Move margin/padding to SCSS 2024-01-24 23:32:24 -05:00
Abe Jellinek
873c87956c Open tabs menu: Escape regex special characters 
So we don't throw an error/match inappropriately when the filter
contains backslashes, periods, pluses, and so on.
 2024-01-24 23:32:24 -05:00
Abe Jellinek
a1134255ee Always rerender sidenav, even if item doesn't change 
Feeds issue remains.
 2024-01-24 23:32:23 -05:00
Abe Jellinek
2b50536775 Tweak method name 2024-01-24 23:32:23 -05:00
Dan Stillman
c2cc5e1935 Separate lines for extension-change confirmation into two strings 2024-01-24 23:32:23 -05:00
windingwind
4f73ea0cfa Fix attachment box rename 2024-01-24 23:32:23 -05:00
Abe Jellinek
3472d6cabe Prevent window overflow in Standard mode 2024-01-24 23:32:23 -05:00
Dan Stillman
613a907f3e Change pref from reader.useDarkModeForContent to reader.contentDarkMode 2024-01-24 23:32:23 -05:00
abaevbog
620b35ab78 minor focus tweaks 
- after an item is added via "Add item by identifier" panel, end
focus to that item in itemTree.
- restored default behavior when the focus remains visible around an
element when all menupopups open, except for the item type menu in itemBox.
- opening item type menu will still hide the focus-ring
 2024-01-24 23:32:23 -05:00
abaevbog
ed8e3f142b itempane keyboard navigation 
- right/left arrows on section header expand/collapse the sections
- space/enter on section header toggle section collapsed/expanded
- tab from the header goes through the header's buttons and then
tabs into the section if that's opened
- arrow up/down on the header jumps to the previous/next header
- space/enter on clickable elements simulate a click
- if there is a pinned section, tab from the title will focus its header
 2024-01-24 23:32:23 -05:00
windingwind
3bdcf34a89 Fix stacked mode layout when toggle item pane 2024-01-24 23:32:23 -05:00
windingwind
7f58873e0b Fix item pane size when switching to note in stacked mode 2024-01-24 23:32:23 -05:00
Dan Stillman
1d8baa635a New app icons 2024-01-24 23:32:22 -05:00
Tom Najdek
ccfc3127ba Tweak padding in the tag selector list 2024-01-24 23:32:22 -05:00
Dan Stillman
61cca0fc69 Use Fluent instead of DTD for "Use Dark Mode for Content" string 2024-01-24 23:32:22 -05:00
abaevbog
11fc1ebd8e remove "Go to this item online" tooltip from url field in itembox 
Also:

- set the .tooltiptext for options button in fluent file, so that text
shows up on hover
- added tooltiptext to creator + and - buttons
 2024-01-24 23:32:22 -05:00
Abe Jellinek
b8f2aaafa9 Attachment preview: Fix cut-off snapshots 
Also:
- Prevent selecting any text within the snapshot
 2024-01-24 23:32:22 -05:00
Abe Jellinek
832a6f3eff Fix right-click -> Merge Items... 2024-01-24 23:32:22 -05:00
windingwind
0cd7a52dc0 Fix attachment preview retry and error catch 2024-01-24 23:32:21 -05:00
windingwind
1c343ee820 Fix viewItem unnecessary scroll 2024-01-24 23:32:21 -05:00
windingwind
86947d7154 Remove attachment-preview-box 2024-01-24 23:32:21 -05:00
Abe Jellinek
3ac8f803c9 Fix duplicate creator context menus, extract utility function 2024-01-24 23:32:21 -05:00
Abe Jellinek
f468245caf Attachments box: Don't set this._item to non-regular item 
Fixes occasional errors due to `getAttachments()` being called on a
non-regular item in `updateCount()`.
 2024-01-24 23:32:21 -05:00
Martynas Bagdonas
c208325aeb Add menu option to toggle dark mode for reader content 2024-01-24 23:32:21 -05:00
Abe Jellinek
c549a96834 Restore notes-box add button 2024-01-24 23:32:21 -05:00
Tom Najdek
03be35426c Couple of small fixes to the tag selector 
* Add bottom padding
* Increase padding for macOS 0-width scrollbars
 2024-01-24 23:32:21 -05:00
Dan Stillman
f084b8c8ad Move density options to separate submenu in View 2024-01-24 23:32:20 -05:00
abaevbog
4a096665a0 refresh collectionTree rowMap after row is added 
It prevents the trash row from getting wrong offset and overlapping
with the row above it
 2024-01-24 23:32:20 -05:00
Abe Jellinek
be3d7c95f9 Match Reset Sync with "Sync Reset Options" 
Only adding warning2 because that's really the only relevant, searchable part of the warning.
 2024-01-24 23:32:20 -05:00
Abe Jellinek
05747f050a Fix undefined errors in feed settings window 2024-01-24 23:32:19 -05:00
windingwind
982289b484 Fix dialog background 2024-01-24 23:32:19 -05:00
Tom Najdek
2f9a12c2da Improve "Run JavaScript" dialog 2024-01-24 23:32:19 -05:00
Tom Najdek
a54ed665bf Improve style editor dialog 2024-01-24 23:32:19 -05:00
Tom Najdek
c514f92f9b Update csl editor theme based on system color scheme 2024-01-24 23:32:19 -05:00
Tom Najdek
d99ad84d4c Improve long tag fixer dialog 2024-01-24 23:32:19 -05:00
Tom Najdek
f0de6d0d57 Tweak spacing in select items dialog 2024-01-24 23:32:19 -05:00
Tom Najdek
701c76aa3f Redesign RTF Scan wizard 2024-01-24 23:32:19 -05:00
Tom Najdek
b30e975379 Inject custom styles into <wizard> 
<wizard> is a custom element built-in in FF. This commit monkey-patches
attachShadow to inject custom styles into the shadow root of <wizard>.
 2024-01-24 23:32:19 -05:00
Abe Jellinek
37d2b41778 Make clicky item icons match line height 2024-01-24 23:32:18 -05:00
Abe Jellinek
1d662b9fef Preferences: Fix and improve search 2024-01-24 23:32:18 -05:00
Abe Jellinek
fbbe9625fc Focus new tag when popup is opened 2024-01-24 23:32:18 -05:00
Abe Jellinek
6948252e32 Prevent collapsing / hide twisty in tags popup 2024-01-24 23:32:18 -05:00
Abe Jellinek
8e3abd8706 Add padding to reader tags popup 
And move styles to SCSS.
 2024-01-24 23:32:18 -05:00
Abe Jellinek
482e436203 Import SCSS in reader windows 
Fixes unstyled tags popup.
 2024-01-24 23:32:18 -05:00
Abe Jellinek
b391b6ca21 Tags box: Fix tag being saved every time autocomplete popup hides 2024-01-24 23:32:18 -05:00
Dan Stillman
f2bf40a314 Don't default existing users to Compact 2024-01-24 23:32:18 -05:00
Abe Jellinek
99b0411857 Return created collection from newCollection() 
Regression from fd0664bfb06409118ecaff73e064ab9c3103d823
 2024-01-24 23:32:17 -05:00
Abe Jellinek
57a1214eaa Remove reader pointerdown listener on close 
Avoids a memory leak.
 2024-01-24 23:32:17 -05:00
Abe Jellinek
2624770cea Remove debug from collapsible-section 2024-01-24 23:32:17 -05:00
Abe Jellinek
49fe2b98d9 Restore tag autocomplete popup 
Regression from 275ea6f because of a duplicate element ID. Now we only create
one popup, even if there are multiple tags-boxes.
 2024-01-24 23:32:17 -05:00
windingwind
b2ce3d4a5c Fix sidenav button default status 2024-01-24 23:32:17 -05:00
windingwind
365e97ba1e Fix quick search does not re-run when changing mode 2024-01-24 23:32:17 -05:00
Dan Stillman
0c089efd8a More attachment box fixes 
- Only try to show preview or check file existence for file attachments
- Use fileExists() for file check
- Show Accessed for linked-URL attachments
 2024-01-24 23:32:17 -05:00
windingwind
61a5704dd4 Fix attachment box bugs 2024-01-24 23:32:17 -05:00
Dan Stillman
b34d0d2acc Fix regression in Zotero.FullText.canReindex() 2024-01-24 23:32:16 -05:00
Dan Stillman
3b9afcc500 Add Zotero.FullText.canIndex() 
Currently identical to canReindex(), but in theory attachments aren't
supposed to be reindexable if they're already fully indexed
 2024-01-24 23:32:16 -05:00
Bogdan Abaev
3338b4b285 new item focus handling tweaks 
- properly re-focus previously focused item type menu in itemBox
- fix strange behavior of re-emerging item type menu popup caused by
itemBox.focusFirstField
- force the focus-ring to be around the itemType menu
 2024-01-24 23:32:16 -05:00
Bogdan Abaev
b6d5a52417 additional focus management for popups 
When a menupopup is opened, the active element does not change, so
their focus-ring will be hidden until the menupopup closes for it to be
less distracting.

When a panel popup is opened, the focus will be moved inside
of the panel, so we keep track of whichever element was previously
focused, and re-focus it when the panel goes away.

Minor reorganization of focus-ring mixin to use variables instead
of parameters to make hiding of focus-ring easier.
 2024-01-24 23:32:16 -05:00
Dan Stillman
1427e3e324 Open item pane if closed on New Item 2024-01-24 23:32:16 -05:00
Bogdan Abaev
8e4fd75f1d passing newItem tests 2024-01-24 23:32:16 -05:00
Bogdan Abaev
99ab42a674 Prevent trash row from receiving focus on Enter in filter box 
Prevent trash/duplicated/unfiled/etc. rows from getting focused on Enter
if it is the currently selected collection row that technically
passes the filter and Enter is pressed.
 2024-01-24 23:32:16 -05:00
Bogdan Abaev
2c97a7a03e avoid blinking of focused collection row on escape 
Make sure that on escape, the focus is moved to collectionTree strictly
once all filtered rows are rendered. Minor refactoring to achieve
it, since setFilter is async.
 2024-01-24 23:32:16 -05:00
Bogdan Abaev
0f0badea27 restore collection scroll position after filter 
Before filtering starts, save the selected row, scroll position, and
which rows were collapsed before filering, and restore them once the
filtering is over if a row was focused during filtering.
 2024-01-24 23:32:16 -05:00
yexingsha
6e7c80d97b changed all font-weight: bold/590 to 600 2024-01-24 23:32:15 -05:00
Abe Jellinek
ee5106939c Potentially fix Linux popup positioning issue 2024-01-24 23:32:15 -05:00
windingwind
f039124312 Use html label in info table 2024-01-24 23:32:15 -05:00
windingwind
d00fc7ca22 Fix attachment box info table layout 2024-01-24 23:32:15 -05:00
windingwind
3603254d35 Fix attachment row rendering bug with web attachment 2024-01-24 23:32:15 -05:00
windingwind
607f9814a0 Fix uncaught errors on item.save() coming from attachmentBox 2024-01-24 23:32:15 -05:00
windingwind
6af4605bd0 Implement attachment preview 
- Implement attachment preview
- Implement attachment-box redesign
- Make filename editable
- Use new reindex icon
- Update attachment note layout
- Fix reader.js eslint errors
- Add fallback attachment icon and use redesign
- Use attachment preview for regular items
- Fix pinned pane not exists error
- Double click preview to open to page
- Fix itemPane pin bug
- Preload preview iframe
- Fix item pane scroll
- Add media preview support
- Fix item pane scroll bar on macos
- Fix reader sidebar with standalone attachment
- Fix attributeChangedCallback
- Add attachmentBox _updateAttachmentIDs
- Make attachment notes readonly and simplify note window script
- Implement convert attachment note to new note
- Support preview dragging
- Annotations box redesign
- Support custom buttons in the collapsible-section
- Add preview toggle button
- Fix collapsible section attribute listener
- Make attachment box notify sync to fix errors in test
 2024-01-24 23:32:15 -05:00
windingwind
2a5d713f98 Move drag handler into utilities_internal 2024-01-24 23:32:14 -05:00
Abe Jellinek
9a0a15abbe Don't show string "PLACEHOLDER" in menu while localization runs 
Ideally we should cache these/not recreate the menuitems every time, or
something like that, so that localization pop-in doesn't happen at all. But a
brief flash of an empty menuitem is better than a brief flash of placeholder
text.
 2024-01-24 23:32:14 -05:00
Abe Jellinek
f44cc548f9 Locate menu: Get selected item(s) from current tab 2024-01-24 23:32:14 -05:00
windingwind
424afb9af6 Fix splitter style 2024-01-24 23:32:14 -05:00
yexingsha
cf241447ab fixed some spacing in collectionTree and itemTree 2024-01-24 23:32:14 -05:00
Bogdan Abaev
30b4577283 pinned panes for reader contextPane 
When tab selection changes, scroll to the pinned pane if there is one.
 2024-01-24 23:32:14 -05:00
Bogdan Abaev
6ac6c2582d do not reopen collapsed itemPane on item change 
To preserve the proper scroll behavior to top pane/pinned pane on item
change, remember which pane needs to be scrolled to when itemPane is
collapsed, and scroll to it when the itemPane is expanded.
 2024-01-24 23:32:14 -05:00
Abe Jellinek
2963b86176 Bidi: Allow switching text direction & add control for bidi pref 2024-01-24 23:32:14 -05:00
Abe Jellinek
6836bde339 Fix RTL layout issues in item tree 2024-01-24 23:32:13 -05:00
Abe Jellinek
f4d3ef94e7 New Collection dialog: Apply macOS non-native menu fixes 2024-01-24 23:32:13 -05:00
Abe Jellinek
2ab1bf6e11 RTL: Put creator commas on left, use locale character 2024-01-24 23:32:13 -05:00
Abe Jellinek
4490da93ca RTL: Flip Locate icon (by making it a zotero-tb-button) 2024-01-24 23:32:13 -05:00
Abe Jellinek
f938445271 Prevent error when itemsView hasn't been initialized 2024-01-24 23:32:12 -05:00
Abe Jellinek
64b8068504 Focus item tree on Escape in empty Quick Search textbox 2024-01-24 23:32:12 -05:00
Dan Stillman
5167ac2d6f Restore Dev/Troubleshooting Mode warning after redesign 
Show label after tabs menu, and adjust Troubleshooting Mode color for
dark mode
 2024-01-24 23:32:12 -05:00