Commit graph

471 commits

Author SHA1 Message Date
Abe Jellinek
0c9200c862 Feed abstract: Set line-height to 1.5
Fixes #4581
2024-08-19 13:46:22 -04:00
Dan Stillman
d6c78336da Use line-height: 1.5 for abstracts
Some checks are pending
CI / Build, Upload, Test (push) Waiting to run
Addresses #4581, but need to do feed items separately, since that's in a
browser
2024-08-17 03:15:07 -04:00
Abe Jellinek
1f26b64519
RTL: Small item tree tag display fixes (#4576)
Some checks are pending
CI / Build, Upload, Test (push) Waiting to run
2024-08-16 02:10:52 -04:00
Tom Najdek
596703b21b
Fix inverted tag colors order. Resolve #4569
Some checks are pending
CI / Build, Upload, Test (push) Waiting to run
2024-08-15 11:15:51 +02:00
abaevbog
8c3f13909c
vpat 59: make quickFormat reference box separator text darker (#4400)
So that on Windows, the separator text on white background
has a high enough contrast ratio for accessibility

Also remove opacity when reference panel opens. Without the opacity
on the reference panel, there is a shadow appearing below and to the
right of the panel on Windows. If we let the panel render with
opacity: 0.9 and only then set opacity: 1, the panel will no longer
be transparent and there will be no shadow.
2024-08-13 00:05:11 -04:00
Abe Jellinek
181afb92ac Bidi improvements and fixes (#4534) 2024-08-12 15:09:10 -04:00
Abe Jellinek
041d190286
Item box: Remove hidden buttons from flex calculations (#4541) 2024-08-09 13:53:25 -06:00
Abe Jellinek
b3589e1d89 macOS menupopup styles: RTL fixes
- Use padding-inline-start for gutter
- Refactor other rules that used left/right margins/paddings, to make
  future accidental breakage less likely

Fixes #4538
2024-08-09 13:15:26 -06:00
windingwind
69b4789c17
Unify richlistitem styling rules (#4511)
Unify richlistitem styling rules

- Fix richlistitem unwanted focus ring on Linux
fix: #4510
- Simplify richlistbox styling rules and do not follow Mozilla code
- Use --default-focusring-width for v-table
2024-08-09 15:57:56 +03:00
Abe Jellinek
2d32efbccd
Apply tag text color to ellipsis (#4536) 2024-08-08 22:54:10 -04:00
Bogdan Abaev
7450622047 itembox: switch creator mode button (#4535)
- added button to switch mode to creator rows
- removed that option from options menu
- extra tweak to avoid cursor flickering during re-render after
clicking on the button
- increased itemPane min-width to 320px

Fixes: #3959
2024-08-08 22:50:26 -04:00
Tom Najdek
083ad9ee05
Fix missing margin between colored and emoji tags
In the item tree, emojis are spaced 4px apart, but there was no space
between the colored circles and the first emoji, making it look crowded.
2024-08-08 18:09:19 +02:00
windingwind
6f6444dc12
Fix tab bar scroll arrow button click not working (#4529)
fix: #4527
2024-08-08 04:19:41 -04:00
windingwind
01f9222735
Remove form element rule !important suffix on Windows (#4528)
Fix tab bar button hover effect on Windows
A follow up fix of #4518
2024-08-08 03:40:59 -04:00
abaevbog
35da1187b3
prefs: fix text-link not clicking on space/enter (#4522)
Fix regression after 117197e11d
where space or enter would not trigger a click on
link outside of the main window.

".keyboard-clickable" is handled by listener in ZoteroPane,
so links outside of it (e.g. preferences) are not affected by it.
For now, just explicitly handle "keypress" event by the
zotero-text-link component.

Also, added a focus-ring around the link so it is visible
when it is focused.

Fixes: #4521
2024-08-08 00:24:19 -04:00
Abe Jellinek
531f55120c
Feed settings: Make disclosure triangle focusable, extract SCSS (#4513)
- <hbox> -> <button>, <toolbarbutton> -> <dropmarker>
- Extract styles to SCSS and use focus-ring mixin

Fixes #4512
2024-08-08 00:22:09 -04:00
Abe Jellinek
14ab0cd529
Fix button selector specificity on Windows (#4518)
And remove !important.
2024-08-08 00:21:26 -04:00
windingwind
55017926b5
Fix window background overflow when no native titlebar (#4516) 2024-08-07 03:01:59 -04:00
abaevbog
0352fa35b4
OpenURL resolver pref: Fix glitchy drop-down keyboard navigation (#4506)
- minor refactoring to avoid deleting the first ("Custom") menuitem
of the resolver menulist. It is the first item that is selected when
popup opens and deleting it confuses keyboard navigation, so that
arrowDown/Up won't navigate the menu (unless the menu is hovered
over with a mouse)
- explicitly re-select the first item when the menulist closes.
Otherwise, in case of having navigated the menus with arrows
without changing selection and closing the popup, next time
resolver selector appears, arrowUp/Down will not navigate the list.
Only occurs on Windows.
- clear the resolver menus (except for the 1st item) when the popup closes
so that arrowUp/Down on focused dropdown don't select invalid
top-level menus (e.g. "North America").
- make sure that if the URL has been edited, the resolver dropdown's
value will switch to "Custom" even if the resolvers were not loaded

fixes: #4491
2024-08-06 01:31:47 -04:00
windingwind
129938c8fe
Fix quick search styling (#4501)
fix: #4497
fix: #4498
2024-08-05 05:01:59 -04:00
Tom Najdek
7c3d04e03a
Warn users running non-ARM version on ARM CPU (#4473) 2024-08-01 01:22:03 -04:00
windingwind
98d1f84263 Fix banner style on Windows (#4466)
fix: #4449
2024-07-31 03:23:51 -04:00
windingwind
06f359df23 Fix merge window style (#4430) 2024-07-31 01:37:37 -04:00
Abe Jellinek
15fa86410d Update Advanced Search styles (#4464) 2024-07-31 01:35:48 -04:00
Abe Jellinek
fbcadd06ba Update progress queue dialog styles (#4464) 2024-07-31 01:35:43 -04:00
Abe Jellinek
74b86a7033 Make macOS control normalization into a mixin (#4464)
And include in stylesheets that have been updated.

Have to make sure not to include this mixin in the global scope in
stylesheets that are themselves imported elsewhere (i.e., filename
begins with an underscore).
2024-07-31 01:35:31 -04:00
windingwind
c7757131a6
Fix Prefs window style on Windows (#4465) 2024-07-31 01:28:05 -04:00
Abe Jellinek
73a317b8d8 Add gap between file type checkboxes on macOS (#4458) 2024-07-30 01:29:12 -04:00
Abe Jellinek
c836fb3448 Move negative margin on checkboxes/radios (#4458)
Move it from the parent element (<checkbox>, <radio>) to the first child
(.checkbox-check, .radio-check). This way, margins set by classes like
.indented-pref don't negate our global styles.
2024-07-30 01:29:12 -04:00
Abe Jellinek
9d8845b961 Locate manager: Fix button spacing (#3807) 2024-07-28 03:26:39 -04:00
Abe Jellinek
1573d251e0 Advanced Search: Fix button spacing (#3807) 2024-07-28 03:26:36 -04:00
Abe Jellinek
9a2d6fd8c0 Preferences: Remove Reset button font-size override (#3807) 2024-07-28 03:26:34 -04:00
Abe Jellinek
3d0014f258 Preferences: Fix styling a bit (#3807)
- Don't import global Zotero SCSS
   - I think this was always a mistake - preferences have their own
     root SCSS file (preferences.scss) and don't need zotero.scss
- Don't add margins on radio or button labels
   - Like above - I don't think this was correct even before the latest
     button style tweaks!
- Don't add global margins
   - Otherwise we start an arms race with all the other elements in the
     pane - anything without a margin-inline-start will look like it's
     sticking out to the left. Apply specific margins instead.
2024-07-28 03:26:28 -04:00
Abe Jellinek
75cb9d44bd Add global button/radio/checkbox styles (#3807) 2024-07-28 03:26:24 -04:00
Abe Jellinek
5f717d3bde Show first-run banner on upgrade (#3807) 2024-07-28 03:26:12 -04:00
Abe Jellinek
7020d60351 Generalize Find Available PDF -> Find Full Text (#4397) 2024-07-27 02:11:22 -04:00
Abe Jellinek
7c7d8c1433
Implement Select Items dialog redesign (#4406) 2024-07-26 02:55:43 -04:00
Abe Jellinek
38391f356c
Restore autoscroll support in reader (#4405)
- Mozilla's ActorManagerParent was only being imported when devtools
  were initialized (either by opening the Error Console or by connecting
  via remote debugging). Import it in our ActorManager so Mozilla
  actors, including AutoScroll, are always registered.
   - This may have other effects! I'm assuming most of us test with
     the error console visible, though, so we would've had Mozilla
     actors, while users running without devtools wouldn't have. We
     definitely want those actors. (Most of them, at least.)
- Don't override autoscroller styles with our panel customizations.
2024-07-19 01:57:45 -04:00
abaevbog
e6b5ba60dd
fix tab not scrolling into view (#4404)
After react 18 update, the tab node may not yet be rendered
by tabBar.jsx when we try to scroll it into view in Zotero_Tabs.select.

- To make sure scrolling happens when rendering is done, move scroll-related
logic into a useEffect of tabBar.jxs. It also makes sure that we'll scroll to
a selected tab if it is moved via context menu to the very beginning or the end.

- Added a small scroll-padding to tabs container to make sure the border
does not get cutoff after the tab is scrolled into view instead of
JS code accounting for the border.

- Fixed a glitch where the pinned library tab would not get selected
on shift-tab from opened tabs menu.

Fixes: #4382
2024-07-18 02:19:07 -04:00
Bogdan Abaev
a73035c848 vpat 66-68: fix focus within tagsBox popup (#4231)
- focus will always enter the tagsBox popup opened from the reader
- escape from within the popup with tagsBox will close the popup (vpat
  67)
- one should not be able to collapse the tagsBox. Added `collapsible`
  getter and setters to the collapsible panel to prevent the section
  from changing its open status. This may be also used in other cases,
  such as to prevent itemBox from being collapsed in duplicates mode.
- patched a glitch where tab from the last empty tab input would loose
  focus.
- changed the `menupopup` for `panel` to display the `tagsbox` because
  `menupopup` has implicit `role="menu"` which is not meant to contain
  inputs, so voiceover completely looses cursor when inputs are focused
  inside of the popup. Also, tweaked spacing a bit to avoid the
  focus-ring getting cutoff.

Addresses: #4222
Fixes: #4230
Fixes: #4226
Addresses: #4388
2024-07-16 02:35:53 -04:00
windingwind
b16bbc4a8a Fix richlistitem inner element style
fix: https://github.com/zotero/zotero/pull/4339#issuecomment-2225908561
2024-07-13 23:51:56 +08:00
windingwind
f79dab8f3e
No focus ring and background in CR readonly fields (#4380)
fix: #4138
2024-07-12 00:57:04 -04:00
abaevbog
c0f6671542
fixes to saved search dialog layout (#4378)
- remove padding between the <dialog> and the window edges
- explicit width for all zoterosearch fields because otherwise
a menulist with a long content (e.g. longer collection name) name
can push the + and - buttons outside of the window

Fixes: #4374
2024-07-12 00:55:49 -04:00
Tom Najdek
260709969e Improve RTF Scan UI
* Multiple accessiblity fixes
* Increase font size
* Nicer layout of the welcome screen
* Fix description in the welcome screen
* Add stripes to the table in citations matching screen
* Change icons for accept and resolve manually buttons
2024-07-11 01:46:16 -04:00
Tom Najdek
9cb7e7bb92 Few small tweaks to the wizards styling
* Align buttons with content on macOS
* Slightly reduce padding
* Remove font-size definition
2024-07-11 01:46:16 -04:00
Tom Najdek
843300c62d Use built-in color for the focus ring on macOS 2024-07-11 01:46:16 -04:00
Abe Jellinek
13496afeb3
Use SelectedItemText color on SelectedItem backgrounds (#4350) 2024-07-10 01:20:47 -04:00
Abe Jellinek
0f5fc2962a RTL: Reverse collapsible-section animation 2024-07-10 00:43:59 -04:00
Abe Jellinek
ddfe376900 RTL: Flip attachment preview arrows 2024-07-10 00:43:59 -04:00
abaevbog
b0fa4415ee
fix focusring not appearing on linux (#4365)
-moz-accent-color variable doesn't seem to exist on linux.
Use --color-accent as the focus border, same as what is
already done in the reader.

Fixes: #4340
2024-07-10 00:41:13 -04:00