Commit graph

4277 commits

Author SHA1 Message Date
Dan Stillman
0b82266882 Don't show nsIChannel passwords in debug output 2013-03-26 16:00:55 -04:00
Dan Stillman
760c327a1b Update locales from Transifex 2013-03-26 13:35:27 -04:00
Dan Stillman
5a005cd5ae Fix WebDAV file sync conflict 2013-03-26 02:50:01 -04:00
Dan Stillman
48544729e7 Replace some uses of Q.allResolved() with Q.all() in storage sync 2013-03-26 02:50:01 -04:00
Dan Stillman
acb45593e7 Fix WebDAV file purging
Deleted files are purged at the end of every sync, without any delay.
(If there's a conflict, it will be resolved before the file is deleted.)

Orphaned files are deleted once every 10 days, since it's a potentially
expensive operation for the server.
2013-03-26 02:50:00 -04:00
Simon Kornblith
107dc081b9 Fix duplicate requests to provider sites
When the user follows a link from a proxy-by-port EZProxy to another
proxy-by-port EZProxy, we make an additional request to the target site
with no cookies. This yields a redirect to the EZProxy login page. We
use the query parameters to determine the true domain of the site.

Previously, we allowed the redirect to continue, and used the same code we
use to detect EZProxy logins to map the proxied domain to the true domain.
This caused duplicate requests to providers and apparently infinite loops.

We now read the query parameter directly from the redirect to the EZProxy
login page and then cancel the request so that the redirect doesn't get
followed.

The changeset also improves logging of proxy-related information.

See https://forums.zotero.org/discussion/28505/ for further discussion.
2013-03-25 21:45:40 -04:00
Dan Stillman
e61350a3b2 Fix positioning of sync error popup 2013-03-22 17:56:53 -04:00
Dan Stillman
b54b77a107 Clarify WebDAV error messages 2013-03-22 17:47:35 -04:00
Dan Stillman
ffcabcd44e Make text in sync error panel selectable 2013-03-22 17:23:19 -04:00
Dan Stillman
4a334fa7f7 Fix file sync error continuing to show after error had cleared 2013-03-22 17:22:10 -04:00
Dan Stillman
b208097a8e options.requestObserver callback for Zotero.HTTP.promise()
The callback receives the XMLHttpRequest object after the open() call.
2013-03-22 17:04:38 -04:00
Dan Stillman
059906a11e Fix wide prefpane if PDF tools aren't installed 2013-03-22 13:45:57 -04:00
Dan Stillman
c7c8cbbeae Mention Search pane in PDF tools message 2013-03-22 13:34:01 -04:00
Dan Stillman
f9c9253e88 Fix Proxies prefpane 2013-03-22 03:20:33 -04:00
Dan Stillman
15caec9a32 Remove hardcoded prefwindow width 2013-03-22 03:13:32 -04:00
Dan Stillman
553173f7ba Fix cutoff of bottom of Search prefpane on Linux 2013-03-22 03:08:47 -04:00
Dan Stillman
f5d33a3a0c Update submodules and versions 2013-03-22 02:34:12 -04:00
Dan Stillman
fcce6327ae Merge pull request #277 from aurimasv/escape-path
Escape special characters in file paths when attaching files
2013-03-21 01:26:12 -07:00
aurimasv
6524e17ded Show error message when attaching file fails. 2013-03-21 03:24:47 -05:00
aurimasv
82448c4a4d Escape special characters in file paths when attaching files 2013-03-21 03:24:47 -05:00
Dan Stillman
cf9dd6d73f Merge locales from Transifex 2013-03-20 22:53:59 -04:00
Dan Stillman
c227fdb3f7 Fix bottom padding of Sync->Reset pane 2013-03-20 22:41:15 -04:00
Dan Stillman
e85790541b Remove per-library sync error indicators, at least for now
The hidden column caused collection names to be cut off unnecessarily,
and the extra icons were overly distracting. For now, just show the
first error that comes in in the main sync error panel, along with the
library name.
2013-03-20 22:41:15 -04:00
Simon Kornblith
0782344c41 Revert "Don't truncate text in Add Item by Identifier box at less than the full box width"
This reverts commit 5f2f120a98.

This seems to be a bug in Nightly, not Zotero.
2013-03-20 16:54:52 -04:00
Dan Stillman
7cdc420304 Remove obsolete code 2013-03-20 16:45:09 -04:00
Dan Stillman
1f1c6d16ff Quit rather than restart when changing data directory 2013-03-20 16:45:09 -04:00
Simon Kornblith
5f2f120a98 Don't truncate text in Add Item by Identifier box at less than the full box width 2013-03-20 16:33:05 -04:00
Dan Stillman
7c3d6a54e8 Adjust bottom padding of prefpanes 2013-03-20 13:06:53 -04:00
Dan Stillman
ddd7cdf431 Use nicer alert for PDF tools download error 2013-03-20 05:10:48 -04:00
Dan Stillman
49a97d104b Fix strict mode error downloading PDF tools 2013-03-20 05:10:48 -04:00
Dan Stillman
a417c9ef59 Fix window height bug in Zotero preferences, and reorganize code
Prefpanes are now in separate overlays, which fixes the age-old resizing
bug when switching between panes (at least on OS X) that varied
depending on the initial pane. Code has also been moved into
pane-specific files and objects, with strict mode enabled. When calling
code from another pane (e.g., for a UI update in another pane), first
check whether the Zotero_Preferences.[Pane] object exists--if it doesn't
then nothing needs to be called.

This change breaks the word integration plugin pref overlays, which
hopefully can be rewritten to work with either overlay format.

There is a good chance that this breaks some other things in the
preferences too.

Fixes #243
2013-03-20 05:10:38 -04:00
Dan Stillman
41e2f3008e Sort empty titles last when title isn't primary sort
When sorting by Title, empty titles get sorted to the top of the items
list for visibility, but when sorting by another column and using the
title as a secondary/tertiary sort, empty titles should get sorted last
so that new empty items go to the end of the list rather than the
middle.

This is a little weird, and the alternative would be to just always sort
empty titles last even when sorting by Title, but this preserves the
current behavior for Title sorting. (Before f0f6772b01 titles weren't
used for secondary sorting at all, so there's no precedent for
title-sorting behavior when sorting by another column.)

Addresses #275
2013-03-19 15:59:40 -04:00
Dan Stillman
d69dc3d5a7 If Year column is visible and not Date, don't sort by full date
Otherwise use full date, even if Date column is hidden

Addresses #275
2013-03-19 15:42:39 -04:00
Dan Stillman
1647f28135 Fix error selecting separator above Group Libraries
This is super annoying, but I can't seem to stop the separator row from
being selected in seltype="single" mode (where isSelectable() isn't
called). Until we have a better solution, at least clear the items list
and avoid an error.
2013-03-19 06:53:48 -04:00
Dan Stillman
78618ff88b Fix collections-containing-an-item highlighting in Fx22+ 2013-03-19 06:16:11 -04:00
Dan Stillman
b1f80a3615 Use dateAdded rather than dateModified for final fallback sort
Addresses #275
2013-03-19 06:00:11 -04:00
Dan Stillman
f0f6772b01 Sort by title after creator and date, if not primary sort
Addresses #275
2013-03-19 05:16:31 -04:00
Dan Stillman
8bd7536c2c Remove reference to missing .dtd file 2013-03-19 02:25:58 -04:00
Dan Stillman
4717e3497f Fix missing "Deleted" in CR window
Addresses #273
2013-03-19 02:25:25 -04:00
Dan Stillman
cf54a5da34 Fix code style
Refs #274
2013-03-19 02:22:33 -04:00
Aurimas Vinckevicius
cc93a0c7b8 Unbreak adding new items. Broken by dbf6bc0ee1. 2013-03-19 01:05:53 -05:00
Simon Kornblith
67bccfc9fe Only show annotation toolbar on pages that already have annotations 2013-03-18 20:37:27 -04:00
Dan Stillman
22f9fc04a8 Fix update marking for uploaded file versions that exist remotely
If a file version existed on the server, the uploaded attachment wasn't
marked as updated until the next sync.
2013-03-18 20:28:16 -04:00
Dan Stillman
47299c9e85 Remove debug line and update error message 2013-03-18 20:27:54 -04:00
Dan Stillman
8e1b8022ad Download locally existing remotely modified files in on-demand mode
If a file doesn't exist locally it won't be downloaded until opened, but
if a file does exist locally and has been modified remotely the latest
version will be downloaded at sync time regardless of the file sync
mode. (If a locally existing file has been updated remotely, just
opening it won't currently download the latest version. You have to
sync. This may change in the future.)
2013-03-18 20:21:48 -04:00
Dan Stillman
0853dbc070 Fix problem with items list scrollbar size between views
Caused by 2cd45be191, though not sure why it's happening.
2013-03-17 16:12:46 -04:00
Simon Kornblith
c457139573 Merge pull request #270 from aurimasv/RDFimport
Fix RDF import for large notes
2013-03-17 13:05:14 -07:00
Dan Stillman
9796e60617 Don't update item when tabbing through empty Date field 2013-03-17 03:49:31 -04:00
aurimasv
f3bda1643d Normalize DOM nodes after parsing 2013-03-17 02:43:41 -05:00
aurimasv
d974c78cef Add $rdf.log.error for rdflib.js 2013-03-17 02:43:41 -05:00