Commit graph

1880 commits

Author SHA1 Message Date
Dan Stillman
2f2e8c25da Additional file sync debugging 2010-09-08 18:33:28 +00:00
Dan Stillman
af304f0834 Commons:
- Align bucket name checks between UI and data layer
2010-09-08 17:51:24 +00:00
Dan Stillman
6c7413ed72 Commons:
- Fix collection creation
- Don't display alerts for errors retrieving bucket contents, since IA returns various errors for a while after bucket creation
2010-09-08 17:31:30 +00:00
Dan Stillman
bc53f32595 Recover from wrong-library-tag-item issue without using the DB Repair Tool 2010-09-08 08:44:42 +00:00
Dan Stillman
3fb8d66e1e Link to SSL certificate error KB page on error 2010-09-07 20:21:13 +00:00
Dan Stillman
055f641188 Fix error message in previous commit 2010-09-07 19:01:26 +00:00
Dan Stillman
539ac39d70 Trigger Full Sync when trying to insert an item into a missing local library (though I think the causes of this have been addressed server-side) 2010-09-07 18:39:05 +00:00
Dan Stillman
1f93fa405c Fix an NS_ERROR_FAILURE from nsIFileURL.file, though I don't yet know what causes it 2010-09-07 08:57:35 +00:00
Dan Stillman
6a42d2ee12 Suggest restarting Firefox and/or computer to fix file sync errors 2010-09-07 00:33:42 +00:00
Dan Stillman
e69f9d156f Fixes #1721, Zotero.File.getContents() method ignores small values of maxLength
- Modified version of Frank's patch -- among other things, requested bytes aren't guaranteed by readString()
- Unit tests
2010-09-06 19:10:15 +00:00
Dan Stillman
330f8697f8 Check for long tags not associated with items after TAG_TOO_LONG sync error 2010-09-06 18:36:34 +00:00
Dan Stillman
6ba92efdbb - Add instructions line to CR window saying to click Next/Done
- Resize CR window better for smaller screens (which will hopefully keep the button in view)
2010-09-05 07:18:06 +00:00
Simon Kornblith
937b583c9f update to citeproc-js 1.0.53 (finally)
In this release:

 Fix a subtle bug that caused full author names to
 be erroneously rendered in citations although the
 style parameters did not permit them.
2010-09-04 22:52:52 +00:00
Dan Stillman
3ce6e429ed Commons:
- Fix encoding issues with uploaded files
- Use a more reliable method of generating the file list that doesn't depend on IA filename sanity
- Get user display name from and prepend slugify()'ed version to bucket names (still including "zc-test-" for now)
2010-09-03 20:22:32 +00:00
Dan Stillman
c0091db15e Fixes #1719, Autosync suspension needs to persist
Don't auto-sync on Zotero pane open if a manual sync is required
2010-09-02 16:48:48 +00:00
Dan Stillman
0e45473992 Commons:
- Items must have a title
- Warn if some items are skipped
2010-09-02 04:23:48 +00:00
Dan Stillman
b97c2213b6 Commons:
- Encode apostrophes, since IA wants it that way
- Allow uploading only for regular items with attached files
- Fix error if no local item
2010-09-02 03:14:14 +00:00
Dan Stillman
3d555e030a Commons:
- Don't break reloading on "Invalid response retrieving file upload parameters"
- Don't break loading if a <file> doesn't have a <format>
2010-09-02 02:03:10 +00:00
Dan Stillman
01d3d0057c Don't try to download attachments with empty paths, which can't be saved 2010-09-01 05:42:02 +00:00
Dan Stillman
338096e1a3 Display more helpful message for "Hash not found in HEAD response" error 2010-09-01 05:13:28 +00:00
Dan Stillman
a815fefa28 - Second half of ZFS quota message wasn't being shown in dialog
- Display filename of file that would put user over quota
2010-08-31 17:50:03 +00:00
Dan Stillman
a081315876 Fix UI update on Commons enable/disable 2010-08-31 06:45:45 +00:00
Dan Stillman
ab398bcd84 JS strict warning 2010-08-30 21:00:35 +00:00
Dan Stillman
2d47daf684 Fix for cursor being reset to beginning while editing notes 2010-08-30 20:54:25 +00:00
Dan Stillman
43a6d5190b Fix a couple JS strict warnings 2010-08-30 19:18:33 +00:00
Dan Stillman
6ba90d53b3 Missing semicolon 2010-08-30 18:39:04 +00:00
Dan Stillman
9c366a4bcb Clear Commons credentials on disable 2010-08-30 18:38:32 +00:00
Dan Stillman
a3108335f3 Fix importing of Commons settings, possibly 2010-08-30 18:28:52 +00:00
Dan Stillman
25d354d83d Advanced earches for exact creator names didn't match creators without first names 2010-08-30 00:46:38 +00:00
Dan Stillman
e17bffcdd4 Disable unresponsive script warning during translator initialization, since subsequent runs should be much quicker due to cache
(Change is just an indent, despite messiness of diff)
2010-08-29 18:45:59 +00:00
Dan Stillman
80f5047687 Commons:
- Reload bucket on bucket click if not loaded in the last 60 seconds
- Add "Show Original" button to Commons metadata pane to switch back to original linked item, if it exists
- Hide metadata pane tabs in Commons view
- Add support for setting credentials via zotero.org (untested, and not yet stored in Fx login manager)

Also:

- Add ZoteroPane.getItemGroup() function
2010-08-29 04:14:05 +00:00
Dan Stillman
c97491821f Don't include deleted items in "Export Library" output 2010-08-28 17:21:24 +00:00
Dan Stillman
0d9f45b0fa Fixes #1714, Adding by PMID doesn't work for groups 2010-08-28 17:00:43 +00:00
Dan Stillman
dbcc4408bc Fix FK constraint error (previously requiring a Full Sync to fix) that could occur if an attachment/note was added to a collection on one side and made a child item on the other 2010-08-27 19:27:08 +00:00
Dan Stillman
feca078284 Clarify comments 2010-08-27 19:21:01 +00:00
Dan Stillman
6a12bfd521 Remove obsolete line 2010-08-27 19:18:56 +00:00
Dan Stillman
fe6713b358 Fix CSS parsing errors (which possibly meant the affected rules aren't necessary) 2010-08-27 19:16:29 +00:00
Dan Stillman
476a5b385d Fix JS strict warning 2010-08-27 19:11:13 +00:00
Dan Stillman
e437ecce6b Fix JS strict errors 2010-08-27 19:10:06 +00:00
Dan Stillman
053b6dace3 Fix JS strict warning 2010-08-27 19:08:41 +00:00
Dan Stillman
6a629490b3 - Fix an XML parsing error (due to trailing whitespace, weirdly) that could cause endless sync icon spinning
- Remove extra whitespace in collection-item blocks that was causing sync upload errors (also fixed on the server)
2010-08-26 21:34:44 +00:00
Dan Stillman
4bc7ab9016 Add note that Commons processing could take a while 2010-08-26 06:32:24 +00:00
Dan Stillman
eec491fe7a Handle invalid filenames without failure during import
Export should be fixed to run exported filenames through getValidFileName()
2010-08-25 16:21:49 +00:00
Dan Stillman
e0c8e30161 - Include translator filename in error message on JSON parsing failure
- Recategorize Zotero.log() errors so they show up as chrome errors in Console2
2010-08-24 21:08:04 +00:00
Dan Stillman
f10da8c527 Don't die if /Users/Shared doesn't exist on OS X 2010-08-24 21:05:38 +00:00
Dan Stillman
b3aa705bfd Fixes #1713, Don't show Zotero Commons in Word Processor Plugins 2010-08-24 20:23:52 +00:00
Dan Stillman
23dae26408 Fix "JavaScript component threw a number as an exception" error (which is actually "Cannot move collection into one of its own descendents!") 2010-08-24 18:57:00 +00:00
Simon Kornblith
4d91ec8f8b fix refresh operation 2010-08-16 08:52:13 +00:00
Simon Kornblith
2f671725b8 disable caching of citeproc-js items (for now) 2010-08-16 08:48:55 +00:00
Simon Kornblith
64f810dd5a fix issues inserting new citations with locators with accented characters (citations will still need to be reinserted) 2010-08-16 08:46:07 +00:00
Simon Kornblith
09ff9ec083 fix upgrading of documents with non-page locatorType 2010-08-16 08:19:12 +00:00
Simon Kornblith
ecd6309fbc update to citeproc-js 1.0.52
closes #1709: [patch] citeproc-js 1.0.51 compatibility patch: makeBibliography() return value
closes #1712: [patch] citeproc-js 1.0.52 compatibility patch

From Frank's notes for 1.0.52:

In this release, the following change may require accomodation
within the calling application:

 The processor quashes double spaces in the output.
 RTF control words can be terminated with a space, but
 this causes an immediately following space to be lost
 from the output. To avoid this, the RTF output mode of
 the processor has been adjusted to terminate RTF control
 words with {} rather than space. Applications that convert
 processor output between other formats (such as HTML)
 may need to be adjusted to accomodate this new behavior.

Also in this release:

 Reverse the RTF-related conservatism in the quashing
 of duplicate spaces that was introduced in 1.0.51.

 Add missing parens to suspect test condition (not
 related to any known bug).

From Frank's notes for 1.0.51:

The API return value changes slightly with this version:

 For styles that have no bibliography element, the command
 makeBibliography() now returns false, rather than a
 stub bibliography object.  Code adjustments in the
 calling application may be required to accommodate
 this change in behavior.

 In other bibliography and citation returns, the processor
 now provides new arrays, bibliography_errors and
 citation_errors respectively, with information on
 bibliography entries or cites that produce no meaningful
 rendered output.  Details are in the processor manual:

   http://gsl-nagoya-u.net/http/pub/citeproc-doc.html#handling-items-with-no-rendered-form

Also in this release:

 Fix string breakage affecting text-case="title".

 Fix over-aggressive quashing of spaces, which affected
 spacing following RTF entities.
2010-08-16 08:07:07 +00:00
Dan Stillman
a94675f402 Add better message for error Kaspersky users have gotten 2010-08-09 06:37:01 +00:00
Dan Stillman
c17336291b Display better messages for NS_ERROR_FAILURE file sync errors 2010-08-09 06:24:06 +00:00
Dan Stillman
1a7629a589 Closes #1710, Clipboard citation copy w/Ctrl-Alt-A always Ibid.
Frank's patch
2010-08-09 01:55:50 +00:00
Dan Stillman
521ab94e35 Ignore any mention of CVE-2009-3555 in error messages 2010-08-06 17:52:33 +00:00
Dan Stillman
bbc8f7812c Add ability to create Zotero Commons buckets via the UI
- "zc-test-" is currently prepended to bucket names
2010-08-06 17:42:14 +00:00
Dan Stillman
6ea7e3dd65 Fix error in Related Items dialog 2010-08-02 21:32:11 +00:00
Simon Kornblith
253ab1e86a closes #1567, Fullscreen does not restore 2010-08-02 02:55:05 +00:00
Simon Kornblith
021cbc8725 closes #1285, Add typeof checks to data read from scraper sandbox
use XPCSafeJSObjectWrappers to enforce security of everything coming out of translators. this seems to work, but needs testing.
2010-08-02 02:26:46 +00:00
Simon Kornblith
dff5adf480 addresses #699, Reconcile Zotero item types with CSL schema
maps dictionaryEntry and encyclopediaArticle to entry-dictionary and entry-encyclopedia respectively (instead of chapter)
2010-08-01 23:11:38 +00:00
Simon Kornblith
63f346b504 closes #1609, Bibliography printing broken
this currently leaks a hidden browser object, since deleting it seems to cause the print command to fail. this may not be a big issue, since this feature is used so rarely anyways...
2010-08-01 20:34:29 +00:00
Simon Kornblith
fe37dc73e1 restore copyright notice to citeproc.js (accidentally removed in last commit) 2010-08-01 20:16:14 +00:00
Simon Kornblith
685338b41a update to citeproc-js 1.0.50
From Frank's announcements:

In 1.0.45:

 Fix duplicate terminal punctuation
 affecting bibliography output.

 Eliminate dereferencing assignments, for
 compatibility with some JS implementations.

 Suppress duplicate spaces affecting some
 styles.

In 1.0.46:

 Add option to updateItems() and updateUncitedItems()
 to suppress sorting of the bibliography.

In 1.0.47:

 Fix a duplicate space issue.

 General refactoring of code for identifying an quashing
 duplicate punctuation and spaces.  The code should be
 easier to control when further issues involving punctuation
 arise down the road.

 Provide for replacement of the citation number in
 numbered styles with a slug, so that strings in a
 bibliography listing can be used in a template
 without rerendering.  This is useful in some server-side
 applications.

In 1.0.48:

 Permit author to vary between parallel citations. Useful
 for French case-and-commentary string cites.

 Permit author to vary between parallel citations. Useful
 for French case-and-commentary string cites.

 Fix bug in short form title support.

 Further fixes to quashing of duplicate punctuation
 and spaces.

 Fix issues with bibliography slug.

 Provide for parsing experimental variables out of the
 content of the note variable.  For use in advance
 testing of styles that require changes to the variables
 available in CSL, or supplied by the calling application.

In 1.0.49:

 Extend support for "parallel" legal citations to include
 case and comment string citations used in French legal
 writing.

 Fix XML parsing code in xmldom.js to screen XML comments
 from the processor.  Thanks to Carles Pina for reporting
 this fault (relevant to non-Firefox, non-gecko browsers).

 Tighten up conditions for suppression of the trailing year
 where the volume number and the year have the same value.
 Suppression will no longer occur when the rendered date
 contains additional details (day, month).

 Throw a more meaningful error when an invalid locale
 is requested.  Thanks to Carles Pina.

 Fix missing definition of quotes="false" in formats.js.
 Thanks to Carles Pina.

 Fix bug in handling of capitalized characters used in
 citeproc-js hackaround for multi-character initials.

In 1.0.50:

 Apply output-mode-specific text_escape function to
 affixes and delimiters.

 Strip XML declaration from CSL and locale strings
 received for parsing in the xmldom.js module.

 Add paranoia fallback to handle comment nodes that
 sneak past the XML parser.
2010-08-01 20:14:51 +00:00
Simon Kornblith
8fe9c5e9e7 closes #1684, checkbox to temporarily disable proxy code
also adds a parameter to disable proxy redirection by domain (although if I had known how much work would be involved in implementing this before I started, I wouldn't have bothered)
2010-08-01 20:10:18 +00:00
Simon Kornblith
84fcd7d4b8 oops: there is no wrappedJSObject for collectionsView 2010-08-01 19:57:42 +00:00
Simon Kornblith
b285f6a7d4 closes #1705, [PATCH] Item cited in document not reselected when cite reopened for editing 2010-08-01 19:56:45 +00:00
Simon Kornblith
c9003f1f40 closes #1706, [PATCH] Item with non-ASCII characters corrupted on save when Show Editor is open
The problem here was that entities weren't properly being encoded as Unicode RTF when the editor was used, because TinyMCE was replacing high characters with HTML entities that were not properly decoded. This is now fixed.
2010-08-01 19:53:08 +00:00
Dan Stillman
c7f025519b Fixes #1696, Group item reported missing from Zotero library on next citation edit
Was breaking when libraryID!=groupID
2010-07-26 17:43:58 +00:00
Simon Kornblith
aec3c4381f closes #1699, Simplified _zoteroFieldMap for citeproc-js (thanks to Frank) 2010-07-26 01:01:18 +00:00
Simon Kornblith
e6a97b46b2 closes #1698, bookAuthor -> container-author CSL mapping (thanks to Frank) 2010-07-24 17:41:56 +00:00
Dan Stillman
d8db1cd61f Store a space in WebDAV lastsync file to work around a server issue where timestamp of an empty file isn't updated on PUT 2010-07-23 18:07:53 +00:00
Simon Kornblith
d022b966fe tweak date regexp to handle WTN8601 properly 2010-07-21 19:52:28 +00:00
Dan Stillman
0acaf22576 Fix Edit Bibliography window on trunk (related to Fx2/3 code removal) 2010-07-13 19:07:08 +00:00
Dan Stillman
ccae2e0b7c Fix error removing >1000 items from a tag (due to compiled SQLite limit) 2010-07-13 19:00:58 +00:00
Dan Stillman
0b83c8c166 Auto-empty trash items older than 30 days by default
- Warning needed on upgrade about this
- Controlled by trashAutoEmptyDays hidden pref, with 0 disabling the functionality
2010-07-13 18:33:47 +00:00
Dan Stillman
9dad2c6048 Commons:
- Use same character-stripping logic as IA when looking for RDF file
- Better handling of empty RDF files
2010-07-13 17:47:01 +00:00
Dan Stillman
2d0874dd66 Remove old Commons code 2010-07-12 17:45:22 +00:00
Dan Stillman
43c0ae9e8a Commons: Fix authentication issue involving files with semicolons or other extended chars, but more fixes are needed on IA side 2010-07-12 17:36:05 +00:00
Simon Kornblith
8068c17f8f closes #1689, When editing a citation, the reference is not selected if it does not exist in the currently selected collection within the Zotero pane 2010-07-12 11:24:29 +00:00
Simon Kornblith
3571b41d95 pick running copy of Word for Mac as AppleScript target 2010-07-12 10:46:25 +00:00
Simon Kornblith
3b0ee0285b add SID to generated openurl 0.1 URLs 2010-07-11 08:02:28 +00:00
Dan Stillman
395833b940 Restore setTimeout() call removed in previous commit 2010-07-09 20:48:10 +00:00
Dan Stillman
92383c7f20 Addresses #1037, Remove Firefox 2.0/3.0-specific code 2010-07-09 20:25:17 +00:00
Dan Stillman
84cf9d8cbe Closes #1037, Remove Firefox 2.0/3.0–specific code 2010-07-09 20:10:43 +00:00
Dan Stillman
973d2cd38c Fix version in newer DB version error message (trunk and branch) 2010-07-09 05:16:13 +00:00
Dan Stillman
00611dc288 Fix message for newer DB version error 2010-07-09 05:10:48 +00:00
Simon Kornblith
d592d3156e Fix translation in Fx4 2010-07-08 22:45:42 +00:00
Dan Stillman
f3a8cbd993 Switch back to multiple items per Zotero Commons bucket
- Creating buckets not yet supported
- Some now-unused single-item-per-bucket code still needs to be removed
- Child attachments are not displayed in Zotero Commons pane
- Manual refreshing via bucket right-click (or a Firefox restart) is currently necessary after adding items
- Double-clicking bucket takes you to bucket page; double-clicking item takes you to named anchor
2010-07-07 18:34:09 +00:00
Dan Stillman
7ce0e9ee23 Don't cache HTTP GET requests in Zotero.Utilities.HTTP.doGet() 2010-07-07 18:28:25 +00:00
Simon Kornblith
2e951139fe use contentLength parameter to determine length of updateCSL.xsl rather than hardcoding a limit 2010-07-06 18:43:15 +00:00
Simon Kornblith
ca0328729a addresses #1691, Update Zotero.QuickCopy.getContentFromItems() for new citation API
fix up problems on first drag
2010-07-06 18:39:49 +00:00
Simon Kornblith
a857cb3e5b closes #1691, Update Zotero.QuickCopy.getContentFromItems() for new citation API
caches updateCSL.xsl, since apparently doing an XHR to load it during drags was breaking things
2010-07-06 18:17:45 +00:00
Dan Stillman
77ecfce0fe Addresses #1691, Update Zotero.QuickCopy.getContentFromItems() for new citation API
Frank's latest patch, but drag-and-drop is still broken for me on OS X. Need to see if this is just my working copy.
2010-07-06 17:42:41 +00:00
Dan Stillman
970c317095 Comment out init() call for Zotero.Connector, which hasn't yet been committed 2010-07-06 17:39:13 +00:00
Simon Kornblith
43c57ec18c closes #1688, Preferences window appears in wrong screen position on Windows 2010-07-06 10:37:16 +00:00
Simon Kornblith
35c44b7470 fix race condition 2010-07-06 10:11:25 +00:00
Simon Kornblith
139036490c a better way of getting the install directory in Fx4 2010-07-06 09:25:58 +00:00
Simon Kornblith
63e08cd714 addresses #1690, Modify all XPCOM components for Firefox 4.0b2+ 2010-07-06 09:02:35 +00:00
Simon Kornblith
59817af546 references #1691, Update Zotero.QuickCopy.getContentFromItems() for new citation API
put a string in date.literal, instead of the whole date object, when passing to citeproc-js
2010-07-06 07:55:07 +00:00