mirrors/zotero
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

Item box: Always save current item when switching items

Browse source 
Fixes #3125
This commit is contained in:
Abe Jellinek 2023-05-23 19:39:55 +03:00
parent 61749d39a6
commit fd6ea99967
1 changed files with 12 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

13
chrome/content/zotero/elements/itemBox.js
View file

@ -285,6 +285,18 @@
this._displayAllCreators = false; this._displayAllCreators = false;
} }
// If switching items, save the current item first
// Before fx102, clicking an item in the item tree would send a blur event before ItemBox.item was updated.
// Now, ItemBox.item is set first, causing us to update this._item and remove the open field before it can
// receive a blur event and trigger a save.
if (this._item && val.id != this._item.id) {
// Not awaiting the blurOpenField() call here is not great practice, but it's unavoidable - setters
// can't be async and should immediately update their backing fields. Additionally, it matches the old
// behavior, as the blur event was triggered immediately before the item setter, with the
// Zotero.Item#saveTx() call continuing in the background.
this.blurOpenField();
}
this._item = val; this._item = val;
this._lastTabIndex = null; this._lastTabIndex = null;
this.scrollToTop(); this.scrollToTop();
@ -298,7 +310,6 @@
set ref(val) { set ref(val) {
this.item = val; this.item = val;
this.refresh();
} }