mirrors/zotero
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

fx-compat: Correct create[XUL]Element[NS]() calls

Browse source 
This fixes the dictionary manager and various other places where a XUL
element was being created with createElement(), and also simplifies a lot
of createElementNS(HTML_NS, ...) calls.

This might cause some minor regressions but everything tested has
worked. Not touching preferences (#2659) or bindings.
This commit is contained in:
Abe Jellinek 2022-06-29 10:16:49 -04:00
parent 8b7d959781
commit f81b4b071f
26 changed files with 103 additions and 110 deletions
Download patch file Download diff file Expand all files Collapse all files

2
chrome/content/scaffold/scaffold.js
View file

@ -124,7 +124,7 @@ var Scaffold = new function () {
var primaryTypes = ['book', 'bookSection', 'conferencePaper', 'journalArticle', 'magazineArticle', 'newspaperArticle'];
for (let type of types) {
if (primaryTypes.includes(type)) continue;
var menuitem = document.createElement('menuitem');
var menuitem = document.createXULElement('menuitem');
menuitem.setAttribute('label', type);
menuitem.addEventListener('command', () => {
Scaffold.addTemplate('templateNewItem', type);