mirrors/zotero
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

Percent-encode " character in DOIs when opening/copying as link

Browse source 
I'm not sure a double-quote actually appears in any DOIs, but it's
technically valid and would result in an invalid URL.

Follow-up to 782c2a1d1

Addresses #295
This commit is contained in:
Dan Stillman 2019-06-10 17:06:59 -04:00
parent 5e1beed6fd
commit f7f55f05ad
1 changed files with 4 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

6
chrome/content/zotero/bindings/itembox.xml
View file

@ -429,10 +429,12 @@
var doi = Zotero.Utilities.cleanDOI(val); var doi = Zotero.Utilities.cleanDOI(val);
if (doi) { if (doi) {
doi = "https://doi.org/" doi = "https://doi.org/"
// Encode some characters. '/' doesn't need to be encoded // Encode some characters that are technically valid in DOIs,
// though generally not used. '/' doesn't need to be encoded.
+ doi.replace(/#/g, '%23') + doi.replace(/#/g, '%23')
.replace(/\?/g, '%3f') .replace(/\?/g, '%3f')
.replace(/%/g, '%25'); .replace(/%/g, '%25')
.replace(/"/g, '%22');
label.classList.add("pointer"); label.classList.add("pointer");
label.setAttribute("onclick", "ZoteroPane_Local.loadURI('" + doi + "', event)"); label.setAttribute("onclick", "ZoteroPane_Local.loadURI('" + doi + "', event)");
label.setAttribute("tooltiptext", Zotero.getString('locate.online.tooltip')); label.setAttribute("tooltiptext", Zotero.getString('locate.online.tooltip'));