mirrors/zotero
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

FileHandlers tests: Wait for notifier instead of _setState() call

Browse source 
_setState() doesn't await setAttachmentLastPageIndex(), so the setting
sometimes won't be updated in the cache by the time we call
getAttachmentLastPageIndex() below. Notifier event should work every
time (and is a lot simpler).
This commit is contained in:
Abe Jellinek 2024-02-29 11:05:12 -08:00
parent 9e78957c72
commit ea63780600
1 changed files with 2 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

12
test/tests/fileHandlersTest.js
View file

@ -34,20 +34,12 @@ describe("Zotero.FileHandlers", () => {
let reader = Zotero.Reader.getByTabID(win.Zotero_Tabs.selectedID); let reader = Zotero.Reader.getByTabID(win.Zotero_Tabs.selectedID);
assert.ok(reader); assert.ok(reader);
// Wait for _setState() (is there an easier way to do this?) let notifierPromise = waitForNotifierEvent('add', 'setting');
let stub = sinon.stub(reader, '_setState');
let setStatePromise = new Promise((resolve) => {
stub.callsFake(async (...args) => {
await stub.wrappedMethod.apply(reader, args);
resolve();
});
});
await reader._waitForReader(); await reader._waitForReader();
await setStatePromise; await notifierPromise;
// Check that the reader navigated to the correct page // Check that the reader navigated to the correct page
assert.equal(pdf.getAttachmentLastPageIndex(), 2); assert.equal(pdf.getAttachmentLastPageIndex(), 2);
stub.restore();
}); });
it("should open a PDF in a new window when no handler is set and openInWindow is passed", async function () { it("should open a PDF in a new window when no handler is set and openInWindow is passed", async function () {