mirrors/zotero
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

Fix trashing of descendant items when deleting a collection

Browse source 
Also allows 'collections' property to be passed to
createDataObject()/createUnsavedDataObject() in tests.
This commit is contained in:
Dan Stillman 2016-01-17 16:55:34 -05:00
parent a80f130997
commit e873617890
9 changed files with 72 additions and 32 deletions
Download patch file Download diff file Expand all files Collapse all files

25
test/tests/collectionTest.js
View file

@ -13,6 +13,31 @@ describe("Zotero.Collection", function() {
});
})
describe("#erase()", function () {
it("should delete a collection but not its descendant item by default", function* () {
var collection = yield createDataObject('collection');
var item = yield createDataObject('item', { collections: [collection.id] });
assert.isTrue(collection.hasItem(item.id));
yield collection.eraseTx();
assert.isFalse((yield Zotero.Items.getAsync(item.id)).deleted);
})
it("should delete a collection and trash its descendant items with deleteItems: true", function* () {
var collection = yield createDataObject('collection');
var item1 = yield createDataObject('item', { collections: [collection.id] });
var item2 = yield createDataObject('item', { collections: [collection.id] });
assert.isTrue(collection.hasItem(item1.id));
assert.isTrue(collection.hasItem(item2.id));
yield collection.eraseTx({ deleteItems: true });
assert.isTrue((yield Zotero.Items.getAsync(item1.id)).deleted);
assert.isTrue((yield Zotero.Items.getAsync(item2.id)).deleted);
})
})
describe("#version", function () {
it("should set object version", function* () {
var version = 100;