From e21a914a1fc2279b21746d9484b9cd7137fff628 Mon Sep 17 00:00:00 2001 From: Dan Stillman Date: Sat, 21 May 2016 15:52:48 -0400 Subject: [PATCH] Clarify comment for local object version updating behavior --- chrome/content/zotero/xpcom/sync/syncEngine.js | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/chrome/content/zotero/xpcom/sync/syncEngine.js b/chrome/content/zotero/xpcom/sync/syncEngine.js index e34b70bc22..e36c3ada65 100644 --- a/chrome/content/zotero/xpcom/sync/syncEngine.js +++ b/chrome/content/zotero/xpcom/sync/syncEngine.js @@ -940,10 +940,11 @@ Zotero.Sync.Data.Engine.prototype._uploadObjects = Zotero.Promise.coroutine(func toCache.push(current); } else { - // This won't reflect the actual version of the item on the server, but - // it will guarantee that the item won't be redownloaded unnecessarily - // in the case of a full sync, because the version will be higher than - // whatever version is on the server. + // This won't necessarily reflect the actual version of the object on the server, + // since objects are uploaded in batches and we only get the final version, but it + // will guarantee that the item won't be redownloaded unnecessarily in the case of + // a full sync, because the version will be higher than whatever version is on the + // server. batch[index].version = libraryVersion toCache.push(batch[index]); }