From e009f56109bf851922862b6e109acacf7ca42062 Mon Sep 17 00:00:00 2001 From: Simon Kornblith Date: Tue, 17 Apr 2012 13:57:34 -0400 Subject: [PATCH] Don't try to validate fields whose values are false --- .../zotero/tools/testTranslators/translatorTester.js | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/chrome/content/zotero/tools/testTranslators/translatorTester.js b/chrome/content/zotero/tools/testTranslators/translatorTester.js index 854dc58de4..ab495c0da7 100644 --- a/chrome/content/zotero/tools/testTranslators/translatorTester.js +++ b/chrome/content/zotero/tools/testTranslators/translatorTester.js @@ -189,7 +189,7 @@ Zotero_TranslatorTester = function(translator, type, debugCallback) { * Removes document objects, which contain cyclic references, and other fields to be ignored from items * @param {Object} Item, in the format returned by Zotero.Item.serialize() */ -Zotero_TranslatorTester._sanitizeItem = function(item, forSave) { +Zotero_TranslatorTester._sanitizeItem = function(item, testItem) { // remove cyclic references if(item.attachments && item.attachments.length) { // don't actually test URI equality @@ -225,7 +225,8 @@ Zotero_TranslatorTester._sanitizeItem = function(item, forSave) { continue; } - if(!item[field] || !(fieldID = Zotero.ItemFields.getID(field))) { + if((!item[field] && (!testItem || item[field] !== false) + || !(fieldID = Zotero.ItemFields.getID(field))) { delete item[field]; continue; } @@ -501,14 +502,14 @@ Zotero_TranslatorTester.prototype._checkResult = function(test, translate, retur } for(var i=0, n=test.items.length; i