mirrors/zotero
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

Don't try to migrate Extra fields in read-only libraries

Browse source
This commit is contained in:
Dan Stillman 2020-03-15 19:52:44 -04:00
parent 23c936f016
commit dd9ec54c3b
2 changed files with 30 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

4
chrome/content/zotero/xpcom/data/item.js
View file

@ -4621,6 +4621,10 @@ Zotero.Item.prototype.toResponseJSON = function (options = {}) {
* A separate save is required * A separate save is required
*/ */
Zotero.Item.prototype.migrateExtraFields = function () { Zotero.Item.prototype.migrateExtraFields = function () {
if (!this.isEditable()) {
return false;
}
var { itemType, fields, creators, extra } = Zotero.Utilities.Internal.extractExtraFields( var { itemType, fields, creators, extra } = Zotero.Utilities.Internal.extractExtraFields(
this.getField('extra'), this this.getField('extra'), this
); );

26
test/tests/schemaTest.js
View file

@ -111,6 +111,32 @@ describe("Zotero.Schema", function() {
assert.equal(item.getField('extra'), 'Foo: Bar'); assert.equal(item.getField('extra'), 'Foo: Bar');
assert.isFalse(item.synced); assert.isFalse(item.synced);
}); });
it("shouldn't migrate fields in read-only library", async function () {
var library = await createGroup({ editable: false, filesEditable: false });
var item = createUnsavedDataObject('item', { libraryID: library.libraryID, itemType: 'book' });
item.setField('extra', 'Foo Bar: This is a value.');
item.synced = true;
await item.saveTx({
skipEditCheck: true
});
schema.version++;
schema.itemTypes.find(x => x.itemType == 'book').fields.splice(0, 1, { field: 'fooBar' })
var newLocales = {};
Object.keys(schema.locales).forEach((locale) => {
var o = schema.locales[locale];
o.fields.fooBar = 'Foo Bar';
newLocales[locale] = o;
});
await Zotero.Schema._updateGlobalSchemaForTest(schema);
await Zotero.Schema.migrateExtraFields();
assert.isNumber(Zotero.ItemFields.getID('fooBar'));
assert.equal(item.getField('fooBar'), '');
assert.equal(item.getField('extra'), 'Foo Bar: This is a value.');
assert.isTrue(item.synced);
});
}); });
}); });