mirrors/zotero
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

Don't select new groups in collections pane

Browse source
This commit is contained in:
Dan Stillman 2015-07-19 17:08:36 -04:00
parent 5c523d8694
commit d868f007e9
2 changed files with 8 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

6
chrome/content/zotero/xpcom/collectionTreeView.js
View file

@ -431,12 +431,10 @@ Zotero.CollectionTreeView.prototype.notify = Zotero.Promise.coroutine(function*
} }
break; break;
case 'group': case 'group':
yield this.reload(); yield this.reload();
// Groups can only be created during sync yield this.restoreSelection(currentTreeRow);
let libraryID = Zotero.Groups.getLibraryIDFromGroupID(id);
yield this.selectByID("L" + libraryID);
break; break;
} }
} }

6
test/tests/collectionTreeViewTest.js
View file

@ -235,6 +235,12 @@ describe("Zotero.CollectionTreeView", function() {
} }
}) })
it("shouldn't select a new group", function* () {
var group = yield createGroup();
// Library should still be selected
assert.equal(cv.getSelectedLibraryID(), Zotero.Libraries.userLibraryID);
})
it("should remove a group and all children", function* () { it("should remove a group and all children", function* () {
// Make sure Group Libraries separator and header exist already, // Make sure Group Libraries separator and header exist already,
// since otherwise they'll interfere with the count // since otherwise they'll interfere with the count