mirrors/zotero
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

Tests for Item#fromJSON() changes (#3422)

Browse source
This commit is contained in:
Dan Stillman 2025-01-22 03:22:38 -05:00
parent b4bf86915b
commit d2c9a310a8
1 changed files with 62 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

63
test/tests/itemTest.js
View file

@ -2731,7 +2731,7 @@ describe("Zotero.Item", function () {
});
describe("not-strict mode", function () {
it("should handle Extra in non-strict mode", function () {
it("should preserve Extra", function () {
var json = {
itemType: "journalArticle",
title: "Test",
@ -2834,6 +2834,45 @@ describe("Zotero.Item", function () {
assert.equal(item.getField('extra'), '');
});
it("should use a Zotero item type stored in Extra", async function () {
var json = {
itemType: "document",
title: "Test",
extra: "Type: dataset\nCitation Key: abc123\nFoo: Bar"
};
var item = new Zotero.Item;
item.fromJSON(json);
assert.equal(Zotero.ItemTypes.getName(item.itemTypeID), 'dataset');
// Move a valid field out of Extra
assert.equal(item.getField('citationKey'), 'abc123');
assert.equal(item.getField('extra'), 'Foo: Bar');
});
it("should use a CSL item type stored in Extra", async function () {
var json = {
itemType: "journalArticle",
title: "Test",
extra: "Type: song"
};
var item = new Zotero.Item;
item.fromJSON(json);
assert.equal(item.itemTypeID, Zotero.ItemTypes.getID('audioRecording'));
});
it("should move a now-invalid existing field to Extra when using Type from Extra", async function () {
var json = {
itemType: "journalArticle",
title: "Test",
pages: "123",
extra: "Type: audioRecording"
};
var item = new Zotero.Item;
item.fromJSON(json);
assert.equal(item.itemTypeID, Zotero.ItemTypes.getID('audioRecording'));
// 'pages' should've been moved to Extra, since it's not valid for the new type
assert.equal(item.getField('extra'), 'Pages: 123');
});
it("should ignore some redundant fields from RDF translator (temporary)", function () {
var json = {
itemType: "book",
@ -2941,6 +2980,28 @@ describe("Zotero.Item", function () {
};
assert.throws(f, /^Invalid creator type/);
});
it("should ignore item type in Extra", function () {
var json = {
itemType: "document",
title: "",
extra: "Type: preprint"
};
var item = new Zotero.Item;
item.fromJSON(json, { strict: true });
assert.equal(item.getField('extra'), "Type: preprint");
});
it("should ignore valid field in Extra", function () {
var json = {
itemType: "journalArticle",
title: "",
extra: "DOI: 10.1234/abcd"
};
var item = new Zotero.Item;
item.fromJSON(json, { strict: true });
assert.equal(item.getField('extra'), "DOI: 10.1234/abcd");
});
});
it("should accept ISO 8601 dates", function* () {