mirrors/zotero
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

fix strict mode error and add JSDoc to selectitems.js

Browse source
This commit is contained in:
Simon Kornblith 2008-09-02 19:30:14 +00:00
parent c4c65f0a50
commit c9f1592704
1 changed files with 15 additions and 18 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

33
chrome/content/zotero/ingester/selectitems.js
View file

@ -20,14 +20,9 @@
***** END LICENSE BLOCK ***** ***** END LICENSE BLOCK *****
*/ */
////////////////////////////////////////////////////////////////////////////// /**
// * @namespace Singleton to interface with the browser when ingesting data
// Zotero_Ingester_Interface_SelectItems */
//
//////////////////////////////////////////////////////////////////////////////
// Class to interface with the browser when ingesting data
var Zotero_Ingester_Interface_SelectItems = function() {} var Zotero_Ingester_Interface_SelectItems = function() {}
////////////////////////////////////////////////////////////////////////////// //////////////////////////////////////////////////////////////////////////////
@ -36,9 +31,9 @@ var Zotero_Ingester_Interface_SelectItems = function() {}
// //
////////////////////////////////////////////////////////////////////////////// //////////////////////////////////////////////////////////////////////////////
/* /**
* Initialize some variables and prepare event listeners for when chrome is done * Presents items to select in the select box. Assumes window.arguments[0].dataIn is an object with
* loading * URLs as keys and descriptions as values
*/ */
Zotero_Ingester_Interface_SelectItems.init = function() { Zotero_Ingester_Interface_SelectItems.init = function() {
// Set font size from pref // Set font size from pref
@ -48,7 +43,7 @@ Zotero_Ingester_Interface_SelectItems.init = function() {
this.io = window.arguments[0]; this.io = window.arguments[0];
var listbox = document.getElementById("zotero-selectitems-links"); var listbox = document.getElementById("zotero-selectitems-links");
for(i in this.io.dataIn) { // we could use a tree for this if we wanted to for(var i in this.io.dataIn) { // we could use a tree for this if we wanted to
var itemNode = document.createElement("listitem"); var itemNode = document.createElement("listitem");
itemNode.setAttribute("type", "checkbox"); itemNode.setAttribute("type", "checkbox");
itemNode.setAttribute("value", i); itemNode.setAttribute("value", i);
@ -58,6 +53,10 @@ Zotero_Ingester_Interface_SelectItems.init = function() {
} }
} }
/**
* Selects or deselects all items
* @param {Boolean} deselect If true, deselect all items instead of selecting all items
*/
Zotero_Ingester_Interface_SelectItems.selectAll = function(deselect) { Zotero_Ingester_Interface_SelectItems.selectAll = function(deselect) {
var listbox = document.getElementById("zotero-selectitems-links"); var listbox = document.getElementById("zotero-selectitems-links");
for (var i=0; i<listbox.childNodes.length; i++){ for (var i=0; i<listbox.childNodes.length; i++){
@ -65,6 +64,9 @@ Zotero_Ingester_Interface_SelectItems.selectAll = function(deselect) {
} }
} }
/**
* Called when "OK" button is pressed to populate window.arguments[0].dataOut with selected items
*/
Zotero_Ingester_Interface_SelectItems.acceptSelection = function() { Zotero_Ingester_Interface_SelectItems.acceptSelection = function() {
var listbox = document.getElementById("zotero-selectitems-links"); var listbox = document.getElementById("zotero-selectitems-links");
@ -80,10 +82,5 @@ Zotero_Ingester_Interface_SelectItems.acceptSelection = function() {
} }
} }
// What a hack! this makes code down the road much easier because otherwise if(!returnObject) this.io.dataOut = null;
// an empty array is true but empty and we can't figure that out, because
// there's no length
if(!returnObject) {
this.io.dataOut = null;
}
} }