From c87b40e5cace1638f4a493b9bfdcc4be4e35b07b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Adomas=20Ven=C4=8Dkauskas?= Date: Thu, 24 Mar 2022 10:33:58 +0200 Subject: [PATCH] Fix secondary sort submenu breakage in 8e31bf5b --- chrome/content/zotero/itemTree.jsx | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/chrome/content/zotero/itemTree.jsx b/chrome/content/zotero/itemTree.jsx index d16b97472f..a53383bd13 100644 --- a/chrome/content/zotero/itemTree.jsx +++ b/chrome/content/zotero/itemTree.jsx @@ -3593,7 +3593,8 @@ var ItemTree = class ItemTree extends LibraryTree { } }); - const columns = this._getColumns().filter(col => !col.ignoreInColumnPicker); + // Filter out ignored columns + let columns = this._getColumns().filter(col => !col.ignoreInColumnPicker); for (let i = 0; i < columns.length; i++) { const column = columns[i]; if (column.ignoreInColumnPicker === true) continue; @@ -3649,7 +3650,9 @@ var ItemTree = class ItemTree extends LibraryTree { Zotero.logError(e); Zotero.debug(e, 1); } - + + // Secondary sort submenu can include columns that cannot have their visibility toggled + columns = this._getColumns(); // // Secondary Sort menu //