vpat 80: focus first field in search window/dialog (#4402)

Instead of focusing the first condition, which ends up placing
focus in the middle of the new window or modal. It is best
to focus the first node, which is the general convention,
per https://www.w3.org/WAI/ARIA/apg/patterns/dialog-modal/, and
what many screen reader users expect. When we focus a field in
the middle of the window/dialog, it makes it seem for some users
that this is the first node, which will make them miss all the
fields above it.

Also, linked search name input to its label in searchDialog.xhtml.

chrome/content/zotero/advancedSearch.js

@@ -90,6 +90,8 @@ var ZoteroAdvancedSearch = new function() {
 		};
 
 		this.itemsView.changeCollectionTreeRow(collectionTreeRow);
+		// Focus the first field in the window
+		Services.focus.moveFocus(window, null, Services.focus.MOVEFOCUS_FORWARD, 0);
 	}
 	
 	this.onUnload = function () {

chrome/content/zotero/elements/zoteroSearch.js

@@ -631,8 +631,6 @@
 			}
 			
 			this.onConditionSelected(menu.value);
-			
-			this.querySelector('#conditionsmenu').focus();
 		}
 
 		updateSearch() {

chrome/content/zotero/searchDialog.js

@@ -40,7 +40,9 @@ function doLoad()
 	var searchBox = document.getElementById('search-box');
 	searchBox.groups = io.dataIn.groups;
 	searchBox.search = io.dataIn.search;
-	document.getElementById('search-name').value = io.dataIn.name;
+	let searchName = document.getElementById('search-name');
+	searchName.value = io.dataIn.name;
+	searchName.select();
 
 	document.addEventListener('dialogaccept', doAccept);
 }

chrome/content/zotero/searchDialog.xhtml

@@ -35,7 +35,7 @@
 	
 	<vbox id="zotero-search-box-container" flex="1">
 		<hbox align="center">
-			<label value="&zotero.search.name;"/>
+			<label control="search-name" value="&zotero.search.name;"/>
 			<html:input id="search-name" type="text" width="275" maxlength="80"/>
 		</hbox>
 		<zoterosearch id="search-box" flex="1"/>