mirrors/zotero
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

- Remove null, undefined, and false properties from items before passing to parent translators or handlers

Browse source 
- Fix a bug in Zotero.done()-less operation when a child translator encounters an error
This commit is contained in:
Simon Kornblith 2011-06-23 09:13:21 +00:00
parent 33e1ed9532
commit c453db744a
1 changed files with 12 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
chrome/content/zotero/xpcom/translation/translate.js
View file

@ -91,6 +91,11 @@ Zotero.Translate.Sandbox = {
// if we're not supposed to save the item or we're in a child translator,
// just return the item array
if(translate._libraryID === false || translate._parentTranslator) {
// remove null, undefined, and false properties
for(var i in item) {
if(!item[i] && item[i] !== 0) delete item[i];
}
translate.newItems.push(item);
translate._runHandler("itemDone", item, item);
return;
@ -899,7 +904,14 @@ Zotero.Translate.Base.prototype = {
return;
}
var oldState = this._currentState;
// reset async processes and propagate them to parent
if(this._parentTranslator) {
this._parentTranslator._runningAsyncProcesses -= this._runningAsyncProcesses;
if(this._parentTranslator._runningAsyncProcesses === 0) this._parentTranslator.complete();
}
this._runningAsyncProcesses = 0;
if(!returnValue && this._returnValue) returnValue = this._returnValue;
var errorString = null;