From c1035958d44cb32e1ce505b4868d451645e87de3 Mon Sep 17 00:00:00 2001 From: Dan Stillman Date: Mon, 19 Dec 2016 04:19:18 -0500 Subject: [PATCH] Fix for child attachments being saved if prefs off (from 8c2c097c6) --- chrome/content/zotero/xpcom/translation/translate_item.js | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/chrome/content/zotero/xpcom/translation/translate_item.js b/chrome/content/zotero/xpcom/translation/translate_item.js index a4930d7a47..03c2559c59 100644 --- a/chrome/content/zotero/xpcom/translation/translate_item.js +++ b/chrome/content/zotero/xpcom/translation/translate_item.js @@ -137,9 +137,10 @@ Zotero.Translate.ItemSaver.prototype = { // handle attachments if (specialFields.attachments) { for (let attachment of specialFields.attachments) { - if (this._canSaveAttachment(attachment)) { - attachmentCallback(attachment, 0); + if (!this._canSaveAttachment(attachment)) { + continue; } + attachmentCallback(attachment, 0); childAttachments.push([attachment, myID]); } // Restore the attachments field, since we use it later in