From bf84e16002d8f0bb30f63591fb2334a522663b11 Mon Sep 17 00:00:00 2001 From: Martynas Bagdonas Date: Wed, 17 Mar 2021 13:43:12 +0200 Subject: [PATCH] Show crash popover on annotation saving failure #2006 --- chrome/content/zotero/xpcom/reader.js | 5 +++-- pdf-reader | 2 +- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/chrome/content/zotero/xpcom/reader.js b/chrome/content/zotero/xpcom/reader.js index 98da4d88a4..3a7348e399 100644 --- a/chrome/content/zotero/xpcom/reader.js +++ b/chrome/content/zotero/xpcom/reader.js @@ -479,9 +479,10 @@ class ReaderInstance { } } catch (e) { + let crash = ['setAnnotation'].includes(message.action); this._postMessage({ - action: 'error', - message: `An error occured during '${message ? message.action : ''}'`, + action: crash ? 'crash' : 'error', + message: `An error occurred during '${message ? message.action : ''}'`, moreInfo: { message: e.message, stack: e.stack, diff --git a/pdf-reader b/pdf-reader index afae0b4fbd..cb9547a4da 160000 --- a/pdf-reader +++ b/pdf-reader @@ -1 +1 @@ -Subproject commit afae0b4fbdca16192d217cc0ab702b8ec40a6e1d +Subproject commit cb9547a4dabe35d60ea258c8343983ba0ca6185e