mirrors/zotero
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

Fix advanced-search tests

Browse source
This commit is contained in:
Dan Stillman 2023-04-14 15:59:53 -04:00
parent c81391b5b6
commit b99e581929
1 changed files with 11 additions and 11 deletions
Download patch file Download diff file Expand all files Collapse all files

22
test/tests/advancedSearchTest.js
View file

@ -55,7 +55,7 @@ describe("Advanced Search", function () {
zp.openAdvancedSearchWindow(); zp.openAdvancedSearchWindow();
searchWin = yield promise; searchWin = yield promise;
searchBox = searchWin.document.getElementById('zotero-search-box'); searchBox = searchWin.document.getElementById('zotero-search-box');
conditions = searchBox.id('conditions'); conditions = searchBox.querySelector('#conditions');
}); });
after(function () { after(function () {
@ -77,8 +77,8 @@ describe("Advanced Search", function () {
searchBox.search = s; searchBox.search = s;
var searchCondition = conditions.firstChild; var searchCondition = conditions.firstChild;
var conditionsMenu = searchCondition.id('conditionsmenu'); var conditionsMenu = searchCondition.querySelector('#conditionsmenu');
var valueMenu = searchCondition.id('valuemenu'); var valueMenu = searchCondition.querySelector('#valuemenu');
assert.isTrue(valueMenu.hidden); assert.isTrue(valueMenu.hidden);
// Select 'Collection' condition // Select 'Collection' condition
@ -117,8 +117,8 @@ describe("Advanced Search", function () {
searchBox.search = s; searchBox.search = s;
var searchCondition = conditions.firstChild; var searchCondition = conditions.firstChild;
var conditionsMenu = searchCondition.id('conditionsmenu'); var conditionsMenu = searchCondition.querySelector('#conditionsmenu');
var valueMenu = searchCondition.id('valuemenu'); var valueMenu = searchCondition.querySelector('#valuemenu');
assert.equal(conditionsMenu.selectedItem.value, 'collection'); assert.equal(conditionsMenu.selectedItem.value, 'collection');
assert.isFalse(valueMenu.hidden); assert.isFalse(valueMenu.hidden);
@ -136,8 +136,8 @@ describe("Advanced Search", function () {
searchBox.search = s; searchBox.search = s;
var searchCondition = conditions.firstChild; var searchCondition = conditions.firstChild;
var conditionsMenu = searchCondition.id('conditionsmenu'); var conditionsMenu = searchCondition.querySelector('#conditionsmenu');
var valueMenu = searchCondition.id('valuemenu'); var valueMenu = searchCondition.querySelector('#valuemenu');
// Select 'Collection' condition // Select 'Collection' condition
for (let i = 0; i < conditionsMenu.itemCount; i++) { for (let i = 0; i < conditionsMenu.itemCount; i++) {
@ -178,8 +178,8 @@ describe("Advanced Search", function () {
searchBox.search = s; searchBox.search = s;
var searchCondition = conditions.firstChild; var searchCondition = conditions.firstChild;
var conditionsMenu = searchCondition.id('conditionsmenu'); var conditionsMenu = searchCondition.querySelector('#conditionsmenu');
var valueMenu = searchCondition.id('valuemenu'); var valueMenu = searchCondition.querySelector('#valuemenu');
// Select 'Collection' condition // Select 'Collection' condition
for (let i = 0; i < conditionsMenu.itemCount; i++) { for (let i = 0; i < conditionsMenu.itemCount; i++) {
@ -209,7 +209,7 @@ describe("Advanced Search", function () {
} }
var values = []; var values = [];
valueMenu = searchCondition.id('valuemenu') valueMenu = searchCondition.querySelector('#valuemenu')
assert.equal(valueMenu.value, "C" + collection2.key); assert.equal(valueMenu.value, "C" + collection2.key);
for (let i = 0; i < valueMenu.itemCount; i++) { for (let i = 0; i < valueMenu.itemCount; i++) {
let menuitem = valueMenu.getItemAtIndex(i); let menuitem = valueMenu.getItemAtIndex(i);
@ -228,7 +228,7 @@ describe("Advanced Search", function () {
describe("Saved Search", function () { describe("Saved Search", function () {
it("shouldn't appear", function* () { it("shouldn't appear", function* () {
var searchCondition = conditions.firstChild; var searchCondition = conditions.firstChild;
var conditionsMenu = searchCondition.id('conditionsmenu'); var conditionsMenu = searchCondition.querySelector('#conditionsmenu');
// Make sure "Saved Search" isn't present // Make sure "Saved Search" isn't present
for (let i = 0; i < conditionsMenu.itemCount; i++) { for (let i = 0; i < conditionsMenu.itemCount; i++) {