mirrors/zotero
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

Fix inability to drag subcollection to top level within group library

Browse source 
HTML tree regression

Fixes #2201
This commit is contained in:
Dan Stillman 2021-09-14 00:15:07 -04:00
parent c5067edd2d
commit aeabe0b3f6
1 changed files with 2 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
chrome/content/zotero/collectionTree.jsx
View file

@ -1372,13 +1372,14 @@ var CollectionTree = class CollectionTree extends LibraryTree {
return true; return true;
} }
else if (dataType == 'zotero/collection') { else if (dataType == 'zotero/collection') {
if (!treeRow.isLibrary() && !treeRow.isCollection()) { if (!treeRow.isLibrary(true) && !treeRow.isCollection()) {
return false; return false;
} }
let draggedCollectionID = data[0]; let draggedCollectionID = data[0];
let draggedCollection = Zotero.Collections.get(draggedCollectionID); let draggedCollection = Zotero.Collections.get(draggedCollectionID);
// Dragging within same library
if (treeRow.ref.libraryID == draggedCollection.libraryID) { if (treeRow.ref.libraryID == draggedCollection.libraryID) {
// Collections cannot be dropped on themselves // Collections cannot be dropped on themselves
if (draggedCollectionID == treeRow.ref.id) { if (draggedCollectionID == treeRow.ref.id) {
@ -1390,13 +1391,6 @@ var CollectionTree = class CollectionTree extends LibraryTree {
return false; return false;
} }
} }
// Dragging a collection to a different library
else {
// Allow cross-library drag only to root library and collections
if (!treeRow.isLibrary(true) && !treeRow.isCollection()) {
return false;
}
}
return true; return true;
} }