mirrors/zotero
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

Don't use 'dialog=no' or 'modal' for preferences window

Browse source 
Since at least 2009, for reasons unclear, we've used `dialog=no` when
`instantApply` is true (macOS/Linux) and `modal` (with implicit
`dialog=yes`) when false (Windows). `dialog=no` doesn't seem to have an
effect on macOS, and `modal` doesn't seem to have an effect on Windows
(at least with `openDialog()`), but on Linux `dialog=no` allows the
dialog to be resized, which it shouldn't be, and causes problems with a
tiling window manager. This change switches to the implicit `dialog=yes`
on all platforms. (On Linux, this also centers the dialog on the screen,
keeps it in front of other windows, and does a weird opening animation.)

https://forums.zotero.org/discussion/82050/zotero-preferences-window-issue-with-tiling-window-managers
This commit is contained in:
Dan Stillman 2020-03-24 17:30:42 -04:00
parent 0f212bdd76
commit ad9604e267
1 changed files with 1 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

3
chrome/content/zotero/xpcom/utilities_internal.js
View file

@ -1744,8 +1744,7 @@ Zotero.Utilities.Internal = {
let args = [ let args = [
'chrome://zotero/content/preferences/preferences.xul', 'chrome://zotero/content/preferences/preferences.xul',
'zotero-prefs', 'zotero-prefs',
'chrome,titlebar,toolbar,centerscreen,' 'chrome,titlebar,toolbar,centerscreen',
+ Zotero.Prefs.get('browser.preferences.instantApply', true) ? 'dialog=no' : 'modal',
io io
]; ];