mirrors/zotero
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

Skip DB query in getBestAttachmentState() if item is already known

Browse source
This commit is contained in:
Tom Najdek 2024-03-13 17:53:33 +01:00
parent 3c785e2a91
commit aa0ec7849a
No known key found for this signature in database
GPG key ID: EEC61A7B4C667D77
1 changed files with 31 additions and 24 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

55
chrome/content/zotero/xpcom/data/item.js
View file

@ -3787,32 +3787,39 @@ Zotero.Item.prototype.getBestAttachmentState = async function (checkIfExists = t
if (this._bestAttachmentState !== null && this._bestAttachmentState.type && (!checkIfExists || ('exists' in this._bestAttachmentState && this._bestAttachmentState.exists !== null))) {
return this._bestAttachmentState;
}
var item = this.isAttachment() && this.isTopLevelItem()
? this
: await this.getBestAttachment();
if (!item) {
return this._bestAttachmentState = {
type: 'none'
};
}
var type;
if (item.isPDFAttachment()) {
type = 'pdf';
}
else if (item.isSnapshotAttachment()) {
type = 'snapshot';
}
else if (item.isEPUBAttachment()) {
type = 'epub';
}
else if (item.isImageAttachment()) {
type = 'image';
}
else if (item.isVideoAttachment()) {
type = 'video';
var item;
if (!this._bestAttachmentState?.type || !this._bestAttachmentState.key) {
item = this.isAttachment() && this.isTopLevelItem()
? this
: await this.getBestAttachment();
if (!item) {
return this._bestAttachmentState = {
type: 'none'
};
}
var type;
if (item.isPDFAttachment()) {
type = 'pdf';
}
else if (item.isSnapshotAttachment()) {
type = 'snapshot';
}
else if (item.isEPUBAttachment()) {
type = 'epub';
}
else if (item.isImageAttachment()) {
type = 'image';
}
else if (item.isVideoAttachment()) {
type = 'video';
}
else {
type = 'other';
}
}
else {
type = 'other';
item = await this.ObjectsClass.getByLibraryAndKeyAsync(this.libraryID, this._bestAttachmentState.key);
type = this._bestAttachmentState.type;
}
var exists = checkIfExists ? await item.fileExists() : null;