From a74c86d9484a3a3080dec9c4d277c449d10adeed Mon Sep 17 00:00:00 2001
From: abaevbog <bogdan@zotero.org>
Date: Fri, 2 Feb 2024 03:58:27 -0500
Subject: [PATCH] collection search tooltiptext and placeholder cleanup (#3632)

Fluent tooltiptext for collection search button and placeholder
for collection search input
---
 chrome/content/zotero/zoteroPane.xhtml | 6 +++---
 chrome/locale/en-US/zotero/zotero.ftl  | 5 ++++-
 2 files changed, 7 insertions(+), 4 deletions(-)

diff --git a/chrome/content/zotero/zoteroPane.xhtml b/chrome/content/zotero/zoteroPane.xhtml
index 5fe992a56d..387e19d214 100644
--- a/chrome/content/zotero/zoteroPane.xhtml
+++ b/chrome/content/zotero/zoteroPane.xhtml
@@ -1024,11 +1024,11 @@
 											<toolbarbutton id="zotero-tb-collection-add" tabindex="-1" class="zotero-tb-button" tooltiptext="&zotero.toolbar.newCollection.label;" command="cmd_zotero_newCollection"/>
 											<spacer flex="1"></spacer>
 											<html:div style="display: flex;flex-direction: row;">
-												<toolbarbutton id="zotero-tb-collections-search" tabindex="-1" class="zotero-tb-button" tooltiptext="&zotero.toolbar.newCollection.label;"/>
-												<!-- For unknown reason, the data-l10n-id.placeholder doesn't work here. Hard code it for now -->
+												<toolbarbutton id="zotero-tb-collections-search" data-l10n-id="zotero-collections-search-btn" tabindex="-1" class="zotero-tb-button"/>
 												<search-textbox
 													id="zotero-collections-search" class="hidden" disabled="true"
-													placeholder="Filter Collections" data-l10n-id="zotero-collections-search"
+													data-l10n-id="zotero-collections-search"
+													data-l10n-attrs="placeholder"
 													oncommand="ZoteroPane.handleCollectionSearchInput()"/>
 											</html:div>
 										</hbox>									
diff --git a/chrome/locale/en-US/zotero/zotero.ftl b/chrome/locale/en-US/zotero/zotero.ftl
index 4f1258fd10..284d8ee942 100644
--- a/chrome/locale/en-US/zotero/zotero.ftl
+++ b/chrome/locale/en-US/zotero/zotero.ftl
@@ -34,8 +34,11 @@ menu-new-item-note =
 
 zotero-toolbar-tabs-menu =
     .tooltiptext = List all tabs
+filter-collections = Filter Collections
 zotero-collections-search =
-    .placeholder = Filter Collections
+    .placeholder = { filter-collections }
+zotero-collections-search-btn =
+    .tooltiptext = { filter-collections }
 zotero-tabs-menu-filter =
     .placeholder = Search Tabs
 zotero-tabs-menu-close-button =