mirrors/zotero
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

Always favor PDF attachments over non-PDF attachments

Browse source
This commit is contained in:
Dan Stillman 2011-02-17 04:06:18 +00:00
parent 091326b7e6
commit a342cb3546
1 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
chrome/content/zotero/xpcom/data/item.js
View file

@ -3279,8 +3279,8 @@ Zotero.Item.prototype.getBestAttachment = function() {
/*
* Looks for attachment in the following order: oldest PDF attachment matching parent URL,
* oldest non-PDF attachment matching parent URL, oldest PDF attachment not matching URL,
* old non-PDF attachment not matching URL
* oldest PDF attachment not matching parent URL, oldest non-PDF attachment matching parent URL,
* old non-PDF attachment not matching parent URL
*
* @return {Array} itemIDs for attachments
*/
@ -3296,7 +3296,7 @@ Zotero.Item.prototype.getBestAttachments = function() {
+ "LEFT JOIN itemDataValues IDV ON (ID.valueID=IDV.valueID) "
+ "WHERE sourceItemID=? AND linkMode NOT IN (?) "
+ "AND IA.itemID NOT IN (SELECT itemID FROM deletedItems) "
+ "ORDER BY value=? DESC, mimeType='application/pdf' DESC, dateAdded ASC";
+ "ORDER BY mimeType='application/pdf' DESC, value=? DESC, dateAdded ASC";
return Zotero.DB.columnQuery(sql, [this.id, Zotero.Attachments.LINK_MODE_LINKED_URL, url]);
}