mirrors/zotero
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

Strip non-printable characters in tab titles when restoring session

Browse source 
https://forums.zotero.org/discussion/118303/zotero-blocked-with-the-loading-items-message
and probably others

Fixes #4721
This commit is contained in:
Dan Stillman 2024-10-02 00:37:27 -04:00
parent 20d13f5a8e
commit a0da169664
1 changed files with 5 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
chrome/content/zotero/tabs.js
View file

@ -206,9 +206,13 @@ var Zotero_Tabs = new function () {
} }
else if (tab.type === 'reader') { else if (tab.type === 'reader') {
if (Zotero.Items.exists(tab.data.itemID)) { if (Zotero.Items.exists(tab.data.itemID)) {
// Strip non-printable characters, which can result in DOM syntax errors
// ("An invalid or illegal string was specified") -- reproduced with "\u0001"
// in a title in session.json
let title = tab.title.replace(/[\u0000-\u001F\u007F-\u009F]/g, "");
this.add({ this.add({
type: 'reader-unloaded', type: 'reader-unloaded',
title: tab.title, title,
index: i, index: i,
data: tab.data, data: tab.data,
select: tab.selected select: tab.selected