From 9cc2993e702e4b03ca60b86933a728e1a30fdc67 Mon Sep 17 00:00:00 2001 From: Abe Jellinek Date: Mon, 7 Nov 2022 16:05:21 -0500 Subject: [PATCH] fx-compat: Fix Locate Manager appearance - Correct padding and don't use Mozilla preferences styles - Fixed v-t issue that applied the wrong class names to columns, giving them incorrect widths --- chrome/content/zotero/components/virtualized-table.jsx | 4 ++-- chrome/content/zotero/locateManager.jsx | 1 + chrome/content/zotero/locateManager.xhtml | 3 +-- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/chrome/content/zotero/components/virtualized-table.jsx b/chrome/content/zotero/components/virtualized-table.jsx index 4d3c8e97f7..7117fb869b 100644 --- a/chrome/content/zotero/components/virtualized-table.jsx +++ b/chrome/content/zotero/components/virtualized-table.jsx @@ -1600,9 +1600,9 @@ function renderCell(index, data, column) { return span; } -function renderCheckboxCell(index, data, columnName) { +function renderCheckboxCell(index, data, column) { let span = document.createElement('span'); - span.className = `cell checkbox ${columnName}`; + span.className = `cell checkbox ${column.className}`; span.setAttribute('role', 'checkbox'); span.setAttribute('aria-checked', data); if (data) { diff --git a/chrome/content/zotero/locateManager.jsx b/chrome/content/zotero/locateManager.jsx index 0297e6eb08..a38f6e6649 100644 --- a/chrome/content/zotero/locateManager.jsx +++ b/chrome/content/zotero/locateManager.jsx @@ -50,6 +50,7 @@ function init() { showHeader={true} multiSelect={true} columns={columns} + onColumnSort={null} disableFontSizeScaling={true} getRowString={index => getRowData(index).name} onActivate={handleActivate} diff --git a/chrome/content/zotero/locateManager.xhtml b/chrome/content/zotero/locateManager.xhtml index 7f5f1c153f..faf58e06aa 100644 --- a/chrome/content/zotero/locateManager.xhtml +++ b/chrome/content/zotero/locateManager.xhtml @@ -27,7 +27,6 @@ - @@ -37,7 +36,7 @@ windowtype="zotero:pref" xmlns="http://www.mozilla.org/keymaster/gatekeeper/there.is.only.xul" xmlns:html="http://www.w3.org/1999/xhtml" - style="display: flex;"> + style="display: flex; padding: 15px;">